Page MenuHomePhabricator
Differential D7863

[backport#17261 13/13] Refactor: Replace SigningProvider pointers with unique_ptrs
ClosedPublic
Actions

Authored by majcosta on Oct 10 2020, 00:29.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCe6d44e7f1124: [backport#17261 13/13] Refactor: Replace SigningProvider pointers with…
Summary

Needed for future ScriptPubKeyMans which may need to create
SigningProviders dynamically and thus a normal pointer is not enough

This commit does not change behavior.

https://github.com/bitcoin/bitcoin/pull/17261/commits/3f373659d732a5b1e5fdc692a45b2b8179f66bec

Depends on D7861

Concludes backport of Core PR17261

Test Plan
ninja all check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
interfaces/
4 lines
wallet/
13 lines
27 lines
34 lines
4 lines
7 lines
14 lines

Diff 24511

View Options

src/interfaces/wallet.cpp

Loading...
View Options

src/wallet/psbtwallet.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

src/wallet/scriptpubkeyman.h

Loading...
View Options

src/wallet/scriptpubkeyman.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...