Differential D7416

[backport#17381 1/5] Add EnsureLegacyScriptPubKeyMan and use in rpcwallet.cpp
ClosedPublic
Actions

Authored by majcosta on Sep 10 2020, 18:05.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABC6c1781a66c30: [backport#17381 1/5] Add EnsureLegacyScriptPubKeyMan and use in rpcwallet.cpp

Summary

This also fixes unused variable warnings in rpcdump.cpp

https://github.com/bitcoin/bitcoin/pull/17381/commits/b07b07cd8779355ba1dd16e7eb4af42e0ae1c587

Partial backport of Core PR17381

Test Plan

ninja check check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.Sep 10 2020, 18:05

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 10 2020, 18:05

majcosta requested review of this revision.Sep 10 2020, 18:05

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta added a child revision: D7417: [backport#17381 2/5] Pass CTxDestination to ScriptPubKeyMan::GetMetadata.Sep 10 2020, 18:05

Harbormaster completed remote builds in B12698: Diff 23432.Sep 10 2020, 18:18

deadalnix accepted this revision.Sep 10 2020, 22:29

This revision is now accepted and ready to land.Sep 10 2020, 22:29

Closed by commit rABC6c1781a66c30: [backport#17381 1/5] Add EnsureLegacyScriptPubKeyMan and use in rpcwallet.cpp (authored by Russell Yanofsky <[email protected]>, committed by majcosta). · Explain WhySep 11 2020, 15:10

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABC6c1781a66c30: [backport#17381 1/5] Add EnsureLegacyScriptPubKeyMan and use in rpcwallet.cpp.

Revision Contents
Changeset List

Path

Size

src/

wallet/

rpcdump.cpp

23 lines

rpcwallet.h

2 lines

rpcwallet.cpp

35 lines

Diff 23451

View Options

src/wallet/rpcdump.cpp

View Options

src/wallet/rpcwallet.h

View Options

[backport#17381 1/5] Add EnsureLegacyScriptPubKeyMan and use in rpcwallet.cppClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 23451

src/wallet/rpcdump.cpp

src/wallet/rpcwallet.h

src/wallet/rpcwallet.cpp

[backport#17381 1/5] Add EnsureLegacyScriptPubKeyMan and use in rpcwallet.cpp
ClosedPublic
Actions

Revision Contents
Changeset List