Page MenuHomePhabricator
Differential D6471

Increase maxconnections limit when using poll.
ClosedPublic
Actions

Authored by nakihito on Jun 8 2020, 22:13.

Details

Reviewers
majcosta
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC6f41fa19a3ca: Increase maxconnections limit when using poll.
Summary

Partial backport of Core PR14336
https://github.com/bitcoin/bitcoin/pull/14336/commits/4927bf2f257ac53569978980eaf1f61c2c6b04cc

Depends on D6470

Test Plan
ninja
ninja check-all
src/bitcoind --debug=net

Verify normal node behavior.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nakihito created this revision.Jun 8 2020, 22:13
Owners added a reviewer: Restricted Owners Package.Jun 8 2020, 22:13
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 8 2020, 22:13
nakihito requested review of this revision.Jun 8 2020, 22:13
nakihito planned changes to this revision.
teamcity edited the summary of this revision. (Show Details)Jun 8 2020, 22:13

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

nakihito requested review of this revision.Jun 8 2020, 22:15
nakihito edited the summary of this revision. (Show Details)
nakihito added a parent revision: D6470: Implement poll() on systems which support it properly..
Harbormaster completed remote builds in B11341: Diff 21126.Jun 8 2020, 22:30
majcosta requested changes to this revision.Jun 8 2020, 23:46
majcosta added a subscriber: majcosta.
majcosta added inline comments.
src/init.cpp
1712 ↗(On Diff #21126)

please rebase onto https://github.com/bitcoin/bitcoin/commit/629a47a1543a6e77cbf9c73917e2e419669b04df

This revision now requires changes to proceed.Jun 8 2020, 23:46
nakihito updated this revision to Diff 21191.Jun 9 2020, 20:23

Rebased.

Harbormaster completed remote builds in B11373: Diff 21191.Jun 9 2020, 20:40
majcosta accepted this revision.Jun 9 2020, 23:07
This revision is now accepted and ready to land.Jun 9 2020, 23:07
Closed by commit rABC6f41fa19a3ca: Increase maxconnections limit when using poll. (authored by Patrick Strateman <[email protected]>, committed by nakihito). · Explain WhyJun 9 2020, 23:52
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABC6f41fa19a3ca: Increase maxconnections limit when using poll..

Revision Contents
Changeset List

PathSize
src/
11 lines

Diff 21205

View Options

src/init.cpp

Loading...