Page MenuHomePhabricator
Differential D6423

[backport#15006] Add option to create an encrypted wallet
ClosedPublic
Actions

Authored by majcosta on Jun 6 2020, 23:58.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC8345f442a7e6: [backport#15006] Add option to create an encrypted wallet
Summary

https://github.com/bitcoin/bitcoin/pull/15006/commits/662d1171d9e29964b039ba4c5bc8a2304426c003

Backport of Core PR15006

Test Plan
ninja check
./test/functional/test_runner.py wallet_createwallet.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Jun 6 2020, 23:58
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 6 2020, 23:58
majcosta requested review of this revision.Jun 6 2020, 23:58
teamcity edited the summary of this revision. (Show Details)Jun 6 2020, 23:58

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11274: Diff 21014.Jun 7 2020, 00:14
majcosta added a child revision: D6425: [backport#16244] Move wallet creation out of the createwallet rpc into its own function.Jun 7 2020, 00:14
deadalnix requested changes to this revision.Jun 7 2020, 01:12
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/wallet/rpcwallet.cpp
3156 ↗(On Diff #21014)

Put comment on its own line.

This revision now requires changes to proceed.Jun 7 2020, 01:12
majcosta updated this revision to Diff 21027.Jun 7 2020, 01:20

placed a comment on its own line

deadalnix accepted this revision.Jun 7 2020, 01:22
This revision is now accepted and ready to land.Jun 7 2020, 01:22
Harbormaster completed remote builds in B11282: Diff 21027.Jun 7 2020, 01:44
Closed by commit rABC8345f442a7e6: [backport#15006] Add option to create an encrypted wallet (authored by Andrew Chow <[email protected]>, committed by majcosta). · Explain WhyJun 7 2020, 01:50
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC8345f442a7e6: [backport#15006] Add option to create an encrypted wallet.

Revision Contents
Changeset List

PathSize
doc/
5 lines
src/
wallet/
104 lines
test/
functional/
51 lines

Diff 21030

View Options

doc/release-notes.md

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

test/functional/wallet_createwallet.py

Loading...