Page MenuHomePhabricator
Differential D6261

[backport#16034] Move LockAnnotation from threadsafety.h (imported code) to sync.h (our code)
ClosedPublic
Actions

Authored by majcosta on May 26 2020, 20:06.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC08a7b78cc44c: [backport#16034] Move LockAnnotation from threadsafety.h (imported code) to…
Summary

https://github.com/bitcoin/bitcoin/pull/16034/commits/cc2588579c3fbc133a7ca762fa213ca18b736551

Move LockAnnotation to make it reflect the truth
https://github.com/bitcoin/bitcoin/pull/16034/commits/3a809446b3881e1a6853da78cccf42643c9a5927

Make sure the compile-time locking promises given via LockAnnotation:s hold also in practice at runtime (ifdef DEBUG_LOCKORDER)
https://github.com/bitcoin/bitcoin/pull/16034/commits/de9b5dbca34230b8213ce612036fccabdb6ee53b

Depends on D6259

Partial backport of Core PR16034

Test Plan
ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.May 26 2020, 20:06
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 26 2020, 20:06
majcosta requested review of this revision.May 26 2020, 20:06
teamcity edited the summary of this revision. (Show Details)May 26 2020, 20:06

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 26 2020, 20:07

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 26 2020, 20:07

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 26 2020, 20:07

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

majcosta added a child revision: D6262: [backport#16034] scripted-diff: Rename LockAnnotation to LockAssertion.May 26 2020, 20:07
teamcity added a comment.May 26 2020, 20:09

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 26 2020, 20:12

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 26 2020, 20:19

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B11039: Diff 20626.May 26 2020, 20:19
majcosta edited the summary of this revision. (Show Details)May 26 2020, 21:55
majcosta edited the summary of this revision. (Show Details)
deadalnix accepted this revision.May 27 2020, 11:49
This revision is now accepted and ready to land.May 27 2020, 11:49
Closed by commit rABC08a7b78cc44c: [backport#16034] Move LockAnnotation from threadsafety.h (imported code) to… (authored by practicalswift <[email protected]>, committed by majcosta). · Explain WhyMay 27 2020, 19:34
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC08a7b78cc44c: [backport#16034] Move LockAnnotation from threadsafety.h (imported code) to….

Revision Contents
Changeset List

PathSize
src/
12 lines
8 lines
wallet/
test/
2 lines

Diff 20653

View Options

src/sync.h

Loading...
View Options

src/threadsafety.h

Loading...
View Options

src/wallet/test/wallet_tests.cpp

Loading...