Paths

Table of Contentst

Differential D17998

RPC: Extract InvalidateBlock and ReconsiderBlock helpers
ClosedPublic
Actions

Authored by PiRK on Apr 26 2025, 06:41.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC913404a4fb9c: RPC: Extract InvalidateBlock and ReconsiderBlock helpers

Summary

The end goal is to reuse these helpers in dumptxoutset when dumping a utxo snapshot for a particular block height.

This is a partial backport of core#29553

https://github.com/bitcoin/bitcoin/pull/29553/commits/446ce51c21cd2466cb12fa0166fd069d42b603bf
https://github.com/bitcoin/bitcoin/pull/29553/commits/fccf4f91d21c351d742943d35476f53d40963b8b

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Apr 26 2025, 06:41

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 26 2025, 06:41

PiRK requested review of this revision.Apr 26 2025, 06:41

teamcity edited the summary of this revision. (Show Details)Apr 26 2025, 06:41

Harbormaster completed remote builds in B33113: Diff 53702.Apr 26 2025, 06:55

Please avoid copies when possible

src/rpc/blockchain.cpp
1617 ↗	(On Diff #53702)
1723 ↗	(On Diff #53702)

This revision now requires changes to proceed.Apr 26 2025, 09:13

pass block hash by const reference & mark function as static

PiRK added a child revision: D17999: rpc: call RecalculateBestHeader as part of reconsiderblock.Apr 26 2025, 12:20

Harbormaster completed remote builds in B33114: Diff 53706.Apr 26 2025, 12:44

Fabien accepted this revision.Apr 28 2025, 07:10

This revision is now accepted and ready to land.Apr 28 2025, 07:10

PiRK edited the summary of this revision. (Show Details)Apr 30 2025, 06:08

PiRK removed a parent revision: D17997: [avalanche] Fix staking reward flakiness after node restart in contenders test.

Closed by commit rABC913404a4fb9c: RPC: Extract InvalidateBlock and ReconsiderBlock helpers (authored by Fabian Jahr <[email protected]>, committed by PiRK). · Explain WhyMay 2 2025, 16:21

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC913404a4fb9c: RPC: Extract InvalidateBlock and ReconsiderBlock helpers.

Revision Contents
Changeset List

Path

Size

src/

rpc/

blockchain.cpp

92 lines

Diff 53831

View Options

RPC: Extract InvalidateBlock and ReconsiderBlock helpersClosedPublicActions