Page MenuHomePhabricator
Differential D12587

document and clean up MaybeUpdateMempoolForReorg
ClosedPublic
Actions

Authored by PiRK on Nov 23 2022, 07:49.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC597f5af02b1d: document and clean up MaybeUpdateMempoolForReorg
Summary

Co-authored-by: John Newbery <[email protected]>

This is a partial backport of core#23976
https://github.com/bitcoin/bitcoin/pull/23976/commits/c7cd98c7176800a51e6a6b3634a26b508aa33ff2

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Nov 23 2022, 07:49
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 23 2022, 07:49
PiRK requested review of this revision.Nov 23 2022, 07:49
teamcity edited the summary of this revision. (Show Details)Nov 23 2022, 07:49
PiRK added a child revision: D12588: Replace `struct update_lock_points` with lambda.Nov 23 2022, 07:50
Harbormaster completed remote builds in B21060: Diff 36531.Nov 23 2022, 08:05
Fabien requested changes to this revision.Nov 23 2022, 11:08
Fabien added a subscriber: Fabien.

You're missing the PR number in the summary

src/txmempool.cpp
1558 ↗(On Diff #36531)

you don't need the else

This revision now requires changes to proceed.Nov 23 2022, 11:08
PiRK edited the summary of this revision. (Show Details)Nov 23 2022, 16:32
PiRK updated this revision to Diff 36566.Nov 23 2022, 16:44

remove unnecessary else

Harbormaster completed remote builds in B21093: Diff 36566.Nov 23 2022, 16:58
Fabien accepted this revision.Nov 23 2022, 19:49
This revision is now accepted and ready to land.Nov 23 2022, 19:49
Closed by commit rABC597f5af02b1d: document and clean up MaybeUpdateMempoolForReorg (authored by glozow <[email protected]>, committed by PiRK). · Explain WhyNov 24 2022, 09:00
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC597f5af02b1d: document and clean up MaybeUpdateMempoolForReorg.

Revision Contents
Changeset List

PathSize
src/
12 lines
61 lines

Diff 36579

View Options

src/txmempool.h

Loading...
View Options

src/txmempool.cpp

Loading...