Page MenuHomePhabricator
Differential D12507

Move BlockManager to node/blockstorage
ClosedPublic
Actions

Authored by PiRK on Nov 16 2022, 10:04.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC65330d5b88b8: Move BlockManager to node/blockstorage
Summary

Can be reviewed with --color-moved=dimmed-zebra

This is a backport of core#23581
https://github.com/bitcoin/bitcoin/pull/23581/commits/fade2a44f4aabc64185031dbf4c70d875ece6740

Depends on D12487

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Nov 16 2022, 10:04
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 16 2022, 10:04
PiRK requested review of this revision.Nov 16 2022, 10:04
teamcity edited the summary of this revision. (Show Details)Nov 16 2022, 10:04
Harbormaster completed remote builds in B20936: Diff 36323.Nov 16 2022, 10:16
Fabien requested changes to this revision.Nov 16 2022, 11:07
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/CMakeLists.txt
711 ↗(On Diff #36323)
src/node/blockstorage.cpp
21 ↗(On Diff #36323)

you need blockindexworkcomparator.h also

This revision now requires changes to proceed.Nov 16 2022, 11:07
PiRK updated this revision to Diff 36331.Nov 16 2022, 13:58

review

Fabien accepted this revision.Nov 16 2022, 14:08
This revision is now accepted and ready to land.Nov 16 2022, 14:08
Harbormaster completed remote builds in B20942: Diff 36331.Nov 16 2022, 14:12
Closed by commit rABC65330d5b88b8: Move BlockManager to node/blockstorage (authored by PiRK). · Explain WhyNov 16 2022, 15:59
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC65330d5b88b8: Move BlockManager to node/blockstorage.

Revision Contents
Changeset List

PathSize
src/
4 lines
node/
96 lines
417 lines
95 lines
419 lines

Diff 36338

View Options

src/CMakeLists.txt

Loading...
View Options

src/node/blockstorage.h

Loading...
View Options

src/node/blockstorage.cpp

Loading...
View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...