Paths

Table of Contentst

Differential D12169

[bench] Benchmark CTxMemPool::check()
ClosedPublic
Actions

Authored by PiRK on Oct 7 2022, 09:13.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC8a5d04de8890: [bench] Benchmark CTxMemPool::check()

Summary

This is a backport of core#23157 [1 & 2/8]
https://github.com/bitcoin/bitcoin/pull/23157/commits/cb1407196fba648aa75504e3ab3d46aa0181563a
https://github.com/bitcoin/bitcoin/pull/23157/commits/30e240f65e69c6dffcd033afc63895345bd51f53

Test Plan

ninja bench-bitcoin

ns/op	op/s	err%	total	benchmark
172,478,220.00	5.80	0.1%	1.90	`ComplexMemPool`
...	...	...	...	...
8.07	123,977,164.61	0.0%	0.00	`MempoolCheck`

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 7 2022, 09:13

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 7 2022, 09:13

PiRK requested review of this revision.Oct 7 2022, 09:13

teamcity edited the summary of this revision. (Show Details)Oct 7 2022, 09:13

PiRK edited the test plan for this revision. (Show Details)Oct 7 2022, 09:14

PiRK added a child revision: D12170: [mempool] use coins cache and iterate in topo order in check().Oct 7 2022, 09:18

Harbormaster completed remote builds in B20392: Diff 35508.Oct 7 2022, 09:26

Fabien accepted this revision.Oct 7 2022, 09:48

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/bench/mempool_stress.cpp
96 ↗	(On Diff #35508)	That's unused ?

This revision is now accepted and ready to land.Oct 7 2022, 09:48

PiRK added inline comments.Oct 7 2022, 13:37

src/bench/mempool_stress.cpp
96 ↗	(On Diff #35508)	You are right. I checked other benchmarks, and it seems like a common pattern to create an unused TestingSetup, so maybe there is some cleanup to do.

Closed by commit rABC8a5d04de8890: [bench] Benchmark CTxMemPool::check() (authored by glozow <[email protected]>, committed by PiRK). · Explain WhyOct 7 2022, 13:39

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC8a5d04de8890: [bench] Benchmark CTxMemPool::check().

Revision Contents
Changeset List

Path

Size

src/

bench/

mempool_stress.cpp

51 lines

Diff 35522

src/bench/mempool_stress.cpp

Loading...