Page MenuHomePhabricator
Differential D11486

txorphanage: Extract GetOrphanTx
ClosedPublic
Actions

Authored by PiRK on May 18 2022, 08:30.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC718ec9723107: txorphanage: Extract GetOrphanTx
Summary

Extract orphan lookup code into GetOrphanTx function.

This is a backport of core#21148 [6/14]
https://github.com/bitcoin/bitcoin/pull/21148/commits/f294da727413210fda279afdc206a4dd12046d56

Depends on D11485

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.May 18 2022, 08:30
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 18 2022, 08:30
PiRK requested review of this revision.May 18 2022, 08:30
teamcity edited the summary of this revision. (Show Details)May 18 2022, 08:30
PiRK edited the summary of this revision. (Show Details)May 18 2022, 08:30
PiRK added a parent revision: D11485: txorphanage: Extract HaveOrphanTx.
PiRK removed a parent revision: D11445: test: Misc cleanup for p2p_blockfilters.
Harbormaster completed remote builds in B19075: Diff 33577.May 18 2022, 08:41
PiRK added a child revision: D11487: txorphanage: Extract OrphanageAddTx and drop AddOrphanTx.May 18 2022, 08:44
Fabien accepted this revision.May 18 2022, 14:51
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/net_processing.cpp
3001 ↗(On Diff #33577)

Revert

This revision is now accepted and ready to land.May 18 2022, 14:51
PiRK updated this revision to Diff 33599.May 19 2022, 07:59

rebase

PiRK updated this revision to Diff 33605.May 19 2022, 08:04

revert removed line

Harbormaster completed remote builds in B19096: Diff 33599.May 19 2022, 08:22
Harbormaster completed remote builds in B19102: Diff 33605.May 19 2022, 08:59
Closed by commit rABC718ec9723107: txorphanage: Extract GetOrphanTx (authored by Anthony Towns <[email protected]>, committed by PiRK). · Explain WhyMay 19 2022, 16:07
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC718ec9723107: txorphanage: Extract GetOrphanTx.

Revision Contents
Changeset List

PathSize
src/
11 lines
2 lines
10 lines

Diff 33619

View Options

src/net_processing.cpp

Loading...
View Options

src/txorphanage.h

Loading...
View Options

src/txorphanage.cpp

Loading...