Page MenuHomePhabricator
Differential D11351

blockstorage: [refactor] Use chainman reference where possible
ClosedPublic
Actions

Authored by PiRK on Apr 13 2022, 13:11.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC1ee3cb4fdc93: blockstorage: [refactor] Use chainman reference where possible
Summary

This is a backport of core#21575 [5/6]
https://github.com/bitcoin/bitcoin/pull/21575/commits/fa121b628d51bb0e25eb3fbd716881fa55527dc7

Depends on D11350

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Apr 13 2022, 13:11
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 13 2022, 13:11
PiRK requested review of this revision.Apr 13 2022, 13:11
teamcity edited the summary of this revision. (Show Details)Apr 13 2022, 13:11
PiRK edited the summary of this revision. (Show Details)Apr 13 2022, 13:13
Harbormaster completed remote builds in B18815: Diff 33204.Apr 13 2022, 13:32
teamcity added a comment.Apr 13 2022, 13:32
Build Bitcoin ABC Diffs / Diff Testing (lint-circular-dependencies) failed.

Tail of the build log:

/work /work/abc-ci-builds/lint-circular-dependencies
A new circular dependency in the form of "node/blockstorage -> validation -> txdb -> node/blockstorage" appears to have been introduced.

/work/abc-ci-builds/lint-circular-dependencies
Build lint-circular-dependencies failed with exit code 1
PiRK planned changes to this revision.Apr 13 2022, 13:43
PiRK updated this revision to Diff 33297.Apr 25 2022, 09:03

rebase

Harbormaster completed remote builds in B18875: Diff 33297.Apr 25 2022, 09:22
teamcity added a comment.Apr 25 2022, 09:22
Build Bitcoin ABC Diffs / Diff Testing (lint-circular-dependencies) failed.

Tail of the build log:

/work /work/abc-ci-builds/lint-circular-dependencies
A new circular dependency in the form of "node/blockstorage -> validation -> txdb -> node/blockstorage" appears to have been introduced.

/work/abc-ci-builds/lint-circular-dependencies
Build lint-circular-dependencies failed with exit code 1
PiRK planned changes to this revision.Apr 25 2022, 13:23
PiRK updated this revision to Diff 33301.Apr 25 2022, 14:13

rebase

PiRK updated this revision to Diff 33302.Apr 25 2022, 14:13

rebase

Harbormaster completed remote builds in B18879: Diff 33301.Apr 25 2022, 14:25
Harbormaster completed remote builds in B18880: Diff 33302.Apr 25 2022, 14:35
Fabien accepted this revision.Apr 25 2022, 14:47
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/node/blockstorage.cpp
41 ↗(On Diff #33302)

revert

This revision is now accepted and ready to land.Apr 25 2022, 14:47
PiRK updated this revision to Diff 33311.Apr 26 2022, 06:10
PiRK edited the summary of this revision. (Show Details)

restore blank line, remove comment about deleting blank line in summary

Harbormaster completed remote builds in B18888: Diff 33311.Apr 26 2022, 06:25
Closed by commit rABC1ee3cb4fdc93: blockstorage: [refactor] Use chainman reference where possible (authored by MarcoFalke <[email protected]>, committed by PiRK). · Explain WhyApr 27 2022, 10:18
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC1ee3cb4fdc93: blockstorage: [refactor] Use chainman reference where possible.

Revision Contents
Changeset List

PathSize
src/
node/
7 lines

Diff 33327

View Options

src/node/blockstorage.cpp

Loading...