Changeset 933166

Timestamp:

06/16/2014 05:44:34 PM (11 years ago)

Author:

jimmywb

Message:

Fixed bug that limited the list to 9 items

Location:

simple-link-list-widget

Files:

• assets/banner-1544x500.jpg (added)
• assets/banner-772x250.jpg (added)
• tags/0.3.1 (added)
• tags/0.3.1/css (added)
• tags/0.3.1/css/sllw.css (added)
• tags/0.3.1/images (added)
• tags/0.3.1/images/add.png (added)
• tags/0.3.1/images/delete.png (added)
• tags/0.3.1/js (added)
• tags/0.3.1/js/sllw-sort.js (added)
• tags/0.3.1/readme.txt (added)
• tags/0.3.1/simple-link-list-widget.php (added)
• trunk/js/sllw-sort.js (modified) (4 diffs)
• trunk/readme.txt (modified) (3 diffs)
• trunk/screenshot-1.png (deleted)
• trunk/simple-link-list-widget.php (modified) (2 diffs)

simple-link-list-widget/trunk/js/sllw-sort.js

@@ -53 +53 @@
         var item = sllw.find('.simple-link-list .list-item:last-child').clone();
         var item_id = item.attr('id');
-        item.attr('id',item_id.substring(0,item_id.length-1)+num);
+        item.attr('id',increment_last_num(item_id));
 
         $('.toggled-off',item).removeClass('toggled-off');
@@ -61 +61 @@
         $('label',item).each(function() {
             var for_val = $(this).attr('for');
-            $(this).attr('for',for_val.substring(0,for_val.length-1)+num);
+            $(this).attr('for',increment_last_num(for_val));
         });
         
@@ -67 +67 @@
             var id_val = $(this).attr('id');
             var name_val = $(this).attr('name');
-            $(this).attr('id',id_val.substring(0,id_val.length-1)+num);
-            $(this).attr('name',name_val.substring(0,name_val.length-2)+num+"]");
+            $(this).attr('id',increment_last_num(id_val));
+            $(this).attr('name',increment_last_num(name_val));
             if($(':checked',this)){
                $(this).removeAttr('checked');
@@ -84 +84 @@
 }
 
+function increment_last_num(v) {
+    return v.replace(/[0-9]+(?!.*[0-9])/, function(match) {
+        return parseInt(match, 10)+1;
+    });
+}
+
 function updateOrder(self){
     var sllw = self.parents(".widget-content");

simple-link-list-widget/trunk/readme.txt

@@ -4 +4 @@
 Requires at least: 2.8
 Tested up to: 3.9
-Stable tag: 0.3
+Stable tag: 0.3.1
 
 This plugin makes a widget available which allows you to add a simple link list (bulleted or numbered) to a sidebar.
@@ -14 +14 @@
 The plugin then needs to be activated before it can be used.
 
-To use, simply drag the 'Simple Link List' widget into a sidebar. To use the widget, your theme must be widget-enabled.
+To use, simply drag the 'List' widget into a sidebar. To use the widget, your theme must be widget-enabled.
 
 == Frequently Asked Questions ==
@@ -36 +36 @@
 
 == Changelog ==
+= 0.3.1 =
+* Fixed bug that limited the number of items to 9
+
 = 0.3 =
 * Added drag and drop support

simple-link-list-widget/trunk/simple-link-list-widget.php

@@ -5 +5 @@
 Author: James Bowles
 Author URI: http://thebowles.org
-Version: 0.3
+Version: 0.3.1
 */
 
@@ -90 +90 @@
             $order = explode(',',$new_instance['order']);
             foreach($order as $key => $order_str){
-                $order[$key] = substr($order_str,-1);
+                $num = strrpos($order_str,'-');
+                if($num !== false){
+                    $order[$key] = substr($order_str,$num+1);
+                }
             }
         }