Changeset 928294

Timestamp:

06/07/2014 09:45:06 PM (12 years ago)

Author:

kylereicks

Message:

updating to version 1.3.3

Location:

picturefillwp/trunk

Files:

• inc/class-model-picturefill-wp.php (modified) (2 diffs)
• inc/class-picturefill-wp.php (modified) (1 diff)
• picturefill-wp.php (modified) (2 diffs)
• readme.txt (modified) (6 diffs)

picturefillwp/trunk/inc/class-model-picturefill-wp.php

@@ -19 +19 @@
 
     static function syntax_present($DOMDocument, $html){
+      $libxml_previous_error_state = libxml_use_internal_errors(true);
       $DOMDocument->loadHTML('<meta http-equiv="Content-Type" content="text/html; charset=UTF-8" />' . $html);
+      apply_filters('picturefill_wp_syntax_present_libxml_errors', libxml_get_errors(), $html, $DOMDocument);
+      libxml_clear_errors();
+      libxml_use_internal_errors($libxml_previous_error_state);
       $spans = $DOMDocument->getElementsByTagName('span');
       if(0 === $spans->length){
@@ -33 +37 @@
 
     static function get_images($DOMDocument, $html){
+      $libxml_previous_error_state = libxml_use_internal_errors(true);
       $DOMDocument->loadHTML('<meta http-equiv="Content-Type" content="text/html; charset=UTF-8" />' . $html);
+      apply_filters('picturefill_wp_get_images_libxml_errors', libxml_get_errors(), $html, $DOMDocument);
+      libxml_clear_errors();
+      libxml_use_internal_errors($libxml_previous_error_state);
       return $DOMDocument->getElementsByTagName('img');
     }

picturefillwp/trunk/inc/class-picturefill-wp.php

@@ -61 +61 @@
     }
 
-    public function cache_picturefill_output($html, $content_type){
-      global $wp_scripts, $page;
-      if(!isset($content_type)){
-        return $html;
-      }
-      $post_id = get_the_ID();
+    public function cache_picturefill_output($html, $content_type = 'depreciated'){
+      global $wp_scripts;
+      $html_hash = md5($html);
       $cache_duration = apply_filters('picturefill_wp_cache_duration', 86400);
-      $cached_output = get_transient('picturefill_wp_' . $content_type . '_output_' . $post_id . '_p' . $page);
-      if(is_singular() && is_main_query() && !empty($cached_output) && (get_option('_transient_timeout_picturefill_wp_' . $content_type . '_output_' . $post_id . '_p' . $page) - $cache_duration) > get_the_modified_time('U') && (get_option('picturefill_wp_update_timestamp') - $cache_duration) > get_the_modified_time('U')){
+      $cached_output = get_transient('picturefill_wp_output_' . $html_hash);
+      if(!empty($cached_output)){
         wp_enqueue_script('picturefill');
         return $cached_output;
       }else{
         $output = $this->replace_images($html);
-        if(is_singular() && is_main_query() && in_array('picturefill', $wp_scripts->queue)){
-          set_transient('picturefill_wp_' . $content_type . '_output_' . $post_id . '_p' . $page, $output, $cache_duration);
+        if($output !== $html){
+          set_transient('picturefill_wp _output_' . $html_hash, $output, $cache_duration);
         }
         return $output;

picturefillwp/trunk/picturefill-wp.php

@@ -6 +6 @@
 Description: A wordpress plugin to load responsive/retina images via picturefill.js.
 Author: Kyle Reicks
-Version: 1.3.2
+Version: 1.3.3
 Author URI: http://github.com/kylereicks/
 */
@@ -12 +12 @@
 define('PICTUREFILL_WP_PATH', plugin_dir_path(__FILE__));
 define('PICTUREFILL_WP_URL', plugins_url('/', __FILE__));
-define('PICTUREFILL_WP_VERSION', '1.3.2');
+define('PICTUREFILL_WP_VERSION', '1.3.3');
 
 require_once(PICTUREFILL_WP_PATH . 'inc/class-picturefill-wp.php');

picturefillwp/trunk/readme.txt

@@ -4 +4 @@
 Tags: images, retina, retina images, responsive images, picturefill, picturefillJS, picturefill.js, HDPI, High DPI
 Requires at least: 3.2
-Tested up to: 3.9
-Stable tag: 1.3.2
+Tested up to: 3.9.1
+Stable tag: 1.3.3
 License: GPLv2 or later
 License URI: http://www.gnu.org/licenses/gpl-2.0.html
@@ -25 +25 @@
 If you are installing Picturefill.WP on a large and image heavy site, you may want to consider using another plugin like [Regenerate Thumbnails](http://wordpress.org/plugins/regenerate-thumbnails/) to create the new image sizes for existing posts and pages.
 
+####500 or 504 server errors
+
+These errors are related to the slow loading listed above. If the server reaches its timeout limit before it is finished processing new images, it will return a 500 or 504 error. Refreshing the page usually gives the server the time it needs to finish processing the images. On some image-heavy posts, it may take more than one refresh.
+
 ####Image Sizes
 
@@ -35 +39 @@
 ####Errors and Warnings
 
-When using Picturefill.WP with your website, you may occasionally notice a warning very much like the following:
-
-    [Mon Jan 01 12:00:00 2000] [error] [client 999.999.99.99] PHP Warning: DOMDocument::loadHTML() [domdocument.loadhtml]: Unexpected end tag : a in Entity, line: 17 in /server/www/wp-content/plugins/picturefill/inc/class-model-picturefill-wp.php on line 20
-
-This error indicates improperly formed HTML. In this case, the `Unexpected end tag : a` comes from nested links. If you are seeing errors like this on your WordPress site, you may want to consider implementing an [error logging](http://codex.wordpress.org/Editing_wp-config.php#Configure_Error_Logging) system, or alternatively suppressing errors by adding `error_reporting(0);` and `@ini_set('display_errors', 0);` to `wp-config.php`.
-
-Additionally, the PHP DOM parser `DOMDocument` often has trouble with HTML5 elements and may throw an error if your post includes a `<canvas>` element, or a `<section>` element, for example. All the more reason to implement an error handling system on production sites.
+As of version 1.3.3 Picturefill.WP suppresses errors and warnings in parsing the DOM. Errors and warnings can now be collected via the `picturefill_wp_syntax_present_libxml_errors` and `picturefill_wp_get_images_libxml_errors` filters.
+
+    add_filter('picturefill_wp_get_images_libxml_errors', 'handle_errors');
+
+    function handle_errors($errors){
+      foreach($errors as $error){
+        // Handle errors here.
+      }
+    }
 
 ####Theme CSS
@@ -116 +122 @@
 The standard version of [picturefill.js](https://github.com/scottjehl/picturefill) will work well enough with Picturefill.WP; however, Picturefill.WP has a slightly diferent goal than picturefill.js. Picturefill.js aims to pollyfill the proposed `<picture>` element. It expects a special `<picture>` like markup, and outputs the appropriate `<img>`, but the resulting `<img>` does not include a class, id or other attribute. The generated `<img>` tags can only be targeted by the attributes of its parent elements. Picturefill.WP aims to take an `<img>` and then output an `<img>` exactly like it, apart form the width or pixel density. This way, `<img>` tags can be targeted without regard to the `<picture>` syntax.
 
-= Is the picture element really the direction responsive images are heading? =
-
-The debate over what to do about responsive images has been long and vigorous, but the `picture` element is happening. The major browsers have anounced that they will be adding support in the very near future. The future of this plugin will depend on what that support looks like, both in the browser and in the WordPress core. Picturefill.WP was never intended to be a permanent solution for responsive images. One day soon, it may be completely unnecessary. In the mean time, Picturefill.WP provides a serviceable solution that can be turned off at any time. Once deactivated, all images return to normal, as though the plugin had never been used.
+= Are there any plans to update this plugin to Picturefill 2.0 =
+
+A new version of Picturefill.WP using Picturefill 2.x is in the works. Because of significant diferences between Picturefill 1.x and Picturefill 2.x, the new Picturefill.WP 2 will be maintained alongside the original Picteufill.WP 1.3.x. I will update this plugin with more details as they become available.
+
 
 == Advanced Use ==
@@ -137 +144 @@
 
 == Changelog ==
+
+= 1.3.3 =
+* [Suppress warnings](https://github.com/kylereicks/picturefill.js.wp/issues/29) from DOM parsing
+* [Update transient caching](https://github.com/kylereicks/picturefill.js.wp/issues/31) to use a hash as an identifier. 
 
 = 1.3.1 =
@@ -196 +207 @@
 == Upgrade Notice ==
 
-= 1.3.2 =
-Corrects an issue with IE7 and below, and enqueues picturefill.js when manual picturefill syntax is present.
+= 1.3.3 =
+[Suppress warnings](https://github.com/kylereicks/picturefill.js.wp/issues/29) from DOM parsing and [update transient caching](https://github.com/kylereicks/picturefill.js.wp/issues/31) to use a hash as an identifier.