Changeset 793455

Timestamp:

10/25/2013 08:57:49 AM (12 years ago)

Author:

vicchi

Message:

Committing v3.3.2 changes

Location:

wp-biographia/trunk

Files:

• help/whatsnew-332.html (added)
• readme.txt (modified) (3 diffs)
• wp-biographia.php (modified) (4 diffs)

wp-biographia/trunk/readme.txt

@@ -3 +3 @@
 Donate link: http://www.vicchi.org/codeage/donate/
 Tags: wp-biographia, wp biographia, biographia, bio, biography, bio box, biography box, twitter, facebook, linkedin, googleplus, google+, delicious, flickr, picasa, vimeo, youtube, reddit, website, about, author, user, about author, user box, author box, contributors, author biography, user biography, avatar, gravatar, guest post, guest author
-Requires at least: 3.4
-Tested up to: 3.5.0
-Stable tag: 3.3.1
+Requires at least: 3.7
+Tested up to: 3.7.0
+Stable tag: 3.3.2
 License: GPLv2 or later
 License URI: http://www.gnu.org/licenses/gpl-2.0.html
@@ -221 +221 @@
 == Changelog ==
 
-The current version is 3.3.1 (2012.12.18)
+The current version is 3.3.2 (2013.10.25)
+
+= 3.3.2 =
+* Released 2013.10.25
+* Fixed: After upgrading to WordPress 3.7, all posts are considered to be excluded by category due to an apparent change in WP 3.7's handling of categories (exposed via the plugin's use of in_category). The plugin now checks for a non empty set of category exclusions before checking
+the post for a category.
 
 = 3.3.1 =
@@ -387 +392 @@
 
 == Upgrade Notice ==
+= 3.3.2 =
+This version now supports changes in category behaviour introduced in WordPress v3.7 and which meant every post was considered to be excluded by category.
 
 = 3.3.1 =

wp-biographia/trunk/wp-biographia.php

@@ -4 +4 @@
 Plugin URI: http://www.vicchi.org/codeage/wp-biographia/
 Description: Add and display a customizable author biography for individual posts, in RSS feeds, on pages, in archives and on each entry on the landing page and much more.
-Version: 3.3.1
+Version: 3.3.2
 Author: Gary Gale & Travis Smith
 Author URI: http://www.garygale.com/
@@ -106 +106 @@
     
         const OPTIONS = 'wp_biographia_settings';
-        const VERSION = '330';
-        const DISPLAY_VERSION = 'v3.3.0';
+        const VERSION = '332';
+        const DISPLAY_VERSION = 'v3.3.2';
         const PRIORITY = 10;
         const META_NONCE = 'wp-biographia-meta-nonce';
@@ -986 +986 @@
 
             if (!is_page ()) {
-                $categories = explode (',', $settings['wp_biographia_category_exclusions']);
-                if (!empty ($categories)) {
-                    foreach ($categories as $category) {
-                        if (in_category ($category, $post->ID)) {
-                            $excluded = true;
-                            break;
-                        }
-                    }   // end-foreach (...)
+                // It looks like the behaviour of in_category() has changed in WP 3.7. Prior
+                // to this release a call to in_category() with an empty $category argument
+                // returned false (due to explode returning an array with a single empty
+                // element if wp_biographia_category_exclusions was set to ''), but after
+                // upgrading to WP 3.7, in_category() now returns true in this case, which
+                // effectively means every single post is excluded from displaying the
+                // Biography Box. Not good. So now, check whether this option is empty and
+                // then only check for category exclusions if there's at least one category
+                // configured for exclusion.
+                //
+                // You could argue that this was a bug waiting to happen if you're being
+                // uncharitable. I'd tend to agree with you.
+                
+                if (isset($settings['wp_biographia_category_exclusions']) &&
+                        !empty($settings['wp_biographia_category_exclusions'])) {
+                    $categories = explode (',', $settings['wp_biographia_category_exclusions']);
+                    if (!empty ($categories)) {
+                        foreach ($categories as $category) {
+                            if (in_category ($category, $post->ID)) {
+                                $excluded = true;
+                                break;
+                            }
+                        }   // end-foreach (...)
+                    }
                 }
             }
@@ -2469 +2485 @@
                         $this->admin_upgrade_option ($settings, 'admin_lock_to_loop', '');
                         $this->admin_upgrade_option ($settings, 'style_border_color', '#000000');
+
+                    case '332':
                         $settings['wp_biographia_version'] = self::VERSION;
                         $upgrade_settings = true;