Changeset 730333

Timestamp:

06/23/2013 12:14:07 PM (13 years ago)

Author:

rolice

Message:

v1.3

• Fix of inner join with left one in join method. This fixes the bug with disappeared custom posts.
• New settings field for custom post types in plugin admin. For now it tells WordPress to make Sorting column sortable, since the plugin is attached to any post type.
• General code refactoring.

Location:

post-sorter/trunk

Files:

• css/style.css (modified) (1 diff)
• page/general.php (modified) (1 diff)
• post_sorter.php (modified) (5 diffs)
• readme.txt (modified) (2 diffs)
• uninstall.php (modified) (1 diff)

post-sorter/trunk/css/style.css

@@ -24 +24 @@
 .post_sorter_form .controller { margin-top: 24px; clear: both; }
 
-.post_sorter_form input[type="checkbox"], .post_sorter_form input[type="radio"]
+.post_sorter_form input[type="checkbox"],
+.post_sorter_form input[type="radio"]
 {
     margin-right: 16px;
 }
 
-.post_sorter_form textarea {}
-.post_sorter_form textarea[readonly="readonly"] { background-color: #eee; }
+.post_sorter_form input[type="text"],
+.post_sorter_form textarea
+{
+    width: 480px;
+}
+
+.post_sorter_form input[type="text"][readonly="readonly"],
+.post_sorter_form textarea[readonly="readonly"]
+{ background-color: #eee; }

post-sorter/trunk/page/general.php

@@ -54 +54 @@
                         <input name="post_sorter_arrows_enabled" id="post_sorter_arrows_enabled" type="checkbox" <?php checked( 1, get_option( 'post_sorter_arrows_enabled' ) )?> />
                         <span class="hint"><?php _e( 'Allows quick sorting with arrow buttons in the sorting column', 'post_sorter' ) ?></span>
+                    </td>
+                </tr>
+                <tr valign="top">
+                    <th scope="row"><label for="post_sorter_custom_types"><?php _e( 'Custom post types', 'post_sorter' ) ?></label>:</th>
+                    <td>
+                        <input name="post_sorter_custom_types" id="post_sorter_custom_types" type="text" value="<?php echo get_option( 'post_sorter_custom_types' ) ?>" /><br />
+                        <span class="hint"><?php _e( 'Enables sorting on the Sorting column for those types.<br />However, the sort column is shown on every post type. Example: <b>custom1, custom2</b>', 'post_sorter' ) ?></span>
                     </td>
                 </tr>

post-sorter/trunk/post_sorter.php

@@ -4 +4 @@
   Plugin URI: http://intellisys.org/
   Description: Plugin for easy sorting of posts and pages by numeric value, both ascending and descending.
-  Version: 1.2
+  Version: 1.3
   Author: Lyubomir Gardev
   Author URI: http://rolice.intellisys.info/
@@ -36 +36 @@
         add_filter( 'manage_edit-page_sortable_columns', array( $this, 'add_sorter_sort' ) );
 
+        $custom_types = get_option( 'post_sorter_custom_types' );
+        $custom_types = explode( ',', sanitize_text_field( trim( str_replace( ' ', '', $custom_types ) ) ) );
+
+        if( $custom_types && is_array( $custom_types ) )
+            foreach( $custom_types as $t )
+                add_filter( 'manage_edit-' . $t . '_sortable_columns', array( $this, 'add_sorter_sort' ) );
 
         //add_filter( 'request', array( $this, 'order_by_at_request' ) );
@@ -210 +216 @@
         }
             
-        $sql .= "INNER JOIN {$wpdb->postmeta} AS post_sorter ON ({$wpdb->posts}.ID = post_sorter.post_id AND post_sorter.meta_key = '" . POST_SORTER_META_KEY . "')";
+        $sql .= "LEFT JOIN {$wpdb->postmeta} AS post_sorter ON ({$wpdb->posts}.ID = post_sorter.post_id AND post_sorter.meta_key = '" . POST_SORTER_META_KEY . "')";
 
         return $sql;
@@ -285 +291 @@
     }
 
+
+    /**
+     * Saves settings for the plugin
+     */
+    public function save_settings() {
+        if ( !current_user_can( 'manage_options' ) )
+            return;
+
+        if ( empty( $_POST ) )
+            return;
+
+        update_option( 'post_sorter_enabled', isset( $_POST['post_sorter_enabled'] ) );
+        update_option( 'post_sorter_direction', isset( $_POST['post_sorter_direction'] ) && mb_strtoupper( $_POST['post_sorter_direction'] ) == 'DESC' ? 'DESC' : ''    );
+
+        $custom_types = isset($_POST['post_sorter_custom_types']) ? $_POST['post_sorter_custom_types'] : ''; // Get custom post types from $_POST or make it empty if no data is received
+        $custom_types = sanitize_text_field( trim( str_replace( ' ', '', $custom_types ) ) ); // cleanup, trimming and space removal
+
+        $custom_types = explode( ',', $custom_types ); // To be sure it explodable
+
+        update_option( 'post_sorter_arrows_enabled', isset( $_POST['post_sorter_arrows_enabled'] ) );
+        update_option( 'post_sorter_custom_types', implode( ', ', $custom_types ) );
+        
+        update_option( 'post_sorter_custom_enabled', isset( $_POST['post_sorter_custom_enabled'] ) );
+        $own_risk = get_option( 'post_sorter_custom_enabled' );
+        
+        update_option( 'post_sorter_join_clause', $own_risk ? $this->_sanitize_sql( $_POST['post_sorter_join_clause'] ) : '' );
+        update_option( 'post_sorter_order_by_clause', $own_risk ? $this->_sanitize_sql( $_POST['post_sorter_order_by_clause'] ) : '' );
+    }
+
     /**
      * Save a position for a given post. Data for post ID and position is retrieved from $_POST
@@ -337 +372 @@
         
         return $sql;
-    }
-    
-    /**
-     * Saves settings for the plugin
-     */
-    public function save_settings() {
-        if ( !current_user_can( 'manage_options' ) )
-            return;
-
-        if ( empty( $_POST ) )
-            return;
-
-        update_option( 'post_sorter_enabled', isset( $_POST['post_sorter_enabled'] ) );
-        update_option(
-            'post_sorter_direction', isset( $_POST['post_sorter_direction'] ) && mb_strtoupper( $_POST['post_sorter_direction'] ) == 'DESC' ? 'DESC' : ''
-        );
-
-        update_option( 'post_sorter_arrows_enabled', isset( $_POST['post_sorter_arrows_enabled'] ) );
-        
-        update_option( 'post_sorter_custom_enabled', isset( $_POST['post_sorter_custom_enabled'] ) );
-        $own_risk = get_option( 'post_sorter_custom_enabled' );
-        
-        update_option( 'post_sorter_join_clause', $own_risk ? $this->_sanitize_sql( $_POST['post_sorter_join_clause'] ) : '' );
-        update_option( 'post_sorter_order_by_clause', $own_risk ? $this->_sanitize_sql( $_POST['post_sorter_order_by_clause'] ) : '' );
     }
 

post-sorter/trunk/readme.txt

@@ -5 +5 @@
 Requires at least: 3.2
 Tested up to: 3.5
-Stable tag: 1.2
+Stable tag: 1.3
 License: GPLv2 or later
 License URI: http://www.gnu.org/licenses/gpl-2.0.html
@@ -67 +67 @@
 == Changelog ==
 
+= 1.3 =
+* Fixed a bug where custom post types disappear from the list. This problem was due to INNER join, but not OUTER.
+* New option for custom post types in the settings. With it post sorter will know which custom post types it has to handle (it handles them already, but some functionality needs explicit telling).
+
 = 1.2 =
 * Fixed a ordering bug where the postmeta.meta_value is sorted as longtext, but not as unsigned int.

post-sorter/trunk/uninstall.php

@@ -8 +8 @@
 
 delete_option( 'post_sorter_arrows_enabled' );
+delete_option( 'post_sorter_custom_types' );
 
 delete_option( 'post_sorter_custom_enabled' );