Changeset 643762

Timestamp:

12/23/2012 07:11:10 PM (13 years ago)

Author:

FranceImage

Message:

test presense of attribute 'id' in javascript before using it

Location:

fi-geolocation/trunk

Files:

• fi-geolocation.php (modified) (1 diff)
• js/showme-where.js (modified) (1 diff)

fi-geolocation/trunk/fi-geolocation.php

@@ -463 +463 @@
             
             $this->has_showme_where = true;
+        }
+        
+        return $ret;
+    }
+    
+    
+    function showme_config() {
+        if($this->has_showme_where) {
             wp_enqueue_script('fi-geolocation-showme-where');
             wp_enqueue_style( 'fi-geolocation-style');
-        }
-        
-        return $ret;
-    }
-    
-    
-    function showme_config() {
-        if($this->has_showme_where) {
-            
+        
             echo '
             <div id="fi-showme-where-popup" style="width:'.$this->options->default_map_width.';height:'.$this->options->default_map_height.';position:absolute;visibility:hidden;top:0;left:0;z-index:9999" coords="'.$this->options->default_map_lat.','.$this->options->default_map_lng.','.$this->options->default_map_zoom.'"></div>

fi-geolocation/trunk/js/showme-where.js

@@ -126 +126 @@
         
         // target id
-        var post_id = $j(this).attr('id').substr('fi-showme-where-'.length);
-        if($j('#fi-showme-where-target-' + post_id).length != 0) {
-            popup_left = $j('#fi-showme-where-target-' + post_id).offset().left;
-            popup_top = $j('#fi-showme-where-target-' + post_id).offset().top;
+        if($j(this).attr('id') !== undefined) {
+            var post_id = $j(this).attr('id').substr('fi-showme-where-'.length);
+            if($j('#fi-showme-where-target-' + post_id).length != 0) {
+                popup_left = $j('#fi-showme-where-target-' + post_id).offset().left;
+                popup_top = $j('#fi-showme-where-target-' + post_id).offset().top;
+            }
         }