Changeset 589574

Timestamp:

08/23/2012 10:12:38 PM (14 years ago)

Author:

submarine

Message:

bug fixed : checkboxes options were not saved correctly

Location:

category-icons/tags/2.2.3

Files:

• category_icons.php (modified) (3 diffs)
• readme.txt (modified) (1 diff)

category-icons/tags/2.2.3/category_icons.php

@@ -1113 +1113 @@
         update_option('igcaticons_max_icons', $_POST['igcaticons_max_icons']);
         update_option('igcaticons_before_name', $_POST['igcaticons_before_name']);
-        if (isset($_POST['igcaticons_templatecode_patch'])) update_option('igcaticons_templatecode_patch', $_POST['igcaticons_templatecode_patch']);
-        if (isset($_POST['igcaticons_templatecode_sidebar'])) update_option('igcaticons_templatecode_sidebar', $_POST['igcaticons_templatecode_sidebar']);
-        update_option('igcaticons_rssfeeds', $_POST['igcaticons_rssfeeds']);
-        if (isset($_POST['igcaticons_useseo_plugin'])) update_option('igcaticons_useseo_plugin', $_POST['igcaticons_useseo_plugin']);
         update_option('igcaticons_max_width', $_POST['igcaticons_max_width']);
         update_option('igcaticons_max_height', $_POST['igcaticons_max_height']);
-        if (isset($_POST['igcaticons_iconcatpage'])) update_option('igcaticons_iconcatpage', $_POST['igcaticons_iconcatpage']);
         
+        bm_caticons_updatemyoption('igcaticons_templatecode_patch');
+        bm_caticons_updatemyoption('igcaticons_templatecode_sidebar');
+        bm_caticons_updatemyoption('igcaticons_rssfeeds');  
+        bm_caticons_updatemyoption('igcaticons_useseo_plugin');
+        bm_caticons_updatemyoption('igcaticons_iconcatpage');       
     }
     
@@ -1137 +1137 @@
 }
 
+function bm_caticons_updatemyoption($option) {
+    if (isset($_POST[$option])) {
+        update_option($option, $_POST[$option]);
+    }
+    else {
+        update_option($option, 0);
+    }  
+}
 /**
  * Display the menu (Icons, Options, Template Tags)
@@ -1189 +1197 @@
             </div>
                 <label><input type="checkbox" name="igcaticons_rssfeeds" id="rssfeeds" value="1" <?php checked('1', get_option('igcaticons_rssfeeds')); ?> />&nbsp;<?php _e('Display category icons in RSS feeds','category_icons'); ?></label>
-                <label><input type="checkbox" name="igcaticons_iconcatpage" id="iconcatpage" value="1" <?php checked('0', get_option('igcaticons_iconcatpage')); ?> />&nbsp;<?php _e('Display only the icon of the selected category in the category page','category_icons'); ?></label>
+                <label><input type="checkbox" name="igcaticons_iconcatpage" id="iconcatpage" value="1" <?php checked('1', get_option('igcaticons_iconcatpage')); ?> />&nbsp;<?php _e('Display only the icon of the selected category in the category page','category_icons'); ?></label>
                 
             <?php if (function_exists('seo_friendly_images')) : ?>

category-icons/tags/2.2.3/readme.txt

@@ -65 +65 @@
 = 2.2.3 =
 * I've added an option in the panel settings for this : "in the category page, only that category icon is displayed in front of the title if the post has more than one category".
+* Bug fixed : the options with a checkbox were not saved correctly (!)
 
 = 2.2.2 =