Changeset 482762

Timestamp:

12/31/2011 01:19:39 PM (14 years ago)

Author:

sebstein

Message:

version: 1.1.0

• feature: set length of title of imported posts
• docs: extended list of frequently asked questions

Location:

g-crossposting/trunk

Files:

• admin.php (modified) (4 diffs)
• gplus-crosspost.php (modified) (4 diffs)
• readme.txt (modified) (3 diffs)

g-crossposting/trunk/admin.php

@@ -57 +57 @@
     // add field for each option
     add_settings_field('g_crossposting_gplusid', __('Your Google+ ID'), 'g_crossposting_gplusid_field', 'g_crossposting', 'g_crossposting_section_main');
-    // https://code.google.com/apis/console/
     add_settings_field('g_crossposting_apikey', __('Your Google API key'), 'g_crossposting_apikey_field', 'g_crossposting', 'g_crossposting_section_main');
     add_settings_field('g_crossposting_user', __('Wordpress user to set as author of imported Google+ activities'), 'g_crossposting_author_field', 'g_crossposting', 'g_crossposting_section_options');
@@ -63 +62 @@
     add_settings_field('g_crossposting_comment', __('Enable comments on imported Google+ activities'), 'g_crossposting_comment_field', 'g_crossposting', 'g_crossposting_section_options');
     add_settings_field('g_crossposting_maxactivities', __('Maximum number of new activities to import'), 'g_crossposting_maxactivities_field', 'g_crossposting', 'g_crossposting_section_options');
+    add_settings_field('g_crossposting_titlelen', __('Maximum length of imported title (set to 0 for full length)'), 'g_crossposting_titlelen_field', 'g_crossposting', 'g_crossposting_section_options');
     add_settings_field('g_crossposting_addcanonical', __('Add canonical meta tag pointing to Google+'), 'g_crossposting_addcanonical_field', 'g_crossposting', 'g_crossposting_section_options');
 }
@@ -88 +88 @@
     $options = get_option('g_crossposting_options');
     echo "<input id='g_crossposting_maxactivities' name='g_crossposting_options[maxactivities]' size='59' maxlength='3' type='text' value='{$options['maxactivities']}' />";
+}
+
+/**
+ *  output the input field for the maximum length of post title
+ */
+function g_crossposting_titlelen_field() {
+    $options = get_option('g_crossposting_options');
+    echo "<input id='g_crossposting_titlelen' name='g_crossposting_options[titlelen]' size='59' maxlength='3' type='text' value='{$options['titlelen']}' />";
 }
 
@@ -190 +198 @@
         $new_input['maxactivities'] = 1;
         g_crossposting_add_error('g_crossposting_err_maxactivities', __("The maximum number of activities to import must be a number between 1 and 100."));
+    }
+
+    // validate maximum length of title field
+    $new_input['titlelen'] = trim($input['titlelen']);
+    if (! g_crossposting_check_titlelen($new_input['titlelen'])) {
+        $new_input['titlelen'] = 0;
+        g_crossposting_add_error('g_crossposting_err_titlelen', __("The maximum length of post title should be a number between 0 and 100."));
     }
 

g-crossposting/trunk/gplus-crosspost.php

@@ -4 +4 @@
     Plugin URI: http://wordpress.org/extend/plugins/g-crossposting/
     Description: Imports your public Google+ activities in your Wordpress blog.
-    Version: 1.0.1
+    Version: 1.1.0
     Author: Sebastian Stein
     Author URI: http://sebstein.hpfsc.de/
@@ -175 +175 @@
     // go on validating remaining settings
     if (! g_crossposting_check_maxactivities($options['maxactivities'])) {
+        return FALSE;
+    }
+
+    if (! g_crossposting_check_titlelen($options['titlelen'])) {
         return FALSE;
     }
@@ -323 +327 @@
 
         // set title for post
-        // TODO Make this a setting?
         if ($activity->title) {
-            $post_title = substr($activity->title, 0, 35).'…';
+            $post_title = $activity->title;
         } else if ($att_title) {
-            $post_title = substr($att_title, 0, 35).'…';
+            $post_title = $att_title;
         } else {
             $post_title = 'Google+ post: No title available…';
+        }
+        // shorten post title if required
+        if ($options['titlelen'] > 0 && strlen($post_title) > $options['titlelen']) {
+            $post_title = substr($post_title, 0, $options['titlelen']).'…';
         }
 
@@ -405 +412 @@
 
 /**
+ *  maximum length of post title to import
+ *
+ *  @return true if this is set to a number from 0 to 100
+ */
+function g_crossposting_check_titlelen($given_titlelen) {
+    // must be number from 0 to 100
+    if (!is_numeric($given_titlelen) || $given_titlelen < 0 || $given_titlelen > 100) {
+        return FALSE;
+    }
+
+    return TRUE;
+}
+
+/**
  *  simple binary option whether canonical tag should be added
  *

g-crossposting/trunk/readme.txt

@@ -4 +4 @@
 Tags: google, googleplus, posts
 Requires at least: 3.0.0
-Tested up to: 3.2.1
-Stable tag: 1.0.1
+Tested up to: 3.3.0
+Stable tag: 1.1.0
 
 Imports your public Google+ activities in your Wordpress blog.
@@ -50 +50 @@
 1. There you are, it is written next to the API key label.
 
-It might be that there no key yet, but a button to generate one. In that case,
-click the button first. There should also be a *Generate new key* link on this
-page.
+It might be that there is no key yet, but a button to generate one. In that
+case, click the button first. There should also be a *Generate new key* link on
+this page.
+
+Important: Don't forget to activate your key! It is not enough to just generate
+one, but you need to activate it on those Google pages, too.
+
+= I can't set my Google+ ID or Google API key in the setting form. Why do they disappear? =
+
+After you entered a Google+ ID or Google API key in the settings form of this
+plugin and confirm your change, the plugin will try to access your public
+Google+ profile. For this purpose, it uses the Google+ ID and the Google API key
+you provided. If access fails, one of both or even both of them must be wrong.
+However, the plugin can't determine which one is wrong. Therefore, it removes
+both settings again to show you that something must have been wrong.
+
+= Everything is set up properly, but it doesn't import anything? =
+
+This plugin only imports your public Google+ activities. It won't access your
+private posts on Google+, which you only shared with some circles. If you have
+never posted anything in public, this plugin won't import anything to your blog.
+
+This should prevent that people make something public by accident. If you want
+something to also appear in your blog, make sure to share it with the public
+first!
+
+= Post titles are still shortened, even if I set length to 0 (meaning unlimited length)? =
+
+Google+ itself limits the length of a post title. If you set 0 for the length of
+the post title, the plugin will import the whole title provided by Google+. If
+Google+ shortens your title, there is nothing this plugin can do.
 
 == Screenshots ==
@@ -59 +87 @@
 
 == Changelog ==
+
+= 1.1.0 =
+* make sure to post on Google+ that you are using this plugin!!!
+* feature: set length of title of imported posts
+* docs: extended list of frequently asked questions
 
 = 1.0.1 =