WordPress.org
Get WordPress

Plugin Directory

Changeset 425427


Ignore:
Timestamp:
08/18/2011 03:44:53 PM (14 years ago)
Author:
mdbitz
Message:

Restriction of preview servlet to edtior enabled users and removal of html entities and escaping of strings in styling code to remove XSS vulnerability

Location:
wordpress-amazon-associate/trunk
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • wordpress-amazon-associate/trunk/WPAA/ShortCodeHandler.php

    r410533 r425427  
    202202        $output = "";
    203203        if( ! empty($options['container']) ) {
     204            // strip inclusion of html entities
     205            $options['container'] = strip_tags( $options['container'] );
    204206            $output = "<" . $options['container'];
    205207            if( ! empty($options['container_class']) ) {
    206                 $output .= ' class="' . $options['container_class'] . '"';
     208                $output .= ' class="' . htmlentities(strip_tags($options['container_class']), ENT_COMPAT) . '"';
    207209            }
    208210            if( ! empty($options['container_style']) ) {
    209                 $output .= ' style="' . $options['container_style'] . '"';
     211                $output .= ' style="' . htmlentities(strip_tags($options['container_style']), ENT_COMPAT) . '"';
    210212            }
    211213            return $output . ">" . $output_str . "</" . $options['container'] . ">";

  • wordpress-amazon-associate/trunk/readme.txt

    r421932 r425427  
    188188The full project changelogs can be found at [http://labs.mdbitz.com/wordpress/wordpress-amazon-associate-plugin/changelog](http://labs.mdbitz.com/wordpress/wordpress-amazon-associate-plugin/changelog/?utm_source=wordpress&utm_medium=plugin-readme&utm_campaign=plugin)
    189189
    190 = 1.7.4 - 08/10/2011 =
     190= 1.7.4 - 08/18/2011 =
    191191* Removal of activate / deactivate hooks as per newly communicated [plugin guidelines](http://labs.mdbitz.com/2011/08/the-hidden-plugin-guidelines-all-wordpress-plugin-developers-should-know/)
     192* Restrition of Preview Servlet to logged in users with edit capability
     193* Tag and Entity Stripping of container, container_class and container_style attributes within preview serlvet to remove vulnerability to xss attacks
    192194
    193195= 1.7.3 - 08/05/2011 =

  • wordpress-amazon-associate/trunk/servlet/preview.php

    r353979 r425427  
    2222// load WordPress
    2323require_once( '../../../../wp-load.php');
     24// User can Edit Content
     25if (current_user_can('edit_posts') ) {
    2426?>
    2527<html>
    … …  
    2830        <?php
    2931        $width = '600';
    30         if (!empty($_GET['width'])) {
     32        if (!empty($_GET['width']) && is_numeric( $_GET['width']) ) {
    3133            $width = $_GET['width'];
    3234        }
    3335        $height = '600';
    34         if (!empty($_GET['height'])) {
     36        if (!empty($_GET['height']) && is_numeric( $_GET['height'])) {
    3537            $height = $_GET['height'];
    3638        }
    … …  
    8385    </body>
    8486</html>
     87<?php }

  • wordpress-amazon-associate/trunk/wordpress_amazon_associate.php

    r421932 r425427  
    4545global $wpaa_update_date;
    4646$wpaa_version = "1.7.4";
    47 $wpaa_update_date = "08-10-2011";
     47$wpaa_update_date = "08-18-2011";
    4848
    4949// load Admin Class
Note: See TracChangeset for help on using the changeset viewer.