Changeset 3462482

Timestamp:

02/16/2026 12:06:35 PM (5 days ago)

Author:

gkanters

Message:

Harden language switcher behavior across themes by preventing hash-anchor hijacks, replacing fixed mobile init timeout with retry binding, removing fragile style-attribute CSS selector, and using translated title cleanup plus root-safe redirect.

Location:

ai-translate/trunk

Files:

• ai-translate.php (modified) (2 diffs)
• assets/language-switcher.css (modified) (1 diff)
• assets/language-switcher.js (modified) (3 diffs)
• assets/switcher.js (modified) (1 diff)

ai-translate/trunk/ai-translate.php

@@ -654 +654 @@
                 \AITranslate\AI_Lang::set_cookie((string) $defaultLang);
                 \AITranslate\AI_Lang::set_current((string) $defaultLang);
-                // Add JavaScript redirect to / after page renders
+                // Add JavaScript redirect to site root after page renders
                 add_action('wp_footer', function() {
-                    echo '<script>setTimeout(function(){window.location.href="/";},100);</script>';
+                    echo '<script>window.location.replace(' . wp_json_encode(home_url('/')) . ');</script>';
                 }, 999);
                 // Continue to render page - Rule 3 below will be skipped
@@ -2931 +2931 @@
                 $menu_item->ID,
                 array(
-                    'menu-item-title' => 'Language Switcher'
+                            'menu-item-title' => __('Language Switcher', 'ai-translate')
                 )
             );

ai-translate/trunk/assets/language-switcher.css

@@ -126 +126 @@
 
 /* Force show submenu when JavaScript sets ai-force-show class */
-.menu-item-language-switcher .sub-menu.ai-force-show,
-.menu-item-language-switcher .sub-menu[style*="display: block"] {
+.menu-item-language-switcher .sub-menu.ai-force-show {
     display: block !important;
     opacity: 1 !important;

ai-translate/trunk/assets/language-switcher.js

@@ -218 +218 @@
  */
 function initMobileMenuSupport() {
-    // Wait for mobile menu to be ready
-    setTimeout(function() {
+    let attempts = 0;
+    const maxAttempts = 10;
+
+    function bindMobileSwitchers() {
         // Find language switcher menu items
         const languageItems = document.querySelectorAll('.menu-item-language-switcher');
+        let boundCount = 0;
 
         languageItems.forEach(function(item) {
@@ -229 +232 @@
             // Only handle dropdown items (with submenu), inline items work without JS
             if (link && submenu) {
+                if (link.getAttribute('data-ai-mobile-bound') === '1') {
+                    return;
+                }
+                link.setAttribute('data-ai-mobile-bound', '1');
+                boundCount++;
+
                 // Add click handler for mobile
                 link.addEventListener('click', function(event) {
+                    // Prevent hash-jumps and theme anchor handlers from hijacking this toggle.
+                    event.preventDefault();
+
                     // Only handle click on mobile/tablet (screen width <= 768px)
                     if (window.innerWidth <= 768) {
-                        event.preventDefault();
                         event.stopPropagation();
 
@@ -270 +281 @@
         });
 
-
-    }, 1000); // Shorter timeout for testing
+        // Retry shortly for themes that render/replace menus after initial load.
+        if (boundCount === 0 && attempts < maxAttempts) {
+            attempts++;
+            setTimeout(bindMobileSwitchers, 300);
+        }
+    }
+
+    bindMobileSwitchers();
 }

ai-translate/trunk/assets/switcher.js

@@ -64 +64 @@
       // Handle dropdown toggle button clicks
       b.addEventListener("click", function (e) {
+        e.preventDefault();
         e.stopPropagation();
         var open = !w.classList.contains("ai-trans-open");