Changeset 3455441

Timestamp:

02/06/2026 01:53:51 PM (7 weeks ago)

Author:

whiteshadow

Message:

Attempted fix for a PHP compatibility issue where using PHP versions older than 8.1 could lead to errors like "Fatal error: Uncaught Error: Cannot unpack Traversable with string keys".

File:

• admin-menu-editor/trunk/includes/module.php (modified) (1 diff)

admin-menu-editor/trunk/includes/module.php

@@ -326 +326 @@
 
     public function getIterator(): Traversable {
-        return new ArrayIterator($this->selectedDeps);
+        //PHP < 8.1 compatibility: We use the iterator with a splat operator later, which
+        //doesn't support arrays/Traversable with string keys. So we reindex the array here.
+        return new ArrayIterator(array_values($this->selectedDeps));
     }