Changeset 3451457

Timestamp:

02/01/2026 03:40:27 PM (8 weeks ago)

Author:

jackdewey

Message:

1.6.4

• Fixed potential security issue

Location:

tune-library/trunk

Files:

• readme.txt (modified) (2 diffs)
• tune-library.php (modified) (5 diffs)
• writeNodes.php (modified) (4 diffs)

tune-library/trunk/readme.txt

@@ -4 +4 @@
 Tags: iTunes, music, collection, list, XML, AJAX
 Requires at least: 2.7
-Tested up to: 6.8.2
-Stable tag: 1.6.3
+Tested up to: 6.9
+Stable tag: 1.6.4
 
 Import your iTunes music list into Wordpress and display your song collection on any page.
@@ -28 +28 @@
 
 == Changelog ==
+
+= 1.6.4 =
+* Fixed potential security issue
 
 = 1.6.3 =

tune-library/trunk/tune-library.php

@@ -4 +4 @@
 Plugin URI: https://ylefebvre.github.io/wordpress-plugins/tune-library/
 Description: A plugin that can be used to import an iTunes Library into a MySQl database and display the contents of the collection on a Wordpress Page.
-Version: 1.6.3
+Version: 1.6.4
 Author: Yannick Lefebvre
 Author URI: https://ylefebvre.github.io/
@@ -175 +175 @@
 
             if ( isset( $_POST['importitunes'] ) ) {
+
+                // ADD: Capability check and nonce validation
+                if ( !current_user_can( 'manage_options' ) ) {
+                    die( __( 'Unauthorized' ) );
+                }
+
+                check_admin_referer( 'tunelibrarypp-config' );
+
                 echo "<div id='message' class='updated fade'>";
                 $options  = get_option('TuneLibraryPP');
@@ -218 +226 @@
                 echo '</div>';
             } elseif ( isset( $_POST['importcsv'] ) ) {
+
+                // ADD: Capability check and nonce validation
+                if ( !current_user_can( 'manage_options' ) ) {
+                    die( __( 'Unauthorized' ) );
+                }
+
+                check_admin_referer( 'tunelibrarypp-config' );
+
                 global $wpdb;
                 $row = 0;
@@ -233 +249 @@
                         if (!$skiprow) {
                             if ( count( $data ) == 5 ) {
-                                $wpdb->insert( $wpdb->get_blog_prefix() . "tracks", array( 'title' => $data[0], 'artist' => $data[1], 'albumartist' => $data[2], 'album' => $data[3], 'tracknum' => $data[4] ) );
+                                $wpdb->insert( $wpdb->get_blog_prefix() . "tracks", array( 'title' => sanitize_text_field( $data[0] ), 'artist' => sanitize_text_field( $data[1] ), 'albumartist' => sanitize_text_field( $data[2] ), 'album' => sanitize_text_field( $data[3] ), 'tracknum' => intval( $data[4] ) ) );
                             }
                         }
@@ -308 +324 @@
                     <input type="hidden" name="action" value="tune_lib_admin" />
                     <input type="hidden" name="MAX_FILE_SIZE" value="128000000" />
+
                     <table class="form-table" style="width:100%;">
                     <?php

tune-library/trunk/writeNodes.php

@@ -15 +15 @@
         
         foreach($tracks as $track){
-            echo "<li><a href='#'> ".$track->album."</a>
+            echo "<li><a href='#'> ". esc_html( $track->album )."</a>
                 <ul>
                     <li parentId='album::".urlencode($itemData)."::".urlencode($track->album)."'><a href='#'>Loading...</a></li>
@@ -29 +29 @@
         
         foreach($tracks as $track){
-            echo "<li><a href='#'> ".$track->album."</a>
+            echo "<li><a href='#'> ". esc_html( $track->album )."</a>
                 <ul>
                     <li parentId='albumvarious::".urlencode($itemData)."::".urlencode($track->album)."'><a href='#'>Loading...</a></li>
@@ -67 +67 @@
                 echo '<li class="dhtmlgoodies_sheet.gif"><a href="#" disabled></a> ';
                 if ( isset( $track['diskid'] ) && ( 1 != $track['diskid'] || count( $disk_id_array ) > 1 ) ) {
-                    echo $track['diskid'] . ' - ';
+                    echo intval( $track['diskid'] ) . ' - ';
                 }
-                echo $track['tracknum'] . ' - ' . $track['title'] . '</li>';
+                echo intval( $track['tracknum'] ) . ' - ' . esc_html( $track['title'] ) . '</li>';
             } else {
-                echo "<li class='dhtmlgoodies_sheet.gif'><a href='#' disabled></a> " . $track['title'] . '</li>';
+                echo "<li class='dhtmlgoodies_sheet.gif'><a href='#' disabled></a> " . esc_html( $track['title'] ) . '</li>';
             }
         }
@@ -109 +109 @@
                 echo '<li class="dhtmlgoodies_sheet.gif"><a href="#" disabled></a> ';
                 if ( isset( $track['diskid'] ) && ( 1 != $track['diskid'] || count( $disk_id_array ) > 1 ) ) {
-                    echo $track['diskid'] . ' - ';
+                    echo intval( $track['diskid'] ) . ' - ';
                 }
-                echo $track['tracknum'] . ' - ' . $track['artist'] . ' - ' . $track['title'] . '</li>';
+                echo intval( $track['tracknum'] ) . ' - ' . esc_html( $track['artist'] ) . ' - ' . esc_html( $track['title'] ) . '</li>';
             } else {
-                echo '<li class="dhtmlgoodies_sheet.gif"><a href="#" disabled></a> ' . $track['title'] . '</li>';
+                echo '<li class="dhtmlgoodies_sheet.gif"><a href="#" disabled></a> ' . esc_html( $track['title'] ) . '</li>';
             }
         }