Changeset 3443546

Timestamp:

01/20/2026 08:09:40 PM (5 weeks ago)

Author:

routedev

Message:

bugfix: improve how order metadata is handled

Location:

routeapp/trunk

Files:

• public/class-routeapp-public.php (modified) (8 diffs)
• readme.txt (modified) (2 diffs)
• routeapp.php (modified) (2 diffs)

routeapp/trunk/public/class-routeapp-public.php

@@ -846 +846 @@
                 throw new Exception( "Order with ID {$order_id} could not be retrieved." );
             }
-
-            $this->updateRouteIncludedOrderStatusMetaFields( $order );
-
+            $is_hpos = class_exists('Automattic\WooCommerce\Utilities\OrderUtil')
+                       && OrderUtil::custom_orders_table_usage_is_enabled();
+
+            $acceptedOrderStatuses = get_option('routeapp_included_order_statuses') ? get_option('routeapp_included_order_statuses') : [];
+            $acceptedCanceledStatuses = get_option('routeapp_cancel_order_statuses') ? get_option('routeapp_cancel_order_statuses') : [];
+
+            $updated = false;
+            $updated |= $this->updateRouteOrderMetaData( $order, $is_hpos, '_routeapp_included_order_statuses', $acceptedOrderStatuses );
+            $updated |= $this->updateRouteOrderMetaData( $order, $is_hpos, '_routeapp_cancel_order_statuses', $acceptedCanceledStatuses );
+
+            if ($updated && $is_hpos) {
+                $order->save();
+            }
         } catch ( Exception $e ) {
             error_log( "An error occurred while updating Route order status meta fields for order ID {$order_id}: " . $e->getMessage() );
@@ -866 +876 @@
         }
         $order = wc_get_order($order_id);
-        if ( class_exists('Automattic\WooCommerce\Utilities\OrderUtil')
-            && OrderUtil::custom_orders_table_usage_is_enabled() ) {
-            // HPOS usage is enabled.
+        if (!$order) {
+            return;
+        }
+        //MSS-6248, Support High-Performance Order Storage (HPOS); fall back to legacy order storage when disabled.
+        $is_hpos = class_exists('Automattic\WooCommerce\Utilities\OrderUtil')
+                   && OrderUtil::custom_orders_table_usage_is_enabled();
+
+        $updated = false;
+
+        if ($is_hpos) {
             $quote = $order->get_meta('_routeapp_quote');
         } else {
@@ -874 +891 @@
             $quote = get_post_meta($order->get_id(), '_routeapp_quote', true);
         }
-        if (!$quote) {
+
+        if (!$quote) {
             $cartRef = $order->get_cart_hash();
             if (!$cartRef) {
@@ -886 +904 @@
                 if (isset($cached) && is_array($cached) && isset($cached['body'])) {
 
-                    $acceptedOrderStatuses = get_option('routeapp_included_order_statuses') ? get_option('routeapp_included_order_statuses') : [];
-                    $acceptedCanceledStatuses = get_option('routeapp_cancel_order_statuses') ? get_option('routeapp_cancel_order_statuses') : [];
-
                     $fees = $order->get_items('fee');
                     if (!empty($fees)) {
                         foreach ($fees as $fee) {
                             if ($fee->get_name() === $this->routeapp_get_insurance_label()) {
-                                $insurance_selected = true;
                                 $insurance_amount = $fee->get_amount();
-                                if (class_exists('Automattic\WooCommerce\Utilities\OrderUtil')
-                                    && OrderUtil::custom_orders_table_usage_is_enabled()) {
-                                    // HPOS usage is enabled.
-                                    $order->update_meta_data('_routeapp_route_charge', $insurance_amount);
-                                    $order->update_meta_data('_routeapp_route_protection', $insurance_selected);
-                                    $order->save();
-                                } else {
-                                    // Traditional CPT-based orders are in use.
-                                    update_post_meta($order->get_id(), '_routeapp_route_charge', $insurance_amount);
-                                    update_post_meta($order->get_id(), '_routeapp_route_protection', $insurance_selected);
-                                }
+                                $updated |= $this->updateRouteOrderMetaData( $order, $is_hpos, '_routeapp_route_charge', $insurance_amount );
+                                $updated |= $this->updateRouteOrderMetaData( $order, $is_hpos, '_routeapp_route_protection', true );
                             }
                         }
@@ -917 +922 @@
                                     foreach ($cart_fees as $cart_fee) {
                                         if ($cart_fee->name === $this->routeapp_get_insurance_label()) {
-                                            $insurance_selected = true;
                                             $insurance_amount = $cart_fee->amount; // Correct method for cart fee amount
-
-                                            if (class_exists('Automattic\WooCommerce\Utilities\OrderUtil') &&
-                                                OrderUtil::custom_orders_table_usage_is_enabled()) {
-                                                // HPOS usage is enabled.
-                                                $order->update_meta_data('_routeapp_route_charge', $insurance_amount);
-                                                $order->update_meta_data('_routeapp_route_protection', $insurance_selected);
-                                                $order->save();
-                                            } else {
-                                                // Traditional CPT-based orders are in use.
-                                                update_post_meta($order->get_id(), '_routeapp_route_charge', $insurance_amount);
-                                                update_post_meta($order->get_id(), '_routeapp_route_protection', $insurance_selected);
-                                            }
+                                            $updated |= $this->updateRouteOrderMetaData( $order, $is_hpos, '_routeapp_route_charge', $insurance_amount );
+                                            $updated |= $this->updateRouteOrderMetaData( $order, $is_hpos, '_routeapp_route_protection', true );
                                         }
                                     }
@@ -941 +935 @@
 
                     }
-
-                    if ( class_exists('Automattic\WooCommerce\Utilities\OrderUtil')
-                        && OrderUtil::custom_orders_table_usage_is_enabled() ) {
-                        // HPOS usage is enabled.
-                        $order->update_meta_data('_routeapp_quote', $cached['body'] );
-
-                        //save to order the configuration selected regarding order statuses
-                        $order->update_meta_data('_routeapp_included_order_statuses', json_encode($acceptedOrderStatuses));
-                        $order->update_meta_data( '_routeapp_cancel_order_statuses', json_encode($acceptedCanceledStatuses));
-
-                        $order->save();
-                    } else {
-                        // Traditional CPT-based orders are in use.
-                        update_post_meta( $order->get_id(), '_routeapp_quote', $cached['body'] );
-                        //save to order the configuration selected regarding order statuses
-                        update_post_meta( $order->get_id(), '_routeapp_included_order_statuses', json_encode($acceptedOrderStatuses));
-                        update_post_meta( $order->get_id(), '_routeapp_cancel_order_statuses', json_encode($acceptedCanceledStatuses));
-                    }
+                    $updated |= $this->updateRouteOrderMetaData( $order, $is_hpos, '_routeapp_quote', $cached['body'] );
 
                     //clear cache!
@@ -967 +944 @@
         }
 
-        //Update route included order statuses and route cancel order statuses when the order is created by the admin page without route fee
-        if(is_admin()){
-            $this->updateRouteIncludedOrderStatusMetaFields( $order );
-        }
+        //Add orders status meta data
+        $acceptedOrderStatuses = get_option('routeapp_included_order_statuses') ? get_option('routeapp_included_order_statuses') : [];
+        $acceptedCanceledStatuses = get_option('routeapp_cancel_order_statuses') ? get_option('routeapp_cancel_order_statuses') : [];
+
+        $updated |= $this->updateRouteOrderMetaData( $order, $is_hpos, '_routeapp_included_order_statuses', $acceptedOrderStatuses );
+        $updated |= $this->updateRouteOrderMetaData( $order, $is_hpos, '_routeapp_cancel_order_statuses', $acceptedCanceledStatuses );
+
+        // Save order if there is any update
+        if ($updated && $is_hpos) {
+            $order->save();
+        }
     }
 
@@ -1734 +1718 @@
 
     /**
-     * @param $order
+     * Update order meta only if changed (HPOS & CPT safe)
      *
-     * @return void
+     * @return bool True if meta changed
      */
-    public function updateRouteIncludedOrderStatusMetaFields( $order ): void {
+    public function updateRouteOrderMetaData(
+        WC_Order $order,
+        bool $is_hpos,
+        string $meta_key,
+        $meta_value
+    ): bool {
         try {
-            $acceptedOrderStatuses    = get_option( 'routeapp_included_order_statuses' ) ? get_option( 'routeapp_included_order_statuses' ) : [];
-            $acceptedCanceledStatuses = get_option( 'routeapp_cancel_order_statuses' ) ? get_option( 'routeapp_cancel_order_statuses' ) : [];
-
-            if ( class_exists( 'Automattic\WooCommerce\Utilities\OrderUtil' )
-                 && OrderUtil::custom_orders_table_usage_is_enabled() ) {
-                //save to order the configuration selected regarding order statuses
-                $order->update_meta_data( '_routeapp_included_order_statuses', json_encode( $acceptedOrderStatuses ) );
-                $order->update_meta_data( '_routeapp_cancel_order_statuses', json_encode( $acceptedCanceledStatuses ) );
-                $order->save();
-            } else {
-                update_post_meta( $order->get_id(), '_routeapp_included_order_statuses', json_encode( $acceptedOrderStatuses ) );
-                update_post_meta( $order->get_id(), '_routeapp_cancel_order_statuses', json_encode( $acceptedCanceledStatuses ) );
+            if ( ! $order || empty( $meta_key ) ) {
+                return false;
             }
+
+            $normalized = is_scalar( $meta_value )
+                ? (string) $meta_value
+                : wp_json_encode( $meta_value );
+
+            if ( $is_hpos ) {
+                $current = $order->get_meta( $meta_key, true );
+                $current = is_scalar( $current ) ? (string) $current : wp_json_encode( $current );
+
+
+                if ( (string) $current === (string) $normalized ) {
+                    return false;
+                }
+
+                $order->update_meta_data( $meta_key, $normalized );
+                return true;
+
+            }
+
+            $order_id = $order->get_id();
+            $current = get_post_meta( $order_id, $meta_key, true );
+            $current = is_scalar( $current ) ? (string) $current : wp_json_encode( $current );
+
+
+            if ( (string) $current === (string) $normalized ) {
+                return false;
+            }
+
+            update_post_meta( $order_id, $meta_key, $normalized );
+            return true;
+
         } catch ( Exception $e ) {
-            // Log the exception and ensure the application flow continues
-            error_log( "An error occurred while updating Route order status meta fields: " . $e->getMessage() );
+            error_log(
+                'RouteApp: error updating order meta (' . $meta_key . '): ' . $e->getMessage()
+            );
+            return false;
         }
     }

routeapp/trunk/readme.txt

@@ -6 +6 @@
 Requires at least: 4.0
 Tested up to: 6.7.1
-Stable tag: 2.2.33
+Stable tag: 2.2.34
 Requires PHP: 5.6
 License: GPLv2 or later
@@ -106 +106 @@
 
 == Changelog ==
+
+= 2.2.34 =
+* Fix Route order metadata reliability and prevent duplicate order updates
 
 = 2.2.33 =

routeapp/trunk/routeapp.php

@@ -10 +10 @@
  * Plugin URI:        https://route.com/for-merchants/
  * Description:       Route allows shoppers to insure their orders with one-click during checkout, adding a layer of 3rd party trust while improving the customer shopping experience.
- * Version:           2.2.33
+ * Version:           2.2.34
  * Author:            Route
  * Author URI:        https://route.com/
@@ -26 +26 @@
  * Currently plugin version.
  */
-define( 'ROUTEAPP_VERSION', '2.2.33' );
+define( 'ROUTEAPP_VERSION', '2.2.34' );
 
 /**