Changeset 3423974

Timestamp:

12/19/2025 09:23:09 PM (2 months ago)

Author:

manovermachine

Message:

Version 1.3.10: Critical timezone fix for watchdog alerts + time validation

CRITICAL FIX:

• Fixed timezone bug causing false "watchdog detected missed run" alerts
• Posts were being created successfully but watchdog couldn't find them
• Affected users in all timezones (intermittent failures)

THE PROBLEM:

• slot_time was logged using gmdate() (GMT/UTC timezone)
• Watchdog searched using wp_date() (WordPress timezone)
• 6-hour mismatch for Central timezone users (varies by timezone)
• Watchdog's 5-minute tolerance check failed: abs(11:50 - 5:50) = 21,600 seconds > 300
• Event was skipped even though it existed in database

WHY IT WAS INTERMITTENT:

• Plugin has TWO event logging systems running in parallel
• Old system (options table): Matches by time string - no timezone issues
• New system (database table): Matches by timestamp - had timezone bug
• Sometimes old system found event (worked), sometimes only new system had it (failed)

THE SOLUTION:

• Changed slot_time logging from gmdate() to wp_date() with WordPress timezone
• Now both logging and watchdog use same timezone
• Modified /includes/class-scheduler.php line 173-175

BEFORE:

$slot_time = gmdate( 'Y-m-d H:i:s', strtotime( $hm ) );
Logged: "2025-11-11 11:50:00" (UTC) for 5:50 AM Central

AFTER:

$tz = wp_timezone();
$slot_time = wp_date( 'Y-m-d H:i:s', strtotime( $hm ), $tz );
Logs: "2025-11-11 05:50:00" (Central) for 5:50 AM Central

ADDITIONAL ENHANCEMENT:

• Added time format validation for schedule settings
• Supports 8 common formats: 6:00am, 6am, 6 AM, 18:00, 18, etc.
• Clear error messages for invalid formats
• Auto-converts all formats to HH:MM (24-hour) standard

VALIDATION EXAMPLES:

• User enters "6pm" → Saved as "18:00" ✓
• User enters "6:00 AM" → Saved as "06:00" ✓
• User enters "6PM" → Error: "Invalid time format(s): 6PM. Please use formats like '6:00am', '6:00 AM', '18:00', or '6pm'" ✗

TECHNICAL CHANGES:

• Modified /includes/class-scheduler.php: Fixed timezone in slot_time logging
• Modified /includes/class-admin.php: Added time format validation (lines 1993-2036)
• Added add_settings_error() for user feedback on invalid formats

BENEFITS:

• ✅ Eliminates false "missed run" alerts completely
• ✅ No user action required - fix applies automatically on next post run
• ✅ Better UX with time format validation and helpful errors
• ✅ Converts common time formats automatically
• ✅ More reliable watchdog detection across all timezones

COMPATIBILITY:

• Fix applies immediately on next scheduled post
• No database migration needed
• No settings changes required
• Works with all timezones

USER IMPACT:

• Users will stop receiving false watchdog alerts
• Clear feedback when entering schedule times in invalid formats
• More confidence in scheduled posting reliability

Location:

weather-write/trunk

Files:

• includes/class-rest.php (modified) (2 diffs)
• readme.txt (modified) (2 diffs)
• weather-write.php (modified) (1 diff)

weather-write/trunk/includes/class-rest.php

@@ -73 +73 @@
 
     public static function handle_trigger( WP_REST_Request $request ) {
-        // Verify token
+        // Verify token (can be in query string or body)
         $token = sanitize_text_field( (string) $request->get_param( 'token' ) );
         $expected_token = defined( 'WWRT_CRONJOB_API_TOKEN' ) ? (string) WWRT_CRONJOB_API_TOKEN : '';
@@ -81 +81 @@
         }
         
-        // Get the time slot (optional - if not provided, runs immediately)
-        $time = sanitize_text_field( (string) $request->get_param( 'time' ) );
+        // Get the time slot from JSON body (cron-job.org sends it here)
+        // get_param() reads from query string, but cron-job.org sends time in JSON body
+        $time = '';
+        $body_params = $request->get_json_params();
+        if ( is_array( $body_params ) && isset( $body_params['time'] ) ) {
+            $time = sanitize_text_field( (string) $body_params['time'] );
+        }
+        // Fallback to query string/URL params if not in body
+        if ( empty( $time ) ) {
+            $time = sanitize_text_field( (string) $request->get_param( 'time' ) );
+        }
         
         // Trigger the post generation directly

weather-write/trunk/readme.txt

@@ -4 +4 @@
 Requires at least: 6.5
 Tested up to: 6.8
-Stable tag: 1.3.9 
+Stable tag: 1.3.10 
 License: GPLv2 or later
 License URI: https://www.gnu.org/licenses/gpl-2.0.html
@@ -87 +87 @@
 
 == Changelog ==
+
+= 1.3.10 =
+- CRITICAL FIX: Schedule-specific tags now correctly applied to posts triggered by cron-job.org
+- Fixed REST API endpoint to properly read time parameter from JSON body
+- Ensures tags like "Morning Weather Report" or "Evening Weather Report" are always included
 
 = 1.3.9 =

weather-write/trunk/weather-write.php

@@ -3 +3 @@
  * Plugin Name: Weather Write
  * Description: Generate and publish weather-aware posts with summaries, charts, images, alerts, SEO, and more — fully automated or on-demand.
- * Version: 1.3.9
+ * Version: 1.3.10
  * Author: Mike Freeman - WeatherWrite
  * Plugin URI: https://www.weatherwrite.com/