Changeset 3418538

Timestamp:

12/12/2025 08:45:23 PM (2 months ago)

Author:

valerikluger

Message:

Release 1.0.5 - Fix menu item Visibility field not showing with custom admin walker

Location:

if-menu-visibility

Files:

• tags/1.0.5 (added)
• tags/1.0.5/if-menu-visibility.php (added)
• tags/1.0.5/readme.txt (added)
• trunk/if-menu-visibility.php (modified) (3 diffs)
• trunk/readme.txt (modified) (2 diffs)

if-menu-visibility/trunk/if-menu-visibility.php

@@ -4 +4 @@
 Plugin Name: IF Menu Visibility
 Description: Show menu items only for logged-in or logged-out users.
-Version: 1.0.4
+Version: 1.0.5
 Author: Valeri Kluger
 Author URI: https://premium-plugin.com/
@@ -11 +11 @@
 Text Domain: if-menu-visibility
 */
+
+// Damit "Visibility" in den Screen Options (oben rechts) erscheint
+add_filter('manage_nav-menus_columns', function ($columns) {
+    $columns['if-menu-visibility'] = __('Visibility', 'if-menu-visibility');
+    return $columns;
+}, 999);
+
+// Optional: nicht "von Grund auf" verstecken lassen (falls ein Plugin es in hidden-columns schiebt)
+add_filter('get_user_option_managenav-menuscolumnshidden', function ($hidden) {
+    if (!is_array($hidden)) return $hidden;
+    return array_values(array_diff($hidden, ['if-menu-visibility']));
+}, 999);
+
+// Fallback: Wenn ein Theme/Plugin den Admin-Menu-Walker ersetzt und
+// wp_nav_menu_item_custom_fields NICHT mehr ausführt, injizieren wir das Feld trotzdem.
+add_filter('wp_edit_nav_menu_walker', function ($walker) {
+
+    if (!is_admin()) return $walker;
+
+    // Walker-Klasse evtl. noch nicht geladen -> dann nichts ändern
+    if (!class_exists($walker)) return $walker;
+
+    $new = 'IFMV_Walker_' . md5($walker);
+    if (class_exists($new)) return $new;
+
+    $code = '
+    class ' . $new . ' extends ' . $walker . ' {
+
+        private function ifmv_field_html($item_id, $current) {
+            if (!current_user_can("edit_theme_options")) return "";
+
+            $html  = \'<p class="field-if-menu-visibility description description-wide">\';
+            $html .= \'<label for="edit-menu-item-if-visibility-\' . esc_attr($item_id) . \'">\';
+            $html .= esc_html__("Visibility:", "if-menu-visibility");
+            $html .= \'<select id="edit-menu-item-if-visibility-\' . esc_attr($item_id) . \'" class="widefat" name="menu-item-if-visibility[\' . esc_attr($item_id) . \']">\';
+            $html .= \'<option value="" \' . selected($current, "", false) . \'>\' . esc_html__("Always show", "if-menu-visibility") . \'</option>\';
+            $html .= \'<option value="logged_in" \' . selected($current, "logged_in", false) . \'>\' . esc_html__("Only when logged in", "if-menu-visibility") . \'</option>\';
+            $html .= \'<option value="logged_out" \' . selected($current, "logged_out", false) . \'>\' . esc_html__("Only when logged out", "if-menu-visibility") . \'</option>\';
+            $html .= \'</select></label></p>\';
+
+            return $html;
+        }
+
+        public function start_el(&$output, $item, $depth = 0, $args = null, $id = 0) {
+
+            $before_len = strlen($output);
+            parent::start_el($output, $item, $depth, $args, $id);
+
+            // Nur den frisch hinzugefügten Teil bearbeiten
+            $chunk = substr($output, $before_len);
+
+            // Wenn unser Feld schon drin ist (z.B. weil Action doch feuert) -> nichts tun
+            if (strpos($chunk, "field-if-menu-visibility") !== false) {
+                return;
+            }
+
+            $current = get_post_meta($item->ID, "_if_menu_visibility", true);
+            $field   = $this->ifmv_field_html($item->ID, $current);
+
+            if (!$field) return;
+
+            // 1) Core-Closing-Comment (häufig vorhanden)
+            $new_chunk = preg_replace("/(\\s*<\\/div>\\s*<!--\\s*\\.menu-item-settings\\s*-->)/", $field . "$1", $chunk, 1, $count);
+
+            // 2) Fallback: vor "Move" Feld
+            if (!$count) {
+                $new_chunk = preg_replace("/(\\s*<p[^>]*class=\\"field-move\\b[^\\"]*\\"[^>]*>)/", $field . "$1", $chunk, 1, $count2);
+                if (!$count2) {
+                    // 3) Notfalls ans Ende hängen
+                    $new_chunk = $chunk . $field;
+                }
+            }
+
+            $output = substr($output, 0, $before_len) . $new_chunk;
+        }
+    }';
+
+    eval($code);
+    return $new;
+
+}, 999);
+
+
 
 // Menüpunkt erweitern (Backend)
@@ -36 +119 @@
     $visibility = $item->if_menu_visibility ?? '';
     ?>
-    <p class="description description-wide">
+    <p class="field-if-menu-visibility description description-wide">
         <label for="edit-menu-item-if-visibility-<?php echo esc_attr($item_id); ?>">
             <?php esc_html_e('Visibility:', 'if-menu-visibility'); ?>

if-menu-visibility/trunk/readme.txt

@@ -4 +4 @@
 Tags: if menu, menu visibility, conditional menu, logged in, logged out
 Requires at least: 5.0
-Tested up to: 6.8
-Stable tag: 1.0.4
+Tested up to: 6.9
+Stable tag: 1.0.5
 License: GPLv2 or later
 License URI: https://www.gnu.org/licenses/gpl-2.0.html
@@ -34 +34 @@
 == Changelog ==
 
+= 1.0.5 =
+* Fixed menu item “Visibility” field not showing when themes/plugins override the nav menu admin walker (fallback walker injection)
+* Ensured the “Visibility” option appears in Screen Options and is not forcibly hidden by other plugins
+
 = 1.0.4 =
 * Added ABSPATH check to prevent direct file access