Changeset 3373443

Timestamp:

10/06/2025 06:52:30 AM (5 months ago)

Author:

smartling

Message:

Update to v 4.3.6

Location:

smartling-connector/trunk

Files:

• inc/Smartling/Helpers/AbsoluteLinkedAttachmentCoreHelper.php (modified) (2 diffs)
• inc/Smartling/Helpers/WordpressFunctionProxyHelper.php (modified) (1 diff)
• inc/Smartling/WP/View/ConfigurationProfileForm.php (modified) (1 diff)
• readme.txt (modified) (2 diffs)
• smartling-connector.php (modified) (1 diff)

smartling-connector/trunk/inc/Smartling/Helpers/AbsoluteLinkedAttachmentCoreHelper.php

@@ -218 +218 @@
         if (true === FileHelper::testFile($localOriginalFile)) {
             $originalPathinfo = pathinfo($localOriginalFile);
+            $wpAttachmentUrlToPostId = $this->wordpressProxy->attachment_url_to_postid($url);
+            if ($wpAttachmentUrlToPostId !== 0) {
+                return $wpAttachmentUrlToPostId;
+            }
+            // TODO revisit after second half of 2026, see https://smartling.atlassian.net/browse/WP-963
             $possibleId = $this->lookForDirectGuidEntry($url);
             if (null === $possibleId && $this->fileLooksLikeThumbnail($originalPathinfo['filename'])) {
@@ -229 +234 @@
                 $this->getLogger()->info(vsprintf('No \'attachment\' found for url=%s', [$url]));
             }
+            if ($possibleId !== null) {
+                $this->getLogger()->debug("attachment_url_to_postid result for url=$url was 0, legacy code determined possible_id=$possibleId");
+            }
 
             return $possibleId;

smartling-connector/trunk/inc/Smartling/Helpers/WordpressFunctionProxyHelper.php

@@ -22 +22 @@
     }
 
+    public function attachment_url_to_postid()
+    {
+        return attachment_url_to_postid(...func_get_args());
+    }
+
     public function get_home_url()
     {

smartling-connector/trunk/inc/Smartling/WP/View/ConfigurationProfileForm.php

@@ -729 +729 @@
                             ]
                         ),
-                        ['name' => 'smartling_settings[' . ConfigurationProfileFormController::FILTER_FIELD_NAME_REGEXP . ']'])
-                    ?>
+                        [
+                                'id' => 'filter-field-name-regexp',
+                                'name' => 'smartling_settings[' . ConfigurationProfileFormController::FILTER_FIELD_NAME_REGEXP . ']'
+                        ]
+                    )
+                    ?>
+                    <script>
+                        document.getElementById('filter-field-name-regexp').addEventListener('change', function (e) {
+                            for (const input of [
+                                document.getElementById('filter-skip'),
+                                document.getElementById('filter-copy-by-name'),
+                            ]) {
+                                input.value = input.value.split('\n')
+                                    .map(e.target.value === '0' ? function removeRegexStartAndEnd (value) {
+                                        if (value.length > 0) {
+                                            if (value[0] === '^') {
+                                                value = value.substring(1);
+                                            }
+                                            if (value[value.length - 1] === '$') {
+                                                value = value.substring(0, value.length - 1);
+                                            }
+                                        }
+
+                                        return value
+                                    } : function addRegexStartAndEnd (value) {
+                                        if (value.length > 0) {
+                                            if (value[0] !== '^') {
+                                                value = '^' + value;
+                                            }
+                                            if (value[value.length - 1] !== '$') {
+                                                value = value + '$';
+                                            }
+                                        }
+
+                                        return value;
+                                    })
+                                    .join('\n');
+                            }
+                        })
+                    </script>
                 </td>
             </tr>

smartling-connector/trunk/readme.txt

@@ -5 +5 @@
 Tested up to: 6.6.2
 Requires PHP: 8.0
-Stable tag: 4.3.5
+Stable tag: 4.3.6
 License: GPLv2 or later
 
@@ -63 +63 @@
 
 == Changelog ==
+= 4.3.6 =
+* Improved replacement of attachment URLs in translated content by using WordPress built-in attachment_url_to_postid() function
+* Exclude and Copy fields by field name will now change to a stricter regex when changing the "Treat Exclude fields by field name and Copy fields by field name as regex" setting
+
 = 4.3.5 =
 * Added support for ACF metafields that have multiple relations

smartling-connector/trunk/smartling-connector.php

@@ -12 +12 @@
  * Plugin URI:        https://www.smartling.com/products/automate/integrations/wordpress/
  * Description:       Integrate your WordPress site with Smartling to upload your content and download translations.
- * Version:           4.3.5
+ * Version:           4.3.6
  * Author:            Smartling
  * Author URI:        https://www.smartling.com