Changeset 3267631

Timestamp:

04/07/2025 05:16:31 AM (12 months ago)

Author:

developer1998

Message:

• URLs will correctly trigger your sitemap generator instead of redirecting to the homepage.
• Performance is improved by avoiding unnecessary flush operations.
• Query variables are correctly registered.

Location:

image-video-xml-sitemap/trunk

Files:

• image-video-xml-sitemap.php (modified) (2 diffs)
• includes/class-image-video-xml-sitemap.php (modified) (3 diffs)
• readme.txt (modified) (4 diffs)

image-video-xml-sitemap/trunk/image-video-xml-sitemap.php

@@ -3 +3 @@
 Plugin Name: Image & Video XML Sitemap
 Description: Enhance your website's media SEO by creating separate sitemaps for images and videos. Fully compatible with Yoast SEO, with advanced customization options.
-Version: 1.0.0
+Version: 1.0.1
 Requires at least: 5.2
 Requires PHP: 7.4
@@ -27 +27 @@
 
 //Activation hook
-register_activation_hook(__FILE__, 'ivxy_plugin_activation');
-function ivxy_plugin_activation() {
+register_activation_hook(__FILE__, function() {
+    (new ivxs_ImageVideoSitemap())->ivxs_add_sitemap_rewrites();
     flush_rewrite_rules();
-}
+});
 
 //Deactivation hook
-register_deactivation_hook(__FILE__, 'ivxs_plugin_deactivation');
-function ivxs_plugin_deactivation() {
+register_deactivation_hook(__FILE__, function() {
     flush_rewrite_rules();
-}
+});
 
 // Hook into WordPress admin initialization to check for SEO plugin.

image-video-xml-sitemap/trunk/includes/class-image-video-xml-sitemap.php

@@ -94 +94 @@
                         <?php submit_button(); ?>
                     </form>
+                    <p><em><strong>Note</strong>: Please visit Settings → Permalinks in your WordPress dashboard and simply click 'Save Changes' if the image or video XML sitemap URL is not working.</em></p>
                 </div>
                 <div class="ivxs-col-4">
@@ -115 +116 @@
 
     public function ivxs_save_settings() {
-        if (!current_user_can('manage_options') || !check_admin_referer('ivxs_save_settings', 'ivxs_nonce')) {
+        if (!is_admin() || !current_user_can('manage_options') || !check_admin_referer('ivxs_save_settings', 'ivxs_nonce')) {
             wp_die(esc_html(__('You are not allowed to perform this action.', 'image-video-xml-sitemap')));
         }
@@ -233 +234 @@
     }
 
-    public function ivxs_add_sitemap_rewrites(){
-        $image_sitemap_filename = get_option( 'ivxs_image_sitemap_filename', '' );
-        $video_sitemap_filename = get_option( 'ivxs_video_sitemap_filename', '' );
-
-        add_rewrite_rule( '^'.$image_sitemap_filename.'.xml$', 'index.php?custom_sitemap=image', 'top' );
-        add_rewrite_rule( '^'.$video_sitemap_filename.'.xml$', 'index.php?custom_sitemap=video', 'top' );
-
-        flush_rewrite_rules();
-    }
-
-    public function ivxs_add_query_vars(){
+    public function ivxs_add_sitemap_rewrites() {
+        $image_sitemap_filename = get_option('ivxs_image_sitemap_filename', 'image');
+        $video_sitemap_filename = get_option('ivxs_video_sitemap_filename', 'video');
+    
+        if (!empty($image_sitemap_filename)) {
+            add_rewrite_rule('^' . preg_quote($image_sitemap_filename) . '\.xml$', 'index.php?custom_sitemap=image', 'top');
+        }
+    
+        if (!empty($video_sitemap_filename)) {
+            add_rewrite_rule('^' . preg_quote($video_sitemap_filename) . '\.xml$', 'index.php?custom_sitemap=video', 'top');
+        }
+    }
+    
+    public function ivxs_add_query_vars($vars) {
         $vars[] = 'custom_sitemap';
         return $vars;
     }
-
+    
     public function ivxs_generate_custom_sitemap() {
         $custom_sitemap = get_query_var( 'custom_sitemap' );

image-video-xml-sitemap/trunk/readme.txt

@@ -5 +5 @@
 Tested up to: 6.7  
 Requires PHP: 7.4  
-Stable tag: 1.0.0  
+Stable tag: 1.0.1  
 License: GPLv2 or later  
 License URI: https://www.gnu.org/licenses/gpl-2.0.html
@@ -33 +33 @@
 ### Advanced Feature:
 Even with Yoast SEO's media sitemap options enabled, this plugin generates independent sitemaps for better control and optimization of your media assets.
+
+### Extra Notes:
+Please visit **Settings → Permalinks** in your WordPress dashboard and simply click "Save Changes". This will flush and refresh the rewrite rules so that the custom sitemap URLs start working properly.
 
 == Installation ==
@@ -76 +79 @@
 == Changelog ==
 
-= 1.0 =
+= 1.0.1 =
+- URLs will correctly trigger your sitemap generator instead of redirecting to the homepage.
+- Performance is improved by avoiding unnecessary flush operations.
+- Query variables are correctly registered.
+
+= 1.0.0 =
 - Initial release.
 - Added support for separate sitemaps for images and videos.
@@ -84 +92 @@
 == Upgrade Notice ==
 
-= 1.0 =
+= 1.0.1 =
+Performance is improved by avoiding unnecessary flush operations. 
+
+= 1.0.0 =
 Initial release. Ensure you have Yoast SEO installed and activated to use this plugin.