Changeset 3215845

Timestamp:

01/02/2025 07:51:16 AM (12 months ago)

Author:

dhanendran

Message:

validate taxonomy before use

Location:

term-taxonomy-converter/trunk

Files:

• readme.md (modified) (1 diff)
• term-taxonomy-converter.php (modified) (6 diffs)

term-taxonomy-converter/trunk/readme.md

@@ -4 +4 @@
 Tags: importer, converter, copy, duplicate, categories and tags converter, taxonomy converter, copy taxonomies, duplicate taxonomies, terms
 Requires at least: 3.0
-Tested up to: 6.2.2
-Stable tag: 1.2
+Tested up to: 6.7.1
+Stable tag: 1.2.1
 License: GPLv3 or later
 License URI: <a href="http://www.gnu.org/licenses/gpl-3.0.html">http://www.gnu.org/licenses/gpl-3.0.html</a>

term-taxonomy-converter/trunk/term-taxonomy-converter.php

@@ -11 +11 @@
  * Description:       Copy or convert terms between taxonomies. This plugin, allows you to copy (duplicate) or convert (move) terms from one taxonomy to another or to multiple taxonomies, while maintaining associated posts.
  * Tags:              importer, converter, copy, duplicate, categories and tags converter, taxonomy converter, copy taxonomies, duplicate taxonomies, terms
- * Version:           1.2
+ * Version:           1.2.1
  * Author:            Dhanendran
  * Author URI:        http://dhanendranrajagopal.me/
@@ -32 +32 @@
     public $all_terms = array();
     public $hybrids_ids = array();
+    public $terms_to_convert = array();
 
     function __construct() {
@@ -87 +88 @@
     public function page() {
         $tax = ( isset( $_GET['tax'] ) ) ? sanitize_text_field( $_GET['tax'] ) : 'category';
+        // Validate that the taxonomy exists
+        if ( ! taxonomy_exists( $tax ) ) {
+            $tax = 'category'; // Fallback to default if invalid
+        }
         $step = ( isset( $_GET['step'] ) ) ? (int) sanitize_text_field( $_GET['step'] ) : 1;
 
@@ -226 +231 @@
 
         if (
-                ( ! isset( $_POST['terms_to_convert' ] ) || ! is_array( $_POST['terms_to_convert'] ) )
-                && empty( $this->terms_to_convert ) || ( ! isset( $_POST['taxes'] ) )
-        ) { ?>
-            <div class="narrow">
-                <p><?php printf( __( 'Uh, oh. Something didn&#8217;t work. Please <a href="%s">try again</a>.', 'd9_ttc' ), esc_attr( 'tools.php?page=term_tax_converter&amp;tax=' . $tax ) ); ?></p>
-            </div>
+                ( ! isset( $_POST['terms_to_convert' ] ) || ! is_array( $_POST['terms_to_convert'] ) )
+                && empty( $this->terms_to_convert ) || ( ! isset( $_POST['taxes'] ) )
+        ) { ?>
+            <div class="narrow">
+                <p><?php printf( __( 'Uh, oh. Something didn&#8217;t work. Please <a href="%s">try again</a>.', 'd9_ttc' ), esc_attr( 'tools.php?page=term_tax_converter&amp;tax=' . $tax ) ); ?></p>
+            </div>
             <?php
-            return;
+            return;
         }
 
         if ( empty( $this->terms_to_convert ) )
-            $this->terms_to_convert = filter_input( INPUT_POST, 'terms_to_convert', FILTER_SANITIZE_STRING, FILTER_REQUIRE_ARRAY );
+            $this->terms_to_convert = filter_input( INPUT_POST, 'terms_to_convert', FILTER_DEFAULT, FILTER_REQUIRE_ARRAY );
 
         $taxonomy = $this->taxes[ $tax ];
@@ -247 +252 @@
             $c_label = 'Copy';
 
-        $new_taxes = filter_input( INPUT_POST, 'taxes', FILTER_SANITIZE_STRING, FILTER_REQUIRE_ARRAY );
+        $new_taxes = filter_input( INPUT_POST, 'taxes', FILTER_DEFAULT, FILTER_REQUIRE_ARRAY );
 
         $hybrid_cats = $clear_parents = $parents = false;
@@ -300 +305 @@
                         if ( ! $convert ) {
                             $hybrid_cats = true;
-                            echo '*';
+                            echo '*';
                         }
                         $clean_term_cache[] = $term->term_id;