Changeset 3148652

Timestamp:

09/09/2024 11:58:28 AM (18 months ago)

Author:

ccsd

Message:

fix warnings and handle response with error

File:

• hal/trunk/wp-hal.php (modified) (5 diffs)

hal/trunk/wp-hal.php

@@ -178 +178 @@
             $param
         ));
+        $content = 'Plugin is not configured correctly or shortcode parameters are not valid, please check the <a href="https://doc.archives-ouvertes.fr/afficher-une-liste-de-publications-dans-wordpress/" target="_blank" id="wrong_params">documentation</a>';
 
         /** @var  $id         :  defined by extract
@@ -203 +204 @@
 
             $json = wphal_do_get_data($url);
+            if(!isset($json->error)){
             $hal_page = (get_query_var('hal_page')) ? get_query_var('hal_page') : 1;
 
@@ -921 +923 @@
     </div>
 </div>';
-        }else{
-            $content = 'Plugin is not configured correctly or shortcode parameters are not valid, please check the <a href="https://doc.archives-ouvertes.fr/afficher-une-liste-de-publications-dans-wordpress/" target="_blank" id="wrong_params">documentation</a>';
-        }
+        }}
         $content .= '<div class="wphal-footer">';
         $content .= '<p style="color:#B3B2B0">' . __("Documents récupérés de l'archive ouverte HAL", 'wp-hal') . '&nbsp;<a href="' . wphal_site . '" target="_blank"><img alt="logo" src=" ' . esc_url(plugin_dir_url(__FILE__) . 'img/logo-hal.png').'" style="width:90px;"></a></p>';
@@ -1089 +1089 @@
             foreach($facet_fields->{'affiliated_'.$k} as $r){
                 $t = explode(wphal_delimiter_join, $r[0]);
-                if (isset($result[$t[1]])){
+                if (!isset($result[$t[1]])){
                     $result[$t[1]] = $r[1];
                 }else {
@@ -1208 +1208 @@
                 $json = wphal_do_get_data($url);
 
-                $count_results = count($json->response->docs);
-                if ($count_results > 0) {
+                $count_results = is_array($json->response->docs) ? count($json->response->docs) : 0;
+                if (isset($json->response->docs) && $count_results > 0) {
                     $content = '<ul class="widhal-ul">';
                     for ($i = 0; $i < $count_results - 1; $i++) {