Changeset 3087634

Timestamp:

05/16/2024 09:57:40 AM (19 months ago)

Author:

konamiman

Message:

PR 14: Fix fatal error when deactivating the plugin

Location:

woocommerce-legacy-rest-api/trunk

Files:

• includes/class-wc-legacy-rest-api-plugin.php (modified) (3 diffs)
• readme.txt (modified) (3 diffs)
• woocommerce-legacy-rest-api.php (modified) (1 diff)

woocommerce-legacy-rest-api/trunk/includes/class-wc-legacy-rest-api-plugin.php

@@ -109 +109 @@
     private static function maybe_remove_hpos_incompatibility_admin_notice() {
         if ( WC_Admin_Notices::has_notice( 'legacy_rest_api_is_incompatible_with_hpos' ) && ! self::hpos_is_enabled() ) {
-            self::remove_notice( 'legacy_rest_api_is_incompatible_with_hpos' );
+            WC_Admin_Notices::remove_notice( 'legacy_rest_api_is_incompatible_with_hpos' );
         }
     }
@@ -127 +127 @@
 
         if ( WC_Admin_Notices::has_notice( 'legacy_rest_api_is_incompatible_with_hpos' ) ) {
-            self::remove_notice( 'legacy_rest_api_is_incompatible_with_hpos' );
+            WC_Admin_Notices::remove_notice( 'legacy_rest_api_is_incompatible_with_hpos' );
         }
     }
@@ -169 +169 @@
      */
     private static function user_has_dismissed_admin_notice( $notice_id ) {
-        return '' !== get_user_meta( get_current_user_id(), "dismissed_${notice_id}_notice", true );
+        if ( method_exists( 'WC_Admin_Notices', 'user_has_dismissed_notice' ) ) {
+            return WC_Admin_Notices::user_has_dismissed_notice( $notice_id );
+        } else {
+            return (bool) get_user_meta( get_current_user_id(), "dismissed_{$notice_id}_notice", true );
+        }
     }
 }

woocommerce-legacy-rest-api/trunk/readme.txt

@@ -5 +5 @@
 Tested up to: 6.3
 Requires PHP: 7.4
-Stable tag: 1.0.3
+Stable tag: 1.0.4
 License: GPLv3
 License URI: https://www.gnu.org/licenses/gpl-3.0.html
@@ -36 +36 @@
 First version, replicates the WooCommerce Legacy REST API v3.1.0 present in WooCommerce 8.3.
 
-
 = 1.0.1 2024-01-08 =
 
@@ -42 +41 @@
 - Add sanitization for data received via query string arguments and the $_SERVER array.
 
+= 1.0.2 2024-05-01 =
 
-= 1.0.2 2024-05-01
+- Add a dismissable admin notice indicating that the Legacy REST API is not compatible with HPOS.
+- The notice will appear if the orders table is (or has been) selected as the orders data store in the WooCommerce features settings page, and will disappear when that ceases to be true. Once the notice is dismissed it will never appear again.
 
-Add a dismissable admin notice indicating that the Legacy REST API is not compatible with HPOS.
-The notice will appear if the orders table is (or has been) selected as the orders data store in the WooCommerce features settings page,
-and will disappear when that ceases to be true. Once the notice is dismissed it will never appear again.
+= 1.0.3 2024-05-15 =
 
+- Fix a bug introduced in 1.0.2 that caused a fatal error when checking if HPOS is enabled.
 
-= 1.0.3 2024-05-15
+= 1.0.4 2024-05-16 =
 
-Fix a bug introduced in 1.0.2 that caused a fatal error when checking if HPOS is enabled.
+- Correct a problem in which the attempted removal of admin notices (warning of HPOS incompatibility) could lead to a fatal error during plugin deactivation.

woocommerce-legacy-rest-api/trunk/woocommerce-legacy-rest-api.php

@@ -4 +4 @@
  * Plugin URI: https://github.com/woocommerce/woocommerce-legacy-rest-api
  * Description: The legacy WooCommerce REST API, which used to be part of WooCommerce itself but is removed as of WooCommerce 9.0.
- * Version: 1.0.3
+ * Version: 1.0.4
  * Author: WooCommerce
  * Author URI: https://woocommerce.com