Changeset 3052698

Timestamp:

03/17/2024 02:33:03 PM (2 years ago)

Author:

stephend

Message:

Add strict checks

File:

• smart-app-banner/trunk/wsl-smart-app-banner.php (modified) (10 diffs)

smart-app-banner/trunk/wsl-smart-app-banner.php

@@ -66 +66 @@
     }
 
-    if ( ( is_null( $app_id_list ) || '' == $app_id ) &&
-        ( is_front_page() || get_option( 'wsl_global_banner' ) == 'Yes' ) ) {
+    if ( ( is_null( $app_id_list ) || '' === $app_id ) &&
+        ( is_front_page() || get_option( 'wsl_global_banner' ) === 'Yes' ) ) {
         $app_id         = get_option( 'wsl_homepage_appid' );
         $app_id_ipad    = get_option( 'wsl_homepage_appid_ipad' );
@@ -75 +75 @@
 
     // if it's not there, exit.
-    if ( is_null( $app_id ) || '' == $app_id ) {
+    if ( is_null( $app_id ) || '' === $app_id ) {
         return;
     }
@@ -81 +81 @@
     $options = '';
 
-    if ( ! is_null( $affiliate_data ) && '' != $affiliate_data ) {
+    if ( ! is_null( $affiliate_data ) && '' !== $affiliate_data ) {
         $options = "$options, affiliate-data=$affiliate_data";
     }
-    if ( ! is_null( $app_argument ) && '' != $app_argument ) {
+    if ( ! is_null( $app_argument ) && '' !== $app_argument ) {
         $options = "$options, app-argument=$app_argument";
     }
 
     // if it is, output the header.
-    if ( is_null( $app_id_ipad ) || '' == $app_id_ipad ) {
+    if ( is_null( $app_id_ipad ) || '' === $app_id_ipad ) {
         echo "<meta name=\"apple-itunes-app\" content=\"app-id=$app_id$options\"/>";
     } else {
@@ -95 +95 @@
 <script language="javascript">
 <!--
-if (navigator.userAgent.match(/iPad/i) != null) {
+if (navigator.userAgent.match(/iPad/i) !== null) {
 document.write("<meta name=\"apple-itunes-app\" content=\"app-id=<?php echo "$app_id_ipad$options"; ?>\"/>\n");
 }
@@ -141 +141 @@
     $protocol             = wp_parse_url( $url, PHP_URL_SCHEME );
     $disallowed_protocols = array( 'javascript' );
-    if ( in_array( $protocol, $disallowed_protocols ) ) {
+    if ( in_array( $protocol, $disallowed_protocols, true ) ) {
         return false;
     }
@@ -159 +159 @@
 function wsl_validate_input( $app_id, $app_id_ipad, $affiliate_data, $app_argument ) {
     $error_message = null;
-    if ( preg_match( '/[^0-9]/', $app_id ) == 1 ) {
+    if ( preg_match( '/[^0-9]/', $app_id ) === 1 ) {
         $error_message = __( 'Invalid App ID' );
-    } elseif ( preg_match( '/[^0-9]/', $app_id_ipad ) == 1 ) {
+    } elseif ( preg_match( '/[^0-9]/', $app_id_ipad ) === 1 ) {
         $error_message = __( 'Invalid iPad App ID' );
-    } elseif ( isset( $app_argument ) && '' != $app_argument && ! wsl_custom_url_validator( $app_argument ) ) {
+    } elseif ( isset( $app_argument ) && '' !== $app_argument && ! wsl_custom_url_validator( $app_argument ) ) {
         $error_message = __( 'Invalid URL for app argument' );
     }
@@ -205 +205 @@
     // See if the user has posted us some information.
     // If they did, this hidden field will be set to 'Y'.
-    if ( isset( $_POST[ $hidden_field_name ] ) && 'Y' == $_POST[ $hidden_field_name ] ) {
+    if ( isset( $_POST[ $hidden_field_name ] ) && 'Y' === $_POST[ $hidden_field_name ] ) {
 
         if ( ! isset( $_POST['wsl-update'] ) || ! wp_verify_nonce( $_POST['wsl-update'], 'wsl-update' ) ) {
@@ -225 +225 @@
             <div class="error"><p><strong><?php _e( $error_message, 'smart-app-banner' ); ?></strong></p></div>
                 <?php
-            } elseif ( isset( $app_id ) && '' != $app_id ) {
+            } elseif ( isset( $app_id ) && '' !== $app_id ) {
                 $app_list[ $app_id ] = array(
                     'app_name'       => $app_name,
@@ -260 +260 @@
                 update_option( $affiliate_field_name, $affiliate_val );
                 update_option( $argument_field_name, $argument_val );
-                if ( 'Yes' == $_POST[ $global_banner_field_name ] ) {
+                if ( 'Yes' === $_POST[ $global_banner_field_name ] ) {
                                 update_option( $global_banner_field_name, 'Yes' );
                 } else {
@@ -330 +330 @@
     <td><input type="checkbox" name="<?php echo $global_banner_field_name; ?>" value="Yes" 
                                                 <?php
-                                                if ( 'Yes' == $global_banner_val ) {
+                                                if ( 'Yes' === $global_banner_val ) {
                                                     echo 'checked'; }
                                                 ?>