Changeset 3048698

Timestamp:

03/10/2024 06:44:56 PM (2 years ago)

Author:

evgenyviner

Message:

Corrected security vulnerabilities.

Location:

demo-awesome/trunk

Files:

• README.txt (modified) (2 diffs)
• demo-awesome.php (modified) (1 diff)
• inc/admin/class-demo-awesome-admin.php (modified) (4 diffs)
• inc/admin/required-plugins.php (modified) (1 diff)

demo-awesome/trunk/README.txt

@@ -3 +3 @@
 Tags: theme4press, data importer, one-click demo import, theme demo, demos, importer, theme4press demo
 Requires at least: 4.7
-Tested up to: 6.3
+Tested up to: 6.4.3
 Requires PHP: 7.0
 Stable tag: trunk
@@ -49 +49 @@
 == Changelog ==
 
+= 1.0.2 =
+* Fixed some security vulnerablities
+
 = 1.0.1 =
 * Corrected a bug, which caused the message "Missing plugins" to appear, when all required plugins are actually installed.

demo-awesome/trunk/demo-awesome.php

@@ -10 +10 @@
  * Plugin URI:        https://theme4press.com/demo-awesome-the-data-importer/
  * Description:       Import the Theme4Press theme demo content including theme settings, menus, widgets, sliders, and much more with just one click. Awesome!
- * Version:           1.0.1
+ * Version:           1.0.2
  * Author:            Theme4Press
  * Author URI:        https://theme4press.com

demo-awesome/trunk/inc/admin/class-demo-awesome-admin.php

@@ -202 +202 @@
             }
         }
+       
 
         /**
@@ -208 +209 @@
         function call_import_function_from_ajax()
         {
-
-            $data_demo = isset($_REQUEST['data_demo']) ? $_REQUEST['data_demo'] : array();
+            if ( !current_user_can('manage_options') ) {
+                wp_die('You do not have sufficient permissions to access this feature.');
+            }        
+            $data_demo_raw = isset($_REQUEST['data_demo']) ? $_REQUEST['data_demo'] : array();
+            $data_demo = array();
+
+            //TODO (EvgenyViner): Look for a more elegant way to sanitize the data
+
+            if (is_array($data_demo_raw)) {
+                foreach($data_demo_raw as $key => $item) {
+                    if(is_array($data_demo_raw[$key])) {
+                        foreach($data_demo_raw[$key] as $key2 => $item2) {
+                            if(is_array($data_demo_raw[$key][$key2])) {
+                                foreach($data_demo_raw[$key][$key2] as $key3 => $item3) {
+                                    $data_demo[$key][$key2][$key3] = esc_attr($item3);
+                                }
+                            }
+                            else $data_demo[$key][$key2] = esc_attr($item2);
+                        }
+                    }
+                    else $data_demo[$key] = esc_attr($item);
+                }
+            }
+                else {
+                    $data_demo = htmlspecialchars((string)$data_demo_raw, ENT_QUOTES, 'UTF-8');
+                }
 
             $template_name = isset($data_demo['folder_path']) ? $data_demo['folder_path'] : '';
@@ -317 +342 @@
             // Include the required plugins list
             require dirname(__FILE__).'/required-plugins.php';
-            $data_demo = isset($_REQUEST['data_demo']) ? $_REQUEST['data_demo'] : array();
+            $data_demo_raw = isset($_REQUEST['data_demo']) ? $_REQUEST['data_demo'] : array();
+            $data_demo = array();
+           
+            //TODO (EvgenyViner): Look for a more elegant way to sanitize the data
+
+            if (is_array($data_demo_raw)) {
+                foreach($data_demo_raw as $key => $item) {
+                    if(is_array($data_demo_raw[$key])) {
+                        foreach($data_demo_raw[$key] as $key2 => $item2) {
+                            if(is_array($data_demo_raw[$key][$key2])) {
+                                foreach($data_demo_raw[$key][$key2] as $key3 => $item3) {
+                                    $data_demo[$key][$key2][$key3] = esc_attr($item3);
+                                }
+                            }
+                            else $data_demo[$key][$key2] = esc_attr($item2);
+                        }
+                    }
+                    else $data_demo[$key] = esc_attr($item);
+                }
+            }
+                else {
+                    $data_demo = htmlspecialchars((string)$data_demo_raw, ENT_QUOTES, 'UTF-8');
+                }
+            
             demo_awesome_required_plugins($data_demo);
             wp_die(); // this is required to terminate immediately and return a proper response
@@ -371 +419 @@
 
             }
+
             $all_plugins = apply_filters('all_plugins', get_plugins());
 

demo-awesome/trunk/inc/admin/required-plugins.php

@@ -127 +127 @@
                                             $plugin['disable_description']
                                         );
+                                     //   var_dump($plugin);
+                                        $plugin['slug'] =  isset( $plugin['slug']{1} ) ? $plugin['slug'] : $plugin['keyword'];
                                         $premium_plugin = sprintf(
                                             '<a class="button evole-install-plugin button-proceed" target="_blank"