WordPress.org
Get WordPress

Plugin Directory

Changeset 3044352


Ignore:
Timestamp:
03/03/2024 10:11:36 AM (2 years ago)
Author:
podpirate
Message:

Release 3.3.3

Location:
acf-quickedit-fields
Files:
28 edited
1 copied

Legend:

Unmodified
Added
Removed

  • acf-quickedit-fields/tags/3.3.3/include/ACFQuickEdit/Admin/Admin.php

    r2988906 r3044352  
    8585
    8686        // init field group admin
    87         add_action( 'acf/field_group/admin_head', [ $this, 'field_group_admin_head' ] );
     87        add_action( 'acf/field_group/admin_head', [ $this, 'init_field_group' ] );
     88        add_action( 'wp_ajax_acf/field_group/render_field_settings', [ $this, 'init_field_group' ], 1 );
    8889
    8990        add_filter('acf/load_field_group', [ $this, 'load_field_group' ] );
    90 
    9191    }
    9292
    … …  
    113113    /**
    114114     *  @action acf/field_group/admin_head
    115      */
    116     public function field_group_admin_head() {
     115     *  @action wp_ajax_acf/field_group/render_field_settings
     116     */
     117    public function init_field_group() {
    117118        if ( version_compare( acf()->version, '6.0.0', '>=' ) ) {
    118119            FieldGroup::instance();
    … …  
    129130    public function setup() {
    130131
    131         // early return if conditions not met
     132        // early return if no ACF
    132133        if ( ! function_exists('acf') || ! class_exists('acf') || version_compare( acf()->version, '5.7', '<' ) ) {
    133134            if ( current_user_can( 'activate_plugins' ) ) {
    … …  
    137138        }
    138139
     140        // Features
    139141        $this->columns          = Columns::instance();
    140142        $this->quickedit        = Quickedit::instance();
    … …  
    142144        $this->filters          = Filters::instance();
    143145        $this->backendsearch    = BackendSearch::instance();
     146
    144147        $this->ajax_handler     = new Ajax\AjaxHandler( 'get_acf_post_meta', [
    145148            'public'            => false,
    … …  
    154157        add_action( 'acf/field_group/admin_enqueue_scripts', [ $this, 'enqueue_fieldgroup_assets' ] );
    155158
     159    }
     160
     161    public function is_field_group_saving() {
     162        return isset( $_SERVER ) && isset( $_SERVER['REQUEST_METHOD'] )
     163            && isset( $_POST['action'] ) && isset( $_POST['_acf_screen'] )
     164            && 'POST' === $_SERVER['REQUEST_METHOD']
     165            && 'editpost' === wp_unslash( $_POST['action'] )
     166            && 'field_group' === wp_unslash( $_POST['_acf_screen'] );
    156167    }
    157168

  • acf-quickedit-fields/tags/3.3.3/include/ACFQuickEdit/Admin/BackendSearch.php

    r2988906 r3044352  
    3838     */
    3939    public function init_fields() {
    40         if ( parent::init_fields() ) {
     40        $is_active = parent::init_fields();
     41        if ( $is_active ) {
    4142            $this->init_meta_query();
    4243        }
     44        return $is_active;
    4345    }
    4446

  • acf-quickedit-fields/tags/3.3.3/include/ACFQuickEdit/Admin/Bulkedit.php

    r2970604 r3044352  
    9797    public function init_fields() {
    9898
    99         add_filter( 'acf/validate_value', [ $this, 'validate_value'], 10, 4 );
    100 
    101         parent::init_fields();
    102 
    103         if ( $this->is_active() ) {
    104 
     99        add_filter( 'acf/validate_value', [ $this, 'validate_value' ], 10, 4 );
     100
     101        $is_active = parent::init_fields();
     102
     103        if ( $is_active ) {
    105104            add_action( 'bulk_edit_custom_box', [ $this , 'display_bulk_edit' ], 200, 2 );
    106 
    107         }
    108 
     105        }
     106
     107        return $is_active;
    109108    }
    110109

  • acf-quickedit-fields/tags/3.3.3/include/ACFQuickEdit/Admin/Columns.php

    r3042783 r3044352  
    172172            }
    173173        }
     174
     175        return true;
    174176    }
    175177

  • acf-quickedit-fields/tags/3.3.3/include/ACFQuickEdit/Admin/EditFeature.php

    r2808949 r3044352  
    3232
    3333        if ( ! $is_active ) {
    34             return;
     34            return false;
    3535        }
    3636
    … …  
    100100            add_filter( 'quick_edit_show_taxonomy', [ $this, 'quick_edit_show_taxonomy' ], 10, 3 );
    101101        }
    102 
     102        return true;
    103103    }
    104104
    … …  
    109109     */
    110110    public function quick_edit_show_taxonomy( $show, $taxonomy ) {
    111         return ! in_array( $taxonomy, $this->taxonomies );
     111        return $show && ! in_array( $taxonomy, $this->taxonomies );
    112112    }
    113113

  • acf-quickedit-fields/tags/3.3.3/include/ACFQuickEdit/Admin/Feature.php

    r3042783 r3044352  
    4343        if ( wp_doing_ajax() ) {
    4444            add_action( 'admin_init', [ $this, 'init_fields' ] );
    45         } else {
     45        } else if ( ! $this->admin->is_field_group_saving() )  {
    4646            add_action( 'current_screen', [ $this, 'init_fields' ] );
    4747        }
    … …  
    199199        $field_store = acf_get_store( 'fields' );
    200200
    201 
    202201        $fields_query = [];
    203202        $fields_query[ $this->get_fieldgroup_option() ] = true;

  • acf-quickedit-fields/tags/3.3.3/include/ACFQuickEdit/Admin/FieldGroup.php

    r2988906 r3044352  
    1515     */
    1616    protected function __construct() {
    17 
    1817
    1918        add_filter('acf/field_group/additional_group_settings_tabs', [ $this, 'field_group_tabs' ] );
    … …  
    4342        parent::__construct();
    4443    }
    45 
    4644
    4745    /**

  • acf-quickedit-fields/tags/3.3.3/include/ACFQuickEdit/Admin/Quickedit.php

    r2828750 r3044352  
    4444    public function init_fields() {
    4545
    46         parent::init_fields();
     46        $is_active = parent::init_fields();
    4747
    48         if ( $this->is_active() ) {
     48        if ( $is_active ) {
     49            add_action( 'quick_edit_custom_box',  [ $this, 'display_quick_edit' ], 10, 2 );
     50        }
    4951
    50             add_action( 'quick_edit_custom_box',  [ $this, 'display_quick_edit' ], 10, 2 );
    51 
    52         }
     52        return $is_active;
    5353    }
    5454

  • acf-quickedit-fields/tags/3.3.3/include/ACFQuickEdit/Fields/Field.php

    r3042783 r3044352  
    158158        $this->core = Core\Core::instance();
    159159
    160         $this->acf_field = $acf_field;
     160        $this->acf_field = wp_parse_args( $acf_field, [ 'wrapper' => [ ] ] );
    161161
    162162        $parent_key = '';
    … …  
    290290            return;
    291291        }
     292        $field_wrapper = wp_parse_args( $this->acf_field['wrapper'], [ 'id' => '' ] );
    292293        $wrapper_attr = [
    293294            'class'             => 'acf-field',
    … …  
    296297            'data-allow-null'   => isset( $this->acf_field['allow_null'] ) ? $this->acf_field['allow_null'] : 0,
    297298        ];
     299
     300        if ( $field_wrapper['id'] ) {
     301            $wrapper_attr['data-id'] = $field_wrapper['id'];
     302        }
     303
    298304        $wrapper_attr = $this->get_wrapper_attributes( $wrapper_attr, $mode === 'quick' );
     305
    299306        if ( isset( $this->acf_field['field_type'] ) ) {
    300307            $wrapper_attr['data-field-sub-type'] = $this->acf_field['field_type'];

  • acf-quickedit-fields/tags/3.3.3/include/ACFQuickEdit/Fields/Traits/InputRadio.php

    r2808949 r3044352  
    1818
    1919        $acf_field = wp_parse_args( $acf_field, [
    20             'choices' => [],
     20            'choices'      => [],
    2121            'other_choice' => 0,
     22            'allow_null'   => 0,
    2223        ]);
    2324
    … …  
    2627            $acf_field['key']
    2728        );
     29
     30        if ( $acf_field['allow_null'] ) {
     31            $output .= sprintf( '<li><label for="%s">', $id );
     32            $output .= sprintf( '<input %s />%s', acf_esc_attr( [
     33                'id'                    => $id,
     34                'type'                  => 'radio',
     35                'value'                 => '',
     36                'class'                 => 'acf-quick-edit',
     37                'data-acf-field-key'    => $acf_field['key'],
     38                'name'                  => $input_atts['name'],
     39                'checked'               => 'checked',
     40            ] ), '<em>' . esc_html__('(No value)', 'acf-quickedit-fields') . '</em>' );
     41
     42            $output .= '</label></li>';
     43        }
    2844
    2945        foreach( $acf_field['choices'] as $name => $value) {

  • acf-quickedit-fields/tags/3.3.3/include/version.php

    r3043635 r3044352  
    1 <?php return "3.3.2";
     1<?php return "3.3.3";

  • acf-quickedit-fields/tags/3.3.3/index.php

    r3043635 r3044352  
    66Description: Show Advanced Custom Fields in post list table. Edit field values in Quick Edit and / or Bulk edit.
    77Author: Jörn Lund
    8 Version: 3.3.2
     8Version: 3.3.3
    99Author URI: https://github.com/mcguffin
    1010License: GPL3
    … …  
    5050    Core\Core::instance( __FILE__ );
    5151
     52    $acf_qef_ajax_actions = [
     53        // QuickEdit
     54         'inline-save',
     55         'inline-save-tax',
     56         'get_acf_post_meta',
     57         // Field group admin
     58         'acf/field_group/render_field_settings',
     59         // Polylang
     60         'pll_update_post_rows',
     61         'pll_update_term_rows',
     62    ];
    5263    // performance
    53     if ( ! wp_doing_ajax() || in_array( $_REQUEST['action'], [ 'inline-save', 'inline-save-tax', 'get_acf_post_meta', 'pll_update_post_rows', 'pll_update_term_rows' ] ) ) {
     64    if ( ! wp_doing_ajax() || in_array( wp_unslash($_REQUEST['action']), $acf_qef_ajax_actions ) ) {
    5465        Admin\Admin::instance();
    5566    }

  • acf-quickedit-fields/tags/3.3.3/languages/acf-quickedit-fields.pot

    r3043635 r3044352  
    33msgid ""
    44msgstr ""
    5 "Project-Id-Version: ACF QuickEdit Fields 3.3.2\n"
     5"Project-Id-Version: ACF QuickEdit Fields 3.3.3\n"
    66"Report-Msgid-Bugs-To: https://wordpress.org/support/plugin/acf-quickedit-fields\n"
    77"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
    … …  
    1010"Content-Type: text/plain; charset=UTF-8\n"
    1111"Content-Transfer-Encoding: 8bit\n"
    12 "POT-Creation-Date: 2024-03-01T12:30:01+00:00\n"
     12"POT-Creation-Date: 2024-03-03T10:11:05+00:00\n"
    1313"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
    1414"X-Generator: WP-CLI 2.10.0\n"
    … …  
    4141
    4242#. Translators: 1: ACF Pro URL, 2: plugins page url
    43 #: include/ACFQuickEdit/Admin/Admin.php:244
     43#: include/ACFQuickEdit/Admin/Admin.php:255
    4444msgid "The <strong>ACF QuickEdit Fields</strong> plugin requires <a href=\"%1$s\" target=\"_blank\" rel=\"noopener noreferrer\">ACF version 5.6 or later</a>. You can disable and uninstall it on the <a href=\"%2$s\">plugins page</a>."
    4545msgstr ""
    4646
    47 #: include/ACFQuickEdit/Admin/FieldGroup.php:51
     47#: include/ACFQuickEdit/Admin/FieldGroup.php:49
    4848msgid "QuickEdit Fields"
    4949msgstr ""
    5050
    51 #: include/ACFQuickEdit/Admin/FieldGroup.php:60
     51#: include/ACFQuickEdit/Admin/FieldGroup.php:58
    5252msgid "Simplifed Location Rules"
    5353msgstr ""
    5454
    55 #: include/ACFQuickEdit/Admin/FieldGroup.php:61
     55#: include/ACFQuickEdit/Admin/FieldGroup.php:59
    5656#: include/ACFQuickEdit/Admin/LegacyFieldGroup.php:42
    5757msgid "Forces QuickEdit and columns to display even if Location Rules do not match the current admin screen."
    5858msgstr ""
    5959
    60 #: include/ACFQuickEdit/Admin/FieldGroup.php:76
     60#: include/ACFQuickEdit/Admin/FieldGroup.php:74
    6161msgid "List Table Settings"
    6262msgstr ""
    6363
    64 #: include/ACFQuickEdit/Admin/FieldGroup.php:91
     64#: include/ACFQuickEdit/Admin/FieldGroup.php:89
    6565#: include/ACFQuickEdit/Admin/LegacyFieldGroup.php:105
    6666msgid "Show Column"
    6767msgstr ""
    6868
    69 #: include/ACFQuickEdit/Admin/FieldGroup.php:92
     69#: include/ACFQuickEdit/Admin/FieldGroup.php:90
    7070#: include/ACFQuickEdit/Admin/LegacyFieldGroup.php:89
    7171msgid "Show a column in the posts list table"
    7272msgstr ""
    7373
    74 #: include/ACFQuickEdit/Admin/FieldGroup.php:102
     74#: include/ACFQuickEdit/Admin/FieldGroup.php:100
    7575#: include/ACFQuickEdit/Admin/LegacyFieldGroup.php:118
    7676msgid "Sortable Column"
    7777msgstr ""
    7878
    79 #: include/ACFQuickEdit/Admin/FieldGroup.php:103
     79#: include/ACFQuickEdit/Admin/FieldGroup.php:101
    8080#: include/ACFQuickEdit/Admin/LegacyFieldGroup.php:123
    8181msgid "Make this column sortable"
    8282msgstr ""
    8383
    84 #: include/ACFQuickEdit/Admin/FieldGroup.php:114
     84#: include/ACFQuickEdit/Admin/FieldGroup.php:112
    8585#: include/ACFQuickEdit/Admin/LegacyFieldGroup.php:133
    8686#: include/ACFQuickEdit/Admin/LegacyFieldGroup.php:137
    … …  
    8888msgstr ""
    8989
    90 #: include/ACFQuickEdit/Admin/FieldGroup.php:115
     90#: include/ACFQuickEdit/Admin/FieldGroup.php:113
    9191#: include/ACFQuickEdit/Admin/LegacyFieldGroup.php:134
    9292msgid "Columns with a higher weight will be pushed to the right. The leftmost WordPress column has a weight of <em>0</em>, the next one <em>100</em> and so on. Leave empty to place a column to the rightmost position."
    9393msgstr ""
    9494
    95 #: include/ACFQuickEdit/Admin/FieldGroup.php:135
     95#: include/ACFQuickEdit/Admin/FieldGroup.php:133
    9696msgid "Enable QuickEdit"
    9797msgstr ""
    9898
    99 #: include/ACFQuickEdit/Admin/FieldGroup.php:150
     99#: include/ACFQuickEdit/Admin/FieldGroup.php:148
    100100msgid "Enable Bulk Edit"
    101101msgstr ""
    102102
    103 #: include/ACFQuickEdit/Admin/FieldGroup.php:164
     103#: include/ACFQuickEdit/Admin/FieldGroup.php:162
    104104#: include/ACFQuickEdit/Admin/LegacyFieldGroup.php:232
    105105msgid "Enable filter"
    106106msgstr ""
    107107
    108 #: include/ACFQuickEdit/Admin/FieldGroup.php:165
     108#: include/ACFQuickEdit/Admin/FieldGroup.php:163
    109109#: include/ACFQuickEdit/Admin/LegacyFieldGroup.php:233
    110110msgid "Filters will work with posts and user list tables."
    111111msgstr ""
    112112
    113 #: include/ACFQuickEdit/Admin/FieldGroup.php:179
     113#: include/ACFQuickEdit/Admin/FieldGroup.php:177
    114114msgid "Backend Search"
    115115msgstr ""
    116116
    117 #: include/ACFQuickEdit/Admin/FieldGroup.php:180
     117#: include/ACFQuickEdit/Admin/FieldGroup.php:178
    118118msgid "Field value is searchable in WP-Admin."
    119119msgstr ""
    … …  
    180180msgstr ""
    181181
    182 #: include/ACFQuickEdit/Fields/Field.php:354
     182#: include/ACFQuickEdit/Fields/Field.php:361
    183183msgid "Do not change"
    184184msgstr ""
    185185
    186 #: include/ACFQuickEdit/Fields/Field.php:414
     186#: include/ACFQuickEdit/Fields/Field.php:421
    187187msgid "– Operation –"
    188188msgstr ""
    189189
    190 #: include/ACFQuickEdit/Fields/Field.php:485
     190#: include/ACFQuickEdit/Fields/Field.php:492
     191#: include/ACFQuickEdit/Fields/Traits/InputRadio.php:40
    191192#: include/ACFQuickEdit/Fields/TrueFalseField.php:38
    192193msgid "(No value)"

  • acf-quickedit-fields/tags/3.3.3/readme.txt

    r3043635 r3044352  
    66Tested up to: 6.3
    77Requires PHP: 7.2
    8 Stable tag: 3.3.2
     8Stable tag: 3.3.3
    99License: GPLv2 or later
    1010License URI: http://www.gnu.org/licenses/gpl-2.0.html
    … …  
    105105
    106106== Changelog ==
     107
     108= 3.3.3 =
     109 - QuickEdit: add none-choice to nullable select fields
     110 - Render `data-id` atrribute on field
     111 - Fix: Default Taxonomy UI shown
     112 - Fix: QuickEdit options visible if field is added for the first time
     113 - Fix: Local JSON not saved immediately
    107114
    108115= 3.3.2 =

  • acf-quickedit-fields/trunk/include/ACFQuickEdit/Admin/Admin.php

    r2988906 r3044352  
    8585
    8686        // init field group admin
    87         add_action( 'acf/field_group/admin_head', [ $this, 'field_group_admin_head' ] );
     87        add_action( 'acf/field_group/admin_head', [ $this, 'init_field_group' ] );
     88        add_action( 'wp_ajax_acf/field_group/render_field_settings', [ $this, 'init_field_group' ], 1 );
    8889
    8990        add_filter('acf/load_field_group', [ $this, 'load_field_group' ] );
    90 
    9191    }
    9292
    … …  
    113113    /**
    114114     *  @action acf/field_group/admin_head
    115      */
    116     public function field_group_admin_head() {
     115     *  @action wp_ajax_acf/field_group/render_field_settings
     116     */
     117    public function init_field_group() {
    117118        if ( version_compare( acf()->version, '6.0.0', '>=' ) ) {
    118119            FieldGroup::instance();
    … …  
    129130    public function setup() {
    130131
    131         // early return if conditions not met
     132        // early return if no ACF
    132133        if ( ! function_exists('acf') || ! class_exists('acf') || version_compare( acf()->version, '5.7', '<' ) ) {
    133134            if ( current_user_can( 'activate_plugins' ) ) {
    … …  
    137138        }
    138139
     140        // Features
    139141        $this->columns          = Columns::instance();
    140142        $this->quickedit        = Quickedit::instance();
    … …  
    142144        $this->filters          = Filters::instance();
    143145        $this->backendsearch    = BackendSearch::instance();
     146
    144147        $this->ajax_handler     = new Ajax\AjaxHandler( 'get_acf_post_meta', [
    145148            'public'            => false,
    … …  
    154157        add_action( 'acf/field_group/admin_enqueue_scripts', [ $this, 'enqueue_fieldgroup_assets' ] );
    155158
     159    }
     160
     161    public function is_field_group_saving() {
     162        return isset( $_SERVER ) && isset( $_SERVER['REQUEST_METHOD'] )
     163            && isset( $_POST['action'] ) && isset( $_POST['_acf_screen'] )
     164            && 'POST' === $_SERVER['REQUEST_METHOD']
     165            && 'editpost' === wp_unslash( $_POST['action'] )
     166            && 'field_group' === wp_unslash( $_POST['_acf_screen'] );
    156167    }
    157168

  • acf-quickedit-fields/trunk/include/ACFQuickEdit/Admin/BackendSearch.php

    r2988906 r3044352  
    3838     */
    3939    public function init_fields() {
    40         if ( parent::init_fields() ) {
     40        $is_active = parent::init_fields();
     41        if ( $is_active ) {
    4142            $this->init_meta_query();
    4243        }
     44        return $is_active;
    4345    }
    4446

  • acf-quickedit-fields/trunk/include/ACFQuickEdit/Admin/Bulkedit.php

    r2970604 r3044352  
    9797    public function init_fields() {
    9898
    99         add_filter( 'acf/validate_value', [ $this, 'validate_value'], 10, 4 );
    100 
    101         parent::init_fields();
    102 
    103         if ( $this->is_active() ) {
    104 
     99        add_filter( 'acf/validate_value', [ $this, 'validate_value' ], 10, 4 );
     100
     101        $is_active = parent::init_fields();
     102
     103        if ( $is_active ) {
    105104            add_action( 'bulk_edit_custom_box', [ $this , 'display_bulk_edit' ], 200, 2 );
    106 
    107         }
    108 
     105        }
     106
     107        return $is_active;
    109108    }
    110109

  • acf-quickedit-fields/trunk/include/ACFQuickEdit/Admin/Columns.php

    r3042783 r3044352  
    172172            }
    173173        }
     174
     175        return true;
    174176    }
    175177

  • acf-quickedit-fields/trunk/include/ACFQuickEdit/Admin/EditFeature.php

    r2808949 r3044352  
    3232
    3333        if ( ! $is_active ) {
    34             return;
     34            return false;
    3535        }
    3636
    … …  
    100100            add_filter( 'quick_edit_show_taxonomy', [ $this, 'quick_edit_show_taxonomy' ], 10, 3 );
    101101        }
    102 
     102        return true;
    103103    }
    104104
    … …  
    109109     */
    110110    public function quick_edit_show_taxonomy( $show, $taxonomy ) {
    111         return ! in_array( $taxonomy, $this->taxonomies );
     111        return $show && ! in_array( $taxonomy, $this->taxonomies );
    112112    }
    113113

  • acf-quickedit-fields/trunk/include/ACFQuickEdit/Admin/Feature.php

    r3042783 r3044352  
    4343        if ( wp_doing_ajax() ) {
    4444            add_action( 'admin_init', [ $this, 'init_fields' ] );
    45         } else {
     45        } else if ( ! $this->admin->is_field_group_saving() )  {
    4646            add_action( 'current_screen', [ $this, 'init_fields' ] );
    4747        }
    … …  
    199199        $field_store = acf_get_store( 'fields' );
    200200
    201 
    202201        $fields_query = [];
    203202        $fields_query[ $this->get_fieldgroup_option() ] = true;

  • acf-quickedit-fields/trunk/include/ACFQuickEdit/Admin/FieldGroup.php

    r2988906 r3044352  
    1515     */
    1616    protected function __construct() {
    17 
    1817
    1918        add_filter('acf/field_group/additional_group_settings_tabs', [ $this, 'field_group_tabs' ] );
    … …  
    4342        parent::__construct();
    4443    }
    45 
    4644
    4745    /**

  • acf-quickedit-fields/trunk/include/ACFQuickEdit/Admin/Quickedit.php

    r2828750 r3044352  
    4444    public function init_fields() {
    4545
    46         parent::init_fields();
     46        $is_active = parent::init_fields();
    4747
    48         if ( $this->is_active() ) {
     48        if ( $is_active ) {
     49            add_action( 'quick_edit_custom_box',  [ $this, 'display_quick_edit' ], 10, 2 );
     50        }
    4951
    50             add_action( 'quick_edit_custom_box',  [ $this, 'display_quick_edit' ], 10, 2 );
    51 
    52         }
     52        return $is_active;
    5353    }
    5454

  • acf-quickedit-fields/trunk/include/ACFQuickEdit/Fields/Field.php

    r3042783 r3044352  
    158158        $this->core = Core\Core::instance();
    159159
    160         $this->acf_field = $acf_field;
     160        $this->acf_field = wp_parse_args( $acf_field, [ 'wrapper' => [ ] ] );
    161161
    162162        $parent_key = '';
    … …  
    290290            return;
    291291        }
     292        $field_wrapper = wp_parse_args( $this->acf_field['wrapper'], [ 'id' => '' ] );
    292293        $wrapper_attr = [
    293294            'class'             => 'acf-field',
    … …  
    296297            'data-allow-null'   => isset( $this->acf_field['allow_null'] ) ? $this->acf_field['allow_null'] : 0,
    297298        ];
     299
     300        if ( $field_wrapper['id'] ) {
     301            $wrapper_attr['data-id'] = $field_wrapper['id'];
     302        }
     303
    298304        $wrapper_attr = $this->get_wrapper_attributes( $wrapper_attr, $mode === 'quick' );
     305
    299306        if ( isset( $this->acf_field['field_type'] ) ) {
    300307            $wrapper_attr['data-field-sub-type'] = $this->acf_field['field_type'];

  • acf-quickedit-fields/trunk/include/ACFQuickEdit/Fields/Traits/InputRadio.php

    r2808949 r3044352  
    1818
    1919        $acf_field = wp_parse_args( $acf_field, [
    20             'choices' => [],
     20            'choices'      => [],
    2121            'other_choice' => 0,
     22            'allow_null'   => 0,
    2223        ]);
    2324
    … …  
    2627            $acf_field['key']
    2728        );
     29
     30        if ( $acf_field['allow_null'] ) {
     31            $output .= sprintf( '<li><label for="%s">', $id );
     32            $output .= sprintf( '<input %s />%s', acf_esc_attr( [
     33                'id'                    => $id,
     34                'type'                  => 'radio',
     35                'value'                 => '',
     36                'class'                 => 'acf-quick-edit',
     37                'data-acf-field-key'    => $acf_field['key'],
     38                'name'                  => $input_atts['name'],
     39                'checked'               => 'checked',
     40            ] ), '<em>' . esc_html__('(No value)', 'acf-quickedit-fields') . '</em>' );
     41
     42            $output .= '</label></li>';
     43        }
    2844
    2945        foreach( $acf_field['choices'] as $name => $value) {

  • acf-quickedit-fields/trunk/include/version.php

    r3043635 r3044352  
    1 <?php return "3.3.2";
     1<?php return "3.3.3";

  • acf-quickedit-fields/trunk/index.php

    r3043635 r3044352  
    66Description: Show Advanced Custom Fields in post list table. Edit field values in Quick Edit and / or Bulk edit.
    77Author: Jörn Lund
    8 Version: 3.3.2
     8Version: 3.3.3
    99Author URI: https://github.com/mcguffin
    1010License: GPL3
    … …  
    5050    Core\Core::instance( __FILE__ );
    5151
     52    $acf_qef_ajax_actions = [
     53        // QuickEdit
     54         'inline-save',
     55         'inline-save-tax',
     56         'get_acf_post_meta',
     57         // Field group admin
     58         'acf/field_group/render_field_settings',
     59         // Polylang
     60         'pll_update_post_rows',
     61         'pll_update_term_rows',
     62    ];
    5263    // performance
    53     if ( ! wp_doing_ajax() || in_array( $_REQUEST['action'], [ 'inline-save', 'inline-save-tax', 'get_acf_post_meta', 'pll_update_post_rows', 'pll_update_term_rows' ] ) ) {
     64    if ( ! wp_doing_ajax() || in_array( wp_unslash($_REQUEST['action']), $acf_qef_ajax_actions ) ) {
    5465        Admin\Admin::instance();
    5566    }

  • acf-quickedit-fields/trunk/languages/acf-quickedit-fields.pot

    r3043635 r3044352  
    33msgid ""
    44msgstr ""
    5 "Project-Id-Version: ACF QuickEdit Fields 3.3.2\n"
     5"Project-Id-Version: ACF QuickEdit Fields 3.3.3\n"
    66"Report-Msgid-Bugs-To: https://wordpress.org/support/plugin/acf-quickedit-fields\n"
    77"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
    … …  
    1010"Content-Type: text/plain; charset=UTF-8\n"
    1111"Content-Transfer-Encoding: 8bit\n"
    12 "POT-Creation-Date: 2024-03-01T12:30:01+00:00\n"
     12"POT-Creation-Date: 2024-03-03T10:11:05+00:00\n"
    1313"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
    1414"X-Generator: WP-CLI 2.10.0\n"
    … …  
    4141
    4242#. Translators: 1: ACF Pro URL, 2: plugins page url
    43 #: include/ACFQuickEdit/Admin/Admin.php:244
     43#: include/ACFQuickEdit/Admin/Admin.php:255
    4444msgid "The <strong>ACF QuickEdit Fields</strong> plugin requires <a href=\"%1$s\" target=\"_blank\" rel=\"noopener noreferrer\">ACF version 5.6 or later</a>. You can disable and uninstall it on the <a href=\"%2$s\">plugins page</a>."
    4545msgstr ""
    4646
    47 #: include/ACFQuickEdit/Admin/FieldGroup.php:51
     47#: include/ACFQuickEdit/Admin/FieldGroup.php:49
    4848msgid "QuickEdit Fields"
    4949msgstr ""
    5050
    51 #: include/ACFQuickEdit/Admin/FieldGroup.php:60
     51#: include/ACFQuickEdit/Admin/FieldGroup.php:58
    5252msgid "Simplifed Location Rules"
    5353msgstr ""
    5454
    55 #: include/ACFQuickEdit/Admin/FieldGroup.php:61
     55#: include/ACFQuickEdit/Admin/FieldGroup.php:59
    5656#: include/ACFQuickEdit/Admin/LegacyFieldGroup.php:42
    5757msgid "Forces QuickEdit and columns to display even if Location Rules do not match the current admin screen."
    5858msgstr ""
    5959
    60 #: include/ACFQuickEdit/Admin/FieldGroup.php:76
     60#: include/ACFQuickEdit/Admin/FieldGroup.php:74
    6161msgid "List Table Settings"
    6262msgstr ""
    6363
    64 #: include/ACFQuickEdit/Admin/FieldGroup.php:91
     64#: include/ACFQuickEdit/Admin/FieldGroup.php:89
    6565#: include/ACFQuickEdit/Admin/LegacyFieldGroup.php:105
    6666msgid "Show Column"
    6767msgstr ""
    6868
    69 #: include/ACFQuickEdit/Admin/FieldGroup.php:92
     69#: include/ACFQuickEdit/Admin/FieldGroup.php:90
    7070#: include/ACFQuickEdit/Admin/LegacyFieldGroup.php:89
    7171msgid "Show a column in the posts list table"
    7272msgstr ""
    7373
    74 #: include/ACFQuickEdit/Admin/FieldGroup.php:102
     74#: include/ACFQuickEdit/Admin/FieldGroup.php:100
    7575#: include/ACFQuickEdit/Admin/LegacyFieldGroup.php:118
    7676msgid "Sortable Column"
    7777msgstr ""
    7878
    79 #: include/ACFQuickEdit/Admin/FieldGroup.php:103
     79#: include/ACFQuickEdit/Admin/FieldGroup.php:101
    8080#: include/ACFQuickEdit/Admin/LegacyFieldGroup.php:123
    8181msgid "Make this column sortable"
    8282msgstr ""
    8383
    84 #: include/ACFQuickEdit/Admin/FieldGroup.php:114
     84#: include/ACFQuickEdit/Admin/FieldGroup.php:112
    8585#: include/ACFQuickEdit/Admin/LegacyFieldGroup.php:133
    8686#: include/ACFQuickEdit/Admin/LegacyFieldGroup.php:137
    … …  
    8888msgstr ""
    8989
    90 #: include/ACFQuickEdit/Admin/FieldGroup.php:115
     90#: include/ACFQuickEdit/Admin/FieldGroup.php:113
    9191#: include/ACFQuickEdit/Admin/LegacyFieldGroup.php:134
    9292msgid "Columns with a higher weight will be pushed to the right. The leftmost WordPress column has a weight of <em>0</em>, the next one <em>100</em> and so on. Leave empty to place a column to the rightmost position."
    9393msgstr ""
    9494
    95 #: include/ACFQuickEdit/Admin/FieldGroup.php:135
     95#: include/ACFQuickEdit/Admin/FieldGroup.php:133
    9696msgid "Enable QuickEdit"
    9797msgstr ""
    9898
    99 #: include/ACFQuickEdit/Admin/FieldGroup.php:150
     99#: include/ACFQuickEdit/Admin/FieldGroup.php:148
    100100msgid "Enable Bulk Edit"
    101101msgstr ""
    102102
    103 #: include/ACFQuickEdit/Admin/FieldGroup.php:164
     103#: include/ACFQuickEdit/Admin/FieldGroup.php:162
    104104#: include/ACFQuickEdit/Admin/LegacyFieldGroup.php:232
    105105msgid "Enable filter"
    106106msgstr ""
    107107
    108 #: include/ACFQuickEdit/Admin/FieldGroup.php:165
     108#: include/ACFQuickEdit/Admin/FieldGroup.php:163
    109109#: include/ACFQuickEdit/Admin/LegacyFieldGroup.php:233
    110110msgid "Filters will work with posts and user list tables."
    111111msgstr ""
    112112
    113 #: include/ACFQuickEdit/Admin/FieldGroup.php:179
     113#: include/ACFQuickEdit/Admin/FieldGroup.php:177
    114114msgid "Backend Search"
    115115msgstr ""
    116116
    117 #: include/ACFQuickEdit/Admin/FieldGroup.php:180
     117#: include/ACFQuickEdit/Admin/FieldGroup.php:178
    118118msgid "Field value is searchable in WP-Admin."
    119119msgstr ""
    … …  
    180180msgstr ""
    181181
    182 #: include/ACFQuickEdit/Fields/Field.php:354
     182#: include/ACFQuickEdit/Fields/Field.php:361
    183183msgid "Do not change"
    184184msgstr ""
    185185
    186 #: include/ACFQuickEdit/Fields/Field.php:414
     186#: include/ACFQuickEdit/Fields/Field.php:421
    187187msgid "– Operation –"
    188188msgstr ""
    189189
    190 #: include/ACFQuickEdit/Fields/Field.php:485
     190#: include/ACFQuickEdit/Fields/Field.php:492
     191#: include/ACFQuickEdit/Fields/Traits/InputRadio.php:40
    191192#: include/ACFQuickEdit/Fields/TrueFalseField.php:38
    192193msgid "(No value)"

  • acf-quickedit-fields/trunk/readme.txt

    r3043635 r3044352  
    66Tested up to: 6.3
    77Requires PHP: 7.2
    8 Stable tag: 3.3.2
     8Stable tag: 3.3.3
    99License: GPLv2 or later
    1010License URI: http://www.gnu.org/licenses/gpl-2.0.html
    … …  
    105105
    106106== Changelog ==
     107
     108= 3.3.3 =
     109 - QuickEdit: add none-choice to nullable select fields
     110 - Render `data-id` atrribute on field
     111 - Fix: Default Taxonomy UI shown
     112 - Fix: QuickEdit options visible if field is added for the first time
     113 - Fix: Local JSON not saved immediately
    107114
    108115= 3.3.2 =
Note: See TracChangeset for help on using the changeset viewer.