Changeset 2982111

Timestamp:

10/21/2023 09:10:38 PM (17 months ago)

Author:

firmcatalyst

Message:

Tested up to 6.3

Location:

fcp-lightest-lightbox/trunk

Files:

• fcp-lightbox.php (modified) (3 diffs)
• readme.txt (modified) (1 diff)

fcp-lightest-lightbox/trunk/fcp-lightbox.php

@@ -4 +4 @@
 Plugin Name: FCP Lightest Lightbox
 Description: Super lightweight lighbox. It tracks the links to images and makes it open in a popup lightbox. It also adds prev-next navigation to galleries or image sequences.
-Version: 1.4
+Version: 1.4.1
 Requires at least: 5.7
-Tested up to: 6.2
-Requires PHP: 7.4
+Tested up to: 6.3
+Requires PHP: 7.0.0
 Author: Firmcatalyst, Vadim Volkov
 Author URI: https://firmcatalyst.com
@@ -16 +16 @@
 defined( 'ABSPATH' ) || exit;
 
-define( 'FCPLB_DEV', false );
+define( 'FCPLB_DEV', true );
 define( 'FCPLB_VER', get_file_data( __FILE__, [ 'ver' => 'Version' ] )[ 'ver' ] . ( FCPLB_DEV ? time() : '' ) );
 
@@ -23 +23 @@
 add_action( 'wp_enqueue_scripts', function() {
 
-    $assets_url = function($name, $ext, $ver = '') {
-        return plugin_dir_url(__FILE__) . $name . ( FCPLB_DEV ? '' : '.min' ) . '.' . $ext . ( $ver ? '?' . $ver : '' );
-    };
-    
-    $translations = ['Previous', 'Next', 'Close'];
-    $translations = array_map( function( $a ) use ( $translations ) {
-        return __( $translations[ $a ] );
-    }, array_flip( $translations ) );
-    
-    wp_enqueue_script( 'fcp-lightbox', $assets_url( 'loader', 'js' ), [], FCPLB_VER );
-    add_filter('script_loader_tag', function ($tag, $handle) { // change to async
-        if ( $handle !== 'fcp-lightbox' ) { return $tag; }
-        return str_replace( ' src', ' async src', $tag );
+    // list of used phrases
+    $to_translate = ['Previous', 'Next', 'Close', 'Caption'];
+    $translations = array_map( function( $a ) use ( $to_translate ) {
+        return __( $to_translate[ $a ] );
+    }, array_flip( $to_translate ) );
+
+    // enqueue the loader script
+    $loader_name = 'fcp-lightbox-loader';
+    $loader_file_url = plugins_url( '/loader'.( FCPLB_DEV ? '' : '.min' ).'.js', __FILE__ );
+    wp_enqueue_script( $loader_name, $loader_file_url, [], FCPLB_VER );
+
+    // defer the script loading
+    add_filter('script_loader_tag', function ($tag, $handle) {
+        if ( $handle !== $loader_name || strpos( $tag, 'defer ' ) !== false) { return $tag; }
+        return str_replace( ' src', ' defer src', $tag );
     }, 10, 2);
     
-    // global js values
-    wp_add_inline_script( 'fcp-lightbox', preg_replace( '/[\n\t ]+/', '', '
-        window.fcp_lightbox = {
-            "path" : "' . esc_js( plugin_dir_url(__FILE__) ) . '",
-            "dev" : ' . ( FCPLB_DEV ? 'true' : 'false' ) . ',
-            "ver" : "' . esc_js( FCPLB_VER ) . '",
-            "selector" : "a[href$=\".jpg\"], a[href$=\".jpeg\"], a[href$=\".png\"]",
-            "translations" : ' . json_encode( $translations ) . ',
-        };
-    '));
+    // global js values // ++ eliminate
+    $settings = [
+        'loader' => $loader_name.'-js',
+        'path' => esc_js( plugin_dir_url(__FILE__) ), // ++almost can remove
+        'dev' => FCPLB_DEV,
+        'ver' => esc_js( FCPLB_VER ),
+        'selector' => 'a[href$=".jpg"], a[href$=".jpeg"], a[href$=".png"]',
+        'translations' => $translations,
+    ];
     
-    // wp_enqueue_style( 'fcp-lightbox', $assets_url( 'style', 'css' ), [], FCPLB_VER ); // moved to script.js to eleminate render blocking
-});
+    wp_add_inline_script( $loader_name, 'window.fcp_lightbox = '.json_encode( $settings ).';' );
+
+}, 10 );

fcp-lightest-lightbox/trunk/readme.txt

@@ -3 +3 @@
 Tags: lightbox, gallery, photography, images
 Requires at least: 5.7
-Tested up to: 6.2
-Requires PHP: 7.4
-Stable tag: 1.4
+Tested up to: 6.3
+Requires PHP: 7.0.0
+Stable tag: 1.4.1
 Author: Firmcatalyst, Vadim Volkov
 Author URI: https://firmcatalyst.com