Changeset 2960317

Timestamp:

08/29/2023 11:49:20 PM (2 years ago)

Author:

parselearn

Message:

Fix warning when not set orderby for comment query

Location:

meta-optimizer

Files:

• tags/1.1 (added)
• tags/1.1/inc (added)
• tags/1.1/inc/CommentQueries.php (added)
• trunk/inc/CommentQueries.php (modified) (2 diffs)

meta-optimizer/trunk/inc/CommentQueries.php

@@ -40 +40 @@
 
         // Change OrderBy
-        $order = ( 'ASC' === strtoupper( $this->Queries->queryVars['order'] ) ) ? 'ASC' : 'DESC';
+        $order = isset( $this->Queries->queryVars['order'] ) && ( 'ASC' === strtoupper( $this->Queries->queryVars['order'] ) ) ? 'ASC' : 'DESC';
 
         // Disable ORDER BY with 'none', an empty array, or boolean false.
-        if ( in_array( $this->Queries->queryVars['orderby'], array( 'none', array(), false ), true ) ) {
+        if ( ! isset( $this->Queries->queryVars['orderby'] ) ||
+             in_array( $this->Queries->queryVars['orderby'], array( 'none', array(), false ), true ) ) {
             $orderby = '';
         } elseif ( ! empty( $this->Queries->queryVars['orderby'] ) ) {
@@ -139 +140 @@
      *
      * @return string|false Value to use in the ORDER clause. False otherwise.
-     * @global \wpdb  $wpdb    WordPress database abstraction object.
+     * @global \wpdb $wpdb    WordPress database abstraction object.
      *
      * @copyright Base on WP_Comment_Query: parse_orderby method.