Changeset 2934823

Timestamp:

07/05/2023 09:24:00 PM (21 months ago)

Author:

firmcatalyst

Message:

Minor improvements and update to 1.0.4

Location:

fcp-posts-by-search-query/trunk

Files:

• inc/functions.php (modified) (1 diff)
• inc/meta-boxes.php (modified) (4 diffs)
• inc/shortcode.php (modified) (1 diff)
• posts-by-query.php (modified) (1 diff)
• readme.txt (modified) (1 diff)

fcp-posts-by-search-query/trunk/inc/functions.php

@@ -35 +35 @@
 
 function get_types_to_apply_to() {
-    return filter_by_public_types( get_settings()['apply-to'] );
+    return filter_by_public_types( get_settings()['apply-to'] ?? [] );
 }
 function get_types_to_search_among() {
-    return filter_by_public_types( get_settings()['select-from'] );
+    return filter_by_public_types( get_settings()['select-from'] ?? [] );
 }
 
 function css_minify($css) {
-    $css = preg_replace( '/\/\*(?:.*?)*\*\//', '', $css ); // remove comments
-    $css = preg_replace( '/\s+/', ' ', $css ); // one-line & only single speces
-    $css = preg_replace( '/ ?([\{\};:\>\~\+]) ?/', '$1', $css ); // remove spaces
-    $css = preg_replace( '/\+(\d)/', ' + $1', $css ); // restore spaces in functions
-    $css = preg_replace( '/(?:[^\}]*)\{\}/', '', $css ); // remove empty properties
+    $preg_replace = function($regexp, $replace, $string) { // avoid null result so that css still works even though not fully minified
+        return preg_replace( $regexp, $replace, $string ) ?: $string . '/* --- failed '.$regexp.', '.$replace.' */';
+    };
+    $css = $preg_replace( '/\s+/', ' ', $css ); // one-line & only single speces
+    $css = $preg_replace( '/ ?\/\*(?:.*?)\*\/ ?/', '', $css ); // remove comments
+    $css = $preg_replace( '/ ?([\{\};:\>\~\+]) ?/', '$1', $css ); // remove spaces
+    $css = $preg_replace( '/\+(\d)/', ' + $1', $css ); // restore spaces in functions
+    $css = $preg_replace( '/(?:[^\}]*)\{\}/', '', $css ); // remove empty properties
     $css = str_replace( [';}', '( ', ' )'], ['}', '(', ')'], $css ); // remove last ; and spaces
+    // ++ should also remove 0 from 0.5, but not from svg-s?
+    // ++ try replacing ', ' with ','
+    // ++ remove space between %3E %3C and before %3E and /%3E
     return trim( $css );
 };

fcp-posts-by-search-query/trunk/inc/meta-boxes.php

@@ -29 +29 @@
     ];
 
-
     $screen = get_current_screen();
     if ( !isset( $screen ) || !is_object( $screen ) || !isset( $files[ $screen->base ] ) ) { return; }
+
+    if ( $screen->base === 'post' && !in_array( $screen->post_type, get_types_to_apply_to() ) ) { return; }
 
     $assets_path = FCPPBK_DIR.'assets';
@@ -50 +51 @@
     }
 
+    if ( $screen->base !== 'settings_page_posts-by-query' ) { return; }
+
     // wp color picker
     wp_enqueue_script( 'wp-color-picker' );
@@ -68 +71 @@
 
     $route_args = function($search_by) {
-
-        if ( empty( get_types_to_search_among() ) ) {
-            return new \WP_Error( 'post_type_not_selected', 'Post type not selected', [ 'status' => 404 ] );
-        }
 
         $wp_query_args = [
@@ -100 +99 @@
             'methods'  => 'GET',
             'callback' => function( \WP_REST_Request $request ) use ( $wp_query_args, $format_output ) {
+
+                if ( empty( get_types_to_search_among() ) ) {
+                    return new \WP_Error( 'post_type_not_selected', 'Post type not selected', [ 'status' => 404 ] );
+                }
 
                 if ( FCPPBK_DEV ) { usleep( rand(0, 1000000) ); } // simulate server responce delay

fcp-posts-by-search-query/trunk/inc/shortcode.php

@@ -66 +66 @@
     ];
 
-    $search_by = $metas[ FCPPBK_PREF.'variants' ];
+    $search_by = $metas[ FCPPBK_PREF.'variants' ] ?? 'list';
 
     switch ( $search_by ) {

fcp-posts-by-search-query/trunk/posts-by-query.php

@@ -3 +3 @@
 Plugin Name: FCP Posts by Search Query
 Description: Implement a list of relevant posts to particular pages with a search query or exact list of posts. Easy pick and add.
-Version: 1.0.3
+Version: 1.0.4
 Requires at least: 5.8
 Tested up to: 6.2

fcp-posts-by-search-query/trunk/readme.txt

@@ -5 +5 @@
 Tested up to: 6.2
 Requires PHP: 7.4
-Stable tag: 1.0.3
+Stable tag: 1.0.4
 Author: Firmcatalyst, Vadim Volkov, Aude Jamier
 Author URI: https://firmcatalyst.com