Changeset 2885100

Timestamp:

03/22/2023 04:37:23 PM (3 years ago)

Author:

husobj

Message:

Version 1.4.2

Location:

page-parts/trunk

Files:

• CHANGELOG.md (modified) (2 diffs)
• admin/admin.php (modified) (2 diffs)
• page-parts.php (modified) (2 diffs)
• readme.txt (modified) (2 diffs)

page-parts/trunk/CHANGELOG.md

@@ -4 +4 @@
 
 ## [Unreleased]
+
+## [1.4.2] - 2023-03-22
+
+### Fixed
+- Fix compatibility with WPML plugin where page part translations are duplicated.
 
 ## [1.4.1] - 2021-12-29
@@ -135 +140 @@
 - First public release.
 
-[Unreleased]: https://github.com/benhuson/page-parts/compare/1.4.1...HEAD
+[Unreleased]: https://github.com/benhuson/page-parts/compare/1.4.2...HEAD
+[1.4.2]: https://github.com/benhuson/page-parts/compare/1.4.1...1.4.2
 [1.4.1]: https://github.com/benhuson/page-parts/compare/1.4...1.4.1
 [1.4]: https://github.com/benhuson/page-parts/compare/1.3.1...1.4

page-parts/trunk/admin/admin.php

@@ -745 +745 @@
             if ( isset( $_POST['parent_id'] ) && current_user_can( 'edit_page', $post_id ) ) {
 
-                $parent_id = absint( $_POST['parent_id'] );
-                $post_type_object = get_post_type_object( get_post_type( $parent_id ) );
-
-                if ( 0 == $parent_id || ( $post_type_object && current_user_can( $post_type_object->cap->edit_post, $post_id ) ) ) {
-                    $wpdb->update( $wpdb->posts, array( 'post_parent' => $parent_id ), array( 'ID' => $post_id ) );
+                // For WPML compatibility, check this is not a duplicate translation
+                if ( ! $this->is_post_a_wpml_duplicate( $post_id ) ) {
+
+                    $parent_id = absint( $_POST['parent_id'] );
+                    $post_type_object = get_post_type_object( get_post_type( $parent_id ) );
+
+                    if ( 0 == $parent_id || ( $post_type_object && current_user_can( $post_type_object->cap->edit_post, $post_id ) ) ) {
+                        $wpdb->update( $wpdb->posts, array( 'post_parent' => $parent_id ), array( 'ID' => $post_id ) );
+                    }
+
                 }
 
@@ -841 +846 @@
 
         <?php
+    }
+
+    /**
+     * Check if post is a WPML duplicate.
+     * Used to prevent overriding post parent for duplicate translations.
+     *
+     * Note:
+     * WPML_ELEMENT_IS_NOT_TRANSLATED  = 0
+     * WPML_ELEMENT_IS_TRANSLATED      = 1
+     * WPML_ELEMENT_IS_DUPLICATED      = 2
+     * WPML_ELEMENT_IS_A_DUPLICATE     = 3
+     * 
+     * @param   integer  $post_id
+     * @return  boolean
+     */
+    protected function is_post_a_wpml_duplicate( $post_id ) {
+
+        $translation_type = apply_filters( 'wpml_element_translation_type', NULL, $post_id, get_post_type( $post_id ) );
+
+        return 3 === $translation_type;
+
     }
 

page-parts/trunk/page-parts.php

@@ -5 +5 @@
 Plugin URI: https://github.com/benhuson/page-parts
 Description: Manage subsections of a page.
-Version: 1.4.1
+Version: 1.4.2
 Author: Ben Huson
 Author URI: https://github.com/benhuson
@@ -11 +11 @@
 */
 
-define( 'PAGE_PARTS_VERSION', '1.4.1' );
+define( 'PAGE_PARTS_VERSION', '1.4.2' );
 define( 'PAGE_PARTS_FILE', __FILE__ );
 

page-parts/trunk/readme.txt

@@ -3 +3 @@
 Tags: pages, cms
 Requires at least: 3.9
-Tested up to: 5.8.2
-Stable tag: 1.4.1
+Tested up to: 6.1.1
+Stable tag: 1.4.2
 License: GPL2 or later
 License URI: http://www.gnu.org/licenses/gpl-2.0.html
@@ -38 +38 @@
 
 = Unreleased =
+
+= 1.4.2 =
+
+__Fixed__
+- Fix compatibility with WPML plugin where page part translations are duplicated.
 
 = 1.4.1 =