Changeset 2790365

Timestamp:

09/26/2022 03:13:41 PM (4 years ago)

Author:

Poniard

Message:

Security Patch

Location:

activedemand/trunk

Files:

• ActiveDEMAND.php (modified) (10 diffs)
• readme.txt (modified) (2 diffs)

activedemand/trunk/ActiveDEMAND.php

@@ -5 +5 @@
  * Plugin URI: https://www2.activedemand.com/s/Gnf5n
  * Description: Adds the <a href="https://www2.activedemand.com/s/SW5nU">ActiveDEMAND</a> tracking script to your website. Add custom popups, use shortcodes to embed webforms and dynamic website content.
- * Version: 0.2.30
+ * Version: 0.2.31
  * Author: JumpDEMAND Inc.
  * Author URI: https://www2.activedemand.com/s/SW5nU
@@ -15 +15 @@
 
 
-define(__NAMESPACE__ . '\ACTIVEDEMAND_VER', '0.2.30');
+define(__NAMESPACE__ . '\ACTIVEDEMAND_VER', '0.2.31');
 define(__NAMESPACE__ . "\PLUGIN_VENDOR", "ActiveDEMAND");
 define(__NAMESPACE__ . "\PLUGIN_VENDOR_LINK", "https://1jp.cc/s/SW5nU");
@@ -996 +996 @@
     }
 
-        $user_id = get_current_user_id();
-        $lang = get_bloginfo("language");
-        $currency = get_option('woocommerce_currency');
-    $id_cart = $wpdb->get_var($wpdb->prepare('SELECT id_cart FROM ' . $wpdb->prefix . 'cart WHERE id_customer = ' . (int)$user_id . ' AND cookie_cart_id = "' . $active_demand_cookie_cart . '"'));
-
-            if (!$id_cart) {
+    $user_id = get_current_user_id();
+    $lang = get_bloginfo("language");
+    $currency = get_option('woocommerce_currency');
+    $id_cart = $wpdb->get_var(
+        $wpdb->prepare(
+            "SELECT id_cart FROM {$wpdb->prefix}cart WHERE id_customer = %d AND cookie_cart_id = %s ",
+            array($user_id, $active_demand_cookie_cart)
+        )
+    );
+
+    if (!$id_cart) {
         $wpdb->insert(
             $wpdb->prefix . "cart",
@@ -1011 +1016 @@
                         'date_add' => current_time('mysql'),
             )
-                );
+        );
 
         $id_cart = $wpdb->insert_id;
-            }
+    }
 
     foreach (WC()->cart->get_cart() as $cart_item_key => $cart_item) {
@@ -1021 +1026 @@
         $variation_id = $cart_item['variation_id'];
 
-        $cart_product_id = $wpdb->get_var($wpdb->prepare('SELECT cp.id_cart FROM ' . $wpdb->prefix . 'cart_product cp LEFT JOIN ' . $wpdb->prefix . 'cart c ON cp.id_cart = c.id_cart WHERE cp.id_product = ' . (int)$id_product . ' AND cp.id_product_variation = ' . (int)$variation_id . ' AND c.cookie_cart_id = "' . $active_demand_cookie_cart . '"'));
+        $cart_product_id = $wpdb->get_var(
+            $wpdb->prepare(
+                "SELECT cp.id_cart FROM {$wpdb->prefix}cart_product cp LEFT JOIN {$wpdb->prefix}cart c ON cp.id_cart = c.id_cart WHERE cp.id_product = %d AND cp.id_product_variation = %d AND c.cookie_cart_id = %s ",
+                array($id_product, $variation_id, $active_demand_cookie_cart)
+            )
+        );
 
         $current_url = home_url(sanitize_url($_SERVER['REQUEST_URI']));
@@ -1079 +1089 @@
                 if ($custom_url_content['custom_url'] != '') {
 
-                    $existing_id_access = $wpdb->get_row($wpdb->prepare("SELECT id_access FROM " . $table_access . " where object_key='" . sanitize_text_field($_POST['access_object_key']) . "'"));
-
+                    $existing_id_access = $wpdb->get_row(
+                        $wpdb->prepare("SELECT id_access FROM $table_access WHERE object_key = %s ", array(sanitize_text_field($_POST['access_object_key'])))
+                    );
 
                     if ($existing_id_access) {
@@ -1092 +1103 @@
 
 
-                        $existing_rules = $wpdb->get_row($wpdb->prepare("SELECT * FROM " . $table_access_rule . " where id_rule='" . $custom_url_content['id_rule'] . "'"));
+                        $existing_rules = $wpdb->get_row(
+                            $wpdb->prepare("SELECT * FROM $table_access_rule WHERE id_rule = %d ", array(sanitize_text_field($custom_url_content['id_rule'])))
+                        );
 
 
@@ -1131 +1144 @@
         if ($_POST['method'] == "get_url_object_key") {
 
-            $resp = $wpdb->get_results($wpdb->prepare("SELECT ar.url, a.match , ar.id_rule FROM " . $table_access_rule . " ar
-                LEFT JOIN " . $table_access . " a ON ar.id_access = a.id_access where object_key='" . sanitize_text_field($_POST['valid_content']) . "'"));
+            $resp = $wpdb->get_results(
+                $wpdb->prepare(
+                    "SELECT ar.url, a.match , ar.id_rule FROM $table_access_rule ar
+                    LEFT JOIN $table_access a ON ar.id_access = a.id_access where object_key = %s ",
+                    array(sanitize_text_field($_POST['valid_content']))
+                )
+            );
+
             echo json_encode($resp);
-
-
         }
     }
@@ -1151 +1168 @@
     if (!empty($_POST)) {
         global $wpdb;
-        $id_rule = $_POST['id_rule'];
+        $id_rule = sanitize_text_field($_POST['id_rule']);
         $table = '' . $wpdb->prefix . 'activedemand_access_rule';
         $wpdb->delete($table, array('id_rule' => $id_rule));
@@ -1215 +1232 @@
 
             if (!$match_found) {
-                $get_does_not_match = $wpdb->get_results($wpdb->prepare("SELECT ar.url, a.match , a.object_key, ar.id_rule FROM " . $table_access_rule . " ar
-                LEFT JOIN " . $table_access . " a ON ar.id_access = a.id_access where a.match = '0'"));
+                $get_does_not_match = $wpdb->get_results(
+                    $wpdb->prepare(
+                        "SELECT ar.url, a.match , a.object_key, ar.id_rule FROM $table_access_rule ar
+                        LEFT JOIN $table_access a ON ar.id_access = a.id_access where a.match = %d",
+                        array(0)
+                    )
+                );
 
                 foreach ($get_does_not_match as $key => $result) {

activedemand/trunk/readme.txt

@@ -4 +4 @@
 Requires at least: 2.8
 Tested up to: 6.0.2
-Stable tag: 0.2.30
+Stable tag: 0.2.31
 
 
@@ -45 +45 @@
 
 == Changelog ==
+= 0.2.31 =
+Security Update
+
 = 0.2.30 =
 Security Update