Changeset 2637083

Timestamp:

11/29/2021 09:36:59 PM (4 years ago)

Author:

efreja

Message:

Fix for MSV block that may not show in block search field

Location:

music-sheet-viewer/trunk

Files:

• music-sheet-viewer.php (modified) (7 diffs)
• readme.txt (modified) (1 diff)

music-sheet-viewer/trunk/music-sheet-viewer.php

@@ -8 +8 @@
  * License:        GPL3
  * License URI:    https://www.gnu.org/licenses/gpl-3.0.html
- * Version:        3.2
+ * Version:        3.2.1
 
 Copyright Etienne Frejaville 2018, 2019, 2020, 2021
@@ -30 +30 @@
     class MusicSheetViewerPlugin
     {
-        const MSV_VERSION = '3.2';
+        const MSV_VERSION = '3.2.1';
         
         const MSV_SHORTCODE = 'pn_msv';
@@ -134 +134 @@
         {
             add_action('wp_enqueue_scripts', array($this,'hook_javascript'));
+            // enqueue block assets on the front-end and the editor
+            add_action('enqueue_block_assets', array($this,'register_block'));
             add_shortcode (self::MSV_SHORTCODE, array($this, 'process_shortcode'));
             add_filter('upload_mimes', array($this, 'allowed_mimetypes'), 1, 1);
@@ -140 +142 @@
             add_action('wp_ajax_readfile', array($this, 'read_score_file'));
             add_action('wp_ajax_nopriv_readfile', array($this, 'read_score_file'));
-            $this->register_block();
         }
         
@@ -146 +147 @@
          * Register MSV Block
          */
-        protected function register_block()
+        public function register_block()
         {
             // Skip block registration if Gutenberg is not enabled/merged.
             if (!function_exists('register_block_type')) {
+                error_log('Music Sheet Viewer ERROR : Cannot register block : Function register_block_type does not exist');
                 return;
             }
             
-            wp_register_script('music-sheet-viewer-pn-msv',
+            wp_enqueue_script('music-sheet-viewer-pn-msv',
                                plugins_url('js/block.js', __FILE__),
                                array(
@@ -165 +167 @@
             // !!!! _ forbidden in extension/bloc
             // https://github.com/WordPress/gutenberg/issues/13074
-            register_block_type(self::MSV_BLOCK, array(
+            if (false == register_block_type(self::MSV_BLOCK, array(
                                                                    'editor_script' => 'music-sheet-viewer-pn-msv',
                                                                    'render_callback' => array($this, 'process_block'),
@@ -203 +205 @@
                                                                    ]
                                                                    )
-                                );
+                                             )
+                ) error_log("Music Sheet Viewer ERROR : Cannot register block type: ".self::MSV_BLOCK);
         }
         

music-sheet-viewer/trunk/readme.txt

@@ -78 +78 @@
 == Changelog ==
 
+= 3.2.1 =
+* Fix for MSV block that may not show in block search field
+
 = 3.2 =
 * Embedding of Leland font from MuseScore