Changeset 2622865

Timestamp:

11/01/2021 03:21:13 PM (4 years ago)

Author:

peterfabian1000

Message:

Tagging version 3.4.0

Location:

action-scheduler

Files:

• tags/3.4.0 (copied) (copied from action-scheduler/trunk)
• tags/3.4.0/action-scheduler.php (modified) (4 diffs)
• tags/3.4.0/changelog.txt (modified) (1 diff)
• tags/3.4.0/classes/ActionScheduler_Compatibility.php (modified) (2 diffs)
• tags/3.4.0/classes/ActionScheduler_ListTable.php (modified) (3 diffs)
• tags/3.4.0/classes/ActionScheduler_wcSystemStatus.php (modified) (5 diffs)
• tags/3.4.0/classes/abstracts/ActionScheduler_Abstract_ListTable.php (modified) (44 diffs)
• tags/3.4.0/classes/data-stores/ActionScheduler_DBLogger.php (modified) (7 diffs)
• tags/3.4.0/classes/data-stores/ActionScheduler_DBStore.php (modified) (47 diffs)
• tags/3.4.0/classes/data-stores/ActionScheduler_wpPostStore.php (modified) (49 diffs)
• tags/3.4.0/classes/schema/ActionScheduler_StoreSchema.php (modified) (2 diffs)
• tags/3.4.0/deprecated/ActionScheduler_Schedule_Deprecated.php (modified) (2 diffs)
• tags/3.4.0/readme.txt (modified) (2 diffs)
• trunk/action-scheduler.php (modified) (4 diffs)
• trunk/changelog.txt (modified) (1 diff)
• trunk/classes/ActionScheduler_Compatibility.php (modified) (2 diffs)
• trunk/classes/ActionScheduler_ListTable.php (modified) (3 diffs)
• trunk/classes/ActionScheduler_wcSystemStatus.php (modified) (5 diffs)
• trunk/classes/abstracts/ActionScheduler_Abstract_ListTable.php (modified) (44 diffs)
• trunk/classes/data-stores/ActionScheduler_DBLogger.php (modified) (7 diffs)
• trunk/classes/data-stores/ActionScheduler_DBStore.php (modified) (47 diffs)
• trunk/classes/data-stores/ActionScheduler_wpPostStore.php (modified) (49 diffs)
• trunk/classes/schema/ActionScheduler_StoreSchema.php (modified) (2 diffs)
• trunk/deprecated/ActionScheduler_Schedule_Deprecated.php (modified) (2 diffs)
• trunk/readme.txt (modified) (2 diffs)

action-scheduler/tags/3.4.0/action-scheduler.php

@@ -6 +6 @@
  * Author: Automattic
  * Author URI: https://automattic.com/
- * Version: 3.3.0
+ * Version: 3.4.0
  * License: GPLv3
  *
@@ -27 +27 @@
  */
 
-if ( ! function_exists( 'action_scheduler_register_3_dot_3_dot_0' ) && function_exists( 'add_action' ) ) {
+if ( ! function_exists( 'action_scheduler_register_3_dot_4_dot_0' ) && function_exists( 'add_action' ) ) {
 
-    if ( ! class_exists( 'ActionScheduler_Versions' ) ) {
+    if ( ! class_exists( 'ActionScheduler_Versions', false ) ) {
         require_once __DIR__ . '/classes/ActionScheduler_Versions.php';
         add_action( 'plugins_loaded', array( 'ActionScheduler_Versions', 'initialize_latest_version' ), 1, 0 );
     }
 
-    add_action( 'plugins_loaded', 'action_scheduler_register_3_dot_3_dot_0', 0, 0 );
+    add_action( 'plugins_loaded', 'action_scheduler_register_3_dot_4_dot_0', 0, 0 );
 
     /**
      * Registers this version of Action Scheduler.
      */
-    function action_scheduler_register_3_dot_3_dot_0() {
+    function action_scheduler_register_3_dot_4_dot_0() {
         $versions = ActionScheduler_Versions::instance();
-        $versions->register( '3.3.0', 'action_scheduler_initialize_3_dot_3_dot_0' );
+        $versions->register( '3.4.0', 'action_scheduler_initialize_3_dot_4_dot_0' );
     }
 
@@ -47 +47 @@
      * Initializes this version of Action Scheduler.
      */
-    function action_scheduler_initialize_3_dot_3_dot_0() {
+    function action_scheduler_initialize_3_dot_4_dot_0() {
         // A final safety check is required even here, because historic versions of Action Scheduler
         // followed a different pattern (in some unusual cases, we could reach this point and the
         // ActionScheduler class is already defined—so we need to guard against that).
-        if ( ! class_exists( 'ActionScheduler' ) ) {
+        if ( ! class_exists( 'ActionScheduler', false ) ) {
             require_once __DIR__ . '/classes/abstracts/ActionScheduler.php';
             ActionScheduler::init( __FILE__ );
@@ -58 +58 @@
 
     // Support usage in themes - load this version if no plugin has loaded a version yet.
-    if ( did_action( 'plugins_loaded' ) && ! doing_action( 'plugins_loaded' ) && ! class_exists( 'ActionScheduler' ) ) {
-        action_scheduler_initialize_3_dot_3_dot_0();
+    if ( did_action( 'plugins_loaded' ) && ! doing_action( 'plugins_loaded' ) && ! class_exists( 'ActionScheduler', false ) ) {
+        action_scheduler_initialize_3_dot_4_dot_0();
         do_action( 'action_scheduler_pre_theme_init' );
         ActionScheduler_Versions::initialize_latest_version();

action-scheduler/tags/3.4.0/changelog.txt

@@ -1 +1 @@
 *** Changelog ***
+
+= 3.4.0 - 2021-10-29 =
+* Enhancement - Number of items per page can now be set for the Scheduled Actions view (props @ovidiul). #771
+* Fix - Do not lower the max_execution_time if it is already set to 0 (unlimited) (props @barryhughes). #755
+* Fix - Avoid triggering autoloaders during the version resolution process (props @olegabr). #731 & #776
+* Dev - ActionScheduler_wcSystemStatus PHPCS fixes (props @ovidiul). #761
+* Dev - ActionScheduler_DBLogger.php PHPCS fixes (props @ovidiul). #768
+* Dev - Fixed phpcs for ActionScheduler_Schedule_Deprecated (props @ovidiul). #762
+* Dev - Improve actions table indicies (props @glagonikas). #774 & #777
+* Dev - PHPCS fixes for ActionScheduler_DBStore.php (props @ovidiul). #769 & #778
+* Dev - PHPCS Fixes for ActionScheduler_Abstract_ListTable (props @ovidiul). #763 & #779
+* Dev - Adds new filter action_scheduler_claim_actions_order_by to allow tuning of the claim query (props @glagonikas). #773
+* Dev - PHPCS fixes for ActionScheduler_WpPostStore class (props @ovidiul). #780
 
 = 3.3.0 - 2021-09-15 =

action-scheduler/tags/3.4.0/classes/ActionScheduler_Compatibility.php

@@ -84 +84 @@
      * Only allows raising the existing limit and prevents lowering it. Wrapper for wc_set_time_limit(), when available.
      *
-     * @param int The time limit in seconds.
+     * @param int $limit The time limit in seconds.
      */
     public static function raise_time_limit( $limit = 0 ) {
-        if ( $limit < ini_get( 'max_execution_time' ) ) {
+        $limit = (int) $limit;
+        $max_execution_time = (int) ini_get( 'max_execution_time' );
+
+        /*
+         * If the max execution time is already unlimited (zero), or if it exceeds or is equal to the proposed
+         * limit, there is no reason for us to make further changes (we never want to lower it).
+         */
+        if (
+            0 === $max_execution_time
+            || ( $max_execution_time >= $limit && $limit !== 0 )
+        ) {
             return;
         }
@@ -94 +104 @@
             wc_set_time_limit( $limit );
         } elseif ( function_exists( 'set_time_limit' ) && false === strpos( ini_get( 'disable_functions' ), 'set_time_limit' ) && ! ini_get( 'safe_mode' ) ) { // phpcs:ignore PHPCompatibility.IniDirectives.RemovedIniDirectives.safe_modeDeprecatedRemoved
-            @set_time_limit( $limit );
+            @set_time_limit( $limit ); // phpcs:ignore WordPress.PHP.NoSilencedErrors.Discouraged
         }
     }

action-scheduler/tags/3.4.0/classes/ActionScheduler_ListTable.php

@@ -176 +176 @@
         );
 
-        parent::__construct( array(
-            'singular' => 'action-scheduler',
-            'plural'   => 'action-scheduler',
-            'ajax'     => false,
-        ) );
-    }
-
+        parent::__construct(
+            array(
+                'singular' => 'action-scheduler',
+                'plural'   => 'action-scheduler',
+                'ajax'     => false,
+            )
+        );
+
+        add_screen_option(
+            'per_page',
+            array(
+                'default' => $this->items_per_page,
+            )
+        );
+
+        add_filter( 'set_screen_option_' . $this->get_per_page_option_name(), array( $this, 'set_items_per_page_option' ), 10, 3 );
+        set_screen_options();
+    }
+
+    /**
+     * Handles setting the items_per_page option for this screen.
+     *
+     * @param mixed  $status Default false (to skip saving the current option).
+     * @param string $option Screen option name.
+     * @param int    $value  Screen option value.
+     * @return int
+     */
+    public function set_items_per_page_option( $status, $option, $value ) {
+        return $value;
+    }
     /**
      * Convert an interval of seconds into a two part human friendly string.
@@ -550 +573 @@
         $this->prepare_column_headers();
 
-        $per_page = $this->get_items_per_page( $this->package . '_items_per_page', $this->items_per_page );
+        $per_page = $this->get_items_per_page( $this->get_per_page_option_name(), $this->items_per_page );
+
         $query = array(
             'per_page' => $per_page,
@@ -610 +634 @@
         return __( 'Search hook, args and claim ID', 'action-scheduler' );
     }
+
+    /**
+     * {@inheritDoc}
+     */
+    protected function get_per_page_option_name() {
+        return str_replace( '-', '_', $this->screen->id ) . '_per_page';
+    }
 }

action-scheduler/tags/3.4.0/classes/ActionScheduler_wcSystemStatus.php

@@ -13 +13 @@
     protected $store;
 
-    function __construct( $store ) {
+    /**
+     * Constructor method for ActionScheduler_wcSystemStatus.
+     *
+     * @param ActionScheduler_Store $store Active store object.
+     *
+     * @return void
+     */
+    public function __construct( $store ) {
         $this->store = $store;
     }
@@ -68 +75 @@
         $order = 'oldest' === $date_type ? 'ASC' : 'DESC';
 
-        $action = $this->store->query_actions( array(
-            'claimed'  => false,
-            'status'   => $status,
-            'per_page' => 1,
-            'order'    => $order,
-        ) );
+        $action = $this->store->query_actions(
+            array(
+                'claimed'  => false,
+                'status'   => $status,
+                'per_page' => 1,
+                'order'    => $order,
+            )
+        );
 
         if ( ! empty( $action ) ) {
@@ -93 +102 @@
      */
     protected function get_template( $status_labels, $action_counts, $oldest_and_newest ) {
-        $as_version = ActionScheduler_Versions::instance()->latest_version();
+        $as_version   = ActionScheduler_Versions::instance()->latest_version();
         $as_datastore = get_class( ActionScheduler_Store::instance() );
         ?>
@@ -125 +134 @@
                         '<tr><td>%1$s</td><td>&nbsp;</td><td>%2$s<span style="display: none;">, Oldest: %3$s, Newest: %4$s</span></td><td>%3$s</td><td>%4$s</td></tr>',
                         esc_html( $status_labels[ $status ] ),
-                        number_format_i18n( $count ),
-                        $oldest_and_newest[ $status ]['oldest'],
-                        $oldest_and_newest[ $status ]['newest']
+                        esc_html( number_format_i18n( $count ) ),
+                        esc_html( $oldest_and_newest[ $status ]['oldest'] ),
+                        esc_html( $oldest_and_newest[ $status ]['newest'] )
                     );
                 }
@@ -138 +147 @@
 
     /**
-     * is triggered when invoking inaccessible methods in an object context.
+     * Is triggered when invoking inaccessible methods in an object context.
      *
-     * @param string $name
-     * @param array  $arguments
+     * @param string $name Name of method called.
+     * @param array  $arguments Parameters to invoke the method with.
      *
      * @return mixed

action-scheduler/tags/3.4.0/classes/abstracts/ActionScheduler_Abstract_ListTable.php

@@ -2 +2 @@
 
 if ( ! class_exists( 'WP_List_Table' ) ) {
-    require_once( ABSPATH . 'wp-admin/includes/class-wp-list-table.php' );
+    require_once ABSPATH . 'wp-admin/includes/class-wp-list-table.php';
 }
 
@@ -14 +14 @@
  *
  * This class supports:
- *  - Bulk actions
- *  - Search
+ *  - Bulk actions
+ *  - Search
  *  - Sortable columns
  *  - Automatic translations of the columns
@@ -26 +26 @@
     /**
      * The table name
+     *
+     * @var string
      */
     protected $table_name;
@@ -31 +33 @@
     /**
      * Package name, used to get options from WP_List_Table::get_items_per_page.
+     *
+     * @var string
      */
     protected $package;
@@ -36 +40 @@
     /**
      * How many items do we render per page?
+     *
+     * @var int
      */
     protected $items_per_page = 10;
@@ -42 +48 @@
      * Enables search in this table listing. If this array
      * is empty it means the listing is not searchable.
+     *
+     * @var array
      */
     protected $search_by = array();
@@ -49 +57 @@
      * key must much the table column name and the value is the label, which is
      * automatically translated.
+     *
+     * @var array
      */
     protected $columns = array();
@@ -59 +69 @@
      * (with the prefix row_action_<key>) and the value is the label
      * and title.
+     *
+     * @var array
      */
     protected $row_actions = array();
@@ -64 +76 @@
     /**
      * The Primary key of our table
+     *
+     * @var string
      */
     protected $ID = 'ID';
@@ -70 +84 @@
      * Enables sorting, it expects an array
      * of columns (the column names are the values)
+     *
+     * @var array
      */
     protected $sort_by = array();
 
+    /**
+     * The default sort order
+     *
+     * @var string
+     */
     protected $filter_by = array();
 
     /**
-     * @var array The status name => count combinations for this table's items. Used to display status filters.
+     * The status name => count combinations for this table's items. Used to display status filters.
+     *
+     * @var array
      */
     protected $status_counts = array();
 
     /**
-     * @var array Notices to display when loading the table. Array of arrays of form array( 'class' => {updated|error}, 'message' => 'This is the notice text display.' ).
+     * Notices to display when loading the table. Array of arrays of form array( 'class' => {updated|error}, 'message' => 'This is the notice text display.' ).
+     *
+     * @var array
      */
     protected $admin_notices = array();
 
     /**
-     * @var string Localised string displayed in the <h1> element above the able.
+     * Localised string displayed in the <h1> element above the able.
+     *
+     * @var string
      */
     protected $table_header;
@@ -100 +127 @@
      * is the array with primary keys, the second argument is a string with a list of the primary keys,
      * escaped and ready to use (with `IN`).
+     *
+     * @var array
      */
     protected $bulk_actions = array();
@@ -107 +136 @@
      * `_x` with some default (the package name).
      *
-     * @deprecated 3.0.0
+     * @param string $text The new text to translate.
+     * @param string $context The context of the text.
+     * @return string|void The translated text.
+     *
+     * @deprecated 3.0.0 Use `_x()` instead.
      */
     protected function translate( $text, $context = '' ) {
@@ -117 +150 @@
      * also validates that the bulk method handler exists. It throws an exception because
      * this is a library meant for developers and missing a bulk method is a development-time error.
+     *
+     * @return array
+     *
+     * @throws RuntimeException Throws RuntimeException when the bulk action does not have a callback method.
      */
     protected function get_bulk_actions() {
@@ -147 +184 @@
         check_admin_referer( 'bulk-' . $this->_args['plural'] );
 
-        $method   = 'bulk_' . $action;
+        $method = 'bulk_' . $action;
         if ( array_key_exists( $action, $this->bulk_actions ) && is_callable( array( $this, $method ) ) && ! empty( $_GET['ID'] ) && is_array( $_GET['ID'] ) ) {
             $ids_sql = '(' . implode( ',', array_fill( 0, count( $_GET['ID'] ), '%s' ) ) . ')';
-            $this->$method( $_GET['ID'], $wpdb->prepare( $ids_sql, $_GET['ID'] ) );
-        }
-
-        wp_redirect( remove_query_arg(
-            array( '_wp_http_referer', '_wpnonce', 'ID', 'action', 'action2' ),
-            wp_unslash( $_SERVER['REQUEST_URI'] )
-        ) );
-        exit;
+            $id      = array_map( 'absint', $_GET['ID'] );
+            $this->$method( $id, $wpdb->prepare( $ids_sql, $id ) ); //phpcs:ignore WordPress.DB.PreparedSQL
+        }
+
+        if ( isset( $_SERVER['REQUEST_URI'] ) ) {
+            wp_safe_redirect(
+                remove_query_arg(
+                    array( '_wp_http_referer', '_wpnonce', 'ID', 'action', 'action2' ),
+                    esc_url_raw( wp_unslash( $_SERVER['REQUEST_URI'] ) )
+                )
+            );
+            exit;
+        }
     }
 
@@ -163 +205 @@
      * Default code for deleting entries.
      * validated already by process_bulk_action()
+     *
+     * @param array  $ids ids of the items to delete.
+     * @param string $ids_sql the sql for the ids.
+     * @return void
      */
     protected function bulk_delete( array $ids, $ids_sql ) {
@@ -218 +264 @@
         global $wpdb;
 
-        $per_page = $this->get_items_per_page( $this->package . '_items_per_page', $this->items_per_page );
+        $per_page = $this->get_items_per_page( $this->get_per_page_option_name(), $this->items_per_page );
         return $wpdb->prepare( 'LIMIT %d', $per_page );
     }
@@ -228 +274 @@
      */
     protected function get_items_offset() {
-        $per_page = $this->get_items_per_page( $this->package . '_items_per_page', $this->items_per_page );
+        $per_page     = $this->get_items_per_page( $this->get_per_page_option_name(), $this->items_per_page );
         $current_page = $this->get_pagenum();
         if ( 1 < $current_page ) {
@@ -277 +323 @@
         $valid_sortable_columns = array_values( $this->sort_by );
 
-        if ( ! empty( $_GET['orderby'] ) && in_array( $_GET['orderby'], $valid_sortable_columns ) ) {
-            $orderby = sanitize_text_field( $_GET['orderby'] );
+        if ( ! empty( $_GET['orderby'] ) && in_array( $_GET['orderby'], $valid_sortable_columns, true ) ) { //phpcs:ignore WordPress.Security.NonceVerification.Recommended
+            $orderby = sanitize_text_field( wp_unslash( $_GET['orderby'] ) ); //phpcs:ignore WordPress.Security.NonceVerification.Recommended
         } else {
             $orderby = $valid_sortable_columns[0];
@@ -293 +339 @@
     protected function get_request_order() {
 
-        if ( ! empty( $_GET['order'] ) && 'desc' === strtolower( $_GET['order'] ) ) {
+        if ( ! empty( $_GET['order'] ) && 'desc' === strtolower( sanitize_text_field( wp_unslash( $_GET['order'] ) ) ) ) { //phpcs:ignore WordPress.Security.NonceVerification.Recommended
             $order = 'DESC';
         } else {
@@ -308 +354 @@
      */
     protected function get_request_status() {
-        $status = ( ! empty( $_GET['status'] ) ) ? $_GET['status'] : '';
+        $status = ( ! empty( $_GET['status'] ) ) ? sanitize_text_field( wp_unslash( $_GET['status'] ) ) : ''; //phpcs:ignore WordPress.Security.NonceVerification.Recommended
         return $status;
     }
@@ -318 +364 @@
      */
     protected function get_request_search_query() {
-        $search_query = ( ! empty( $_GET['s'] ) ) ? $_GET['s'] : '';
+        $search_query = ( ! empty( $_GET['s'] ) ) ? sanitize_text_field( wp_unslash( $_GET['s'] ) ) : ''; //phpcs:ignore WordPress.Security.NonceVerification.Recommended
         return $search_query;
     }
@@ -330 +376 @@
     protected function get_table_columns() {
         $columns = array_keys( $this->columns );
-        if ( ! in_array( $this->ID, $columns ) ) {
+        if ( ! in_array( $this->ID, $columns, true ) ) {
             $columns[] = $this->ID;
         }
@@ -344 +390 @@
      * that feature it will return an empty string.
      *
-     * TODO:
-     *   - Improve search doing LIKE by word rather than by phrases.
-     *
      * @return string
      */
@@ -352 +395 @@
         global $wpdb;
 
-        if ( empty( $_GET['s'] ) || empty( $this->search_by ) ) {
+        if ( empty( $_GET['s'] ) || empty( $this->search_by ) ) { //phpcs:ignore WordPress.Security.NonceVerification.Recommended
             return '';
         }
 
-        $filter  = array();
+        $search_string = sanitize_text_field( wp_unslash( $_GET['s'] ) ); //phpcs:ignore WordPress.Security.NonceVerification.Recommended
+
+        $filter = array();
         foreach ( $this->search_by as $column ) {
-            $filter[] = $wpdb->prepare('`' . $column . '` like "%%s%"', $wpdb->esc_like( $_GET['s'] ));
+            $wild     = '%';
+            $sql_like = $wild . $wpdb->esc_like( $search_string ) . $wild;
+            $filter[] = $wpdb->prepare( '`' . $column . '` LIKE %s', $sql_like ); // phpcs:ignore WordPress.Security.NonceVerification.Recommended, WordPress.DB.PreparedSQL.NotPrepared
         }
         return implode( ' OR ', $filter );
@@ -370 +417 @@
         global $wpdb;
 
-        if ( ! $this->filter_by || empty( $_GET['filter_by'] ) || ! is_array( $_GET['filter_by'] ) ) {
+        if ( ! $this->filter_by || empty( $_GET['filter_by'] ) || ! is_array( $_GET['filter_by'] ) ) { //phpcs:ignore WordPress.Security.NonceVerification.Recommended
             return '';
         }
@@ -377 +424 @@
 
         foreach ( $this->filter_by as $column => $options ) {
-            if ( empty( $_GET['filter_by'][ $column ] ) || empty( $options[ $_GET['filter_by'][ $column ] ] ) ) {
+            if ( empty( $_GET['filter_by'][ $column ] ) || empty( $options[ $_GET['filter_by'][ $column ] ] ) ) { //phpcs:ignore WordPress.Security.NonceVerification.Recommended
                 continue;
             }
 
-            $filter[] = $wpdb->prepare( "`$column` = %s", $_GET['filter_by'][ $column ] );
+            $filter[] = $wpdb->prepare( "`$column` = %s", sanitize_text_field( wp_unslash( $_GET['filter_by'][ $column ] ) ) ); //phpcs:ignore WordPress.Security.NonceVerification.Recommended, WordPress.DB.PreparedSQL.InterpolatedNotPrepared
         }
 
@@ -404 +451 @@
         $this->process_row_actions();
 
-        if ( ! empty( $_REQUEST['_wp_http_referer'] ) ) {
+        if ( ! empty( $_REQUEST['_wp_http_referer'] && ! empty( $_SERVER['REQUEST_URI'] ) ) ) { //phpcs:ignore WordPress.Security.NonceVerification.Recommended
             // _wp_http_referer is used only on bulk actions, we remove it to keep the $_GET shorter
-            wp_redirect( remove_query_arg( array( '_wp_http_referer', '_wpnonce' ), wp_unslash( $_SERVER['REQUEST_URI'] ) ) );
+            wp_safe_redirect( remove_query_arg( array( '_wp_http_referer', '_wpnonce' ), esc_url_raw( wp_unslash( $_SERVER['REQUEST_URI'] ) ) ) );
             exit;
         }
@@ -415 +462 @@
         $offset  = $this->get_items_query_offset();
         $order   = $this->get_items_query_order();
-        $where   = array_filter(array(
-            $this->get_items_query_search(),
-            $this->get_items_query_filters(),
-        ));
+        $where   = array_filter(
+            array(
+                $this->get_items_query_search(),
+                $this->get_items_query_filters(),
+            )
+        );
         $columns = '`' . implode( '`, `', $this->get_table_columns() ) . '`';
 
         if ( ! empty( $where ) ) {
-            $where = 'WHERE ('. implode( ') AND (', $where ) . ')';
+            $where = 'WHERE (' . implode( ') AND (', $where ) . ')';
         } else {
             $where = '';
@@ -429 +478 @@
         $sql = "SELECT $columns FROM {$this->table_name} {$where} {$order} {$limit} {$offset}";
 
-        $this->set_items( $wpdb->get_results( $sql, ARRAY_A ) );
+        $this->set_items( $wpdb->get_results( $sql, ARRAY_A ) ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared
 
         $query_count = "SELECT COUNT({$this->ID}) FROM {$this->table_name} {$where}";
-        $total_items = $wpdb->get_var( $query_count );
-        $per_page    = $this->get_items_per_page( $this->package . '_items_per_page', $this->items_per_page );
-        $this->set_pagination_args( array(
-            'total_items' => $total_items,
-            'per_page'    => $per_page,
-            'total_pages' => ceil( $total_items / $per_page ),
-        ) );
-    }
-
+        $total_items = $wpdb->get_var( $query_count ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared
+        $per_page    = $this->get_items_per_page( $this->get_per_page_option_name(), $this->items_per_page );
+        $this->set_pagination_args(
+            array(
+                'total_items' => $total_items,
+                'per_page'    => $per_page,
+                'total_pages' => ceil( $total_items / $per_page ),
+            )
+        );
+    }
+
+    /**
+     * Display the table.
+     *
+     * @param string $which The name of the table.
+     */
     public function extra_tablenav( $which ) {
         if ( ! $this->filter_by || 'top' !== $which ) {
@@ -449 +505 @@
 
         foreach ( $this->filter_by as $id => $options ) {
-            $default = ! empty( $_GET['filter_by'][ $id ] ) ? $_GET['filter_by'][ $id ] : '';
+            $default = ! empty( $_GET['filter_by'][ $id ] ) ? sanitize_text_field( wp_unslash( $_GET['filter_by'][ $id ] ) ) : ''; //phpcs:ignore WordPress.Security.NonceVerification.Recommended
             if ( empty( $options[ $default ] ) ) {
                 $default = '';
@@ -457 +513 @@
 
             foreach ( $options as $value => $label ) {
-                echo '<option value="' . esc_attr( $value ) . '" ' . esc_html( $value == $default ? 'selected' : '' )  .'>'
+                echo '<option value="' . esc_attr( $value ) . '" ' . esc_html( $value === $default ? 'selected' : '' ) . '>'
                     . esc_html( $label )
                 . '</option>';
@@ -472 +528 @@
      * Set the data for displaying. It will attempt to unserialize (There is a chance that some columns
      * are serialized). This can be override in child classes for futher data transformation.
+     *
+     * @param array $items Items array.
      */
     protected function set_items( array $items ) {
@@ -484 +542 @@
      * of how the primary key is named (to keep the code simpler). The bulk actions will do the proper
      * name transformation though using `$this->ID`.
+     *
+     * @param array $row The row to render.
      */
     public function column_cb( $row ) {
-        return '<input name="ID[]" type="checkbox" value="' . esc_attr( $row[ $this->ID ] ) .'" />';
+        return '<input name="ID[]" type="checkbox" value="' . esc_attr( $row[ $this->ID ] ) . '" />';
     }
 
@@ -495 +555 @@
      * and it checks that the row action method exists before rendering it.
      *
-     * @param array $row     Row to render
-     * @param $column_name   Current row
-     * @return
+     * @param array  $row Row to be rendered.
+     * @param string $column_name Column name.
+     * @return string
      */
     protected function maybe_render_actions( $row, $column_name ) {
@@ -506 +566 @@
         $row_id = $row[ $this->ID ];
 
-        $actions = '<div class="row-actions">';
+        $actions      = '<div class="row-actions">';
         $action_count = 0;
         foreach ( $this->row_actions[ $column_name ] as $action_key => $action ) {
@@ -516 +576 @@
             }
 
-            $action_link = ! empty( $action['link'] ) ? $action['link'] : add_query_arg( array( 'row_action' => $action_key, 'row_id' => $row_id, 'nonce'  => wp_create_nonce( $action_key . '::' . $row_id ) ) );
+            $action_link = ! empty( $action['link'] ) ? $action['link'] : add_query_arg(
+                array(
+                    'row_action' => $action_key,
+                    'row_id'     => $row_id,
+                    'nonce'      => wp_create_nonce( $action_key . '::' . $row_id ),
+                )
+            );
             $span_class  = ! empty( $action['class'] ) ? $action['class'] : $action_key;
             $separator   = ( $action_count < count( $this->row_actions[ $column_name ] ) ) ? ' | ' : '';
@@ -528 +594 @@
     }
 
+    /**
+     * Process the bulk actions.
+     *
+     * @return void
+     */
     protected function process_row_actions() {
         $parameters = array( 'row_action', 'row_id', 'nonce' );
         foreach ( $parameters as $parameter ) {
-            if ( empty( $_REQUEST[ $parameter ] ) ) {
+            if ( empty( $_REQUEST[ $parameter ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Recommended
                 return;
             }
         }
 
-        $method = 'row_action_' . $_REQUEST['row_action'];
-
-        if ( $_REQUEST['nonce'] === wp_create_nonce( $_REQUEST[ 'row_action' ] . '::' . $_REQUEST[ 'row_id' ] ) && method_exists( $this, $method ) ) {
-            $this->$method( $_REQUEST['row_id'] );
-        }
-
-        wp_redirect( remove_query_arg(
-            array( 'row_id', 'row_action', 'nonce' ),
-            wp_unslash( $_SERVER['REQUEST_URI'] )
-        ) );
-        exit;
+        $action = sanitize_text_field( wp_unslash( $_REQUEST['row_action'] ) ); // phpcs:ignore WordPress.Security.NonceVerification.Recommended, WordPress.Security.ValidatedSanitizedInput.InputNotValidated
+        $row_id = sanitize_text_field( wp_unslash( $_REQUEST['row_id'] ) ); // phpcs:ignore WordPress.Security.NonceVerification.Recommended, WordPress.Security.ValidatedSanitizedInput.InputNotValidated
+        $nonce  = sanitize_text_field( wp_unslash( $_REQUEST['nonce'] ) ); // phpcs:ignore WordPress.Security.NonceVerification.Recommended, WordPress.Security.ValidatedSanitizedInput.InputNotValidated
+        $method = 'row_action_' . $action; // phpcs:ignore WordPress.Security.NonceVerification.Recommended
+
+        if ( wp_verify_nonce( $nonce, $action . '::' . $row_id ) && method_exists( $this, $method ) ) {
+            $this->$method( sanitize_text_field( wp_unslash( $row_id ) ) ); // phpcs:ignore WordPress.Security.NonceVerification.Recommended
+        }
+
+        if ( isset( $_SERVER['REQUEST_URI'] ) ) {
+            wp_safe_redirect(
+                remove_query_arg(
+                    array( 'row_id', 'row_action', 'nonce' ),
+                    esc_url_raw( wp_unslash( $_SERVER['REQUEST_URI'] ) )
+                )
+            );
+            exit;
+        }
     }
 
     /**
      * Default column formatting, it will escape everythig for security.
+     *
+     * @param array  $item The item array.
+     * @param string $column_name Column name to display.
+     *
+     * @return string
      */
     public function column_default( $item, $column_name ) {
-        $column_html = esc_html( $item[ $column_name ] );
+        $column_html  = esc_html( $item[ $column_name ] );
         $column_html .= $this->maybe_render_actions( $item, $column_name );
         return $column_html;
@@ -575 +658 @@
     protected function display_admin_notices() {
         foreach ( $this->admin_notices as $notice ) {
-            echo '<div id="message" class="' . $notice['class'] . '">';
+            echo '<div id="message" class="' . esc_attr( $notice['class'] ) . '">';
             echo '  <p>' . wp_kses_post( $notice['message'] ) . '</p>';
             echo '</div>';
@@ -589 +672 @@
         $request_status    = $this->get_request_status();
 
-        // Helper to set 'all' filter when not set on status counts passed in
+        // Helper to set 'all' filter when not set on status counts passed in.
         if ( ! isset( $this->status_counts['all'] ) ) {
             $this->status_counts = array( 'all' => array_sum( $this->status_counts ) ) + $this->status_counts;
@@ -613 +696 @@
         if ( $status_list_items ) {
             echo '<ul class="subsubsub">';
-            echo implode( " | \n", $status_list_items );
+            echo implode( " | \n", $status_list_items ); // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
             echo '</ul>';
         }
@@ -625 +708 @@
     protected function display_table() {
         echo '<form id="' . esc_attr( $this->_args['plural'] ) . '-filter" method="get">';
-        foreach ( $_GET as $key => $value ) {
+        foreach ( $_GET as $key => $value ) { // phpcs:ignore WordPress.Security.NonceVerification.Recommended
             if ( '_' === $key[0] || 'paged' === $key || 'ID' === $key ) {
                 continue;
@@ -632 +715 @@
         }
         if ( ! empty( $this->search_by ) ) {
-            echo $this->search_box( $this->get_search_box_button_text(), 'plugin' ); // WPCS: XSS OK
+            echo $this->search_box( $this->get_search_box_button_text(), 'plugin' ); // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
         }
         parent::display();
@@ -645 +728 @@
         $this->process_row_actions();
 
-        if ( ! empty( $_REQUEST['_wp_http_referer'] ) ) {
+        if ( ! empty( $_REQUEST['_wp_http_referer'] ) && ! empty( $_SERVER['REQUEST_URI'] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Recommended
             // _wp_http_referer is used only on bulk actions, we remove it to keep the $_GET shorter
-            wp_redirect( remove_query_arg( array( '_wp_http_referer', '_wpnonce' ), wp_unslash( $_SERVER['REQUEST_URI'] ) ) );
+            wp_safe_redirect( remove_query_arg( array( '_wp_http_referer', '_wpnonce' ), esc_url_raw( wp_unslash( $_SERVER['REQUEST_URI'] ) ) ) );
             exit;
         }
@@ -672 +755 @@
         return esc_html__( 'Search', 'action-scheduler' );
     }
+
+    /**
+     * Gets the screen per_page option name.
+     *
+     * @return string
+     */
+    protected function get_per_page_option_name() {
+        return $this->package . '_items_per_page';
+    }
 }

action-scheduler/tags/3.4.0/classes/data-stores/ActionScheduler_DBLogger.php

@@ -30 +30 @@
         $date_local = $date->format( 'Y-m-d H:i:s' );
 
-        /** @var \wpdb $wpdb */
+        /** @var \wpdb $wpdb */ //phpcs:ignore Generic.Commenting.DocComment.MissingShort
         global $wpdb;
-        $wpdb->insert( $wpdb->actionscheduler_logs, [
-            'action_id'      => $action_id,
-            'message'        => $message,
-            'log_date_gmt'   => $date_gmt,
-            'log_date_local' => $date_local,
-        ], [ '%d', '%s', '%s', '%s' ] );
+        $wpdb->insert(
+            $wpdb->actionscheduler_logs,
+            array(
+                'action_id'      => $action_id,
+                'message'        => $message,
+                'log_date_gmt'   => $date_gmt,
+                'log_date_local' => $date_local,
+            ),
+            array( '%d', '%s', '%s', '%s' )
+        );
 
         return $wpdb->insert_id;
@@ -50 +54 @@
      */
     public function get_entry( $entry_id ) {
-        /** @var \wpdb $wpdb */
+        /** @var \wpdb $wpdb */ //phpcs:ignore Generic.Commenting.DocComment.MissingShort
         global $wpdb;
         $entry = $wpdb->get_row( $wpdb->prepare( "SELECT * FROM {$wpdb->actionscheduler_logs} WHERE log_id=%d", $entry_id ) );
@@ -86 +90 @@
      */
     public function get_logs( $action_id ) {
-        /** @var \wpdb $wpdb */
+        /** @var \wpdb $wpdb */ //phpcs:ignore Generic.Commenting.DocComment.MissingShort
         global $wpdb;
 
         $records = $wpdb->get_results( $wpdb->prepare( "SELECT * FROM {$wpdb->actionscheduler_logs} WHERE action_id=%d", $action_id ) );
 
-        return array_map( [ $this, 'create_entry_from_db_record' ], $records );
+        return array_map( array( $this, 'create_entry_from_db_record' ), $records );
     }
 
@@ -106 +110 @@
         parent::init();
 
-        add_action( 'action_scheduler_deleted_action', [ $this, 'clear_deleted_action_logs' ], 10, 1 );
+        add_action( 'action_scheduler_deleted_action', array( $this, 'clear_deleted_action_logs' ), 10, 1 );
     }
 
@@ -115 +119 @@
      */
     public function clear_deleted_action_logs( $action_id ) {
-        /** @var \wpdb $wpdb */
+        /** @var \wpdb $wpdb */ //phpcs:ignore Generic.Commenting.DocComment.MissingShort
         global $wpdb;
-        $wpdb->delete( $wpdb->actionscheduler_logs, [ 'action_id' => $action_id, ], [ '%d' ] );
+        $wpdb->delete( $wpdb->actionscheduler_logs, array( 'action_id' => $action_id ), array( '%d' ) );
     }
 
@@ -130 +134 @@
         }
 
-        /** @var \wpdb $wpdb */
+        /** @var \wpdb $wpdb */ //phpcs:ignore Generic.Commenting.DocComment.MissingShort
         global $wpdb;
         $date     = as_get_datetime_object();
@@ -139 +143 @@
         $format     = '(%d, ' . $wpdb->prepare( '%s, %s, %s', $message, $date_gmt, $date_local ) . ')';
         $sql_query  = "INSERT {$wpdb->actionscheduler_logs} (action_id, message, log_date_gmt, log_date_local) VALUES ";
-        $value_rows = [];
+        $value_rows = array();
 
         foreach ( $action_ids as $action_id ) {
-            $value_rows[] = $wpdb->prepare( $format, $action_id );
+            $value_rows[] = $wpdb->prepare( $format, $action_id ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared
         }
         $sql_query .= implode( ',', $value_rows );
 
-        $wpdb->query( $sql_query );
+        $wpdb->query( $sql_query ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared
     }
 }

action-scheduler/tags/3.4.0/classes/data-stores/ActionScheduler_DBStore.php

@@ -41 +41 @@
      *
      * @param ActionScheduler_Action $action Action object.
-     * @param DateTime               $date Optional schedule date. Default null.
+     * @param DateTime              $date Optional schedule date. Default null.
      *
      * @return int Action ID.
+     * @throws RuntimeException     Throws exception when saving the action fails.
      */
     public function save_action( ActionScheduler_Action $action, \DateTime $date = null ) {
@@ -52 +53 @@
             /** @var \wpdb $wpdb */
             global $wpdb;
-            $data = [
+            $data = array(
                 'hook'                 => $action->get_hook(),
                 'status'               => ( $action->is_finished() ? self::STATUS_COMPLETE : self::STATUS_PENDING ),
                 'scheduled_date_gmt'   => $this->get_scheduled_date_string( $action, $date ),
                 'scheduled_date_local' => $this->get_scheduled_date_string_local( $action, $date ),
-                'schedule'             => serialize( $action->get_schedule() ),
+                'schedule'             => serialize( $action->get_schedule() ), // phpcs:ignore WordPress.PHP.DiscouragedPHPFunctions.serialize_serialize
                 'group_id'             => $this->get_group_id( $action->get_group() ),
-            ];
+            );
             $args = wp_json_encode( $action->get_args() );
             if ( strlen( $args ) <= static::$max_index_length ) {
@@ -73 +74 @@
 
             if ( is_wp_error( $action_id ) ) {
-                throw new RuntimeException( $action_id->get_error_message() );
-            }
-            elseif ( empty( $action_id ) ) {
-                throw new RuntimeException( $wpdb->last_error ? $wpdb->last_error : __( 'Database error.', 'action-scheduler' ) );
+                throw new \RuntimeException( $action_id->get_error_message() );
+            } elseif ( empty( $action_id ) ) {
+                throw new \RuntimeException( $wpdb->last_error ? $wpdb->last_error : __( 'Database error.', 'action-scheduler' ) );
             }
 
@@ -115 +115 @@
      *
      * @param string $slug The string name of a group.
-     * @param bool $create_if_not_exists Whether to create the group if it does not already exist. Default, true - create the group.
+     * @param bool   $create_if_not_exists Whether to create the group if it does not already exist. Default, true - create the group.
      *
      * @return int The group's ID, if it exists or is created, or 0 if it does not exist and is not created.
@@ -143 +143 @@
         /** @var \wpdb $wpdb */
         global $wpdb;
-        $wpdb->insert( $wpdb->actionscheduler_groups, [ 'slug' => $slug ] );
+        $wpdb->insert( $wpdb->actionscheduler_groups, array( 'slug' => $slug ) );
 
         return (int) $wpdb->insert_id;
@@ -158 +158 @@
         /** @var \wpdb $wpdb */
         global $wpdb;
-        $data = $wpdb->get_row( $wpdb->prepare(
-            "SELECT a.*, g.slug AS `group` FROM {$wpdb->actionscheduler_actions} a LEFT JOIN {$wpdb->actionscheduler_groups} g ON a.group_id=g.group_id WHERE a.action_id=%d",
-            $action_id
-        ) );
+        $data = $wpdb->get_row(
+            $wpdb->prepare(
+                "SELECT a.*, g.slug AS `group` FROM {$wpdb->actionscheduler_actions} a LEFT JOIN {$wpdb->actionscheduler_groups} g ON a.group_id=g.group_id WHERE a.action_id=%d",
+                $action_id
+            )
+        );
 
         if ( empty( $data ) ) {
@@ -173 +175 @@
 
         // Convert NULL dates to zero dates.
-        $date_fields = [
+        $date_fields = array(
             'scheduled_date_gmt',
             'scheduled_date_local',
             'last_attempt_gmt',
-            'last_attempt_gmt'
-        ];
-        foreach( $date_fields as $date_field ) {
+            'last_attempt_gmt',
+        );
+        foreach ( $date_fields as $date_field ) {
             if ( is_null( $data->$date_field ) ) {
                 $data->$date_field = ActionScheduler_StoreSchema::DEFAULT_DATE;
@@ -215 +217 @@
         $hook     = $data->hook;
         $args     = json_decode( $data->args, true );
-        $schedule = unserialize( $data->schedule );
+        $schedule = unserialize( $data->schedule ); // phpcs:ignore WordPress.PHP.DiscouragedPHPFunctions.serialize_unserialize
 
         $this->validate_args( $args, $data->action_id );
@@ -237 +239 @@
      *
      * @return string SQL statement already properly escaped.
+     * @throws InvalidArgumentException If the query is invalid.
      */
     protected function get_query_actions_sql( array $query, $select_or_count = 'select' ) {
 
-        if ( ! in_array( $select_or_count, array( 'select', 'count' ) ) ) {
+        if ( ! in_array( $select_or_count, array( 'select', 'count' ), true ) ) {
             throw new InvalidArgumentException( __( 'Invalid value for select or count parameter. Cannot query actions.', 'action-scheduler' ) );
         }
 
-        $query = wp_parse_args( $query, [
-            'hook'             => '',
-            'args'             => null,
-            'date'             => null,
-            'date_compare'     => '<=',
-            'modified'         => null,
-            'modified_compare' => '<=',
-            'group'            => '',
-            'status'           => '',
-            'claimed'          => null,
-            'per_page'         => 5,
-            'offset'           => 0,
-            'orderby'          => 'date',
-            'order'            => 'ASC',
-        ] );
-
-        /** @var \wpdb $wpdb */
-        global $wpdb;
-        $sql  = ( 'count' === $select_or_count ) ? 'SELECT count(a.action_id)' : 'SELECT a.action_id';
-        $sql .= " FROM {$wpdb->actionscheduler_actions} a";
-        $sql_params = [];
-
-        if ( ! empty( $query[ 'group' ] ) || 'group' === $query[ 'orderby' ] ) {
+        $query = wp_parse_args(
+            $query,
+            array(
+                'hook'             => '',
+                'args'             => null,
+                'date'             => null,
+                'date_compare'     => '<=',
+                'modified'         => null,
+                'modified_compare' => '<=',
+                'group'            => '',
+                'status'           => '',
+                'claimed'          => null,
+                'per_page'         => 5,
+                'offset'           => 0,
+                'orderby'          => 'date',
+                'order'            => 'ASC',
+            )
+        );
+
+        /** @var \wpdb $wpdb */
+        global $wpdb;
+        $sql        = ( 'count' === $select_or_count ) ? 'SELECT count(a.action_id)' : 'SELECT a.action_id';
+        $sql       .= " FROM {$wpdb->actionscheduler_actions} a";
+        $sql_params = array();
+
+        if ( ! empty( $query['group'] ) || 'group' === $query['orderby'] ) {
             $sql .= " LEFT JOIN {$wpdb->actionscheduler_groups} g ON g.group_id=a.group_id";
         }
 
-        $sql .= " WHERE 1=1";
-
-        if ( ! empty( $query[ 'group' ] ) ) {
-            $sql          .= " AND g.slug=%s";
-            $sql_params[] = $query[ 'group' ];
-        }
-
-        if ( $query[ 'hook' ] ) {
-            $sql          .= " AND a.hook=%s";
-            $sql_params[] = $query[ 'hook' ];
-        }
-        if ( ! is_null( $query[ 'args' ] ) ) {
-            $sql          .= " AND a.args=%s";
-            $sql_params[] = $this->get_args_for_query( $query[ 'args' ] );
+        $sql .= ' WHERE 1=1';
+
+        if ( ! empty( $query['group'] ) ) {
+            $sql         .= ' AND g.slug=%s';
+            $sql_params[] = $query['group'];
+        }
+
+        if ( $query['hook'] ) {
+            $sql         .= ' AND a.hook=%s';
+            $sql_params[] = $query['hook'];
+        }
+        if ( ! is_null( $query['args'] ) ) {
+            $sql         .= ' AND a.args=%s';
+            $sql_params[] = $this->get_args_for_query( $query['args'] );
         }
 
@@ -293 +299 @@
         }
 
-        if ( $query[ 'date' ] instanceof \DateTime ) {
-            $date = clone $query[ 'date' ];
+        if ( $query['date'] instanceof \DateTime ) {
+            $date = clone $query['date'];
             $date->setTimezone( new \DateTimeZone( 'UTC' ) );
             $date_string  = $date->format( 'Y-m-d H:i:s' );
-            $comparator   = $this->validate_sql_comparator( $query[ 'date_compare' ] );
-            $sql          .= " AND a.scheduled_date_gmt $comparator %s";
+            $comparator   = $this->validate_sql_comparator( $query['date_compare'] );
+            $sql         .= " AND a.scheduled_date_gmt $comparator %s";
             $sql_params[] = $date_string;
         }
 
-        if ( $query[ 'modified' ] instanceof \DateTime ) {
-            $modified = clone $query[ 'modified' ];
+        if ( $query['modified'] instanceof \DateTime ) {
+            $modified = clone $query['modified'];
             $modified->setTimezone( new \DateTimeZone( 'UTC' ) );
             $date_string  = $modified->format( 'Y-m-d H:i:s' );
-            $comparator   = $this->validate_sql_comparator( $query[ 'modified_compare' ] );
-            $sql          .= " AND a.last_attempt_gmt $comparator %s";
+            $comparator   = $this->validate_sql_comparator( $query['modified_compare'] );
+            $sql         .= " AND a.last_attempt_gmt $comparator %s";
             $sql_params[] = $date_string;
         }
 
-        if ( $query[ 'claimed' ] === true ) {
-            $sql .= " AND a.claim_id != 0";
-        } elseif ( $query[ 'claimed' ] === false ) {
-            $sql .= " AND a.claim_id = 0";
-        } elseif ( ! is_null( $query[ 'claimed' ] ) ) {
-            $sql          .= " AND a.claim_id = %d";
-            $sql_params[] = $query[ 'claimed' ];
+        if ( true === $query['claimed'] ) {
+            $sql .= ' AND a.claim_id != 0';
+        } elseif ( false === $query['claimed'] ) {
+            $sql .= ' AND a.claim_id = 0';
+        } elseif ( ! is_null( $query['claimed'] ) ) {
+            $sql         .= ' AND a.claim_id = %d';
+            $sql_params[] = $query['claimed'];
         }
 
         if ( ! empty( $query['search'] ) ) {
-            $sql .= " AND (a.hook LIKE %s OR (a.extended_args IS NULL AND a.args LIKE %s) OR a.extended_args LIKE %s";
-            for( $i = 0; $i < 3; $i++ ) {
+            $sql .= ' AND (a.hook LIKE %s OR (a.extended_args IS NULL AND a.args LIKE %s) OR a.extended_args LIKE %s';
+            for ( $i = 0; $i < 3; $i++ ) {
                 $sql_params[] = sprintf( '%%%s%%', $query['search'] );
             }
@@ -328 +334 @@
             $search_claim_id = (int) $query['search'];
             if ( $search_claim_id ) {
-                $sql .= ' OR a.claim_id = %d';
+                $sql         .= ' OR a.claim_id = %d';
                 $sql_params[] = $search_claim_id;
             }
@@ -362 +368 @@
             }
 
-            if ( $query[ 'per_page' ] > 0 ) {
-                $sql          .= " LIMIT %d, %d";
-                $sql_params[] = $query[ 'offset' ];
-                $sql_params[] = $query[ 'per_page' ];
+            if ( $query['per_page'] > 0 ) {
+                $sql         .= ' LIMIT %d, %d';
+                $sql_params[] = $query['offset'];
+                $sql_params[] = $query['per_page'];
             }
         }
 
         if ( ! empty( $sql_params ) ) {
-            $sql = $wpdb->prepare( $sql, $sql_params );
+            $sql = $wpdb->prepare( $sql, $sql_params ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared
         }
 
@@ -388 +394 @@
      * @return string|array|null The IDs of actions matching the query. Null on failure.
      */
-    public function query_actions( $query = [], $query_type = 'select' ) {
+    public function query_actions( $query = array(), $query_type = 'select' ) {
         /** @var wpdb $wpdb */
         global $wpdb;
@@ -394 +400 @@
         $sql = $this->get_query_actions_sql( $query, $query_type );
 
-        return ( 'count' === $query_type ) ? $wpdb->get_var( $sql ) : $wpdb->get_col( $sql );
+        return ( 'count' === $query_type ) ? $wpdb->get_var( $sql ) : $wpdb->get_col( $sql ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared, WordPress.DB.DirectDatabaseQuery.NoSql, WordPress.DB.DirectDatabaseQuery.NoCaching
     }
 
@@ -407 +413 @@
         $sql  = "SELECT a.status, count(a.status) as 'count'";
         $sql .= " FROM {$wpdb->actionscheduler_actions} a";
-        $sql .= " GROUP BY a.status";
+        $sql .= ' GROUP BY a.status';
 
         $actions_count_by_status = array();
         $action_stati_and_labels = $this->get_status_labels();
 
-        foreach ( $wpdb->get_results( $sql ) as $action_data ) {
-            // Ignore any actions with invalid status
+        foreach ( $wpdb->get_results( $sql ) as $action_data ) { // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared
+            // Ignore any actions with invalid status.
             if ( array_key_exists( $action_data->status, $action_stati_and_labels ) ) {
                 $actions_count_by_status[ $action_data->status ] = $action_data->count;
@@ -428 +434 @@
      *
      * @return void
+     * @throws \InvalidArgumentException If the action update failed.
      */
     public function cancel_action( $action_id ) {
@@ -435 +442 @@
         $updated = $wpdb->update(
             $wpdb->actionscheduler_actions,
-            [ 'status' => self::STATUS_CANCELED ],
-            [ 'action_id' => $action_id ],
-            [ '%s' ],
-            [ '%d' ]
+            array( 'status' => self::STATUS_CANCELED ),
+            array( 'action_id' => $action_id ),
+            array( '%s' ),
+            array( '%d' )
         );
         if ( empty( $updated ) ) {
@@ -457 +464 @@
      */
     public function cancel_actions_by_hook( $hook ) {
-        $this->bulk_cancel_actions( [ 'hook' => $hook ] );
+        $this->bulk_cancel_actions( array( 'hook' => $hook ) );
     }
 
@@ -468 +475 @@
      */
     public function cancel_actions_by_group( $group ) {
-        $this->bulk_cancel_actions( [ 'group' => $group ] );
+        $this->bulk_cancel_actions( array( 'group' => $group ) );
     }
 
@@ -487 +494 @@
 
         // Don't cancel actions that are already canceled.
-        if ( isset( $query_args['status'] ) && $query_args['status'] == self::STATUS_CANCELED ) {
+        if ( isset( $query_args['status'] ) && self::STATUS_CANCELED === $query_args['status'] ) {
             return;
         }
@@ -494 +501 @@
         $query_args = wp_parse_args(
             $query_args,
-            [
+            array(
                 'per_page' => 1000,
                 'status'   => self::STATUS_PENDING,
                 'orderby'  => 'action_id',
-            ]
+            )
         );
 
@@ -513 +520 @@
 
             $wpdb->query(
-                $wpdb->prepare( // wpcs: PreparedSQLPlaceholders replacement count ok.
-                    "UPDATE {$wpdb->actionscheduler_actions} SET status = %s WHERE action_id IN {$query_in}",
+                $wpdb->prepare(
+                    "UPDATE {$wpdb->actionscheduler_actions} SET status = %s WHERE action_id IN {$query_in}", // phpcs:ignore WordPress.DB.PreparedSQL.InterpolatedNotPrepared
                     $parameters
                 )
@@ -527 +534 @@
      *
      * @param int $action_id Action ID.
+     * @throws \InvalidArgumentException If the action deletion failed.
      */
     public function delete_action( $action_id ) {
         /** @var \wpdb $wpdb */
         global $wpdb;
-        $deleted = $wpdb->delete( $wpdb->actionscheduler_actions, [ 'action_id' => $action_id ], [ '%d' ] );
+        $deleted = $wpdb->delete( $wpdb->actionscheduler_actions, array( 'action_id' => $action_id ), array( '%d' ) );
         if ( empty( $deleted ) ) {
-            throw new \InvalidArgumentException( sprintf( __( 'Unidentified action %s', 'action-scheduler' ), $action_id ) );
+            throw new \InvalidArgumentException( sprintf( __( 'Unidentified action %s', 'action-scheduler' ), $action_id ) ); //phpcs:ignore WordPress.WP.I18n.MissingTranslatorsComment
         }
         do_action( 'action_scheduler_deleted_action', $action_id );
@@ -543 +551 @@
      * @param string $action_id Action ID.
      *
-     * @throws \InvalidArgumentException
      * @return \DateTime The local date the action is scheduled to run, or the date that it ran.
      */
@@ -557 +564 @@
      * @param int $action_id Action ID.
      *
-     * @throws \InvalidArgumentException
+     * @throws \InvalidArgumentException If action cannot be identified.
      * @return \DateTime The GMT date the action is scheduled to run, or the date that it ran.
      */
@@ -565 +572 @@
         $record = $wpdb->get_row( $wpdb->prepare( "SELECT * FROM {$wpdb->actionscheduler_actions} WHERE action_id=%d", $action_id ) );
         if ( empty( $record ) ) {
-            throw new \InvalidArgumentException( sprintf( __( 'Unidentified action %s', 'action-scheduler' ), $action_id ) );
-        }
-        if ( $record->status == self::STATUS_PENDING ) {
+            throw new \InvalidArgumentException( sprintf( __( 'Unidentified action %s', 'action-scheduler' ), $action_id ) ); //phpcs:ignore WordPress.WP.I18n.MissingTranslatorsComment
+        }
+        if ( self::STATUS_PENDING === $record->status ) {
             return as_get_datetime_object( $record->scheduled_date_gmt );
         } else {
@@ -579 +586 @@
      * @param int       $max_actions Maximum number of action to include in claim.
      * @param \DateTime $before_date Jobs must be schedule before this date. Defaults to now.
+     * @param array     $hooks Hooks to filter for.
+     * @param string    $group Group to filter for.
      *
      * @return ActionScheduler_ActionClaim
@@ -587 +596 @@
         $this->claim_before_date = $before_date;
         $this->claim_actions( $claim_id, $max_actions, $before_date, $hooks, $group );
-        $action_ids = $this->find_actions_by_claim_id( $claim_id );
+        $action_ids              = $this->find_actions_by_claim_id( $claim_id );
         $this->claim_before_date = null;
 
@@ -602 +611 @@
         global $wpdb;
         $now = as_get_datetime_object();
-        $wpdb->insert( $wpdb->actionscheduler_claims, [ 'date_created_gmt' => $now->format( 'Y-m-d H:i:s' ) ] );
+        $wpdb->insert( $wpdb->actionscheduler_claims, array( 'date_created_gmt' => $now->format( 'Y-m-d H:i:s' ) ) );
 
         return $wpdb->insert_id;
@@ -613 +622 @@
      * @param int       $limit Number of action to include in claim.
      * @param \DateTime $before_date Should use UTC timezone.
+     * @param array     $hooks Hooks to filter for.
+     * @param string    $group Group to filter for.
      *
      * @return int The number of actions that were claimed.
-     * @throws \RuntimeException
+     * @throws \InvalidArgumentException Throws InvalidArgumentException if group doesn't exist.
+     * @throws \RuntimeException Throws RuntimeException if unable to claim action.
      */
     protected function claim_actions( $claim_id, $limit, \DateTime $before_date = null, $hooks = array(), $group = '' ) {
@@ -624 +636 @@
         $date = is_null( $before_date ) ? $now : clone $before_date;
 
-        // can't use $wpdb->update() because of the <= condition
+        // can't use $wpdb->update() because of the <= condition.
         $update = "UPDATE {$wpdb->actionscheduler_actions} SET claim_id=%d, last_attempt_gmt=%s, last_attempt_local=%s";
         $params = array(
@@ -632 +644 @@
         );
 
-        $where    = "WHERE claim_id = 0 AND scheduled_date_gmt <= %s AND status=%s";
+        $where    = 'WHERE claim_id = 0 AND scheduled_date_gmt <= %s AND status=%s';
         $params[] = $date->format( 'Y-m-d H:i:s' );
         $params[] = self::STATUS_PENDING;
@@ -646 +658 @@
             $group_id = $this->get_group_id( $group, false );
 
-            // throw exception if no matching group found, this matches ActionScheduler_wpPostStore's behaviour
+            // throw exception if no matching group found, this matches ActionScheduler_wpPostStore's behaviour.
             if ( empty( $group_id ) ) {
                 /* translators: %s: group name */
@@ -656 +668 @@
         }
 
-        $order    = "ORDER BY attempts ASC, scheduled_date_gmt ASC, action_id ASC LIMIT %d";
+        /**
+         * Sets the order-by clause used in the action claim query.
+         *
+         * @since x.x.x
+         *
+         * @param string $order_by_sql
+         */
+        $order    = apply_filters( 'action_scheduler_claim_actions_order_by', 'ORDER BY attempts ASC, scheduled_date_gmt ASC, action_id ASC' );
         $params[] = $limit;
 
-        $sql = $wpdb->prepare( "{$update} {$where} {$order}", $params );
-
-        $rows_affected = $wpdb->query( $sql );
-        if ( $rows_affected === false ) {
+        $sql           = $wpdb->prepare( "{$update} {$where} {$order} LIMIT %d", $params ); // phpcs:ignore WordPress.DB.PreparedSQL.InterpolatedNotPrepared, WordPress.DB.PreparedSQLPlaceholders
+        $rows_affected = $wpdb->query( $sql ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared, WordPress.DB.DirectDatabaseQuery.DirectQuery, WordPress.DB.DirectDatabaseQuery.NoCaching
+        if ( false === $rows_affected ) {
             throw new \RuntimeException( __( 'Unable to claim actions. Database error.', 'action-scheduler' ) );
         }
@@ -678 +696 @@
 
         $sql = "SELECT COUNT(DISTINCT claim_id) FROM {$wpdb->actionscheduler_actions} WHERE claim_id != 0 AND status IN ( %s, %s)";
-        $sql = $wpdb->prepare( $sql, [ self::STATUS_PENDING, self::STATUS_RUNNING ] );
-
-        return (int) $wpdb->get_var( $sql );
+        $sql = $wpdb->prepare( $sql, array( self::STATUS_PENDING, self::STATUS_RUNNING ) ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared
+
+        return (int) $wpdb->get_var( $sql ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared
     }
 
@@ -694 +712 @@
 
         $sql = "SELECT claim_id FROM {$wpdb->actionscheduler_actions} WHERE action_id=%d";
-        $sql = $wpdb->prepare( $sql, $action_id );
-
-        return (int) $wpdb->get_var( $sql );
+        $sql = $wpdb->prepare( $sql, $action_id ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared
+
+        return (int) $wpdb->get_var( $sql ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared
     }
 
@@ -702 +720 @@
      * Retrieve the action IDs of action in a claim.
      *
+     * @param  int $claim_id Claim ID.
      * @return int[]
      */
@@ -719 +738 @@
         // Verify that the scheduled date for each action is within the expected bounds (in some unusual
         // cases, we cannot depend on MySQL to honor all of the WHERE conditions we specify).
-        foreach ( $wpdb->get_results( $sql ) as $claimed_action ) {
+        foreach ( $wpdb->get_results( $sql ) as $claimed_action ) { // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared
             if ( $claimed_action->scheduled_date_gmt <= $cut_off ) {
                 $action_ids[] = absint( $claimed_action->action_id );
@@ -736 +755 @@
         /** @var \wpdb $wpdb */
         global $wpdb;
-        $wpdb->update( $wpdb->actionscheduler_actions, [ 'claim_id' => 0 ], [ 'claim_id' => $claim->get_id() ], [ '%d' ], [ '%d' ] );
-        $wpdb->delete( $wpdb->actionscheduler_claims, [ 'claim_id' => $claim->get_id() ], [ '%d' ] );
+        $wpdb->update( $wpdb->actionscheduler_actions, array( 'claim_id' => 0 ), array( 'claim_id' => $claim->get_id() ), array( '%d' ), array( '%d' ) );
+        $wpdb->delete( $wpdb->actionscheduler_claims, array( 'claim_id' => $claim->get_id() ), array( '%d' ) );
     }
 
@@ -752 +771 @@
         $wpdb->update(
             $wpdb->actionscheduler_actions,
-            [ 'claim_id' => 0 ],
-            [ 'action_id' => $action_id ],
-            [ '%s' ],
-            [ '%d' ]
+            array( 'claim_id' => 0 ),
+            array( 'action_id' => $action_id ),
+            array( '%s' ),
+            array( '%d' )
         );
     }
@@ -763 +782 @@
      *
      * @param int $action_id Action ID.
+     * @throws \InvalidArgumentException Throw an exception if action was not updated.
      */
     public function mark_failure( $action_id ) {
@@ -769 +789 @@
         $updated = $wpdb->update(
             $wpdb->actionscheduler_actions,
-            [ 'status' => self::STATUS_FAILED ],
-            [ 'action_id' => $action_id ],
-            [ '%s' ],
-            [ '%d' ]
+            array( 'status' => self::STATUS_FAILED ),
+            array( 'action_id' => $action_id ),
+            array( '%s' ),
+            array( '%d' )
         );
         if ( empty( $updated ) ) {
-            throw new \InvalidArgumentException( sprintf( __( 'Unidentified action %s', 'action-scheduler' ), $action_id ) );
+            throw new \InvalidArgumentException( sprintf( __( 'Unidentified action %s', 'action-scheduler' ), $action_id ) ); //phpcs:ignore WordPress.WP.I18n.MissingTranslatorsComment
         }
     }
@@ -791 +811 @@
 
         $sql = "UPDATE {$wpdb->actionscheduler_actions} SET attempts = attempts+1, status=%s, last_attempt_gmt = %s, last_attempt_local = %s WHERE action_id = %d";
-        $sql = $wpdb->prepare( $sql, self::STATUS_RUNNING, current_time( 'mysql', true ), current_time( 'mysql' ), $action_id );
-        $wpdb->query( $sql );
+        $sql = $wpdb->prepare( $sql, self::STATUS_RUNNING, current_time( 'mysql', true ), current_time( 'mysql' ), $action_id ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared
+        $wpdb->query( $sql ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared
     }
 
@@ -801 +821 @@
      *
      * @return void
+     * @throws \InvalidArgumentException Throw an exception if action was not updated.
      */
     public function mark_complete( $action_id ) {
@@ -807 +828 @@
         $updated = $wpdb->update(
             $wpdb->actionscheduler_actions,
-            [
+            array(
                 'status'             => self::STATUS_COMPLETE,
                 'last_attempt_gmt'   => current_time( 'mysql', true ),
                 'last_attempt_local' => current_time( 'mysql' ),
-            ],
-            [ 'action_id' => $action_id ],
-            [ '%s' ],
-            [ '%d' ]
+            ),
+            array( 'action_id' => $action_id ),
+            array( '%s' ),
+            array( '%d' )
         );
         if ( empty( $updated ) ) {
-            throw new \InvalidArgumentException( sprintf( __( 'Unidentified action %s', 'action-scheduler' ), $action_id ) );
+            throw new \InvalidArgumentException( sprintf( __( 'Unidentified action %s', 'action-scheduler' ), $action_id ) ); //phpcs:ignore WordPress.WP.I18n.MissingTranslatorsComment
         }
     }
@@ -827 +848 @@
      *
      * @return string
+     * @throws \InvalidArgumentException Throw an exception if not status was found for action_id.
+     * @throws \RuntimeException Throw an exception if action status could not be retrieved.
      */
     public function get_status( $action_id ) {
@@ -832 +855 @@
         global $wpdb;
         $sql    = "SELECT status FROM {$wpdb->actionscheduler_actions} WHERE action_id=%d";
-        $sql    = $wpdb->prepare( $sql, $action_id );
-        $status = $wpdb->get_var( $sql );
-
-        if ( $status === null ) {
+        $sql    = $wpdb->prepare( $sql, $action_id ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared
+        $status = $wpdb->get_var( $sql ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared
+
+        if ( null === $status ) {
             throw new \InvalidArgumentException( __( 'Invalid action ID. No status found.', 'action-scheduler' ) );
         } elseif ( empty( $status ) ) {

action-scheduler/tags/3.4.0/classes/data-stores/ActionScheduler_wpPostStore.php

@@ -5 +5 @@
  */
 class ActionScheduler_wpPostStore extends ActionScheduler_Store {
-    const POST_TYPE = 'scheduled-action';
-    const GROUP_TAXONOMY = 'action-group';
+    const POST_TYPE         = 'scheduled-action';
+    const GROUP_TAXONOMY    = 'action-group';
     const SCHEDULE_META_KEY = '_action_manager_schedule';
-    const DEPENDENCIES_MET = 'as-post-store-dependencies-met';
+    const DEPENDENCIES_MET  = 'as-post-store-dependencies-met';
 
     /**
@@ -20 +20 @@
     private $claim_before_date = null;
 
-    /** @var DateTimeZone */
-    protected $local_timezone = NULL;
-
-    public function save_action( ActionScheduler_Action $action, DateTime $scheduled_date = NULL ){
+    /**
+     * Local Timezone.
+     *
+     * @var DateTimeZone
+     */
+    protected $local_timezone = null;
+
+    /**
+     * Save action.
+     *
+     * @param ActionScheduler_Action $action Scheduled Action.
+     * @param DateTime               $scheduled_date Scheduled Date.
+     *
+     * @throws RuntimeException Throws an exception if the action could not be saved.
+     * @return int
+     */
+    public function save_action( ActionScheduler_Action $action, DateTime $scheduled_date = null ) {
         try {
             $this->validate_action( $action );
             $post_array = $this->create_post_array( $action, $scheduled_date );
-            $post_id = $this->save_post_array( $post_array );
+            $post_id    = $this->save_post_array( $post_array );
             $this->save_post_schedule( $post_id, $action->get_schedule() );
             $this->save_action_group( $post_id, $action->get_group() );
@@ -33 +46 @@
             return $post_id;
         } catch ( Exception $e ) {
+            /* translators: %s: action error message */
             throw new RuntimeException( sprintf( __( 'Error saving action: %s', 'action-scheduler' ), $e->getMessage() ), 0 );
         }
     }
 
-    protected function create_post_array( ActionScheduler_Action $action, DateTime $scheduled_date = NULL ) {
+    /**
+     * Create post array.
+     *
+     * @param ActionScheduler_Action $action Scheduled Action.
+     * @param DateTime               $scheduled_date Scheduled Date.
+     *
+     * @return array Returns an array of post data.
+     */
+    protected function create_post_array( ActionScheduler_Action $action, DateTime $scheduled_date = null ) {
         $post = array(
-            'post_type' => self::POST_TYPE,
-            'post_title' => $action->get_hook(),
-            'post_content' => json_encode($action->get_args()),
-            'post_status' => ( $action->is_finished() ? 'publish' : 'pending' ),
+            'post_type'     => self::POST_TYPE,
+            'post_title'    => $action->get_hook(),
+            'post_content'  => wp_json_encode( $action->get_args() ),
+            'post_status'   => ( $action->is_finished() ? 'publish' : 'pending' ),
             'post_date_gmt' => $this->get_scheduled_date_string( $action, $scheduled_date ),
             'post_date'     => $this->get_scheduled_date_string_local( $action, $scheduled_date ),
@@ -49 +71 @@
     }
 
+    /**
+     * Save post array.
+     *
+     * @param array $post_array Post array.
+     * @return int Returns the post ID.
+     * @throws RuntimeException Throws an exception if the action could not be saved.
+     */
     protected function save_post_array( $post_array ) {
         add_filter( 'wp_insert_post_data', array( $this, 'filter_insert_post_data' ), 10, 1 );
@@ -60 +89 @@
         }
 
-        $post_id = wp_insert_post($post_array);
+        $post_id = wp_insert_post( $post_array );
 
         if ( $has_kses ) {
@@ -69 +98 @@
         remove_filter( 'pre_wp_unique_post_slug', array( $this, 'set_unique_post_slug' ), 10 );
 
-        if ( is_wp_error($post_id) || empty($post_id) ) {
+        if ( is_wp_error( $post_id ) || empty( $post_id ) ) {
             throw new RuntimeException( __( 'Unable to save action.', 'action-scheduler' ) );
         }
@@ -75 +104 @@
     }
 
+    /**
+     * Filter insert post data.
+     *
+     * @param array $postdata Post data to filter.
+     *
+     * @return array
+     */
     public function filter_insert_post_data( $postdata ) {
-        if ( $postdata['post_type'] == self::POST_TYPE ) {
+        if ( self::POST_TYPE === $postdata['post_type'] ) {
             $postdata['post_author'] = 0;
-            if ( $postdata['post_status'] == 'future' ) {
+            if ( 'future' === $postdata['post_status'] ) {
                 $postdata['post_status'] = 'publish';
             }
@@ -114 +150 @@
      */
     public function set_unique_post_slug( $override_slug, $slug, $post_ID, $post_status, $post_type ) {
-        if ( self::POST_TYPE == $post_type ) {
+        if ( self::POST_TYPE === $post_type ) {
             $override_slug = uniqid( self::POST_TYPE . '-', true ) . '-' . wp_generate_password( 32, false );
         }
@@ -120 +156 @@
     }
 
+    /**
+     * Save post schedule.
+     *
+     * @param int    $post_id  Post ID of the scheduled action.
+     * @param string $schedule Schedule to save.
+     *
+     * @return void
+     */
     protected function save_post_schedule( $post_id, $schedule ) {
         update_post_meta( $post_id, self::SCHEDULE_META_KEY, $schedule );
     }
 
+    /**
+     * Save action group.
+     *
+     * @param int    $post_id Post ID.
+     * @param string $group   Group to save.
+     * @return void
+     */
     protected function save_action_group( $post_id, $group ) {
-        if ( empty($group) ) {
-            wp_set_object_terms( $post_id, array(), self::GROUP_TAXONOMY, FALSE );
+        if ( empty( $group ) ) {
+            wp_set_object_terms( $post_id, array(), self::GROUP_TAXONOMY, false );
         } else {
-            wp_set_object_terms( $post_id, array($group), self::GROUP_TAXONOMY, FALSE );
-        }
-    }
-
+            wp_set_object_terms( $post_id, array( $group ), self::GROUP_TAXONOMY, false );
+        }
+    }
+
+    /**
+     * Fetch actions.
+     *
+     * @param int $action_id Action ID.
+     * @return object
+     */
     public function fetch_action( $action_id ) {
         $post = $this->get_post( $action_id );
-        if ( empty($post) || $post->post_type != self::POST_TYPE ) {
+        if ( empty( $post ) || self::POST_TYPE !== $post->post_type ) {
             return $this->get_null_action();
         }
@@ -148 +205 @@
     }
 
+    /**
+     * Get post.
+     *
+     * @param string $action_id - Action ID.
+     * @return WP_Post|null
+     */
     protected function get_post( $action_id ) {
-        if ( empty($action_id) ) {
-            return NULL;
-        }
-        return get_post($action_id);
-    }
-
+        if ( empty( $action_id ) ) {
+            return null;
+        }
+        return get_post( $action_id );
+    }
+
+    /**
+     * Get NULL action.
+     *
+     * @return ActionScheduler_NullAction
+     */
     protected function get_null_action() {
         return new ActionScheduler_NullAction();
     }
 
+    /**
+     * Make action from post.
+     *
+     * @param WP_Post $post Post object.
+     * @return WP_Post
+     */
     protected function make_action_from_post( $post ) {
         $hook = $post->post_title;
@@ -168 +242 @@
         $this->validate_schedule( $schedule, $post->ID );
 
-        $group = wp_get_object_terms( $post->ID, self::GROUP_TAXONOMY, array('fields' => 'names') );
-        $group = empty( $group ) ? '' : reset($group);
+        $group = wp_get_object_terms( $post->ID, self::GROUP_TAXONOMY, array( 'fields' => 'names' ) );
+        $group = empty( $group ) ? '' : reset( $group );
 
         return ActionScheduler::factory()->get_stored_action( $this->get_action_status_by_post_status( $post->post_status ), $hook, $args, $schedule, $group );
@@ -175 +249 @@
 
     /**
-     * @param string $post_status
-     *
-     * @throws InvalidArgumentException if $post_status not in known status fields returned by $this->get_status_labels()
+     * Get action status by post status.
+     *
+     * @param string $post_status Post status.
+     *
+     * @throws InvalidArgumentException Throw InvalidArgumentException if $post_status not in known status fields returned by $this->get_status_labels().
      * @return string
      */
@@ -183 +259 @@
 
         switch ( $post_status ) {
-            case 'publish' :
+            case 'publish':
                 $action_status = self::STATUS_COMPLETE;
                 break;
-            case 'trash' :
+            case 'trash':
                 $action_status = self::STATUS_CANCELED;
                 break;
-            default :
+            default:
                 if ( ! array_key_exists( $post_status, $this->get_status_labels() ) ) {
                     throw new InvalidArgumentException( sprintf( 'Invalid post status: "%s". No matching action status available.', $post_status ) );
@@ -201 +277 @@
 
     /**
-     * @param string $action_status
-     * @throws InvalidArgumentException if $post_status not in known status fields returned by $this->get_status_labels()
+     * Get post status by action status.
+     *
+     * @param string $action_status Action status.
+     *
+     * @throws InvalidArgumentException Throws InvalidArgumentException if $post_status not in known status fields returned by $this->get_status_labels().
      * @return string
      */
@@ -208 +287 @@
 
         switch ( $action_status ) {
-            case self::STATUS_COMPLETE :
+            case self::STATUS_COMPLETE:
                 $post_status = 'publish';
                 break;
-            case self::STATUS_CANCELED :
+            case self::STATUS_CANCELED:
                 $post_status = 'trash';
                 break;
-            default :
+            default:
                 if ( ! array_key_exists( $action_status, $this->get_status_labels() ) ) {
                     throw new InvalidArgumentException( sprintf( 'Invalid action status: "%s".', $action_status ) );
@@ -228 +307 @@
      * Returns the SQL statement to query (or count) actions.
      *
-     * @param array $query Filtering options
-     * @param string $select_or_count  Whether the SQL should select and return the IDs or just the row count
-     * @throws InvalidArgumentException if $select_or_count not count or select
+     * @param array  $query            - Filtering options.
+     * @param string $select_or_count  - Whether the SQL should select and return the IDs or just the row count.
+     *
+     * @throws InvalidArgumentException - Throw InvalidArgumentException if $select_or_count not count or select.
      * @return string SQL statement. The returned SQL is already properly escaped.
      */
     protected function get_query_actions_sql( array $query, $select_or_count = 'select' ) {
 
-        if ( ! in_array( $select_or_count, array( 'select', 'count' ) ) ) {
+        if ( ! in_array( $select_or_count, array( 'select', 'count' ), true ) ) {
             throw new InvalidArgumentException( __( 'Invalid schedule. Cannot save action.', 'action-scheduler' ) );
         }
 
-        $query = wp_parse_args( $query, array(
-            'hook' => '',
-            'args' => NULL,
-            'date' => NULL,
-            'date_compare' => '<=',
-            'modified' => NULL,
-            'modified_compare' => '<=',
-            'group' => '',
-            'status' => '',
-            'claimed' => NULL,
-            'per_page' => 5,
-            'offset' => 0,
-            'orderby' => 'date',
-            'order' => 'ASC',
-            'search' => '',
-        ) );
-
-        /** @var wpdb $wpdb */
+        $query = wp_parse_args(
+            $query,
+            array(
+                'hook'             => '',
+                'args'             => null,
+                'date'             => null,
+                'date_compare'     => '<=',
+                'modified'         => null,
+                'modified_compare' => '<=',
+                'group'            => '',
+                'status'           => '',
+                'claimed'          => null,
+                'per_page'         => 5,
+                'offset'           => 0,
+                'orderby'          => 'date',
+                'order'            => 'ASC',
+                'search'           => '',
+            )
+        );
+
+        /**
+         * Global wpdb object.
+         *
+         * @var wpdb $wpdb
+         */
         global $wpdb;
-        $sql  = ( 'count' === $select_or_count ) ? 'SELECT count(p.ID)' : 'SELECT p.ID ';
-        $sql .= "FROM {$wpdb->posts} p";
+        $sql        = ( 'count' === $select_or_count ) ? 'SELECT count(p.ID)' : 'SELECT p.ID ';
+        $sql       .= "FROM {$wpdb->posts} p";
         $sql_params = array();
         if ( empty( $query['group'] ) && 'group' === $query['orderby'] ) {
@@ -266 +353 @@
             $sql .= " LEFT JOIN {$wpdb->terms} t ON tt.term_id=t.term_id";
         } elseif ( ! empty( $query['group'] ) ) {
-            $sql .= " INNER JOIN {$wpdb->term_relationships} tr ON tr.object_id=p.ID";
-            $sql .= " INNER JOIN {$wpdb->term_taxonomy} tt ON tr.term_taxonomy_id=tt.term_taxonomy_id";
-            $sql .= " INNER JOIN {$wpdb->terms} t ON tt.term_id=t.term_id";
-            $sql .= " AND t.slug=%s";
+            $sql         .= " INNER JOIN {$wpdb->term_relationships} tr ON tr.object_id=p.ID";
+            $sql         .= " INNER JOIN {$wpdb->term_taxonomy} tt ON tr.term_taxonomy_id=tt.term_taxonomy_id";
+            $sql         .= " INNER JOIN {$wpdb->terms} t ON tt.term_id=t.term_id";
+            $sql         .= ' AND t.slug=%s';
             $sql_params[] = $query['group'];
         }
-        $sql .= " WHERE post_type=%s";
+        $sql         .= ' WHERE post_type=%s';
         $sql_params[] = self::POST_TYPE;
         if ( $query['hook'] ) {
-            $sql .= " AND p.post_title=%s";
+            $sql         .= ' AND p.post_title=%s';
             $sql_params[] = $query['hook'];
         }
-        if ( !is_null($query['args']) ) {
-            $sql .= " AND p.post_content=%s";
-            $sql_params[] = json_encode($query['args']);
+        if ( ! is_null( $query['args'] ) ) {
+            $sql         .= ' AND p.post_content=%s';
+            $sql_params[] = wp_json_encode( $query['args'] );
         }
 
@@ -292 +379 @@
         if ( $query['date'] instanceof DateTime ) {
             $date = clone $query['date'];
-            $date->setTimezone( new DateTimeZone('UTC') );
-            $date_string = $date->format('Y-m-d H:i:s');
-            $comparator = $this->validate_sql_comparator($query['date_compare']);
-            $sql .= " AND p.post_date_gmt $comparator %s";
+            $date->setTimezone( new DateTimeZone( 'UTC' ) );
+            $date_string  = $date->format( 'Y-m-d H:i:s' );
+            $comparator   = $this->validate_sql_comparator( $query['date_compare'] );
+            $sql         .= " AND p.post_date_gmt $comparator %s";
             $sql_params[] = $date_string;
         }
@@ -301 +388 @@
         if ( $query['modified'] instanceof DateTime ) {
             $modified = clone $query['modified'];
-            $modified->setTimezone( new DateTimeZone('UTC') );
-            $date_string = $modified->format('Y-m-d H:i:s');
-            $comparator = $this->validate_sql_comparator($query['modified_compare']);
-            $sql .= " AND p.post_modified_gmt $comparator %s";
+            $modified->setTimezone( new DateTimeZone( 'UTC' ) );
+            $date_string  = $modified->format( 'Y-m-d H:i:s' );
+            $comparator   = $this->validate_sql_comparator( $query['modified_compare'] );
+            $sql         .= " AND p.post_modified_gmt $comparator %s";
             $sql_params[] = $date_string;
         }
 
-        if ( $query['claimed'] === TRUE ) {
+        if ( true === $query['claimed'] ) {
             $sql .= " AND p.post_password != ''";
-        } elseif ( $query['claimed'] === FALSE ) {
+        } elseif ( false === $query['claimed'] ) {
             $sql .= " AND p.post_password = ''";
-        } elseif ( !is_null($query['claimed']) ) {
-            $sql .= " AND p.post_password = %s";
+        } elseif ( ! is_null( $query['claimed'] ) ) {
+            $sql         .= ' AND p.post_password = %s';
             $sql_params[] = $query['claimed'];
         }
 
         if ( ! empty( $query['search'] ) ) {
-            $sql .= " AND (p.post_title LIKE %s OR p.post_content LIKE %s OR p.post_password LIKE %s)";
-            for( $i = 0; $i < 3; $i++ ) {
+            $sql .= ' AND (p.post_title LIKE %s OR p.post_content LIKE %s OR p.post_password LIKE %s)';
+            for ( $i = 0; $i < 3; $i++ ) {
                 $sql_params[] = sprintf( '%%%s%%', $query['search'] );
             }
@@ -354 +441 @@
             $sql .= " ORDER BY $orderby $order";
             if ( $query['per_page'] > 0 ) {
-                $sql .= " LIMIT %d, %d";
+                $sql         .= ' LIMIT %d, %d';
                 $sql_params[] = $query['offset'];
                 $sql_params[] = $query['per_page'];
@@ -360 +447 @@
         }
 
-        return $wpdb->prepare( $sql, $sql_params );
+        return $wpdb->prepare( $sql, $sql_params ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared
     }
 
@@ -376 +463 @@
      */
     public function query_actions( $query = array(), $query_type = 'select' ) {
-        /** @var wpdb $wpdb */
+        /**
+         * Global $wpdb object.
+         *
+         * @var wpdb $wpdb
+         */
         global $wpdb;
 
         $sql = $this->get_query_actions_sql( $query, $query_type );
 
-        return ( 'count' === $query_type ) ? $wpdb->get_var( $sql ) : $wpdb->get_col( $sql );
+        return ( 'count' === $query_type ) ? $wpdb->get_var( $sql ) : $wpdb->get_col( $sql ); // phpcs:ignore WordPress.DB.DirectDatabaseQuery.DirectQuery,WordPress.DB.DirectDatabaseQuery.NoCaching,WordPress.DB.PreparedSQL.NotPrepared
     }
 
@@ -400 +491 @@
                 $action_status_name = $this->get_action_status_by_post_status( $post_status_name );
             } catch ( Exception $e ) {
-                // Ignore any post statuses that aren't for actions
+                // Ignore any post statuses that aren't for actions.
                 continue;
             }
@@ -412 +503 @@
 
     /**
-     * @param string $action_id
-     *
-     * @throws InvalidArgumentException
+     * Cancel action.
+     *
+     * @param int $action_id Action ID.
+     *
+     * @throws InvalidArgumentException If $action_id is not identified.
      */
     public function cancel_action( $action_id ) {
         $post = get_post( $action_id );
-        if ( empty( $post ) || ( $post->post_type != self::POST_TYPE ) ) {
+        if ( empty( $post ) || ( self::POST_TYPE !== $post->post_type ) ) {
+            /* translators: %s is the action ID */
             throw new InvalidArgumentException( sprintf( __( 'Unidentified action %s', 'action-scheduler' ), $action_id ) );
         }
@@ -427 +521 @@
     }
 
+    /**
+     * Delete action.
+     *
+     * @param int $action_id Action ID.
+     * @return void
+     * @throws InvalidArgumentException If action is not identified.
+     */
     public function delete_action( $action_id ) {
         $post = get_post( $action_id );
-        if ( empty( $post ) || ( $post->post_type != self::POST_TYPE ) ) {
+        if ( empty( $post ) || ( self::POST_TYPE !== $post->post_type ) ) {
+            /* translators: %s is the action ID */
             throw new InvalidArgumentException( sprintf( __( 'Unidentified action %s', 'action-scheduler' ), $action_id ) );
         }
         do_action( 'action_scheduler_deleted_action', $action_id );
 
-        wp_delete_post( $action_id, TRUE );
-    }
-
-    /**
-     * @param string $action_id
-     *
-     * @throws InvalidArgumentException
+        wp_delete_post( $action_id, true );
+    }
+
+    /**
+     * Get date for claim id.
+     *
+     * @param int $action_id Action ID.
      * @return ActionScheduler_DateTime The date the action is schedule to run, or the date that it ran.
      */
@@ -449 +551 @@
 
     /**
-     * @param string $action_id
-     *
-     * @throws InvalidArgumentException
+     * Get Date GMT.
+     *
+     * @param int $action_id Action ID.
+     *
+     * @throws InvalidArgumentException If $action_id is not identified.
      * @return ActionScheduler_DateTime The date the action is schedule to run, or the date that it ran.
      */
     public function get_date_gmt( $action_id ) {
         $post = get_post( $action_id );
-        if ( empty( $post ) || ( $post->post_type != self::POST_TYPE ) ) {
+        if ( empty( $post ) || ( self::POST_TYPE !== $post->post_type ) ) {
+            /* translators: %s is the action ID */
             throw new InvalidArgumentException( sprintf( __( 'Unidentified action %s', 'action-scheduler' ), $action_id ) );
         }
-        if ( $post->post_status == 'publish' ) {
+        if ( 'publish' === $post->post_status ) {
             return as_get_datetime_object( $post->post_modified_gmt );
         } else {
@@ -467 +572 @@
 
     /**
-     * @param int      $max_actions
+     * Stake claim.
+     *
+     * @param int      $max_actions Maximum number of actions.
      * @param DateTime $before_date Jobs must be schedule before this date. Defaults to now.
      * @param array    $hooks       Claim only actions with a hook or hooks.
@@ -478 +585 @@
     public function stake_claim( $max_actions = 10, DateTime $before_date = null, $hooks = array(), $group = '' ) {
         $this->claim_before_date = $before_date;
-        $claim_id = $this->generate_claim_id();
+        $claim_id                = $this->generate_claim_id();
         $this->claim_actions( $claim_id, $max_actions, $before_date, $hooks, $group );
-        $action_ids = $this->find_actions_by_claim_id( $claim_id );
+        $action_ids              = $this->find_actions_by_claim_id( $claim_id );
         $this->claim_before_date = null;
 
@@ -487 +594 @@
 
     /**
+     * Get claim count.
+     *
      * @return int
      */
-    public function get_claim_count(){
+    public function get_claim_count() {
         global $wpdb;
 
-        $sql = "SELECT COUNT(DISTINCT post_password) FROM {$wpdb->posts} WHERE post_password != '' AND post_type = %s AND post_status IN ('in-progress','pending')";
-        $sql = $wpdb->prepare( $sql, array( self::POST_TYPE ) );
-
-        return $wpdb->get_var( $sql );
-    }
-
+        // phpcs:ignore WordPress.DB.DirectDatabaseQuery.DirectQuery,WordPress.DB.DirectDatabaseQuery.NoCaching
+        return $wpdb->get_var(
+            $wpdb->prepare(
+                "SELECT COUNT(DISTINCT post_password) FROM {$wpdb->posts} WHERE post_password != '' AND post_type = %s AND post_status IN ('in-progress','pending')",
+                array( self::POST_TYPE )
+            )
+        );
+    }
+
+    /**
+     * Generate claim id.
+     *
+     * @return string
+     */
     protected function generate_claim_id() {
-        $claim_id = md5(microtime(true) . rand(0,1000));
-        return substr($claim_id, 0, 20); // to fit in db field with 20 char limit
-    }
-
-    /**
-     * @param string   $claim_id
-     * @param int      $limit
+        $claim_id = md5( microtime( true ) . wp_rand( 0, 1000 ) );
+        return substr( $claim_id, 0, 20 ); // to fit in db field with 20 char limit.
+    }
+
+    /**
+     * Claim actions.
+     *
+     * @param string   $claim_id    Claim ID.
+     * @param int      $limit       Limit.
      * @param DateTime $before_date Should use UTC timezone.
      * @param array    $hooks       Claim only actions with a hook or hooks.
      * @param string   $group       Claim only actions in the given group.
      *
-     * @return int The number of actions that were claimed
-     * @throws RuntimeException When there is a database error.
-     * @throws InvalidArgumentException When the group is invalid.
+     * @return int The number of actions that were claimed.
+     * @throws RuntimeException  When there is a database error.
      */
     protected function claim_actions( $claim_id, $limit, DateTime $before_date = null, $hooks = array(), $group = '' ) {
@@ -525 +643 @@
         }
 
-        /** @var wpdb $wpdb */
+        /**
+         * Global wpdb object.
+         *
+         * @var wpdb $wpdb
+         */
         global $wpdb;
 
@@ -560 +682 @@
             $where .= ' AND ID IN (' . join( ',', $ids ) . ')';
         } else {
-            $where .= ' AND post_date_gmt <= %s';
+            $where   .= ' AND post_date_gmt <= %s';
             $params[] = $date->format( 'Y-m-d H:i:s' );
         }
@@ -569 +691 @@
 
         // Run the query and gather results.
-        $rows_affected = $wpdb->query( $wpdb->prepare( "{$update} {$where} {$order}", $params ) );
-        if ( $rows_affected === false ) {
+        $rows_affected = $wpdb->query( $wpdb->prepare( "{$update} {$where} {$order}", $params ) ); // phpcs:ignore // phpcs:ignore WordPress.DB.PreparedSQL.InterpolatedNotPrepared, WordPress.DB.PreparedSQLPlaceholders.UnfinishedPrepare
+
+        if ( false === $rows_affected ) {
             throw new RuntimeException( __( 'Unable to claim actions. Database error.', 'action-scheduler' ) );
         }
@@ -590 +713 @@
     protected function get_actions_by_group( $group, $limit, DateTime $date ) {
         // Ensure the group exists before continuing.
-        if ( ! term_exists( $group, self::GROUP_TAXONOMY )) {
+        if ( ! term_exists( $group, self::GROUP_TAXONOMY ) ) {
+            /* translators: %s is the group name */
             throw new InvalidArgumentException( sprintf( __( 'The group "%s" does not exist.', 'action-scheduler' ), $group ) );
         }
@@ -610 +734 @@
             ),
             'date_query'       => array(
-                'column' => 'post_date_gmt',
-                'before' => $date->format( 'Y-m-d H:i' ),
+                'column'    => 'post_date_gmt',
+                'before'    => $date->format( 'Y-m-d H:i' ),
                 'inclusive' => true,
             ),
-            'tax_query' => array(
+            'tax_query'        => array( // phpcs:ignore WordPress.DB.SlowDBQuery
                 array(
                     'taxonomy'         => self::GROUP_TAXONOMY,
@@ -628 +752 @@
 
     /**
-     * @param string $claim_id
+     * Find actions by claim ID.
+     *
+     * @param string $claim_id Claim ID.
      * @return array
      */
     public function find_actions_by_claim_id( $claim_id ) {
-        /** @var wpdb $wpdb */
+        /**
+         * Global wpdb object.
+         *
+         * @var wpdb $wpdb
+         */
         global $wpdb;
-
-        $sql = "SELECT ID, post_date_gmt FROM {$wpdb->posts} WHERE post_type = %s AND post_password = %s";
-        $sql = $wpdb->prepare( $sql, array( self::POST_TYPE, $claim_id ) );
 
         $action_ids  = array();
@@ -642 +769 @@
         $cut_off     = $before_date->format( 'Y-m-d H:i:s' );
 
+        // phpcs:ignore WordPress.DB.DirectDatabaseQuery.DirectQuery, WordPress.DB.DirectDatabaseQuery.NoCaching
+        $results = $wpdb->get_results(
+            $wpdb->prepare(
+                "SELECT ID, post_date_gmt FROM {$wpdb->posts} WHERE post_type = %s AND post_password = %s",
+                array(
+                    self::POST_TYPE,
+                    $claim_id,
+                )
+            )
+        );
+
         // Verify that the scheduled date for each action is within the expected bounds (in some unusual
         // cases, we cannot depend on MySQL to honor all of the WHERE conditions we specify).
-        foreach ( $wpdb->get_results( $sql ) as $claimed_action ) {
+        foreach ( $results as $claimed_action ) {
             if ( $claimed_action->post_date_gmt <= $cut_off ) {
                 $action_ids[] = absint( $claimed_action->ID );
@@ -653 +791 @@
     }
 
+    /**
+     * Release claim.
+     *
+     * @param ActionScheduler_ActionClaim $claim Claim object to release.
+     * @return void
+     * @throws RuntimeException When the claim is not unlocked.
+     */
     public function release_claim( ActionScheduler_ActionClaim $claim ) {
         $action_ids = $this->find_actions_by_claim_id( $claim->get_id() );
         if ( empty( $action_ids ) ) {
-            return; // nothing to do
+            return; // nothing to do.
         }
         $action_id_string = implode( ',', array_map( 'intval', $action_ids ) );
-        /** @var wpdb $wpdb */
+        /**
+         * Global wpdb object.
+         *
+         * @var wpdb $wpdb
+         */
         global $wpdb;
-        $sql = "UPDATE {$wpdb->posts} SET post_password = '' WHERE ID IN ($action_id_string) AND post_password = %s";
-        $sql = $wpdb->prepare( $sql, array( $claim->get_id() ) );
-        $result = $wpdb->query( $sql );
-        if ( $result === false ) {
+
+        // phpcs:ignore WordPress.DB.DirectDatabaseQuery.DirectQuery, WordPress.DB.DirectDatabaseQuery.NoCaching
+        $result = $wpdb->query(
+            $wpdb->prepare(
+                "UPDATE {$wpdb->posts} SET post_password = '' WHERE ID IN ($action_id_string) AND post_password = %s", //phpcs:ignore
+                array(
+                    $claim->get_id(),
+                )
+            )
+        );
+        if ( false === $result ) {
             /* translators: %s: claim ID */
             throw new RuntimeException( sprintf( __( 'Unable to unlock claim %s. Database error.', 'action-scheduler' ), $claim->get_id() ) );
@@ -671 +827 @@
 
     /**
-     * @param string $action_id
+     * Unclaim action.
+     *
+     * @param string $action_id Action ID.
+     * @throws RuntimeException When unable to unlock claim on action ID.
      */
     public function unclaim_action( $action_id ) {
-        /** @var wpdb $wpdb */
+        /**
+         * Global wpdb object.
+         *
+         * @var wpdb $wpdb
+         */
         global $wpdb;
-        $sql = "UPDATE {$wpdb->posts} SET post_password = '' WHERE ID = %d AND post_type = %s";
-        $sql = $wpdb->prepare( $sql, $action_id, self::POST_TYPE );
-        $result = $wpdb->query( $sql );
-        if ( $result === false ) {
+
+        //phpcs:ignore WordPress.DB.DirectDatabaseQuery.DirectQuery, WordPress.DB.DirectDatabaseQuery.NoCaching
+        $result = $wpdb->query(
+            $wpdb->prepare(
+                "UPDATE {$wpdb->posts} SET post_password = '' WHERE ID = %d AND post_type = %s",
+                $action_id,
+                self::POST_TYPE
+            )
+        );
+        if ( false === $result ) {
             /* translators: %s: action ID */
             throw new RuntimeException( sprintf( __( 'Unable to unlock claim on action %s. Database error.', 'action-scheduler' ), $action_id ) );
@@ -685 +854 @@
     }
 
+    /**
+     * Mark failure on action.
+     *
+     * @param int $action_id Action ID.
+     *
+     * @return void
+     * @throws RuntimeException When unable to mark failure on action ID.
+     */
     public function mark_failure( $action_id ) {
-        /** @var wpdb $wpdb */
+        /**
+         * Global wpdb object.
+         *
+         * @var wpdb $wpdb
+         */
         global $wpdb;
-        $sql = "UPDATE {$wpdb->posts} SET post_status = %s WHERE ID = %d AND post_type = %s";
-        $sql = $wpdb->prepare( $sql, self::STATUS_FAILED, $action_id, self::POST_TYPE );
-        $result = $wpdb->query( $sql );
-        if ( $result === false ) {
+
+        // phpcs:ignore WordPress.DB.DirectDatabaseQuery.DirectQuery, WordPress.DB.DirectDatabaseQuery.NoCaching
+        $result = $wpdb->query(
+            $wpdb->prepare( "UPDATE {$wpdb->posts} SET post_status = %s WHERE ID = %d AND post_type = %s", self::STATUS_FAILED, $action_id, self::POST_TYPE )
+        );
+        if ( false === $result ) {
             /* translators: %s: action ID */
             throw new RuntimeException( sprintf( __( 'Unable to mark failure on action %s. Database error.', 'action-scheduler' ), $action_id ) );
@@ -700 +883 @@
      * Return an action's claim ID, as stored in the post password column
      *
-     * @param string $action_id
+     * @param int $action_id Action ID.
      * @return mixed
      */
@@ -710 +893 @@
      * Return an action's status, as stored in the post status column
      *
-     * @param string $action_id
+     * @param int $action_id Action ID.
+     *
      * @return mixed
+     * @throws InvalidArgumentException When the action ID is invalid.
      */
     public function get_status( $action_id ) {
         $status = $this->get_post_column( $action_id, 'post_status' );
 
-        if ( $status === null ) {
+        if ( null === $status ) {
             throw new InvalidArgumentException( __( 'Invalid action ID. No status found.', 'action-scheduler' ) );
         }
@@ -723 +908 @@
     }
 
+    /**
+     * Get post column
+     *
+     * @param string $action_id Action ID.
+     * @param string $column_name Column Name.
+     *
+     * @return string|null
+     */
     private function get_post_column( $action_id, $column_name ) {
-        /** @var \wpdb $wpdb */
+        /**
+         * Global wpdb object.
+         *
+         * @var wpdb $wpdb
+         */
         global $wpdb;
-        return $wpdb->get_var( $wpdb->prepare( "SELECT {$column_name} FROM {$wpdb->posts} WHERE ID=%d AND post_type=%s", $action_id, self::POST_TYPE ) );
-    }
-
-    /**
-     * @param string $action_id
+
+        // phpcs:ignore WordPress.DB.DirectDatabaseQuery.DirectQuery, WordPress.DB.DirectDatabaseQuery.NoCaching
+        return $wpdb->get_var(
+            $wpdb->prepare(
+                "SELECT {$column_name} FROM {$wpdb->posts} WHERE ID=%d AND post_type=%s", // phpcs:ignore
+                $action_id,
+                self::POST_TYPE
+            )
+        );
+    }
+
+    /**
+     * Log Execution.
+     *
+     * @param string $action_id Action ID.
      */
     public function log_execution( $action_id ) {
-        /** @var wpdb $wpdb */
+        /**
+         * Global wpdb object.
+         *
+         * @var wpdb $wpdb
+         */
         global $wpdb;
 
-        $sql = "UPDATE {$wpdb->posts} SET menu_order = menu_order+1, post_status=%s, post_modified_gmt = %s, post_modified = %s WHERE ID = %d AND post_type = %s";
-        $sql = $wpdb->prepare( $sql, self::STATUS_RUNNING, current_time('mysql', true), current_time('mysql'), $action_id, self::POST_TYPE );
-        $wpdb->query($sql);
+        // phpcs:ignore WordPress.DB.DirectDatabaseQuery.DirectQuery, WordPress.DB.DirectDatabaseQuery.NoCaching
+        $wpdb->query(
+            $wpdb->prepare(
+                "UPDATE {$wpdb->posts} SET menu_order = menu_order+1, post_status=%s, post_modified_gmt = %s, post_modified = %s WHERE ID = %d AND post_type = %s",
+                self::STATUS_RUNNING,
+                current_time( 'mysql', true ),
+                current_time( 'mysql' ),
+                $action_id,
+                self::POST_TYPE
+            )
+        );
     }
 
@@ -744 +963 @@
      * Record that an action was completed.
      *
-     * @param int $action_id ID of the completed action.
-     * @throws InvalidArgumentException|RuntimeException
+     * @param string $action_id ID of the completed action.
+     *
+     * @throws InvalidArgumentException When the action ID is invalid.
+     * @throws RuntimeException         When there was an error executing the action.
      */
     public function mark_complete( $action_id ) {
         $post = get_post( $action_id );
-        if ( empty( $post ) || ( $post->post_type != self::POST_TYPE ) ) {
+        if ( empty( $post ) || ( self::POST_TYPE !== $post->post_type ) ) {
+            /* translators: %s is the action ID */
             throw new InvalidArgumentException( sprintf( __( 'Unidentified action %s', 'action-scheduler' ), $action_id ) );
         }
         add_filter( 'wp_insert_post_data', array( $this, 'filter_insert_post_data' ), 10, 1 );
         add_filter( 'pre_wp_unique_post_slug', array( $this, 'set_unique_post_slug' ), 10, 5 );
-        $result = wp_update_post(array(
-            'ID' => $action_id,
-            'post_status' => 'publish',
-        ), TRUE);
+        $result = wp_update_post(
+            array(
+                'ID'          => $action_id,
+                'post_status' => 'publish',
+            ),
+            true
+        );
         remove_filter( 'wp_insert_post_data', array( $this, 'filter_insert_post_data' ), 10 );
         remove_filter( 'pre_wp_unique_post_slug', array( $this, 'set_unique_post_slug' ), 10 );
@@ -774 +999 @@
             array(
                 'ID'          => $action_id,
-                'post_status' => 'migrated'
+                'post_status' => 'migrated',
             )
         );
@@ -782 +1007 @@
      * Determine whether the post store can be migrated.
      *
+     * @param [type] $setting - Setting value.
      * @return bool
      */
@@ -790 +1016 @@
         if ( empty( $dependencies_met ) ) {
             $maximum_args_length = apply_filters( 'action_scheduler_maximum_args_length', 191 );
-            $found_action        = $wpdb->get_var(
+            $found_action        = $wpdb->get_var( // phpcs:ignore WordPress.DB.DirectDatabaseQuery.DirectQuery, WordPress.DB.DirectDatabaseQuery.NoCaching
                 $wpdb->prepare(
                     "SELECT ID FROM {$wpdb->posts} WHERE post_type = %s AND CHAR_LENGTH(post_content) > %d LIMIT 1",
@@ -797 +1023 @@
                 )
             );
-            $dependencies_met = $found_action ? 'no' : 'yes';
+            $dependencies_met    = $found_action ? 'no' : 'yes';
             set_transient( self::DEPENDENCIES_MET, $dependencies_met, DAY_IN_SECONDS );
         }
 
-        return 'yes' == $dependencies_met ? $setting : false;
+        return 'yes' === $dependencies_met ? $setting : false;
     }
 
@@ -811 +1037 @@
      * developers of this impending requirement.
      *
-     * @param ActionScheduler_Action $action
+     * @param ActionScheduler_Action $action Action object.
      */
     protected function validate_action( ActionScheduler_Action $action ) {
@@ -817 +1043 @@
             parent::validate_action( $action );
         } catch ( Exception $e ) {
+            /* translators: %s is the error message */
             $message = sprintf( __( '%s Support for strings longer than this will be removed in a future version.', 'action-scheduler' ), $e->getMessage() );
-            _doing_it_wrong( 'ActionScheduler_Action::$args', $message, '2.1.0' );
-        }
-    }
-
-    /**
-     * @codeCoverageIgnore
+            _doing_it_wrong( 'ActionScheduler_Action::$args', esc_html( $message ), '2.1.0' );
+        }
+    }
+
+    /**
+     * (@codeCoverageIgnore)
      */
     public function init() {

action-scheduler/tags/3.4.0/classes/schema/ActionScheduler_StoreSchema.php

@@ -17 +17 @@
      * @var int Increment this value to trigger a schema update.
      */
-    protected $schema_version = 5;
+    protected $schema_version = 6;
 
     public function __construct() {
@@ -65 +65 @@
                         KEY group_id (group_id),
                         KEY last_attempt_gmt (last_attempt_gmt),
-                        KEY claim_id (claim_id),
                         KEY `claim_id_status_scheduled_date_gmt` (`claim_id`, `status`, `scheduled_date_gmt`)
                         ) $charset_collate";

action-scheduler/tags/3.4.0/deprecated/ActionScheduler_Schedule_Deprecated.php

@@ -10 +10 @@
      * after a given date & time.
      *
-     * @param DateTime $after
+     * @param DateTime $after DateTime to calculate against.
      *
      * @return DateTime|null
      */
-    public function next( DateTime $after = NULL ) {
+    public function next( DateTime $after = null ) {
         if ( empty( $after ) ) {
             $return_value       = $this->get_date();
@@ -23 +23 @@
         }
 
-        _deprecated_function( __METHOD__, '3.0.0', __CLASS__ . '::' . $replacement_method );
+        _deprecated_function( __METHOD__, '3.0.0', __CLASS__ . '::' . $replacement_method ); // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
 
         return $return_value;

action-scheduler/tags/3.4.0/readme.txt

@@ -4 +4 @@
 Requires at least: 5.2
 Tested up to: 5.7
-Stable tag: 3.3.0
+Stable tag: 3.4.0
 License: GPLv3
 Requires PHP: 5.6
@@ -48 +48 @@
 == Changelog ==
 
+= 3.4.0 - 2021-10-29 =
+* Enhancement - Number of items per page can now be set for the Scheduled Actions view (props @ovidiul). #771
+* Fix - Do not lower the max_execution_time if it is already set to 0 (unlimited) (props @barryhughes). #755
+* Fix - Avoid triggering autoloaders during the version resolution process (props @olegabr). #731 & #776
+* Dev - ActionScheduler_wcSystemStatus PHPCS fixes (props @ovidiul). #761
+* Dev - ActionScheduler_DBLogger.php PHPCS fixes (props @ovidiul). #768
+* Dev - Fixed phpcs for ActionScheduler_Schedule_Deprecated (props @ovidiul). #762
+* Dev - Improve actions table indicies (props @glagonikas). #774 & #777
+* Dev - PHPCS fixes for ActionScheduler_DBStore.php (props @ovidiul). #769 & #778
+* Dev - PHPCS Fixes for ActionScheduler_Abstract_ListTable (props @ovidiul). #763 & #779
+* Dev - Adds new filter action_scheduler_claim_actions_order_by to allow tuning of the claim query (props @glagonikas). #773
+* Dev - PHPCS fixes for ActionScheduler_WpPostStore class (props @ovidiul). #780
+
 = 3.3.0 - 2021-09-15 =
 * Enhancement - Adds as_has_scheduled_action() to provide a performant way to test for existing actions. #645

action-scheduler/trunk/action-scheduler.php

@@ -6 +6 @@
  * Author: Automattic
  * Author URI: https://automattic.com/
- * Version: 3.3.0
+ * Version: 3.4.0
  * License: GPLv3
  *
@@ -27 +27 @@
  */
 
-if ( ! function_exists( 'action_scheduler_register_3_dot_3_dot_0' ) && function_exists( 'add_action' ) ) {
+if ( ! function_exists( 'action_scheduler_register_3_dot_4_dot_0' ) && function_exists( 'add_action' ) ) {
 
-    if ( ! class_exists( 'ActionScheduler_Versions' ) ) {
+    if ( ! class_exists( 'ActionScheduler_Versions', false ) ) {
         require_once __DIR__ . '/classes/ActionScheduler_Versions.php';
         add_action( 'plugins_loaded', array( 'ActionScheduler_Versions', 'initialize_latest_version' ), 1, 0 );
     }
 
-    add_action( 'plugins_loaded', 'action_scheduler_register_3_dot_3_dot_0', 0, 0 );
+    add_action( 'plugins_loaded', 'action_scheduler_register_3_dot_4_dot_0', 0, 0 );
 
     /**
      * Registers this version of Action Scheduler.
      */
-    function action_scheduler_register_3_dot_3_dot_0() {
+    function action_scheduler_register_3_dot_4_dot_0() {
         $versions = ActionScheduler_Versions::instance();
-        $versions->register( '3.3.0', 'action_scheduler_initialize_3_dot_3_dot_0' );
+        $versions->register( '3.4.0', 'action_scheduler_initialize_3_dot_4_dot_0' );
     }
 
@@ -47 +47 @@
      * Initializes this version of Action Scheduler.
      */
-    function action_scheduler_initialize_3_dot_3_dot_0() {
+    function action_scheduler_initialize_3_dot_4_dot_0() {
         // A final safety check is required even here, because historic versions of Action Scheduler
         // followed a different pattern (in some unusual cases, we could reach this point and the
         // ActionScheduler class is already defined—so we need to guard against that).
-        if ( ! class_exists( 'ActionScheduler' ) ) {
+        if ( ! class_exists( 'ActionScheduler', false ) ) {
             require_once __DIR__ . '/classes/abstracts/ActionScheduler.php';
             ActionScheduler::init( __FILE__ );
@@ -58 +58 @@
 
     // Support usage in themes - load this version if no plugin has loaded a version yet.
-    if ( did_action( 'plugins_loaded' ) && ! doing_action( 'plugins_loaded' ) && ! class_exists( 'ActionScheduler' ) ) {
-        action_scheduler_initialize_3_dot_3_dot_0();
+    if ( did_action( 'plugins_loaded' ) && ! doing_action( 'plugins_loaded' ) && ! class_exists( 'ActionScheduler', false ) ) {
+        action_scheduler_initialize_3_dot_4_dot_0();
         do_action( 'action_scheduler_pre_theme_init' );
         ActionScheduler_Versions::initialize_latest_version();

action-scheduler/trunk/changelog.txt

@@ -1 +1 @@
 *** Changelog ***
+
+= 3.4.0 - 2021-10-29 =
+* Enhancement - Number of items per page can now be set for the Scheduled Actions view (props @ovidiul). #771
+* Fix - Do not lower the max_execution_time if it is already set to 0 (unlimited) (props @barryhughes). #755
+* Fix - Avoid triggering autoloaders during the version resolution process (props @olegabr). #731 & #776
+* Dev - ActionScheduler_wcSystemStatus PHPCS fixes (props @ovidiul). #761
+* Dev - ActionScheduler_DBLogger.php PHPCS fixes (props @ovidiul). #768
+* Dev - Fixed phpcs for ActionScheduler_Schedule_Deprecated (props @ovidiul). #762
+* Dev - Improve actions table indicies (props @glagonikas). #774 & #777
+* Dev - PHPCS fixes for ActionScheduler_DBStore.php (props @ovidiul). #769 & #778
+* Dev - PHPCS Fixes for ActionScheduler_Abstract_ListTable (props @ovidiul). #763 & #779
+* Dev - Adds new filter action_scheduler_claim_actions_order_by to allow tuning of the claim query (props @glagonikas). #773
+* Dev - PHPCS fixes for ActionScheduler_WpPostStore class (props @ovidiul). #780
 
 = 3.3.0 - 2021-09-15 =

action-scheduler/trunk/classes/ActionScheduler_Compatibility.php

@@ -84 +84 @@
      * Only allows raising the existing limit and prevents lowering it. Wrapper for wc_set_time_limit(), when available.
      *
-     * @param int The time limit in seconds.
+     * @param int $limit The time limit in seconds.
      */
     public static function raise_time_limit( $limit = 0 ) {
-        if ( $limit < ini_get( 'max_execution_time' ) ) {
+        $limit = (int) $limit;
+        $max_execution_time = (int) ini_get( 'max_execution_time' );
+
+        /*
+         * If the max execution time is already unlimited (zero), or if it exceeds or is equal to the proposed
+         * limit, there is no reason for us to make further changes (we never want to lower it).
+         */
+        if (
+            0 === $max_execution_time
+            || ( $max_execution_time >= $limit && $limit !== 0 )
+        ) {
             return;
         }
@@ -94 +104 @@
             wc_set_time_limit( $limit );
         } elseif ( function_exists( 'set_time_limit' ) && false === strpos( ini_get( 'disable_functions' ), 'set_time_limit' ) && ! ini_get( 'safe_mode' ) ) { // phpcs:ignore PHPCompatibility.IniDirectives.RemovedIniDirectives.safe_modeDeprecatedRemoved
-            @set_time_limit( $limit );
+            @set_time_limit( $limit ); // phpcs:ignore WordPress.PHP.NoSilencedErrors.Discouraged
         }
     }

action-scheduler/trunk/classes/ActionScheduler_ListTable.php

@@ -176 +176 @@
         );
 
-        parent::__construct( array(
-            'singular' => 'action-scheduler',
-            'plural'   => 'action-scheduler',
-            'ajax'     => false,
-        ) );
-    }
-
+        parent::__construct(
+            array(
+                'singular' => 'action-scheduler',
+                'plural'   => 'action-scheduler',
+                'ajax'     => false,
+            )
+        );
+
+        add_screen_option(
+            'per_page',
+            array(
+                'default' => $this->items_per_page,
+            )
+        );
+
+        add_filter( 'set_screen_option_' . $this->get_per_page_option_name(), array( $this, 'set_items_per_page_option' ), 10, 3 );
+        set_screen_options();
+    }
+
+    /**
+     * Handles setting the items_per_page option for this screen.
+     *
+     * @param mixed  $status Default false (to skip saving the current option).
+     * @param string $option Screen option name.
+     * @param int    $value  Screen option value.
+     * @return int
+     */
+    public function set_items_per_page_option( $status, $option, $value ) {
+        return $value;
+    }
     /**
      * Convert an interval of seconds into a two part human friendly string.
@@ -550 +573 @@
         $this->prepare_column_headers();
 
-        $per_page = $this->get_items_per_page( $this->package . '_items_per_page', $this->items_per_page );
+        $per_page = $this->get_items_per_page( $this->get_per_page_option_name(), $this->items_per_page );
+
         $query = array(
             'per_page' => $per_page,
@@ -610 +634 @@
         return __( 'Search hook, args and claim ID', 'action-scheduler' );
     }
+
+    /**
+     * {@inheritDoc}
+     */
+    protected function get_per_page_option_name() {
+        return str_replace( '-', '_', $this->screen->id ) . '_per_page';
+    }
 }

action-scheduler/trunk/classes/ActionScheduler_wcSystemStatus.php

@@ -13 +13 @@
     protected $store;
 
-    function __construct( $store ) {
+    /**
+     * Constructor method for ActionScheduler_wcSystemStatus.
+     *
+     * @param ActionScheduler_Store $store Active store object.
+     *
+     * @return void
+     */
+    public function __construct( $store ) {
         $this->store = $store;
     }
@@ -68 +75 @@
         $order = 'oldest' === $date_type ? 'ASC' : 'DESC';
 
-        $action = $this->store->query_actions( array(
-            'claimed'  => false,
-            'status'   => $status,
-            'per_page' => 1,
-            'order'    => $order,
-        ) );
+        $action = $this->store->query_actions(
+            array(
+                'claimed'  => false,
+                'status'   => $status,
+                'per_page' => 1,
+                'order'    => $order,
+            )
+        );
 
         if ( ! empty( $action ) ) {
@@ -93 +102 @@
      */
     protected function get_template( $status_labels, $action_counts, $oldest_and_newest ) {
-        $as_version = ActionScheduler_Versions::instance()->latest_version();
+        $as_version   = ActionScheduler_Versions::instance()->latest_version();
         $as_datastore = get_class( ActionScheduler_Store::instance() );
         ?>
@@ -125 +134 @@
                         '<tr><td>%1$s</td><td>&nbsp;</td><td>%2$s<span style="display: none;">, Oldest: %3$s, Newest: %4$s</span></td><td>%3$s</td><td>%4$s</td></tr>',
                         esc_html( $status_labels[ $status ] ),
-                        number_format_i18n( $count ),
-                        $oldest_and_newest[ $status ]['oldest'],
-                        $oldest_and_newest[ $status ]['newest']
+                        esc_html( number_format_i18n( $count ) ),
+                        esc_html( $oldest_and_newest[ $status ]['oldest'] ),
+                        esc_html( $oldest_and_newest[ $status ]['newest'] )
                     );
                 }
@@ -138 +147 @@
 
     /**
-     * is triggered when invoking inaccessible methods in an object context.
+     * Is triggered when invoking inaccessible methods in an object context.
      *
-     * @param string $name
-     * @param array  $arguments
+     * @param string $name Name of method called.
+     * @param array  $arguments Parameters to invoke the method with.
      *
      * @return mixed

action-scheduler/trunk/classes/abstracts/ActionScheduler_Abstract_ListTable.php

@@ -2 +2 @@
 
 if ( ! class_exists( 'WP_List_Table' ) ) {
-    require_once( ABSPATH . 'wp-admin/includes/class-wp-list-table.php' );
+    require_once ABSPATH . 'wp-admin/includes/class-wp-list-table.php';
 }
 
@@ -14 +14 @@
  *
  * This class supports:
- *  - Bulk actions
- *  - Search
+ *  - Bulk actions
+ *  - Search
  *  - Sortable columns
  *  - Automatic translations of the columns
@@ -26 +26 @@
     /**
      * The table name
+     *
+     * @var string
      */
     protected $table_name;
@@ -31 +33 @@
     /**
      * Package name, used to get options from WP_List_Table::get_items_per_page.
+     *
+     * @var string
      */
     protected $package;
@@ -36 +40 @@
     /**
      * How many items do we render per page?
+     *
+     * @var int
      */
     protected $items_per_page = 10;
@@ -42 +48 @@
      * Enables search in this table listing. If this array
      * is empty it means the listing is not searchable.
+     *
+     * @var array
      */
     protected $search_by = array();
@@ -49 +57 @@
      * key must much the table column name and the value is the label, which is
      * automatically translated.
+     *
+     * @var array
      */
     protected $columns = array();
@@ -59 +69 @@
      * (with the prefix row_action_<key>) and the value is the label
      * and title.
+     *
+     * @var array
      */
     protected $row_actions = array();
@@ -64 +76 @@
     /**
      * The Primary key of our table
+     *
+     * @var string
      */
     protected $ID = 'ID';
@@ -70 +84 @@
      * Enables sorting, it expects an array
      * of columns (the column names are the values)
+     *
+     * @var array
      */
     protected $sort_by = array();
 
+    /**
+     * The default sort order
+     *
+     * @var string
+     */
     protected $filter_by = array();
 
     /**
-     * @var array The status name => count combinations for this table's items. Used to display status filters.
+     * The status name => count combinations for this table's items. Used to display status filters.
+     *
+     * @var array
      */
     protected $status_counts = array();
 
     /**
-     * @var array Notices to display when loading the table. Array of arrays of form array( 'class' => {updated|error}, 'message' => 'This is the notice text display.' ).
+     * Notices to display when loading the table. Array of arrays of form array( 'class' => {updated|error}, 'message' => 'This is the notice text display.' ).
+     *
+     * @var array
      */
     protected $admin_notices = array();
 
     /**
-     * @var string Localised string displayed in the <h1> element above the able.
+     * Localised string displayed in the <h1> element above the able.
+     *
+     * @var string
      */
     protected $table_header;
@@ -100 +127 @@
      * is the array with primary keys, the second argument is a string with a list of the primary keys,
      * escaped and ready to use (with `IN`).
+     *
+     * @var array
      */
     protected $bulk_actions = array();
@@ -107 +136 @@
      * `_x` with some default (the package name).
      *
-     * @deprecated 3.0.0
+     * @param string $text The new text to translate.
+     * @param string $context The context of the text.
+     * @return string|void The translated text.
+     *
+     * @deprecated 3.0.0 Use `_x()` instead.
      */
     protected function translate( $text, $context = '' ) {
@@ -117 +150 @@
      * also validates that the bulk method handler exists. It throws an exception because
      * this is a library meant for developers and missing a bulk method is a development-time error.
+     *
+     * @return array
+     *
+     * @throws RuntimeException Throws RuntimeException when the bulk action does not have a callback method.
      */
     protected function get_bulk_actions() {
@@ -147 +184 @@
         check_admin_referer( 'bulk-' . $this->_args['plural'] );
 
-        $method   = 'bulk_' . $action;
+        $method = 'bulk_' . $action;
         if ( array_key_exists( $action, $this->bulk_actions ) && is_callable( array( $this, $method ) ) && ! empty( $_GET['ID'] ) && is_array( $_GET['ID'] ) ) {
             $ids_sql = '(' . implode( ',', array_fill( 0, count( $_GET['ID'] ), '%s' ) ) . ')';
-            $this->$method( $_GET['ID'], $wpdb->prepare( $ids_sql, $_GET['ID'] ) );
-        }
-
-        wp_redirect( remove_query_arg(
-            array( '_wp_http_referer', '_wpnonce', 'ID', 'action', 'action2' ),
-            wp_unslash( $_SERVER['REQUEST_URI'] )
-        ) );
-        exit;
+            $id      = array_map( 'absint', $_GET['ID'] );
+            $this->$method( $id, $wpdb->prepare( $ids_sql, $id ) ); //phpcs:ignore WordPress.DB.PreparedSQL
+        }
+
+        if ( isset( $_SERVER['REQUEST_URI'] ) ) {
+            wp_safe_redirect(
+                remove_query_arg(
+                    array( '_wp_http_referer', '_wpnonce', 'ID', 'action', 'action2' ),
+                    esc_url_raw( wp_unslash( $_SERVER['REQUEST_URI'] ) )
+                )
+            );
+            exit;
+        }
     }
 
@@ -163 +205 @@
      * Default code for deleting entries.
      * validated already by process_bulk_action()
+     *
+     * @param array  $ids ids of the items to delete.
+     * @param string $ids_sql the sql for the ids.
+     * @return void
      */
     protected function bulk_delete( array $ids, $ids_sql ) {
@@ -218 +264 @@
         global $wpdb;
 
-        $per_page = $this->get_items_per_page( $this->package . '_items_per_page', $this->items_per_page );
+        $per_page = $this->get_items_per_page( $this->get_per_page_option_name(), $this->items_per_page );
         return $wpdb->prepare( 'LIMIT %d', $per_page );
     }
@@ -228 +274 @@
      */
     protected function get_items_offset() {
-        $per_page = $this->get_items_per_page( $this->package . '_items_per_page', $this->items_per_page );
+        $per_page     = $this->get_items_per_page( $this->get_per_page_option_name(), $this->items_per_page );
         $current_page = $this->get_pagenum();
         if ( 1 < $current_page ) {
@@ -277 +323 @@
         $valid_sortable_columns = array_values( $this->sort_by );
 
-        if ( ! empty( $_GET['orderby'] ) && in_array( $_GET['orderby'], $valid_sortable_columns ) ) {
-            $orderby = sanitize_text_field( $_GET['orderby'] );
+        if ( ! empty( $_GET['orderby'] ) && in_array( $_GET['orderby'], $valid_sortable_columns, true ) ) { //phpcs:ignore WordPress.Security.NonceVerification.Recommended
+            $orderby = sanitize_text_field( wp_unslash( $_GET['orderby'] ) ); //phpcs:ignore WordPress.Security.NonceVerification.Recommended
         } else {
             $orderby = $valid_sortable_columns[0];
@@ -293 +339 @@
     protected function get_request_order() {
 
-        if ( ! empty( $_GET['order'] ) && 'desc' === strtolower( $_GET['order'] ) ) {
+        if ( ! empty( $_GET['order'] ) && 'desc' === strtolower( sanitize_text_field( wp_unslash( $_GET['order'] ) ) ) ) { //phpcs:ignore WordPress.Security.NonceVerification.Recommended
             $order = 'DESC';
         } else {
@@ -308 +354 @@
      */
     protected function get_request_status() {
-        $status = ( ! empty( $_GET['status'] ) ) ? $_GET['status'] : '';
+        $status = ( ! empty( $_GET['status'] ) ) ? sanitize_text_field( wp_unslash( $_GET['status'] ) ) : ''; //phpcs:ignore WordPress.Security.NonceVerification.Recommended
         return $status;
     }
@@ -318 +364 @@
      */
     protected function get_request_search_query() {
-        $search_query = ( ! empty( $_GET['s'] ) ) ? $_GET['s'] : '';
+        $search_query = ( ! empty( $_GET['s'] ) ) ? sanitize_text_field( wp_unslash( $_GET['s'] ) ) : ''; //phpcs:ignore WordPress.Security.NonceVerification.Recommended
         return $search_query;
     }
@@ -330 +376 @@
     protected function get_table_columns() {
         $columns = array_keys( $this->columns );
-        if ( ! in_array( $this->ID, $columns ) ) {
+        if ( ! in_array( $this->ID, $columns, true ) ) {
             $columns[] = $this->ID;
         }
@@ -344 +390 @@
      * that feature it will return an empty string.
      *
-     * TODO:
-     *   - Improve search doing LIKE by word rather than by phrases.
-     *
      * @return string
      */
@@ -352 +395 @@
         global $wpdb;
 
-        if ( empty( $_GET['s'] ) || empty( $this->search_by ) ) {
+        if ( empty( $_GET['s'] ) || empty( $this->search_by ) ) { //phpcs:ignore WordPress.Security.NonceVerification.Recommended
             return '';
         }
 
-        $filter  = array();
+        $search_string = sanitize_text_field( wp_unslash( $_GET['s'] ) ); //phpcs:ignore WordPress.Security.NonceVerification.Recommended
+
+        $filter = array();
         foreach ( $this->search_by as $column ) {
-            $filter[] = $wpdb->prepare('`' . $column . '` like "%%s%"', $wpdb->esc_like( $_GET['s'] ));
+            $wild     = '%';
+            $sql_like = $wild . $wpdb->esc_like( $search_string ) . $wild;
+            $filter[] = $wpdb->prepare( '`' . $column . '` LIKE %s', $sql_like ); // phpcs:ignore WordPress.Security.NonceVerification.Recommended, WordPress.DB.PreparedSQL.NotPrepared
         }
         return implode( ' OR ', $filter );
@@ -370 +417 @@
         global $wpdb;
 
-        if ( ! $this->filter_by || empty( $_GET['filter_by'] ) || ! is_array( $_GET['filter_by'] ) ) {
+        if ( ! $this->filter_by || empty( $_GET['filter_by'] ) || ! is_array( $_GET['filter_by'] ) ) { //phpcs:ignore WordPress.Security.NonceVerification.Recommended
             return '';
         }
@@ -377 +424 @@
 
         foreach ( $this->filter_by as $column => $options ) {
-            if ( empty( $_GET['filter_by'][ $column ] ) || empty( $options[ $_GET['filter_by'][ $column ] ] ) ) {
+            if ( empty( $_GET['filter_by'][ $column ] ) || empty( $options[ $_GET['filter_by'][ $column ] ] ) ) { //phpcs:ignore WordPress.Security.NonceVerification.Recommended
                 continue;
             }
 
-            $filter[] = $wpdb->prepare( "`$column` = %s", $_GET['filter_by'][ $column ] );
+            $filter[] = $wpdb->prepare( "`$column` = %s", sanitize_text_field( wp_unslash( $_GET['filter_by'][ $column ] ) ) ); //phpcs:ignore WordPress.Security.NonceVerification.Recommended, WordPress.DB.PreparedSQL.InterpolatedNotPrepared
         }
 
@@ -404 +451 @@
         $this->process_row_actions();
 
-        if ( ! empty( $_REQUEST['_wp_http_referer'] ) ) {
+        if ( ! empty( $_REQUEST['_wp_http_referer'] && ! empty( $_SERVER['REQUEST_URI'] ) ) ) { //phpcs:ignore WordPress.Security.NonceVerification.Recommended
             // _wp_http_referer is used only on bulk actions, we remove it to keep the $_GET shorter
-            wp_redirect( remove_query_arg( array( '_wp_http_referer', '_wpnonce' ), wp_unslash( $_SERVER['REQUEST_URI'] ) ) );
+            wp_safe_redirect( remove_query_arg( array( '_wp_http_referer', '_wpnonce' ), esc_url_raw( wp_unslash( $_SERVER['REQUEST_URI'] ) ) ) );
             exit;
         }
@@ -415 +462 @@
         $offset  = $this->get_items_query_offset();
         $order   = $this->get_items_query_order();
-        $where   = array_filter(array(
-            $this->get_items_query_search(),
-            $this->get_items_query_filters(),
-        ));
+        $where   = array_filter(
+            array(
+                $this->get_items_query_search(),
+                $this->get_items_query_filters(),
+            )
+        );
         $columns = '`' . implode( '`, `', $this->get_table_columns() ) . '`';
 
         if ( ! empty( $where ) ) {
-            $where = 'WHERE ('. implode( ') AND (', $where ) . ')';
+            $where = 'WHERE (' . implode( ') AND (', $where ) . ')';
         } else {
             $where = '';
@@ -429 +478 @@
         $sql = "SELECT $columns FROM {$this->table_name} {$where} {$order} {$limit} {$offset}";
 
-        $this->set_items( $wpdb->get_results( $sql, ARRAY_A ) );
+        $this->set_items( $wpdb->get_results( $sql, ARRAY_A ) ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared
 
         $query_count = "SELECT COUNT({$this->ID}) FROM {$this->table_name} {$where}";
-        $total_items = $wpdb->get_var( $query_count );
-        $per_page    = $this->get_items_per_page( $this->package . '_items_per_page', $this->items_per_page );
-        $this->set_pagination_args( array(
-            'total_items' => $total_items,
-            'per_page'    => $per_page,
-            'total_pages' => ceil( $total_items / $per_page ),
-        ) );
-    }
-
+        $total_items = $wpdb->get_var( $query_count ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared
+        $per_page    = $this->get_items_per_page( $this->get_per_page_option_name(), $this->items_per_page );
+        $this->set_pagination_args(
+            array(
+                'total_items' => $total_items,
+                'per_page'    => $per_page,
+                'total_pages' => ceil( $total_items / $per_page ),
+            )
+        );
+    }
+
+    /**
+     * Display the table.
+     *
+     * @param string $which The name of the table.
+     */
     public function extra_tablenav( $which ) {
         if ( ! $this->filter_by || 'top' !== $which ) {
@@ -449 +505 @@
 
         foreach ( $this->filter_by as $id => $options ) {
-            $default = ! empty( $_GET['filter_by'][ $id ] ) ? $_GET['filter_by'][ $id ] : '';
+            $default = ! empty( $_GET['filter_by'][ $id ] ) ? sanitize_text_field( wp_unslash( $_GET['filter_by'][ $id ] ) ) : ''; //phpcs:ignore WordPress.Security.NonceVerification.Recommended
             if ( empty( $options[ $default ] ) ) {
                 $default = '';
@@ -457 +513 @@
 
             foreach ( $options as $value => $label ) {
-                echo '<option value="' . esc_attr( $value ) . '" ' . esc_html( $value == $default ? 'selected' : '' )  .'>'
+                echo '<option value="' . esc_attr( $value ) . '" ' . esc_html( $value === $default ? 'selected' : '' ) . '>'
                     . esc_html( $label )
                 . '</option>';
@@ -472 +528 @@
      * Set the data for displaying. It will attempt to unserialize (There is a chance that some columns
      * are serialized). This can be override in child classes for futher data transformation.
+     *
+     * @param array $items Items array.
      */
     protected function set_items( array $items ) {
@@ -484 +542 @@
      * of how the primary key is named (to keep the code simpler). The bulk actions will do the proper
      * name transformation though using `$this->ID`.
+     *
+     * @param array $row The row to render.
      */
     public function column_cb( $row ) {
-        return '<input name="ID[]" type="checkbox" value="' . esc_attr( $row[ $this->ID ] ) .'" />';
+        return '<input name="ID[]" type="checkbox" value="' . esc_attr( $row[ $this->ID ] ) . '" />';
     }
 
@@ -495 +555 @@
      * and it checks that the row action method exists before rendering it.
      *
-     * @param array $row     Row to render
-     * @param $column_name   Current row
-     * @return
+     * @param array  $row Row to be rendered.
+     * @param string $column_name Column name.
+     * @return string
      */
     protected function maybe_render_actions( $row, $column_name ) {
@@ -506 +566 @@
         $row_id = $row[ $this->ID ];
 
-        $actions = '<div class="row-actions">';
+        $actions      = '<div class="row-actions">';
         $action_count = 0;
         foreach ( $this->row_actions[ $column_name ] as $action_key => $action ) {
@@ -516 +576 @@
             }
 
-            $action_link = ! empty( $action['link'] ) ? $action['link'] : add_query_arg( array( 'row_action' => $action_key, 'row_id' => $row_id, 'nonce'  => wp_create_nonce( $action_key . '::' . $row_id ) ) );
+            $action_link = ! empty( $action['link'] ) ? $action['link'] : add_query_arg(
+                array(
+                    'row_action' => $action_key,
+                    'row_id'     => $row_id,
+                    'nonce'      => wp_create_nonce( $action_key . '::' . $row_id ),
+                )
+            );
             $span_class  = ! empty( $action['class'] ) ? $action['class'] : $action_key;
             $separator   = ( $action_count < count( $this->row_actions[ $column_name ] ) ) ? ' | ' : '';
@@ -528 +594 @@
     }
 
+    /**
+     * Process the bulk actions.
+     *
+     * @return void
+     */
     protected function process_row_actions() {
         $parameters = array( 'row_action', 'row_id', 'nonce' );
         foreach ( $parameters as $parameter ) {
-            if ( empty( $_REQUEST[ $parameter ] ) ) {
+            if ( empty( $_REQUEST[ $parameter ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Recommended
                 return;
             }
         }
 
-        $method = 'row_action_' . $_REQUEST['row_action'];
-
-        if ( $_REQUEST['nonce'] === wp_create_nonce( $_REQUEST[ 'row_action' ] . '::' . $_REQUEST[ 'row_id' ] ) && method_exists( $this, $method ) ) {
-            $this->$method( $_REQUEST['row_id'] );
-        }
-
-        wp_redirect( remove_query_arg(
-            array( 'row_id', 'row_action', 'nonce' ),
-            wp_unslash( $_SERVER['REQUEST_URI'] )
-        ) );
-        exit;
+        $action = sanitize_text_field( wp_unslash( $_REQUEST['row_action'] ) ); // phpcs:ignore WordPress.Security.NonceVerification.Recommended, WordPress.Security.ValidatedSanitizedInput.InputNotValidated
+        $row_id = sanitize_text_field( wp_unslash( $_REQUEST['row_id'] ) ); // phpcs:ignore WordPress.Security.NonceVerification.Recommended, WordPress.Security.ValidatedSanitizedInput.InputNotValidated
+        $nonce  = sanitize_text_field( wp_unslash( $_REQUEST['nonce'] ) ); // phpcs:ignore WordPress.Security.NonceVerification.Recommended, WordPress.Security.ValidatedSanitizedInput.InputNotValidated
+        $method = 'row_action_' . $action; // phpcs:ignore WordPress.Security.NonceVerification.Recommended
+
+        if ( wp_verify_nonce( $nonce, $action . '::' . $row_id ) && method_exists( $this, $method ) ) {
+            $this->$method( sanitize_text_field( wp_unslash( $row_id ) ) ); // phpcs:ignore WordPress.Security.NonceVerification.Recommended
+        }
+
+        if ( isset( $_SERVER['REQUEST_URI'] ) ) {
+            wp_safe_redirect(
+                remove_query_arg(
+                    array( 'row_id', 'row_action', 'nonce' ),
+                    esc_url_raw( wp_unslash( $_SERVER['REQUEST_URI'] ) )
+                )
+            );
+            exit;
+        }
     }
 
     /**
      * Default column formatting, it will escape everythig for security.
+     *
+     * @param array  $item The item array.
+     * @param string $column_name Column name to display.
+     *
+     * @return string
      */
     public function column_default( $item, $column_name ) {
-        $column_html = esc_html( $item[ $column_name ] );
+        $column_html  = esc_html( $item[ $column_name ] );
         $column_html .= $this->maybe_render_actions( $item, $column_name );
         return $column_html;
@@ -575 +658 @@
     protected function display_admin_notices() {
         foreach ( $this->admin_notices as $notice ) {
-            echo '<div id="message" class="' . $notice['class'] . '">';
+            echo '<div id="message" class="' . esc_attr( $notice['class'] ) . '">';
             echo '  <p>' . wp_kses_post( $notice['message'] ) . '</p>';
             echo '</div>';
@@ -589 +672 @@
         $request_status    = $this->get_request_status();
 
-        // Helper to set 'all' filter when not set on status counts passed in
+        // Helper to set 'all' filter when not set on status counts passed in.
         if ( ! isset( $this->status_counts['all'] ) ) {
             $this->status_counts = array( 'all' => array_sum( $this->status_counts ) ) + $this->status_counts;
@@ -613 +696 @@
         if ( $status_list_items ) {
             echo '<ul class="subsubsub">';
-            echo implode( " | \n", $status_list_items );
+            echo implode( " | \n", $status_list_items ); // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
             echo '</ul>';
         }
@@ -625 +708 @@
     protected function display_table() {
         echo '<form id="' . esc_attr( $this->_args['plural'] ) . '-filter" method="get">';
-        foreach ( $_GET as $key => $value ) {
+        foreach ( $_GET as $key => $value ) { // phpcs:ignore WordPress.Security.NonceVerification.Recommended
             if ( '_' === $key[0] || 'paged' === $key || 'ID' === $key ) {
                 continue;
@@ -632 +715 @@
         }
         if ( ! empty( $this->search_by ) ) {
-            echo $this->search_box( $this->get_search_box_button_text(), 'plugin' ); // WPCS: XSS OK
+            echo $this->search_box( $this->get_search_box_button_text(), 'plugin' ); // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
         }
         parent::display();
@@ -645 +728 @@
         $this->process_row_actions();
 
-        if ( ! empty( $_REQUEST['_wp_http_referer'] ) ) {
+        if ( ! empty( $_REQUEST['_wp_http_referer'] ) && ! empty( $_SERVER['REQUEST_URI'] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Recommended
             // _wp_http_referer is used only on bulk actions, we remove it to keep the $_GET shorter
-            wp_redirect( remove_query_arg( array( '_wp_http_referer', '_wpnonce' ), wp_unslash( $_SERVER['REQUEST_URI'] ) ) );
+            wp_safe_redirect( remove_query_arg( array( '_wp_http_referer', '_wpnonce' ), esc_url_raw( wp_unslash( $_SERVER['REQUEST_URI'] ) ) ) );
             exit;
         }
@@ -672 +755 @@
         return esc_html__( 'Search', 'action-scheduler' );
     }
+
+    /**
+     * Gets the screen per_page option name.
+     *
+     * @return string
+     */
+    protected function get_per_page_option_name() {
+        return $this->package . '_items_per_page';
+    }
 }

action-scheduler/trunk/classes/data-stores/ActionScheduler_DBLogger.php

@@ -30 +30 @@
         $date_local = $date->format( 'Y-m-d H:i:s' );
 
-        /** @var \wpdb $wpdb */
+        /** @var \wpdb $wpdb */ //phpcs:ignore Generic.Commenting.DocComment.MissingShort
         global $wpdb;
-        $wpdb->insert( $wpdb->actionscheduler_logs, [
-            'action_id'      => $action_id,
-            'message'        => $message,
-            'log_date_gmt'   => $date_gmt,
-            'log_date_local' => $date_local,
-        ], [ '%d', '%s', '%s', '%s' ] );
+        $wpdb->insert(
+            $wpdb->actionscheduler_logs,
+            array(
+                'action_id'      => $action_id,
+                'message'        => $message,
+                'log_date_gmt'   => $date_gmt,
+                'log_date_local' => $date_local,
+            ),
+            array( '%d', '%s', '%s', '%s' )
+        );
 
         return $wpdb->insert_id;
@@ -50 +54 @@
      */
     public function get_entry( $entry_id ) {
-        /** @var \wpdb $wpdb */
+        /** @var \wpdb $wpdb */ //phpcs:ignore Generic.Commenting.DocComment.MissingShort
         global $wpdb;
         $entry = $wpdb->get_row( $wpdb->prepare( "SELECT * FROM {$wpdb->actionscheduler_logs} WHERE log_id=%d", $entry_id ) );
@@ -86 +90 @@
      */
     public function get_logs( $action_id ) {
-        /** @var \wpdb $wpdb */
+        /** @var \wpdb $wpdb */ //phpcs:ignore Generic.Commenting.DocComment.MissingShort
         global $wpdb;
 
         $records = $wpdb->get_results( $wpdb->prepare( "SELECT * FROM {$wpdb->actionscheduler_logs} WHERE action_id=%d", $action_id ) );
 
-        return array_map( [ $this, 'create_entry_from_db_record' ], $records );
+        return array_map( array( $this, 'create_entry_from_db_record' ), $records );
     }
 
@@ -106 +110 @@
         parent::init();
 
-        add_action( 'action_scheduler_deleted_action', [ $this, 'clear_deleted_action_logs' ], 10, 1 );
+        add_action( 'action_scheduler_deleted_action', array( $this, 'clear_deleted_action_logs' ), 10, 1 );
     }
 
@@ -115 +119 @@
      */
     public function clear_deleted_action_logs( $action_id ) {
-        /** @var \wpdb $wpdb */
+        /** @var \wpdb $wpdb */ //phpcs:ignore Generic.Commenting.DocComment.MissingShort
         global $wpdb;
-        $wpdb->delete( $wpdb->actionscheduler_logs, [ 'action_id' => $action_id, ], [ '%d' ] );
+        $wpdb->delete( $wpdb->actionscheduler_logs, array( 'action_id' => $action_id ), array( '%d' ) );
     }
 
@@ -130 +134 @@
         }
 
-        /** @var \wpdb $wpdb */
+        /** @var \wpdb $wpdb */ //phpcs:ignore Generic.Commenting.DocComment.MissingShort
         global $wpdb;
         $date     = as_get_datetime_object();
@@ -139 +143 @@
         $format     = '(%d, ' . $wpdb->prepare( '%s, %s, %s', $message, $date_gmt, $date_local ) . ')';
         $sql_query  = "INSERT {$wpdb->actionscheduler_logs} (action_id, message, log_date_gmt, log_date_local) VALUES ";
-        $value_rows = [];
+        $value_rows = array();
 
         foreach ( $action_ids as $action_id ) {
-            $value_rows[] = $wpdb->prepare( $format, $action_id );
+            $value_rows[] = $wpdb->prepare( $format, $action_id ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared
         }
         $sql_query .= implode( ',', $value_rows );
 
-        $wpdb->query( $sql_query );
+        $wpdb->query( $sql_query ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared
     }
 }

action-scheduler/trunk/classes/data-stores/ActionScheduler_DBStore.php

@@ -41 +41 @@
      *
      * @param ActionScheduler_Action $action Action object.
-     * @param DateTime               $date Optional schedule date. Default null.
+     * @param DateTime              $date Optional schedule date. Default null.
      *
      * @return int Action ID.
+     * @throws RuntimeException     Throws exception when saving the action fails.
      */
     public function save_action( ActionScheduler_Action $action, \DateTime $date = null ) {
@@ -52 +53 @@
             /** @var \wpdb $wpdb */
             global $wpdb;
-            $data = [
+            $data = array(
                 'hook'                 => $action->get_hook(),
                 'status'               => ( $action->is_finished() ? self::STATUS_COMPLETE : self::STATUS_PENDING ),
                 'scheduled_date_gmt'   => $this->get_scheduled_date_string( $action, $date ),
                 'scheduled_date_local' => $this->get_scheduled_date_string_local( $action, $date ),
-                'schedule'             => serialize( $action->get_schedule() ),
+                'schedule'             => serialize( $action->get_schedule() ), // phpcs:ignore WordPress.PHP.DiscouragedPHPFunctions.serialize_serialize
                 'group_id'             => $this->get_group_id( $action->get_group() ),
-            ];
+            );
             $args = wp_json_encode( $action->get_args() );
             if ( strlen( $args ) <= static::$max_index_length ) {
@@ -73 +74 @@
 
             if ( is_wp_error( $action_id ) ) {
-                throw new RuntimeException( $action_id->get_error_message() );
-            }
-            elseif ( empty( $action_id ) ) {
-                throw new RuntimeException( $wpdb->last_error ? $wpdb->last_error : __( 'Database error.', 'action-scheduler' ) );
+                throw new \RuntimeException( $action_id->get_error_message() );
+            } elseif ( empty( $action_id ) ) {
+                throw new \RuntimeException( $wpdb->last_error ? $wpdb->last_error : __( 'Database error.', 'action-scheduler' ) );
             }
 
@@ -115 +115 @@
      *
      * @param string $slug The string name of a group.
-     * @param bool $create_if_not_exists Whether to create the group if it does not already exist. Default, true - create the group.
+     * @param bool   $create_if_not_exists Whether to create the group if it does not already exist. Default, true - create the group.
      *
      * @return int The group's ID, if it exists or is created, or 0 if it does not exist and is not created.
@@ -143 +143 @@
         /** @var \wpdb $wpdb */
         global $wpdb;
-        $wpdb->insert( $wpdb->actionscheduler_groups, [ 'slug' => $slug ] );
+        $wpdb->insert( $wpdb->actionscheduler_groups, array( 'slug' => $slug ) );
 
         return (int) $wpdb->insert_id;
@@ -158 +158 @@
         /** @var \wpdb $wpdb */
         global $wpdb;
-        $data = $wpdb->get_row( $wpdb->prepare(
-            "SELECT a.*, g.slug AS `group` FROM {$wpdb->actionscheduler_actions} a LEFT JOIN {$wpdb->actionscheduler_groups} g ON a.group_id=g.group_id WHERE a.action_id=%d",
-            $action_id
-        ) );
+        $data = $wpdb->get_row(
+            $wpdb->prepare(
+                "SELECT a.*, g.slug AS `group` FROM {$wpdb->actionscheduler_actions} a LEFT JOIN {$wpdb->actionscheduler_groups} g ON a.group_id=g.group_id WHERE a.action_id=%d",
+                $action_id
+            )
+        );
 
         if ( empty( $data ) ) {
@@ -173 +175 @@
 
         // Convert NULL dates to zero dates.
-        $date_fields = [
+        $date_fields = array(
             'scheduled_date_gmt',
             'scheduled_date_local',
             'last_attempt_gmt',
-            'last_attempt_gmt'
-        ];
-        foreach( $date_fields as $date_field ) {
+            'last_attempt_gmt',
+        );
+        foreach ( $date_fields as $date_field ) {
             if ( is_null( $data->$date_field ) ) {
                 $data->$date_field = ActionScheduler_StoreSchema::DEFAULT_DATE;
@@ -215 +217 @@
         $hook     = $data->hook;
         $args     = json_decode( $data->args, true );
-        $schedule = unserialize( $data->schedule );
+        $schedule = unserialize( $data->schedule ); // phpcs:ignore WordPress.PHP.DiscouragedPHPFunctions.serialize_unserialize
 
         $this->validate_args( $args, $data->action_id );
@@ -237 +239 @@
      *
      * @return string SQL statement already properly escaped.
+     * @throws InvalidArgumentException If the query is invalid.
      */
     protected function get_query_actions_sql( array $query, $select_or_count = 'select' ) {
 
-        if ( ! in_array( $select_or_count, array( 'select', 'count' ) ) ) {
+        if ( ! in_array( $select_or_count, array( 'select', 'count' ), true ) ) {
             throw new InvalidArgumentException( __( 'Invalid value for select or count parameter. Cannot query actions.', 'action-scheduler' ) );
         }
 
-        $query = wp_parse_args( $query, [
-            'hook'             => '',
-            'args'             => null,
-            'date'             => null,
-            'date_compare'     => '<=',
-            'modified'         => null,
-            'modified_compare' => '<=',
-            'group'            => '',
-            'status'           => '',
-            'claimed'          => null,
-            'per_page'         => 5,
-            'offset'           => 0,
-            'orderby'          => 'date',
-            'order'            => 'ASC',
-        ] );
-
-        /** @var \wpdb $wpdb */
-        global $wpdb;
-        $sql  = ( 'count' === $select_or_count ) ? 'SELECT count(a.action_id)' : 'SELECT a.action_id';
-        $sql .= " FROM {$wpdb->actionscheduler_actions} a";
-        $sql_params = [];
-
-        if ( ! empty( $query[ 'group' ] ) || 'group' === $query[ 'orderby' ] ) {
+        $query = wp_parse_args(
+            $query,
+            array(
+                'hook'             => '',
+                'args'             => null,
+                'date'             => null,
+                'date_compare'     => '<=',
+                'modified'         => null,
+                'modified_compare' => '<=',
+                'group'            => '',
+                'status'           => '',
+                'claimed'          => null,
+                'per_page'         => 5,
+                'offset'           => 0,
+                'orderby'          => 'date',
+                'order'            => 'ASC',
+            )
+        );
+
+        /** @var \wpdb $wpdb */
+        global $wpdb;
+        $sql        = ( 'count' === $select_or_count ) ? 'SELECT count(a.action_id)' : 'SELECT a.action_id';
+        $sql       .= " FROM {$wpdb->actionscheduler_actions} a";
+        $sql_params = array();
+
+        if ( ! empty( $query['group'] ) || 'group' === $query['orderby'] ) {
             $sql .= " LEFT JOIN {$wpdb->actionscheduler_groups} g ON g.group_id=a.group_id";
         }
 
-        $sql .= " WHERE 1=1";
-
-        if ( ! empty( $query[ 'group' ] ) ) {
-            $sql          .= " AND g.slug=%s";
-            $sql_params[] = $query[ 'group' ];
-        }
-
-        if ( $query[ 'hook' ] ) {
-            $sql          .= " AND a.hook=%s";
-            $sql_params[] = $query[ 'hook' ];
-        }
-        if ( ! is_null( $query[ 'args' ] ) ) {
-            $sql          .= " AND a.args=%s";
-            $sql_params[] = $this->get_args_for_query( $query[ 'args' ] );
+        $sql .= ' WHERE 1=1';
+
+        if ( ! empty( $query['group'] ) ) {
+            $sql         .= ' AND g.slug=%s';
+            $sql_params[] = $query['group'];
+        }
+
+        if ( $query['hook'] ) {
+            $sql         .= ' AND a.hook=%s';
+            $sql_params[] = $query['hook'];
+        }
+        if ( ! is_null( $query['args'] ) ) {
+            $sql         .= ' AND a.args=%s';
+            $sql_params[] = $this->get_args_for_query( $query['args'] );
         }
 
@@ -293 +299 @@
         }
 
-        if ( $query[ 'date' ] instanceof \DateTime ) {
-            $date = clone $query[ 'date' ];
+        if ( $query['date'] instanceof \DateTime ) {
+            $date = clone $query['date'];
             $date->setTimezone( new \DateTimeZone( 'UTC' ) );
             $date_string  = $date->format( 'Y-m-d H:i:s' );
-            $comparator   = $this->validate_sql_comparator( $query[ 'date_compare' ] );
-            $sql          .= " AND a.scheduled_date_gmt $comparator %s";
+            $comparator   = $this->validate_sql_comparator( $query['date_compare'] );
+            $sql         .= " AND a.scheduled_date_gmt $comparator %s";
             $sql_params[] = $date_string;
         }
 
-        if ( $query[ 'modified' ] instanceof \DateTime ) {
-            $modified = clone $query[ 'modified' ];
+        if ( $query['modified'] instanceof \DateTime ) {
+            $modified = clone $query['modified'];
             $modified->setTimezone( new \DateTimeZone( 'UTC' ) );
             $date_string  = $modified->format( 'Y-m-d H:i:s' );
-            $comparator   = $this->validate_sql_comparator( $query[ 'modified_compare' ] );
-            $sql          .= " AND a.last_attempt_gmt $comparator %s";
+            $comparator   = $this->validate_sql_comparator( $query['modified_compare'] );
+            $sql         .= " AND a.last_attempt_gmt $comparator %s";
             $sql_params[] = $date_string;
         }
 
-        if ( $query[ 'claimed' ] === true ) {
-            $sql .= " AND a.claim_id != 0";
-        } elseif ( $query[ 'claimed' ] === false ) {
-            $sql .= " AND a.claim_id = 0";
-        } elseif ( ! is_null( $query[ 'claimed' ] ) ) {
-            $sql          .= " AND a.claim_id = %d";
-            $sql_params[] = $query[ 'claimed' ];
+        if ( true === $query['claimed'] ) {
+            $sql .= ' AND a.claim_id != 0';
+        } elseif ( false === $query['claimed'] ) {
+            $sql .= ' AND a.claim_id = 0';
+        } elseif ( ! is_null( $query['claimed'] ) ) {
+            $sql         .= ' AND a.claim_id = %d';
+            $sql_params[] = $query['claimed'];
         }
 
         if ( ! empty( $query['search'] ) ) {
-            $sql .= " AND (a.hook LIKE %s OR (a.extended_args IS NULL AND a.args LIKE %s) OR a.extended_args LIKE %s";
-            for( $i = 0; $i < 3; $i++ ) {
+            $sql .= ' AND (a.hook LIKE %s OR (a.extended_args IS NULL AND a.args LIKE %s) OR a.extended_args LIKE %s';
+            for ( $i = 0; $i < 3; $i++ ) {
                 $sql_params[] = sprintf( '%%%s%%', $query['search'] );
             }
@@ -328 +334 @@
             $search_claim_id = (int) $query['search'];
             if ( $search_claim_id ) {
-                $sql .= ' OR a.claim_id = %d';
+                $sql         .= ' OR a.claim_id = %d';
                 $sql_params[] = $search_claim_id;
             }
@@ -362 +368 @@
             }
 
-            if ( $query[ 'per_page' ] > 0 ) {
-                $sql          .= " LIMIT %d, %d";
-                $sql_params[] = $query[ 'offset' ];
-                $sql_params[] = $query[ 'per_page' ];
+            if ( $query['per_page'] > 0 ) {
+                $sql         .= ' LIMIT %d, %d';
+                $sql_params[] = $query['offset'];
+                $sql_params[] = $query['per_page'];
             }
         }
 
         if ( ! empty( $sql_params ) ) {
-            $sql = $wpdb->prepare( $sql, $sql_params );
+            $sql = $wpdb->prepare( $sql, $sql_params ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared
         }
 
@@ -388 +394 @@
      * @return string|array|null The IDs of actions matching the query. Null on failure.
      */
-    public function query_actions( $query = [], $query_type = 'select' ) {
+    public function query_actions( $query = array(), $query_type = 'select' ) {
         /** @var wpdb $wpdb */
         global $wpdb;
@@ -394 +400 @@
         $sql = $this->get_query_actions_sql( $query, $query_type );
 
-        return ( 'count' === $query_type ) ? $wpdb->get_var( $sql ) : $wpdb->get_col( $sql );
+        return ( 'count' === $query_type ) ? $wpdb->get_var( $sql ) : $wpdb->get_col( $sql ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared, WordPress.DB.DirectDatabaseQuery.NoSql, WordPress.DB.DirectDatabaseQuery.NoCaching
     }
 
@@ -407 +413 @@
         $sql  = "SELECT a.status, count(a.status) as 'count'";
         $sql .= " FROM {$wpdb->actionscheduler_actions} a";
-        $sql .= " GROUP BY a.status";
+        $sql .= ' GROUP BY a.status';
 
         $actions_count_by_status = array();
         $action_stati_and_labels = $this->get_status_labels();
 
-        foreach ( $wpdb->get_results( $sql ) as $action_data ) {
-            // Ignore any actions with invalid status
+        foreach ( $wpdb->get_results( $sql ) as $action_data ) { // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared
+            // Ignore any actions with invalid status.
             if ( array_key_exists( $action_data->status, $action_stati_and_labels ) ) {
                 $actions_count_by_status[ $action_data->status ] = $action_data->count;
@@ -428 +434 @@
      *
      * @return void
+     * @throws \InvalidArgumentException If the action update failed.
      */
     public function cancel_action( $action_id ) {
@@ -435 +442 @@
         $updated = $wpdb->update(
             $wpdb->actionscheduler_actions,
-            [ 'status' => self::STATUS_CANCELED ],
-            [ 'action_id' => $action_id ],
-            [ '%s' ],
-            [ '%d' ]
+            array( 'status' => self::STATUS_CANCELED ),
+            array( 'action_id' => $action_id ),
+            array( '%s' ),
+            array( '%d' )
         );
         if ( empty( $updated ) ) {
@@ -457 +464 @@
      */
     public function cancel_actions_by_hook( $hook ) {
-        $this->bulk_cancel_actions( [ 'hook' => $hook ] );
+        $this->bulk_cancel_actions( array( 'hook' => $hook ) );
     }
 
@@ -468 +475 @@
      */
     public function cancel_actions_by_group( $group ) {
-        $this->bulk_cancel_actions( [ 'group' => $group ] );
+        $this->bulk_cancel_actions( array( 'group' => $group ) );
     }
 
@@ -487 +494 @@
 
         // Don't cancel actions that are already canceled.
-        if ( isset( $query_args['status'] ) && $query_args['status'] == self::STATUS_CANCELED ) {
+        if ( isset( $query_args['status'] ) && self::STATUS_CANCELED === $query_args['status'] ) {
             return;
         }
@@ -494 +501 @@
         $query_args = wp_parse_args(
             $query_args,
-            [
+            array(
                 'per_page' => 1000,
                 'status'   => self::STATUS_PENDING,
                 'orderby'  => 'action_id',
-            ]
+            )
         );
 
@@ -513 +520 @@
 
             $wpdb->query(
-                $wpdb->prepare( // wpcs: PreparedSQLPlaceholders replacement count ok.
-                    "UPDATE {$wpdb->actionscheduler_actions} SET status = %s WHERE action_id IN {$query_in}",
+                $wpdb->prepare(
+                    "UPDATE {$wpdb->actionscheduler_actions} SET status = %s WHERE action_id IN {$query_in}", // phpcs:ignore WordPress.DB.PreparedSQL.InterpolatedNotPrepared
                     $parameters
                 )
@@ -527 +534 @@
      *
      * @param int $action_id Action ID.
+     * @throws \InvalidArgumentException If the action deletion failed.
      */
     public function delete_action( $action_id ) {
         /** @var \wpdb $wpdb */
         global $wpdb;
-        $deleted = $wpdb->delete( $wpdb->actionscheduler_actions, [ 'action_id' => $action_id ], [ '%d' ] );
+        $deleted = $wpdb->delete( $wpdb->actionscheduler_actions, array( 'action_id' => $action_id ), array( '%d' ) );
         if ( empty( $deleted ) ) {
-            throw new \InvalidArgumentException( sprintf( __( 'Unidentified action %s', 'action-scheduler' ), $action_id ) );
+            throw new \InvalidArgumentException( sprintf( __( 'Unidentified action %s', 'action-scheduler' ), $action_id ) ); //phpcs:ignore WordPress.WP.I18n.MissingTranslatorsComment
         }
         do_action( 'action_scheduler_deleted_action', $action_id );
@@ -543 +551 @@
      * @param string $action_id Action ID.
      *
-     * @throws \InvalidArgumentException
      * @return \DateTime The local date the action is scheduled to run, or the date that it ran.
      */
@@ -557 +564 @@
      * @param int $action_id Action ID.
      *
-     * @throws \InvalidArgumentException
+     * @throws \InvalidArgumentException If action cannot be identified.
      * @return \DateTime The GMT date the action is scheduled to run, or the date that it ran.
      */
@@ -565 +572 @@
         $record = $wpdb->get_row( $wpdb->prepare( "SELECT * FROM {$wpdb->actionscheduler_actions} WHERE action_id=%d", $action_id ) );
         if ( empty( $record ) ) {
-            throw new \InvalidArgumentException( sprintf( __( 'Unidentified action %s', 'action-scheduler' ), $action_id ) );
-        }
-        if ( $record->status == self::STATUS_PENDING ) {
+            throw new \InvalidArgumentException( sprintf( __( 'Unidentified action %s', 'action-scheduler' ), $action_id ) ); //phpcs:ignore WordPress.WP.I18n.MissingTranslatorsComment
+        }
+        if ( self::STATUS_PENDING === $record->status ) {
             return as_get_datetime_object( $record->scheduled_date_gmt );
         } else {
@@ -579 +586 @@
      * @param int       $max_actions Maximum number of action to include in claim.
      * @param \DateTime $before_date Jobs must be schedule before this date. Defaults to now.
+     * @param array     $hooks Hooks to filter for.
+     * @param string    $group Group to filter for.
      *
      * @return ActionScheduler_ActionClaim
@@ -587 +596 @@
         $this->claim_before_date = $before_date;
         $this->claim_actions( $claim_id, $max_actions, $before_date, $hooks, $group );
-        $action_ids = $this->find_actions_by_claim_id( $claim_id );
+        $action_ids              = $this->find_actions_by_claim_id( $claim_id );
         $this->claim_before_date = null;
 
@@ -602 +611 @@
         global $wpdb;
         $now = as_get_datetime_object();
-        $wpdb->insert( $wpdb->actionscheduler_claims, [ 'date_created_gmt' => $now->format( 'Y-m-d H:i:s' ) ] );
+        $wpdb->insert( $wpdb->actionscheduler_claims, array( 'date_created_gmt' => $now->format( 'Y-m-d H:i:s' ) ) );
 
         return $wpdb->insert_id;
@@ -613 +622 @@
      * @param int       $limit Number of action to include in claim.
      * @param \DateTime $before_date Should use UTC timezone.
+     * @param array     $hooks Hooks to filter for.
+     * @param string    $group Group to filter for.
      *
      * @return int The number of actions that were claimed.
-     * @throws \RuntimeException
+     * @throws \InvalidArgumentException Throws InvalidArgumentException if group doesn't exist.
+     * @throws \RuntimeException Throws RuntimeException if unable to claim action.
      */
     protected function claim_actions( $claim_id, $limit, \DateTime $before_date = null, $hooks = array(), $group = '' ) {
@@ -624 +636 @@
         $date = is_null( $before_date ) ? $now : clone $before_date;
 
-        // can't use $wpdb->update() because of the <= condition
+        // can't use $wpdb->update() because of the <= condition.
         $update = "UPDATE {$wpdb->actionscheduler_actions} SET claim_id=%d, last_attempt_gmt=%s, last_attempt_local=%s";
         $params = array(
@@ -632 +644 @@
         );
 
-        $where    = "WHERE claim_id = 0 AND scheduled_date_gmt <= %s AND status=%s";
+        $where    = 'WHERE claim_id = 0 AND scheduled_date_gmt <= %s AND status=%s';
         $params[] = $date->format( 'Y-m-d H:i:s' );
         $params[] = self::STATUS_PENDING;
@@ -646 +658 @@
             $group_id = $this->get_group_id( $group, false );
 
-            // throw exception if no matching group found, this matches ActionScheduler_wpPostStore's behaviour
+            // throw exception if no matching group found, this matches ActionScheduler_wpPostStore's behaviour.
             if ( empty( $group_id ) ) {
                 /* translators: %s: group name */
@@ -656 +668 @@
         }
 
-        $order    = "ORDER BY attempts ASC, scheduled_date_gmt ASC, action_id ASC LIMIT %d";
+        /**
+         * Sets the order-by clause used in the action claim query.
+         *
+         * @since x.x.x
+         *
+         * @param string $order_by_sql
+         */
+        $order    = apply_filters( 'action_scheduler_claim_actions_order_by', 'ORDER BY attempts ASC, scheduled_date_gmt ASC, action_id ASC' );
         $params[] = $limit;
 
-        $sql = $wpdb->prepare( "{$update} {$where} {$order}", $params );
-
-        $rows_affected = $wpdb->query( $sql );
-        if ( $rows_affected === false ) {
+        $sql           = $wpdb->prepare( "{$update} {$where} {$order} LIMIT %d", $params ); // phpcs:ignore WordPress.DB.PreparedSQL.InterpolatedNotPrepared, WordPress.DB.PreparedSQLPlaceholders
+        $rows_affected = $wpdb->query( $sql ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared, WordPress.DB.DirectDatabaseQuery.DirectQuery, WordPress.DB.DirectDatabaseQuery.NoCaching
+        if ( false === $rows_affected ) {
             throw new \RuntimeException( __( 'Unable to claim actions. Database error.', 'action-scheduler' ) );
         }
@@ -678 +696 @@
 
         $sql = "SELECT COUNT(DISTINCT claim_id) FROM {$wpdb->actionscheduler_actions} WHERE claim_id != 0 AND status IN ( %s, %s)";
-        $sql = $wpdb->prepare( $sql, [ self::STATUS_PENDING, self::STATUS_RUNNING ] );
-
-        return (int) $wpdb->get_var( $sql );
+        $sql = $wpdb->prepare( $sql, array( self::STATUS_PENDING, self::STATUS_RUNNING ) ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared
+
+        return (int) $wpdb->get_var( $sql ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared
     }
 
@@ -694 +712 @@
 
         $sql = "SELECT claim_id FROM {$wpdb->actionscheduler_actions} WHERE action_id=%d";
-        $sql = $wpdb->prepare( $sql, $action_id );
-
-        return (int) $wpdb->get_var( $sql );
+        $sql = $wpdb->prepare( $sql, $action_id ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared
+
+        return (int) $wpdb->get_var( $sql ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared
     }
 
@@ -702 +720 @@
      * Retrieve the action IDs of action in a claim.
      *
+     * @param  int $claim_id Claim ID.
      * @return int[]
      */
@@ -719 +738 @@
         // Verify that the scheduled date for each action is within the expected bounds (in some unusual
         // cases, we cannot depend on MySQL to honor all of the WHERE conditions we specify).
-        foreach ( $wpdb->get_results( $sql ) as $claimed_action ) {
+        foreach ( $wpdb->get_results( $sql ) as $claimed_action ) { // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared
             if ( $claimed_action->scheduled_date_gmt <= $cut_off ) {
                 $action_ids[] = absint( $claimed_action->action_id );
@@ -736 +755 @@
         /** @var \wpdb $wpdb */
         global $wpdb;
-        $wpdb->update( $wpdb->actionscheduler_actions, [ 'claim_id' => 0 ], [ 'claim_id' => $claim->get_id() ], [ '%d' ], [ '%d' ] );
-        $wpdb->delete( $wpdb->actionscheduler_claims, [ 'claim_id' => $claim->get_id() ], [ '%d' ] );
+        $wpdb->update( $wpdb->actionscheduler_actions, array( 'claim_id' => 0 ), array( 'claim_id' => $claim->get_id() ), array( '%d' ), array( '%d' ) );
+        $wpdb->delete( $wpdb->actionscheduler_claims, array( 'claim_id' => $claim->get_id() ), array( '%d' ) );
     }
 
@@ -752 +771 @@
         $wpdb->update(
             $wpdb->actionscheduler_actions,
-            [ 'claim_id' => 0 ],
-            [ 'action_id' => $action_id ],
-            [ '%s' ],
-            [ '%d' ]
+            array( 'claim_id' => 0 ),
+            array( 'action_id' => $action_id ),
+            array( '%s' ),
+            array( '%d' )
         );
     }
@@ -763 +782 @@
      *
      * @param int $action_id Action ID.
+     * @throws \InvalidArgumentException Throw an exception if action was not updated.
      */
     public function mark_failure( $action_id ) {
@@ -769 +789 @@
         $updated = $wpdb->update(
             $wpdb->actionscheduler_actions,
-            [ 'status' => self::STATUS_FAILED ],
-            [ 'action_id' => $action_id ],
-            [ '%s' ],
-            [ '%d' ]
+            array( 'status' => self::STATUS_FAILED ),
+            array( 'action_id' => $action_id ),
+            array( '%s' ),
+            array( '%d' )
         );
         if ( empty( $updated ) ) {
-            throw new \InvalidArgumentException( sprintf( __( 'Unidentified action %s', 'action-scheduler' ), $action_id ) );
+            throw new \InvalidArgumentException( sprintf( __( 'Unidentified action %s', 'action-scheduler' ), $action_id ) ); //phpcs:ignore WordPress.WP.I18n.MissingTranslatorsComment
         }
     }
@@ -791 +811 @@
 
         $sql = "UPDATE {$wpdb->actionscheduler_actions} SET attempts = attempts+1, status=%s, last_attempt_gmt = %s, last_attempt_local = %s WHERE action_id = %d";
-        $sql = $wpdb->prepare( $sql, self::STATUS_RUNNING, current_time( 'mysql', true ), current_time( 'mysql' ), $action_id );
-        $wpdb->query( $sql );
+        $sql = $wpdb->prepare( $sql, self::STATUS_RUNNING, current_time( 'mysql', true ), current_time( 'mysql' ), $action_id ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared
+        $wpdb->query( $sql ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared
     }
 
@@ -801 +821 @@
      *
      * @return void
+     * @throws \InvalidArgumentException Throw an exception if action was not updated.
      */
     public function mark_complete( $action_id ) {
@@ -807 +828 @@
         $updated = $wpdb->update(
             $wpdb->actionscheduler_actions,
-            [
+            array(
                 'status'             => self::STATUS_COMPLETE,
                 'last_attempt_gmt'   => current_time( 'mysql', true ),
                 'last_attempt_local' => current_time( 'mysql' ),
-            ],
-            [ 'action_id' => $action_id ],
-            [ '%s' ],
-            [ '%d' ]
+            ),
+            array( 'action_id' => $action_id ),
+            array( '%s' ),
+            array( '%d' )
         );
         if ( empty( $updated ) ) {
-            throw new \InvalidArgumentException( sprintf( __( 'Unidentified action %s', 'action-scheduler' ), $action_id ) );
+            throw new \InvalidArgumentException( sprintf( __( 'Unidentified action %s', 'action-scheduler' ), $action_id ) ); //phpcs:ignore WordPress.WP.I18n.MissingTranslatorsComment
         }
     }
@@ -827 +848 @@
      *
      * @return string
+     * @throws \InvalidArgumentException Throw an exception if not status was found for action_id.
+     * @throws \RuntimeException Throw an exception if action status could not be retrieved.
      */
     public function get_status( $action_id ) {
@@ -832 +855 @@
         global $wpdb;
         $sql    = "SELECT status FROM {$wpdb->actionscheduler_actions} WHERE action_id=%d";
-        $sql    = $wpdb->prepare( $sql, $action_id );
-        $status = $wpdb->get_var( $sql );
-
-        if ( $status === null ) {
+        $sql    = $wpdb->prepare( $sql, $action_id ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared
+        $status = $wpdb->get_var( $sql ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared
+
+        if ( null === $status ) {
             throw new \InvalidArgumentException( __( 'Invalid action ID. No status found.', 'action-scheduler' ) );
         } elseif ( empty( $status ) ) {

action-scheduler/trunk/classes/data-stores/ActionScheduler_wpPostStore.php

@@ -5 +5 @@
  */
 class ActionScheduler_wpPostStore extends ActionScheduler_Store {
-    const POST_TYPE = 'scheduled-action';
-    const GROUP_TAXONOMY = 'action-group';
+    const POST_TYPE         = 'scheduled-action';
+    const GROUP_TAXONOMY    = 'action-group';
     const SCHEDULE_META_KEY = '_action_manager_schedule';
-    const DEPENDENCIES_MET = 'as-post-store-dependencies-met';
+    const DEPENDENCIES_MET  = 'as-post-store-dependencies-met';
 
     /**
@@ -20 +20 @@
     private $claim_before_date = null;
 
-    /** @var DateTimeZone */
-    protected $local_timezone = NULL;
-
-    public function save_action( ActionScheduler_Action $action, DateTime $scheduled_date = NULL ){
+    /**
+     * Local Timezone.
+     *
+     * @var DateTimeZone
+     */
+    protected $local_timezone = null;
+
+    /**
+     * Save action.
+     *
+     * @param ActionScheduler_Action $action Scheduled Action.
+     * @param DateTime               $scheduled_date Scheduled Date.
+     *
+     * @throws RuntimeException Throws an exception if the action could not be saved.
+     * @return int
+     */
+    public function save_action( ActionScheduler_Action $action, DateTime $scheduled_date = null ) {
         try {
             $this->validate_action( $action );
             $post_array = $this->create_post_array( $action, $scheduled_date );
-            $post_id = $this->save_post_array( $post_array );
+            $post_id    = $this->save_post_array( $post_array );
             $this->save_post_schedule( $post_id, $action->get_schedule() );
             $this->save_action_group( $post_id, $action->get_group() );
@@ -33 +46 @@
             return $post_id;
         } catch ( Exception $e ) {
+            /* translators: %s: action error message */
             throw new RuntimeException( sprintf( __( 'Error saving action: %s', 'action-scheduler' ), $e->getMessage() ), 0 );
         }
     }
 
-    protected function create_post_array( ActionScheduler_Action $action, DateTime $scheduled_date = NULL ) {
+    /**
+     * Create post array.
+     *
+     * @param ActionScheduler_Action $action Scheduled Action.
+     * @param DateTime               $scheduled_date Scheduled Date.
+     *
+     * @return array Returns an array of post data.
+     */
+    protected function create_post_array( ActionScheduler_Action $action, DateTime $scheduled_date = null ) {
         $post = array(
-            'post_type' => self::POST_TYPE,
-            'post_title' => $action->get_hook(),
-            'post_content' => json_encode($action->get_args()),
-            'post_status' => ( $action->is_finished() ? 'publish' : 'pending' ),
+            'post_type'     => self::POST_TYPE,
+            'post_title'    => $action->get_hook(),
+            'post_content'  => wp_json_encode( $action->get_args() ),
+            'post_status'   => ( $action->is_finished() ? 'publish' : 'pending' ),
             'post_date_gmt' => $this->get_scheduled_date_string( $action, $scheduled_date ),
             'post_date'     => $this->get_scheduled_date_string_local( $action, $scheduled_date ),
@@ -49 +71 @@
     }
 
+    /**
+     * Save post array.
+     *
+     * @param array $post_array Post array.
+     * @return int Returns the post ID.
+     * @throws RuntimeException Throws an exception if the action could not be saved.
+     */
     protected function save_post_array( $post_array ) {
         add_filter( 'wp_insert_post_data', array( $this, 'filter_insert_post_data' ), 10, 1 );
@@ -60 +89 @@
         }
 
-        $post_id = wp_insert_post($post_array);
+        $post_id = wp_insert_post( $post_array );
 
         if ( $has_kses ) {
@@ -69 +98 @@
         remove_filter( 'pre_wp_unique_post_slug', array( $this, 'set_unique_post_slug' ), 10 );
 
-        if ( is_wp_error($post_id) || empty($post_id) ) {
+        if ( is_wp_error( $post_id ) || empty( $post_id ) ) {
             throw new RuntimeException( __( 'Unable to save action.', 'action-scheduler' ) );
         }
@@ -75 +104 @@
     }
 
+    /**
+     * Filter insert post data.
+     *
+     * @param array $postdata Post data to filter.
+     *
+     * @return array
+     */
     public function filter_insert_post_data( $postdata ) {
-        if ( $postdata['post_type'] == self::POST_TYPE ) {
+        if ( self::POST_TYPE === $postdata['post_type'] ) {
             $postdata['post_author'] = 0;
-            if ( $postdata['post_status'] == 'future' ) {
+            if ( 'future' === $postdata['post_status'] ) {
                 $postdata['post_status'] = 'publish';
             }
@@ -114 +150 @@
      */
     public function set_unique_post_slug( $override_slug, $slug, $post_ID, $post_status, $post_type ) {
-        if ( self::POST_TYPE == $post_type ) {
+        if ( self::POST_TYPE === $post_type ) {
             $override_slug = uniqid( self::POST_TYPE . '-', true ) . '-' . wp_generate_password( 32, false );
         }
@@ -120 +156 @@
     }
 
+    /**
+     * Save post schedule.
+     *
+     * @param int    $post_id  Post ID of the scheduled action.
+     * @param string $schedule Schedule to save.
+     *
+     * @return void
+     */
     protected function save_post_schedule( $post_id, $schedule ) {
         update_post_meta( $post_id, self::SCHEDULE_META_KEY, $schedule );
     }
 
+    /**
+     * Save action group.
+     *
+     * @param int    $post_id Post ID.
+     * @param string $group   Group to save.
+     * @return void
+     */
     protected function save_action_group( $post_id, $group ) {
-        if ( empty($group) ) {
-            wp_set_object_terms( $post_id, array(), self::GROUP_TAXONOMY, FALSE );
+        if ( empty( $group ) ) {
+            wp_set_object_terms( $post_id, array(), self::GROUP_TAXONOMY, false );
         } else {
-            wp_set_object_terms( $post_id, array($group), self::GROUP_TAXONOMY, FALSE );
-        }
-    }
-
+            wp_set_object_terms( $post_id, array( $group ), self::GROUP_TAXONOMY, false );
+        }
+    }
+
+    /**
+     * Fetch actions.
+     *
+     * @param int $action_id Action ID.
+     * @return object
+     */
     public function fetch_action( $action_id ) {
         $post = $this->get_post( $action_id );
-        if ( empty($post) || $post->post_type != self::POST_TYPE ) {
+        if ( empty( $post ) || self::POST_TYPE !== $post->post_type ) {
             return $this->get_null_action();
         }
@@ -148 +205 @@
     }
 
+    /**
+     * Get post.
+     *
+     * @param string $action_id - Action ID.
+     * @return WP_Post|null
+     */
     protected function get_post( $action_id ) {
-        if ( empty($action_id) ) {
-            return NULL;
-        }
-        return get_post($action_id);
-    }
-
+        if ( empty( $action_id ) ) {
+            return null;
+        }
+        return get_post( $action_id );
+    }
+
+    /**
+     * Get NULL action.
+     *
+     * @return ActionScheduler_NullAction
+     */
     protected function get_null_action() {
         return new ActionScheduler_NullAction();
     }
 
+    /**
+     * Make action from post.
+     *
+     * @param WP_Post $post Post object.
+     * @return WP_Post
+     */
     protected function make_action_from_post( $post ) {
         $hook = $post->post_title;
@@ -168 +242 @@
         $this->validate_schedule( $schedule, $post->ID );
 
-        $group = wp_get_object_terms( $post->ID, self::GROUP_TAXONOMY, array('fields' => 'names') );
-        $group = empty( $group ) ? '' : reset($group);
+        $group = wp_get_object_terms( $post->ID, self::GROUP_TAXONOMY, array( 'fields' => 'names' ) );
+        $group = empty( $group ) ? '' : reset( $group );
 
         return ActionScheduler::factory()->get_stored_action( $this->get_action_status_by_post_status( $post->post_status ), $hook, $args, $schedule, $group );
@@ -175 +249 @@
 
     /**
-     * @param string $post_status
-     *
-     * @throws InvalidArgumentException if $post_status not in known status fields returned by $this->get_status_labels()
+     * Get action status by post status.
+     *
+     * @param string $post_status Post status.
+     *
+     * @throws InvalidArgumentException Throw InvalidArgumentException if $post_status not in known status fields returned by $this->get_status_labels().
      * @return string
      */
@@ -183 +259 @@
 
         switch ( $post_status ) {
-            case 'publish' :
+            case 'publish':
                 $action_status = self::STATUS_COMPLETE;
                 break;
-            case 'trash' :
+            case 'trash':
                 $action_status = self::STATUS_CANCELED;
                 break;
-            default :
+            default:
                 if ( ! array_key_exists( $post_status, $this->get_status_labels() ) ) {
                     throw new InvalidArgumentException( sprintf( 'Invalid post status: "%s". No matching action status available.', $post_status ) );
@@ -201 +277 @@
 
     /**
-     * @param string $action_status
-     * @throws InvalidArgumentException if $post_status not in known status fields returned by $this->get_status_labels()
+     * Get post status by action status.
+     *
+     * @param string $action_status Action status.
+     *
+     * @throws InvalidArgumentException Throws InvalidArgumentException if $post_status not in known status fields returned by $this->get_status_labels().
      * @return string
      */
@@ -208 +287 @@
 
         switch ( $action_status ) {
-            case self::STATUS_COMPLETE :
+            case self::STATUS_COMPLETE:
                 $post_status = 'publish';
                 break;
-            case self::STATUS_CANCELED :
+            case self::STATUS_CANCELED:
                 $post_status = 'trash';
                 break;
-            default :
+            default:
                 if ( ! array_key_exists( $action_status, $this->get_status_labels() ) ) {
                     throw new InvalidArgumentException( sprintf( 'Invalid action status: "%s".', $action_status ) );
@@ -228 +307 @@
      * Returns the SQL statement to query (or count) actions.
      *
-     * @param array $query Filtering options
-     * @param string $select_or_count  Whether the SQL should select and return the IDs or just the row count
-     * @throws InvalidArgumentException if $select_or_count not count or select
+     * @param array  $query            - Filtering options.
+     * @param string $select_or_count  - Whether the SQL should select and return the IDs or just the row count.
+     *
+     * @throws InvalidArgumentException - Throw InvalidArgumentException if $select_or_count not count or select.
      * @return string SQL statement. The returned SQL is already properly escaped.
      */
     protected function get_query_actions_sql( array $query, $select_or_count = 'select' ) {
 
-        if ( ! in_array( $select_or_count, array( 'select', 'count' ) ) ) {
+        if ( ! in_array( $select_or_count, array( 'select', 'count' ), true ) ) {
             throw new InvalidArgumentException( __( 'Invalid schedule. Cannot save action.', 'action-scheduler' ) );
         }
 
-        $query = wp_parse_args( $query, array(
-            'hook' => '',
-            'args' => NULL,
-            'date' => NULL,
-            'date_compare' => '<=',
-            'modified' => NULL,
-            'modified_compare' => '<=',
-            'group' => '',
-            'status' => '',
-            'claimed' => NULL,
-            'per_page' => 5,
-            'offset' => 0,
-            'orderby' => 'date',
-            'order' => 'ASC',
-            'search' => '',
-        ) );
-
-        /** @var wpdb $wpdb */
+        $query = wp_parse_args(
+            $query,
+            array(
+                'hook'             => '',
+                'args'             => null,
+                'date'             => null,
+                'date_compare'     => '<=',
+                'modified'         => null,
+                'modified_compare' => '<=',
+                'group'            => '',
+                'status'           => '',
+                'claimed'          => null,
+                'per_page'         => 5,
+                'offset'           => 0,
+                'orderby'          => 'date',
+                'order'            => 'ASC',
+                'search'           => '',
+            )
+        );
+
+        /**
+         * Global wpdb object.
+         *
+         * @var wpdb $wpdb
+         */
         global $wpdb;
-        $sql  = ( 'count' === $select_or_count ) ? 'SELECT count(p.ID)' : 'SELECT p.ID ';
-        $sql .= "FROM {$wpdb->posts} p";
+        $sql        = ( 'count' === $select_or_count ) ? 'SELECT count(p.ID)' : 'SELECT p.ID ';
+        $sql       .= "FROM {$wpdb->posts} p";
         $sql_params = array();
         if ( empty( $query['group'] ) && 'group' === $query['orderby'] ) {
@@ -266 +353 @@
             $sql .= " LEFT JOIN {$wpdb->terms} t ON tt.term_id=t.term_id";
         } elseif ( ! empty( $query['group'] ) ) {
-            $sql .= " INNER JOIN {$wpdb->term_relationships} tr ON tr.object_id=p.ID";
-            $sql .= " INNER JOIN {$wpdb->term_taxonomy} tt ON tr.term_taxonomy_id=tt.term_taxonomy_id";
-            $sql .= " INNER JOIN {$wpdb->terms} t ON tt.term_id=t.term_id";
-            $sql .= " AND t.slug=%s";
+            $sql         .= " INNER JOIN {$wpdb->term_relationships} tr ON tr.object_id=p.ID";
+            $sql         .= " INNER JOIN {$wpdb->term_taxonomy} tt ON tr.term_taxonomy_id=tt.term_taxonomy_id";
+            $sql         .= " INNER JOIN {$wpdb->terms} t ON tt.term_id=t.term_id";
+            $sql         .= ' AND t.slug=%s';
             $sql_params[] = $query['group'];
         }
-        $sql .= " WHERE post_type=%s";
+        $sql         .= ' WHERE post_type=%s';
         $sql_params[] = self::POST_TYPE;
         if ( $query['hook'] ) {
-            $sql .= " AND p.post_title=%s";
+            $sql         .= ' AND p.post_title=%s';
             $sql_params[] = $query['hook'];
         }
-        if ( !is_null($query['args']) ) {
-            $sql .= " AND p.post_content=%s";
-            $sql_params[] = json_encode($query['args']);
+        if ( ! is_null( $query['args'] ) ) {
+            $sql         .= ' AND p.post_content=%s';
+            $sql_params[] = wp_json_encode( $query['args'] );
         }
 
@@ -292 +379 @@
         if ( $query['date'] instanceof DateTime ) {
             $date = clone $query['date'];
-            $date->setTimezone( new DateTimeZone('UTC') );
-            $date_string = $date->format('Y-m-d H:i:s');
-            $comparator = $this->validate_sql_comparator($query['date_compare']);
-            $sql .= " AND p.post_date_gmt $comparator %s";
+            $date->setTimezone( new DateTimeZone( 'UTC' ) );
+            $date_string  = $date->format( 'Y-m-d H:i:s' );
+            $comparator   = $this->validate_sql_comparator( $query['date_compare'] );
+            $sql         .= " AND p.post_date_gmt $comparator %s";
             $sql_params[] = $date_string;
         }
@@ -301 +388 @@
         if ( $query['modified'] instanceof DateTime ) {
             $modified = clone $query['modified'];
-            $modified->setTimezone( new DateTimeZone('UTC') );
-            $date_string = $modified->format('Y-m-d H:i:s');
-            $comparator = $this->validate_sql_comparator($query['modified_compare']);
-            $sql .= " AND p.post_modified_gmt $comparator %s";
+            $modified->setTimezone( new DateTimeZone( 'UTC' ) );
+            $date_string  = $modified->format( 'Y-m-d H:i:s' );
+            $comparator   = $this->validate_sql_comparator( $query['modified_compare'] );
+            $sql         .= " AND p.post_modified_gmt $comparator %s";
             $sql_params[] = $date_string;
         }
 
-        if ( $query['claimed'] === TRUE ) {
+        if ( true === $query['claimed'] ) {
             $sql .= " AND p.post_password != ''";
-        } elseif ( $query['claimed'] === FALSE ) {
+        } elseif ( false === $query['claimed'] ) {
             $sql .= " AND p.post_password = ''";
-        } elseif ( !is_null($query['claimed']) ) {
-            $sql .= " AND p.post_password = %s";
+        } elseif ( ! is_null( $query['claimed'] ) ) {
+            $sql         .= ' AND p.post_password = %s';
             $sql_params[] = $query['claimed'];
         }
 
         if ( ! empty( $query['search'] ) ) {
-            $sql .= " AND (p.post_title LIKE %s OR p.post_content LIKE %s OR p.post_password LIKE %s)";
-            for( $i = 0; $i < 3; $i++ ) {
+            $sql .= ' AND (p.post_title LIKE %s OR p.post_content LIKE %s OR p.post_password LIKE %s)';
+            for ( $i = 0; $i < 3; $i++ ) {
                 $sql_params[] = sprintf( '%%%s%%', $query['search'] );
             }
@@ -354 +441 @@
             $sql .= " ORDER BY $orderby $order";
             if ( $query['per_page'] > 0 ) {
-                $sql .= " LIMIT %d, %d";
+                $sql         .= ' LIMIT %d, %d';
                 $sql_params[] = $query['offset'];
                 $sql_params[] = $query['per_page'];
@@ -360 +447 @@
         }
 
-        return $wpdb->prepare( $sql, $sql_params );
+        return $wpdb->prepare( $sql, $sql_params ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared
     }
 
@@ -376 +463 @@
      */
     public function query_actions( $query = array(), $query_type = 'select' ) {
-        /** @var wpdb $wpdb */
+        /**
+         * Global $wpdb object.
+         *
+         * @var wpdb $wpdb
+         */
         global $wpdb;
 
         $sql = $this->get_query_actions_sql( $query, $query_type );
 
-        return ( 'count' === $query_type ) ? $wpdb->get_var( $sql ) : $wpdb->get_col( $sql );
+        return ( 'count' === $query_type ) ? $wpdb->get_var( $sql ) : $wpdb->get_col( $sql ); // phpcs:ignore WordPress.DB.DirectDatabaseQuery.DirectQuery,WordPress.DB.DirectDatabaseQuery.NoCaching,WordPress.DB.PreparedSQL.NotPrepared
     }
 
@@ -400 +491 @@
                 $action_status_name = $this->get_action_status_by_post_status( $post_status_name );
             } catch ( Exception $e ) {
-                // Ignore any post statuses that aren't for actions
+                // Ignore any post statuses that aren't for actions.
                 continue;
             }
@@ -412 +503 @@
 
     /**
-     * @param string $action_id
-     *
-     * @throws InvalidArgumentException
+     * Cancel action.
+     *
+     * @param int $action_id Action ID.
+     *
+     * @throws InvalidArgumentException If $action_id is not identified.
      */
     public function cancel_action( $action_id ) {
         $post = get_post( $action_id );
-        if ( empty( $post ) || ( $post->post_type != self::POST_TYPE ) ) {
+        if ( empty( $post ) || ( self::POST_TYPE !== $post->post_type ) ) {
+            /* translators: %s is the action ID */
             throw new InvalidArgumentException( sprintf( __( 'Unidentified action %s', 'action-scheduler' ), $action_id ) );
         }
@@ -427 +521 @@
     }
 
+    /**
+     * Delete action.
+     *
+     * @param int $action_id Action ID.
+     * @return void
+     * @throws InvalidArgumentException If action is not identified.
+     */
     public function delete_action( $action_id ) {
         $post = get_post( $action_id );
-        if ( empty( $post ) || ( $post->post_type != self::POST_TYPE ) ) {
+        if ( empty( $post ) || ( self::POST_TYPE !== $post->post_type ) ) {
+            /* translators: %s is the action ID */
             throw new InvalidArgumentException( sprintf( __( 'Unidentified action %s', 'action-scheduler' ), $action_id ) );
         }
         do_action( 'action_scheduler_deleted_action', $action_id );
 
-        wp_delete_post( $action_id, TRUE );
-    }
-
-    /**
-     * @param string $action_id
-     *
-     * @throws InvalidArgumentException
+        wp_delete_post( $action_id, true );
+    }
+
+    /**
+     * Get date for claim id.
+     *
+     * @param int $action_id Action ID.
      * @return ActionScheduler_DateTime The date the action is schedule to run, or the date that it ran.
      */
@@ -449 +551 @@
 
     /**
-     * @param string $action_id
-     *
-     * @throws InvalidArgumentException
+     * Get Date GMT.
+     *
+     * @param int $action_id Action ID.
+     *
+     * @throws InvalidArgumentException If $action_id is not identified.
      * @return ActionScheduler_DateTime The date the action is schedule to run, or the date that it ran.
      */
     public function get_date_gmt( $action_id ) {
         $post = get_post( $action_id );
-        if ( empty( $post ) || ( $post->post_type != self::POST_TYPE ) ) {
+        if ( empty( $post ) || ( self::POST_TYPE !== $post->post_type ) ) {
+            /* translators: %s is the action ID */
             throw new InvalidArgumentException( sprintf( __( 'Unidentified action %s', 'action-scheduler' ), $action_id ) );
         }
-        if ( $post->post_status == 'publish' ) {
+        if ( 'publish' === $post->post_status ) {
             return as_get_datetime_object( $post->post_modified_gmt );
         } else {
@@ -467 +572 @@
 
     /**
-     * @param int      $max_actions
+     * Stake claim.
+     *
+     * @param int      $max_actions Maximum number of actions.
      * @param DateTime $before_date Jobs must be schedule before this date. Defaults to now.
      * @param array    $hooks       Claim only actions with a hook or hooks.
@@ -478 +585 @@
     public function stake_claim( $max_actions = 10, DateTime $before_date = null, $hooks = array(), $group = '' ) {
         $this->claim_before_date = $before_date;
-        $claim_id = $this->generate_claim_id();
+        $claim_id                = $this->generate_claim_id();
         $this->claim_actions( $claim_id, $max_actions, $before_date, $hooks, $group );
-        $action_ids = $this->find_actions_by_claim_id( $claim_id );
+        $action_ids              = $this->find_actions_by_claim_id( $claim_id );
         $this->claim_before_date = null;
 
@@ -487 +594 @@
 
     /**
+     * Get claim count.
+     *
      * @return int
      */
-    public function get_claim_count(){
+    public function get_claim_count() {
         global $wpdb;
 
-        $sql = "SELECT COUNT(DISTINCT post_password) FROM {$wpdb->posts} WHERE post_password != '' AND post_type = %s AND post_status IN ('in-progress','pending')";
-        $sql = $wpdb->prepare( $sql, array( self::POST_TYPE ) );
-
-        return $wpdb->get_var( $sql );
-    }
-
+        // phpcs:ignore WordPress.DB.DirectDatabaseQuery.DirectQuery,WordPress.DB.DirectDatabaseQuery.NoCaching
+        return $wpdb->get_var(
+            $wpdb->prepare(
+                "SELECT COUNT(DISTINCT post_password) FROM {$wpdb->posts} WHERE post_password != '' AND post_type = %s AND post_status IN ('in-progress','pending')",
+                array( self::POST_TYPE )
+            )
+        );
+    }
+
+    /**
+     * Generate claim id.
+     *
+     * @return string
+     */
     protected function generate_claim_id() {
-        $claim_id = md5(microtime(true) . rand(0,1000));
-        return substr($claim_id, 0, 20); // to fit in db field with 20 char limit
-    }
-
-    /**
-     * @param string   $claim_id
-     * @param int      $limit
+        $claim_id = md5( microtime( true ) . wp_rand( 0, 1000 ) );
+        return substr( $claim_id, 0, 20 ); // to fit in db field with 20 char limit.
+    }
+
+    /**
+     * Claim actions.
+     *
+     * @param string   $claim_id    Claim ID.
+     * @param int      $limit       Limit.
      * @param DateTime $before_date Should use UTC timezone.
      * @param array    $hooks       Claim only actions with a hook or hooks.
      * @param string   $group       Claim only actions in the given group.
      *
-     * @return int The number of actions that were claimed
-     * @throws RuntimeException When there is a database error.
-     * @throws InvalidArgumentException When the group is invalid.
+     * @return int The number of actions that were claimed.
+     * @throws RuntimeException  When there is a database error.
      */
     protected function claim_actions( $claim_id, $limit, DateTime $before_date = null, $hooks = array(), $group = '' ) {
@@ -525 +643 @@
         }
 
-        /** @var wpdb $wpdb */
+        /**
+         * Global wpdb object.
+         *
+         * @var wpdb $wpdb
+         */
         global $wpdb;
 
@@ -560 +682 @@
             $where .= ' AND ID IN (' . join( ',', $ids ) . ')';
         } else {
-            $where .= ' AND post_date_gmt <= %s';
+            $where   .= ' AND post_date_gmt <= %s';
             $params[] = $date->format( 'Y-m-d H:i:s' );
         }
@@ -569 +691 @@
 
         // Run the query and gather results.
-        $rows_affected = $wpdb->query( $wpdb->prepare( "{$update} {$where} {$order}", $params ) );
-        if ( $rows_affected === false ) {
+        $rows_affected = $wpdb->query( $wpdb->prepare( "{$update} {$where} {$order}", $params ) ); // phpcs:ignore // phpcs:ignore WordPress.DB.PreparedSQL.InterpolatedNotPrepared, WordPress.DB.PreparedSQLPlaceholders.UnfinishedPrepare
+
+        if ( false === $rows_affected ) {
             throw new RuntimeException( __( 'Unable to claim actions. Database error.', 'action-scheduler' ) );
         }
@@ -590 +713 @@
     protected function get_actions_by_group( $group, $limit, DateTime $date ) {
         // Ensure the group exists before continuing.
-        if ( ! term_exists( $group, self::GROUP_TAXONOMY )) {
+        if ( ! term_exists( $group, self::GROUP_TAXONOMY ) ) {
+            /* translators: %s is the group name */
             throw new InvalidArgumentException( sprintf( __( 'The group "%s" does not exist.', 'action-scheduler' ), $group ) );
         }
@@ -610 +734 @@
             ),
             'date_query'       => array(
-                'column' => 'post_date_gmt',
-                'before' => $date->format( 'Y-m-d H:i' ),
+                'column'    => 'post_date_gmt',
+                'before'    => $date->format( 'Y-m-d H:i' ),
                 'inclusive' => true,
             ),
-            'tax_query' => array(
+            'tax_query'        => array( // phpcs:ignore WordPress.DB.SlowDBQuery
                 array(
                     'taxonomy'         => self::GROUP_TAXONOMY,
@@ -628 +752 @@
 
     /**
-     * @param string $claim_id
+     * Find actions by claim ID.
+     *
+     * @param string $claim_id Claim ID.
      * @return array
      */
     public function find_actions_by_claim_id( $claim_id ) {
-        /** @var wpdb $wpdb */
+        /**
+         * Global wpdb object.
+         *
+         * @var wpdb $wpdb
+         */
         global $wpdb;
-
-        $sql = "SELECT ID, post_date_gmt FROM {$wpdb->posts} WHERE post_type = %s AND post_password = %s";
-        $sql = $wpdb->prepare( $sql, array( self::POST_TYPE, $claim_id ) );
 
         $action_ids  = array();
@@ -642 +769 @@
         $cut_off     = $before_date->format( 'Y-m-d H:i:s' );
 
+        // phpcs:ignore WordPress.DB.DirectDatabaseQuery.DirectQuery, WordPress.DB.DirectDatabaseQuery.NoCaching
+        $results = $wpdb->get_results(
+            $wpdb->prepare(
+                "SELECT ID, post_date_gmt FROM {$wpdb->posts} WHERE post_type = %s AND post_password = %s",
+                array(
+                    self::POST_TYPE,
+                    $claim_id,
+                )
+            )
+        );
+
         // Verify that the scheduled date for each action is within the expected bounds (in some unusual
         // cases, we cannot depend on MySQL to honor all of the WHERE conditions we specify).
-        foreach ( $wpdb->get_results( $sql ) as $claimed_action ) {
+        foreach ( $results as $claimed_action ) {
             if ( $claimed_action->post_date_gmt <= $cut_off ) {
                 $action_ids[] = absint( $claimed_action->ID );
@@ -653 +791 @@
     }
 
+    /**
+     * Release claim.
+     *
+     * @param ActionScheduler_ActionClaim $claim Claim object to release.
+     * @return void
+     * @throws RuntimeException When the claim is not unlocked.
+     */
     public function release_claim( ActionScheduler_ActionClaim $claim ) {
         $action_ids = $this->find_actions_by_claim_id( $claim->get_id() );
         if ( empty( $action_ids ) ) {
-            return; // nothing to do
+            return; // nothing to do.
         }
         $action_id_string = implode( ',', array_map( 'intval', $action_ids ) );
-        /** @var wpdb $wpdb */
+        /**
+         * Global wpdb object.
+         *
+         * @var wpdb $wpdb
+         */
         global $wpdb;
-        $sql = "UPDATE {$wpdb->posts} SET post_password = '' WHERE ID IN ($action_id_string) AND post_password = %s";
-        $sql = $wpdb->prepare( $sql, array( $claim->get_id() ) );
-        $result = $wpdb->query( $sql );
-        if ( $result === false ) {
+
+        // phpcs:ignore WordPress.DB.DirectDatabaseQuery.DirectQuery, WordPress.DB.DirectDatabaseQuery.NoCaching
+        $result = $wpdb->query(
+            $wpdb->prepare(
+                "UPDATE {$wpdb->posts} SET post_password = '' WHERE ID IN ($action_id_string) AND post_password = %s", //phpcs:ignore
+                array(
+                    $claim->get_id(),
+                )
+            )
+        );
+        if ( false === $result ) {
             /* translators: %s: claim ID */
             throw new RuntimeException( sprintf( __( 'Unable to unlock claim %s. Database error.', 'action-scheduler' ), $claim->get_id() ) );
@@ -671 +827 @@
 
     /**
-     * @param string $action_id
+     * Unclaim action.
+     *
+     * @param string $action_id Action ID.
+     * @throws RuntimeException When unable to unlock claim on action ID.
      */
     public function unclaim_action( $action_id ) {
-        /** @var wpdb $wpdb */
+        /**
+         * Global wpdb object.
+         *
+         * @var wpdb $wpdb
+         */
         global $wpdb;
-        $sql = "UPDATE {$wpdb->posts} SET post_password = '' WHERE ID = %d AND post_type = %s";
-        $sql = $wpdb->prepare( $sql, $action_id, self::POST_TYPE );
-        $result = $wpdb->query( $sql );
-        if ( $result === false ) {
+
+        //phpcs:ignore WordPress.DB.DirectDatabaseQuery.DirectQuery, WordPress.DB.DirectDatabaseQuery.NoCaching
+        $result = $wpdb->query(
+            $wpdb->prepare(
+                "UPDATE {$wpdb->posts} SET post_password = '' WHERE ID = %d AND post_type = %s",
+                $action_id,
+                self::POST_TYPE
+            )
+        );
+        if ( false === $result ) {
             /* translators: %s: action ID */
             throw new RuntimeException( sprintf( __( 'Unable to unlock claim on action %s. Database error.', 'action-scheduler' ), $action_id ) );
@@ -685 +854 @@
     }
 
+    /**
+     * Mark failure on action.
+     *
+     * @param int $action_id Action ID.
+     *
+     * @return void
+     * @throws RuntimeException When unable to mark failure on action ID.
+     */
     public function mark_failure( $action_id ) {
-        /** @var wpdb $wpdb */
+        /**
+         * Global wpdb object.
+         *
+         * @var wpdb $wpdb
+         */
         global $wpdb;
-        $sql = "UPDATE {$wpdb->posts} SET post_status = %s WHERE ID = %d AND post_type = %s";
-        $sql = $wpdb->prepare( $sql, self::STATUS_FAILED, $action_id, self::POST_TYPE );
-        $result = $wpdb->query( $sql );
-        if ( $result === false ) {
+
+        // phpcs:ignore WordPress.DB.DirectDatabaseQuery.DirectQuery, WordPress.DB.DirectDatabaseQuery.NoCaching
+        $result = $wpdb->query(
+            $wpdb->prepare( "UPDATE {$wpdb->posts} SET post_status = %s WHERE ID = %d AND post_type = %s", self::STATUS_FAILED, $action_id, self::POST_TYPE )
+        );
+        if ( false === $result ) {
             /* translators: %s: action ID */
             throw new RuntimeException( sprintf( __( 'Unable to mark failure on action %s. Database error.', 'action-scheduler' ), $action_id ) );
@@ -700 +883 @@
      * Return an action's claim ID, as stored in the post password column
      *
-     * @param string $action_id
+     * @param int $action_id Action ID.
      * @return mixed
      */
@@ -710 +893 @@
      * Return an action's status, as stored in the post status column
      *
-     * @param string $action_id
+     * @param int $action_id Action ID.
+     *
      * @return mixed
+     * @throws InvalidArgumentException When the action ID is invalid.
      */
     public function get_status( $action_id ) {
         $status = $this->get_post_column( $action_id, 'post_status' );
 
-        if ( $status === null ) {
+        if ( null === $status ) {
             throw new InvalidArgumentException( __( 'Invalid action ID. No status found.', 'action-scheduler' ) );
         }
@@ -723 +908 @@
     }
 
+    /**
+     * Get post column
+     *
+     * @param string $action_id Action ID.
+     * @param string $column_name Column Name.
+     *
+     * @return string|null
+     */
     private function get_post_column( $action_id, $column_name ) {
-        /** @var \wpdb $wpdb */
+        /**
+         * Global wpdb object.
+         *
+         * @var wpdb $wpdb
+         */
         global $wpdb;
-        return $wpdb->get_var( $wpdb->prepare( "SELECT {$column_name} FROM {$wpdb->posts} WHERE ID=%d AND post_type=%s", $action_id, self::POST_TYPE ) );
-    }
-
-    /**
-     * @param string $action_id
+
+        // phpcs:ignore WordPress.DB.DirectDatabaseQuery.DirectQuery, WordPress.DB.DirectDatabaseQuery.NoCaching
+        return $wpdb->get_var(
+            $wpdb->prepare(
+                "SELECT {$column_name} FROM {$wpdb->posts} WHERE ID=%d AND post_type=%s", // phpcs:ignore
+                $action_id,
+                self::POST_TYPE
+            )
+        );
+    }
+
+    /**
+     * Log Execution.
+     *
+     * @param string $action_id Action ID.
      */
     public function log_execution( $action_id ) {
-        /** @var wpdb $wpdb */
+        /**
+         * Global wpdb object.
+         *
+         * @var wpdb $wpdb
+         */
         global $wpdb;
 
-        $sql = "UPDATE {$wpdb->posts} SET menu_order = menu_order+1, post_status=%s, post_modified_gmt = %s, post_modified = %s WHERE ID = %d AND post_type = %s";
-        $sql = $wpdb->prepare( $sql, self::STATUS_RUNNING, current_time('mysql', true), current_time('mysql'), $action_id, self::POST_TYPE );
-        $wpdb->query($sql);
+        // phpcs:ignore WordPress.DB.DirectDatabaseQuery.DirectQuery, WordPress.DB.DirectDatabaseQuery.NoCaching
+        $wpdb->query(
+            $wpdb->prepare(
+                "UPDATE {$wpdb->posts} SET menu_order = menu_order+1, post_status=%s, post_modified_gmt = %s, post_modified = %s WHERE ID = %d AND post_type = %s",
+                self::STATUS_RUNNING,
+                current_time( 'mysql', true ),
+                current_time( 'mysql' ),
+                $action_id,
+                self::POST_TYPE
+            )
+        );
     }
 
@@ -744 +963 @@
      * Record that an action was completed.
      *
-     * @param int $action_id ID of the completed action.
-     * @throws InvalidArgumentException|RuntimeException
+     * @param string $action_id ID of the completed action.
+     *
+     * @throws InvalidArgumentException When the action ID is invalid.
+     * @throws RuntimeException         When there was an error executing the action.
      */
     public function mark_complete( $action_id ) {
         $post = get_post( $action_id );
-        if ( empty( $post ) || ( $post->post_type != self::POST_TYPE ) ) {
+        if ( empty( $post ) || ( self::POST_TYPE !== $post->post_type ) ) {
+            /* translators: %s is the action ID */
             throw new InvalidArgumentException( sprintf( __( 'Unidentified action %s', 'action-scheduler' ), $action_id ) );
         }
         add_filter( 'wp_insert_post_data', array( $this, 'filter_insert_post_data' ), 10, 1 );
         add_filter( 'pre_wp_unique_post_slug', array( $this, 'set_unique_post_slug' ), 10, 5 );
-        $result = wp_update_post(array(
-            'ID' => $action_id,
-            'post_status' => 'publish',
-        ), TRUE);
+        $result = wp_update_post(
+            array(
+                'ID'          => $action_id,
+                'post_status' => 'publish',
+            ),
+            true
+        );
         remove_filter( 'wp_insert_post_data', array( $this, 'filter_insert_post_data' ), 10 );
         remove_filter( 'pre_wp_unique_post_slug', array( $this, 'set_unique_post_slug' ), 10 );
@@ -774 +999 @@
             array(
                 'ID'          => $action_id,
-                'post_status' => 'migrated'
+                'post_status' => 'migrated',
             )
         );
@@ -782 +1007 @@
      * Determine whether the post store can be migrated.
      *
+     * @param [type] $setting - Setting value.
      * @return bool
      */
@@ -790 +1016 @@
         if ( empty( $dependencies_met ) ) {
             $maximum_args_length = apply_filters( 'action_scheduler_maximum_args_length', 191 );
-            $found_action        = $wpdb->get_var(
+            $found_action        = $wpdb->get_var( // phpcs:ignore WordPress.DB.DirectDatabaseQuery.DirectQuery, WordPress.DB.DirectDatabaseQuery.NoCaching
                 $wpdb->prepare(
                     "SELECT ID FROM {$wpdb->posts} WHERE post_type = %s AND CHAR_LENGTH(post_content) > %d LIMIT 1",
@@ -797 +1023 @@
                 )
             );
-            $dependencies_met = $found_action ? 'no' : 'yes';
+            $dependencies_met    = $found_action ? 'no' : 'yes';
             set_transient( self::DEPENDENCIES_MET, $dependencies_met, DAY_IN_SECONDS );
         }
 
-        return 'yes' == $dependencies_met ? $setting : false;
+        return 'yes' === $dependencies_met ? $setting : false;
     }
 
@@ -811 +1037 @@
      * developers of this impending requirement.
      *
-     * @param ActionScheduler_Action $action
+     * @param ActionScheduler_Action $action Action object.
      */
     protected function validate_action( ActionScheduler_Action $action ) {
@@ -817 +1043 @@
             parent::validate_action( $action );
         } catch ( Exception $e ) {
+            /* translators: %s is the error message */
             $message = sprintf( __( '%s Support for strings longer than this will be removed in a future version.', 'action-scheduler' ), $e->getMessage() );
-            _doing_it_wrong( 'ActionScheduler_Action::$args', $message, '2.1.0' );
-        }
-    }
-
-    /**
-     * @codeCoverageIgnore
+            _doing_it_wrong( 'ActionScheduler_Action::$args', esc_html( $message ), '2.1.0' );
+        }
+    }
+
+    /**
+     * (@codeCoverageIgnore)
      */
     public function init() {

action-scheduler/trunk/classes/schema/ActionScheduler_StoreSchema.php

@@ -17 +17 @@
      * @var int Increment this value to trigger a schema update.
      */
-    protected $schema_version = 5;
+    protected $schema_version = 6;
 
     public function __construct() {
@@ -65 +65 @@
                         KEY group_id (group_id),
                         KEY last_attempt_gmt (last_attempt_gmt),
-                        KEY claim_id (claim_id),
                         KEY `claim_id_status_scheduled_date_gmt` (`claim_id`, `status`, `scheduled_date_gmt`)
                         ) $charset_collate";

action-scheduler/trunk/deprecated/ActionScheduler_Schedule_Deprecated.php

@@ -10 +10 @@
      * after a given date & time.
      *
-     * @param DateTime $after
+     * @param DateTime $after DateTime to calculate against.
      *
      * @return DateTime|null
      */
-    public function next( DateTime $after = NULL ) {
+    public function next( DateTime $after = null ) {
         if ( empty( $after ) ) {
             $return_value       = $this->get_date();
@@ -23 +23 @@
         }
 
-        _deprecated_function( __METHOD__, '3.0.0', __CLASS__ . '::' . $replacement_method );
+        _deprecated_function( __METHOD__, '3.0.0', __CLASS__ . '::' . $replacement_method ); // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
 
         return $return_value;

action-scheduler/trunk/readme.txt

@@ -4 +4 @@
 Requires at least: 5.2
 Tested up to: 5.7
-Stable tag: 3.3.0
+Stable tag: 3.4.0
 License: GPLv3
 Requires PHP: 5.6
@@ -48 +48 @@
 == Changelog ==
 
+= 3.4.0 - 2021-10-29 =
+* Enhancement - Number of items per page can now be set for the Scheduled Actions view (props @ovidiul). #771
+* Fix - Do not lower the max_execution_time if it is already set to 0 (unlimited) (props @barryhughes). #755
+* Fix - Avoid triggering autoloaders during the version resolution process (props @olegabr). #731 & #776
+* Dev - ActionScheduler_wcSystemStatus PHPCS fixes (props @ovidiul). #761
+* Dev - ActionScheduler_DBLogger.php PHPCS fixes (props @ovidiul). #768
+* Dev - Fixed phpcs for ActionScheduler_Schedule_Deprecated (props @ovidiul). #762
+* Dev - Improve actions table indicies (props @glagonikas). #774 & #777
+* Dev - PHPCS fixes for ActionScheduler_DBStore.php (props @ovidiul). #769 & #778
+* Dev - PHPCS Fixes for ActionScheduler_Abstract_ListTable (props @ovidiul). #763 & #779
+* Dev - Adds new filter action_scheduler_claim_actions_order_by to allow tuning of the claim query (props @glagonikas). #773
+* Dev - PHPCS fixes for ActionScheduler_WpPostStore class (props @ovidiul). #780
+
 = 3.3.0 - 2021-09-15 =
 * Enhancement - Adds as_has_scheduled_action() to provide a performant way to test for existing actions. #645