Changeset 2619356

Timestamp:

10/25/2021 11:01:22 AM (4 years ago)

Author:

mahype

Message:

Update to version 1.0.16 from GitHub

Location:

torro-forms

Files:

• tags/1.0.16 (copied) (copied from torro-forms/trunk)
• tags/1.0.16/assets/src/languages/torro-forms.pot (modified) (1 diff)
• tags/1.0.16/readme.txt (modified) (2 diffs)
• tags/1.0.16/src/modules/access-controls/user-identification.php (modified) (1 diff)
• tags/1.0.16/src/modules/form-settings/module.php (modified) (1 diff)
• tags/1.0.16/torro-forms.php (modified) (1 diff)
• trunk/assets/src/languages/torro-forms.pot (modified) (1 diff)
• trunk/readme.txt (modified) (2 diffs)
• trunk/src/modules/access-controls/user-identification.php (modified) (1 diff)
• trunk/src/modules/form-settings/module.php (modified) (1 diff)
• trunk/torro-forms.php (modified) (1 diff)

torro-forms/tags/1.0.16/assets/src/languages/torro-forms.pot

@@ -2531 +2531 @@
 msgid ""
 "This text appears on top of a form and shows the user which fields are "
-"required. The value has to cotain a %s to output the correct indicator."
+"required. The value has to contain a %s to output the correct indicator."
 msgstr ""
 

torro-forms/tags/1.0.16/readme.txt

@@ -9 +9 @@
 Tested up to:      5.8.1
 Requires PHP:      5.6
-Stable tag:        1.0.15
-Version:           1.0.15
+Stable tag:        1.0.16
+Version:           1.0.16
 License:           GNU General Public License v2 (or later)
 License URI:       http://www.gnu.org/licenses/gpl-2.0.html
@@ -84 +84 @@
 == Changelog ==
 
-= 1.0.14 =
-* Enhanced: Fixed deployent issue.
+= 1.0.16 =
+* Fixed: Logical error in 'can_access' function. Thanks to reedsutliff!
+
+= 1.0.15 =
+* Fixed: Deployment issue.
 
 = 1.0.14 =

torro-forms/tags/1.0.16/src/modules/access-controls/user-identification.php

@@ -55 +55 @@
         if ( $this->get_form_option( $form->id, 'prevent_edit_others_submission', true ) && $submission ) {
             $others_submission_error = new WP_Error( 'others_submission', __( 'You do not have access to this form submission.', 'torro-forms' ) );
-
-            if ( is_user_logged_in() && ! empty( $submission->user_id ) && get_current_user_id() !== $submission->user_id ) {
-                return $others_submission_error;
-            }
-
+            
             $skip_further_checks = false;
-            if ( ! empty( $submission->user_key ) ) {
+            if ( is_user_logged_in() && ! empty( $submission->user_id )) {
+                if(get_current_user_id() !== $submission->user_id ) {
+                    return $others_submission_error;
+                } else {
+                    $skip_further_checks = true;    
+                }
+            }
+
+            if ( ! $skip_further_checks && ! empty( $submission->user_key ) ) {
                 if ( filter_has_var( INPUT_COOKIE, 'torro_identity' ) ) {
                     if ( esc_attr( filter_input( INPUT_COOKIE, 'torro_identity' ) ) !== $submission->user_key ) {

torro-forms/tags/1.0.16/src/modules/form-settings/module.php

@@ -83 +83 @@
                 'type'         => 'text',
                 'label'        => __( 'Required fields text', 'torro-forms' ),
-                'description'  => __( 'This text appears on top of a form and shows the user which fields are required. The value has to cotain a %s to output the correct indicator.', 'torro-forms' ), //phpcs:ignore WordPress.WP.I18n.MissingTranslatorsComment
+                'description'  => __( 'This text appears on top of a form and shows the user which fields are required. The value has to contain a %s to output the correct indicator.', 'torro-forms' ), //phpcs:ignore WordPress.WP.I18n.MissingTranslatorsComment
                 'default'      => $this->get_default_required_fields_text(),
                 'wrap_classes' => array( 'has-torro-tooltip-description' ),

torro-forms/tags/1.0.16/torro-forms.php

@@ -10 +10 @@
  * Plugin URI:  https://torro-forms.com
  * Description: Torro Forms is an extendable WordPress form builder with Drag & Drop functionality, chart evaluation and more - with WordPress look and feel.
- * Version:     1.0.15
+ * Version:     1.0.16
  * Author:      Awesome UG
  * Author URI:  https://www.awesome.ug

torro-forms/trunk/assets/src/languages/torro-forms.pot

@@ -2531 +2531 @@
 msgid ""
 "This text appears on top of a form and shows the user which fields are "
-"required. The value has to cotain a %s to output the correct indicator."
+"required. The value has to contain a %s to output the correct indicator."
 msgstr ""
 

torro-forms/trunk/readme.txt

@@ -9 +9 @@
 Tested up to:      5.8.1
 Requires PHP:      5.6
-Stable tag:        1.0.15
-Version:           1.0.15
+Stable tag:        1.0.16
+Version:           1.0.16
 License:           GNU General Public License v2 (or later)
 License URI:       http://www.gnu.org/licenses/gpl-2.0.html
@@ -84 +84 @@
 == Changelog ==
 
-= 1.0.14 =
-* Enhanced: Fixed deployent issue.
+= 1.0.16 =
+* Fixed: Logical error in 'can_access' function. Thanks to reedsutliff!
+
+= 1.0.15 =
+* Fixed: Deployment issue.
 
 = 1.0.14 =

torro-forms/trunk/src/modules/access-controls/user-identification.php

@@ -55 +55 @@
         if ( $this->get_form_option( $form->id, 'prevent_edit_others_submission', true ) && $submission ) {
             $others_submission_error = new WP_Error( 'others_submission', __( 'You do not have access to this form submission.', 'torro-forms' ) );
-
-            if ( is_user_logged_in() && ! empty( $submission->user_id ) && get_current_user_id() !== $submission->user_id ) {
-                return $others_submission_error;
-            }
-
+            
             $skip_further_checks = false;
-            if ( ! empty( $submission->user_key ) ) {
+            if ( is_user_logged_in() && ! empty( $submission->user_id )) {
+                if(get_current_user_id() !== $submission->user_id ) {
+                    return $others_submission_error;
+                } else {
+                    $skip_further_checks = true;    
+                }
+            }
+
+            if ( ! $skip_further_checks && ! empty( $submission->user_key ) ) {
                 if ( filter_has_var( INPUT_COOKIE, 'torro_identity' ) ) {
                     if ( esc_attr( filter_input( INPUT_COOKIE, 'torro_identity' ) ) !== $submission->user_key ) {

torro-forms/trunk/src/modules/form-settings/module.php

@@ -83 +83 @@
                 'type'         => 'text',
                 'label'        => __( 'Required fields text', 'torro-forms' ),
-                'description'  => __( 'This text appears on top of a form and shows the user which fields are required. The value has to cotain a %s to output the correct indicator.', 'torro-forms' ), //phpcs:ignore WordPress.WP.I18n.MissingTranslatorsComment
+                'description'  => __( 'This text appears on top of a form and shows the user which fields are required. The value has to contain a %s to output the correct indicator.', 'torro-forms' ), //phpcs:ignore WordPress.WP.I18n.MissingTranslatorsComment
                 'default'      => $this->get_default_required_fields_text(),
                 'wrap_classes' => array( 'has-torro-tooltip-description' ),

torro-forms/trunk/torro-forms.php

@@ -10 +10 @@
  * Plugin URI:  https://torro-forms.com
  * Description: Torro Forms is an extendable WordPress form builder with Drag & Drop functionality, chart evaluation and more - with WordPress look and feel.
- * Version:     1.0.15
+ * Version:     1.0.16
  * Author:      Awesome UG
  * Author URI:  https://www.awesome.ug