Changeset 2578858

Timestamp:

08/05/2021 03:34:46 PM (4 years ago)

Author:

claygriffiths

Message:

Update to version 3.1.24 from GitHub

Location:

gravity-forms-custom-post-types

Files:

• tags/3.1.24 (copied) (copied from gravity-forms-custom-post-types/trunk)
• tags/3.1.24/gfcptaddon.php (modified) (2 diffs)
• tags/3.1.24/gfcptaddonbase.php (modified) (1 diff)
• tags/3.1.24/readme.txt (modified) (1 diff)
• trunk/gfcptaddon.php (modified) (2 diffs)
• trunk/gfcptaddonbase.php (modified) (1 diff)
• trunk/readme.txt (modified) (1 diff)

gravity-forms-custom-post-types/tags/3.1.24/gfcptaddon.php

@@ -4 +4 @@
 Plugin URI: https://gravitywiz.com/
 Description: Map your Gravity-Forms-generated posts to a custom post type and/or custom taxonomies.
-Version: 3.1.23
+Version: 3.1.24
 Author: Gravity Wiz
 Author URI: https://gravitywiz.com/
@@ -17 +17 @@
     private static $name                     = 'Gravity Forms + Custom Post Types';
     private static $slug                     = 'GFCPTAddon';
-    private static $version                  = '3.1.23';
+    private static $version                  = '3.1.24';
     private static $min_gravityforms_version = '1.9.3';
 

gravity-forms-custom-post-types/tags/3.1.24/gfcptaddonbase.php

@@ -372 +372 @@
             }
 
+            // Choices check is not sufficient in cases where choices were accidentally saved to non-choice fields.
+            if ( ! in_array( $field->get_input_type(), array( 'select', 'multiselect', 'radio', 'checkbox' ), true ) ) {
+                // This clears any choices stored on non-choice based fields due to an earlier bug in GF+CPT. See HS#25737
+                $field['choices'] = '';
+                return;
+            }
+
             $first_choice             = rgars( $field, 'choices/0/text' );
             $field['choices']         = $this->load_taxonomy_choices( $taxonomy, $field['type'], $first_choice, $field );

gravity-forms-custom-post-types/tags/3.1.24/readme.txt

@@ -81 +81 @@
 
 == Changelog ==
+
+= 3.1.24 =
+* Fixed an issue where taxonomy terms may be saved as choices on non-choice based fields.
 
 = 3.1.23 =

gravity-forms-custom-post-types/trunk/gfcptaddon.php

@@ -4 +4 @@
 Plugin URI: https://gravitywiz.com/
 Description: Map your Gravity-Forms-generated posts to a custom post type and/or custom taxonomies.
-Version: 3.1.23
+Version: 3.1.24
 Author: Gravity Wiz
 Author URI: https://gravitywiz.com/
@@ -17 +17 @@
     private static $name                     = 'Gravity Forms + Custom Post Types';
     private static $slug                     = 'GFCPTAddon';
-    private static $version                  = '3.1.23';
+    private static $version                  = '3.1.24';
     private static $min_gravityforms_version = '1.9.3';
 

gravity-forms-custom-post-types/trunk/gfcptaddonbase.php

@@ -372 +372 @@
             }
 
+            // Choices check is not sufficient in cases where choices were accidentally saved to non-choice fields.
+            if ( ! in_array( $field->get_input_type(), array( 'select', 'multiselect', 'radio', 'checkbox' ), true ) ) {
+                // This clears any choices stored on non-choice based fields due to an earlier bug in GF+CPT. See HS#25737
+                $field['choices'] = '';
+                return;
+            }
+
             $first_choice             = rgars( $field, 'choices/0/text' );
             $field['choices']         = $this->load_taxonomy_choices( $taxonomy, $field['type'], $first_choice, $field );

gravity-forms-custom-post-types/trunk/readme.txt

@@ -81 +81 @@
 
 == Changelog ==
+
+= 3.1.24 =
+* Fixed an issue where taxonomy terms may be saved as choices on non-choice based fields.
 
 = 3.1.23 =