Changeset 2529515

Timestamp:

05/11/2021 07:22:31 AM (4 years ago)

Author:

lukasznowicki

Message:

Added one qualifier, changed user capabilities to constants

File:

• postpage-specific-custom-css/tags/0.2.2/post-page-specific-custom-css.php (modified) (9 diffs)

postpage-specific-custom-css/tags/0.2.2/post-page-specific-custom-css.php

@@ -16 +16 @@
 namespace Phylax\WPPlugin\PPCustomCSS;
 
+use WP_Post;
 use const DOING_AUTOSAVE;
 
@@ -42 +43 @@
 
     const NONCE_HIDE_BIRTHDAY = 'ppscc_hide_birthday';
+
+    const CAP_MANAGE_OPTIONS = 'manage_options';
+    const CAP_EDIT_OTHERS_PAGES = 'edit_others_pages';
 
     private $isBirthday = false;
@@ -545 +549 @@
 
     public function current_user_already_seen_message(): bool {
-        if ( ! current_user_can( 'manage_options' ) ) {
+        if ( ! current_user_can( self::CAP_MANAGE_OPTIONS ) ) {
             // Always return true for non-administrators
             return true;
@@ -612 +616 @@
 
     public function add_options_page() {
-        $sub_menu_suffix = add_submenu_page( self::PARENT_MENU_SLUG, __( 'Post/Page specific custom CSS', 'postpage-specific-custom-css' ), __( 'Post/Page CSS', 'postpage-specific-custom-css' ), 'manage_options', self::MENU_SLUG, [
+        $sub_menu_suffix = add_submenu_page( self::PARENT_MENU_SLUG, __( 'Post/Page specific custom CSS', 'postpage-specific-custom-css' ), __( 'Post/Page CSS', 'postpage-specific-custom-css' ), self::CAP_MANAGE_OPTIONS, self::MENU_SLUG, [
             $this,
             'options_page_view',
@@ -675 +679 @@
             return $content;
         }
-        /** @var \WP_Post $post */
+        /** @var WP_Post $post */
         $phylax_ppsccss_single_only = get_post_meta( $post->ID, self::POST_META_SINGLE, true );
         $phylax_ppsccss_css         = get_post_meta( $post->ID, self::POST_META_CSS, true );
@@ -722 +726 @@
     }
 
-    public function allowedToView() {
+    public function allowedToView(): bool {
         $settings      = (array) get_option( self::OPTION_NAME );
         $allow_editors = (bool) ( $settings[ self::OPT_CONTROL_USER_EDITOR ] ?? 0 );
         if (
-            current_user_can( 'manage_options' ) ||
+            current_user_can( self::CAP_MANAGE_OPTIONS ) ||
             (
                 $allow_editors &&
-                current_user_can( 'edit_others_pages' )
+                current_user_can( self::CAP_EDIT_OTHERS_PAGES )
             )
         ) {
@@ -881 +885 @@
     public function init() {
         load_plugin_textdomain( 'postpage-specific-custom-css', false, dirname( plugin_basename( __FILE__ ) ) . '/languages/' );
-        if ( current_user_can( 'manage_options' ) ) {
+        if ( current_user_can( self::CAP_MANAGE_OPTIONS ) ) {
             $ppscc_birthday = (string) ( get_user_meta( get_current_user_id(), 'ppscc_birthday', true ) ?? '' );
             if ( 'hide' === $ppscc_birthday ) {
@@ -894 +898 @@
                     exit;
                 }
-                if ( ! current_user_can( 'manage_options' ) ) {
+                if ( ! current_user_can( self::CAP_MANAGE_OPTIONS ) ) {
                     exit;
                 }
@@ -905 +909 @@
 
     public function update_user_meta() {
-        if ( ! current_user_can( 'manage_options' ) ) {
+        if ( ! current_user_can( self::CAP_MANAGE_OPTIONS ) ) {
             return;
         }