Changeset 2426919

Timestamp:

11/26/2020 09:40:27 PM (5 years ago)

Author:

springthistle

Message:

Updated code, fixed a bunch of PHP compatibility errors, tested with WP 5.6

Location:

aprils-call-posts

Files:

• _originals (added)
• _originals/banner-772x250.psd (added)
• _originals/icon-128x128.psd (added)
• assets (added)
• assets/banner-772x250.png (added)
• assets/icon-128x128.png (added)
• trunk/ahs_callposts.php (modified) (1 diff)
• trunk/ahs_callposts_admin.php (modified) (11 diffs)
• trunk/ahscpstyle.css (modified) (3 diffs)
• trunk/readme.txt (modified) (2 diffs)

aprils-call-posts/trunk/ahs_callposts.php

@@ -4 +4 @@
 Plugin URI: http://springthistle.com/wordpress/plugin_callposts
 Description: Via shortcode, lets you call in a list of posts that are filtered, displayed and ordered based on criteria you provide. <a href="options-general.php?page=ahs_callposts_admin.php">Edit Settings</a>.
-Version: 2.0.14
+Version: 2.1
 Author: Aaron Hodge Silver
 Author URI: http://springthistle.com/
 License: GPL2
 
-    Copyright 2011  Aaron Hodge Silver  (email : ahs@springthistle.com)
+    Copyright 2011  Aaron Hodge Silver  (email : aaron@springthistle.com)
 
     This program is free software; you can redistribute it and/or modify

aprils-call-posts/trunk/ahs_callposts_admin.php

@@ -7 +7 @@
     array("name" => "Title Style",
         "id" => "ahscp_titletype",
+        'type' => 'text',
         'size'=>50,
         'std'=>'h3',
@@ -19 +20 @@
     array("name" => "Date Format",
         "id" => "ahscp_dateformat",
+        'type' => 'text',
+        'std'=>'',
         'size'=>100,
         'help'=>'If you enter a date format here, it will be used to insert the post date for all posts on the site. You can override this default setting in any individual use of the shortcode by including the option <code>dateformat</code> and setting it to a different format or to empty.<br />A nice default is <code>F j</code>. See PHP.net\'s <a href="http://php.net/manual/en/function.date.php" target="_blank">Date Formatting Instructions</a> for more.'),
@@ -30 +33 @@
     array("name" => "Styling",
         "id" => "ahscp_css",
+        'std'=>'',
         'type'=>'textarea',
         'help'=>'When you first install this plugin, this box will have the default css that I put in, mostly to style the 2-column and sidebox options. You can edit this css easily here.'),
@@ -35 +39 @@
     array("name" => "Custom Field",
         "id" => "ahscp_customfield",
+        'type' => 'text',
+        'std'=>'',
         'size'=>150,
         'help'=>'The shortcode automatically orders posts by most-recent-first. If you\'d like them to be ordered by a custom field, enter the name of the custom field here. You can override this default setting in any individual use of the shortcode by including the option <code>custom_field</code>. If you set a custom_field value here, but want it to NOT impact a particular shortcode instances, set its value to <code>false</code>.'),
@@ -99 +105 @@
 
     // add hidden field to store last-used tab
-    $ahscp_options[] = array('id'=>'ahscp_activetab','type'=>'hidden','divclass'=>'hidden','std'=>2);
-
-    if ( $_GET['page'] == basename(__FILE__) ) {
-        if ( 'save' == $_REQUEST['action'] ) {
+    $ahscp_options[] = array('id'=>'ahscp_activetab', 'name'=>'activetab', 'type'=>'hidden','divclass'=>'hidden','std'=>2);
+
+    if ( isset($_GET['page']) && $_GET['page'] == basename(__FILE__) ) {
+        if ( isset($_REQUEST['action']) && 'save' == $_REQUEST['action'] ) {
                 foreach ($ahscp_options as $value) {
                     update_option( $value['id'], $_REQUEST[ $value['id'] ] ); }
@@ -109 +115 @@
                 header("Location: options-general.php?page=".basename(__FILE__)."&saved=true");
                 die;
-        } else if ( 'reset' == $_REQUEST['action'] ) {
+        } else if ( isset($_REQUEST['action']) && 'reset' == $_REQUEST['action'] ) {
             foreach ($ahscp_options as $value) delete_option( $value['id'] );
             header("Location: options-general.php?page=".basename(__FILE__)."&reset=true");
@@ -115 +121 @@
         }
     }
-    add_submenu_page('options-general.php', 'April\'s Call Posts', 'April\'s Call Posts', 8, basename(__FILE__), 'ahscp_adminpage');
+    add_submenu_page('options-general.php', 'April\'s Call Posts', 'April\'s Call Posts', 'edit_theme_options', basename(__FILE__), 'ahscp_adminpage');
 }
 
 function ahscp_adminpage() {
     global $ahscp_options;
-    if ( $_REQUEST['saved'] ) $msg = '<div class="updated" style="width: 785px;"><p>Call Posts settings saved.</p></div>';
-    if ( $_REQUEST['reset'] ) $msg = '<div class="updated" style="width: 785px;"><p>Call Posts ssettings reset.</p></div>';
+    if ( isset($_REQUEST['saved']) && $_REQUEST['saved'] ) $msg = '<div class="updated" style="width: 785px;"><p>Call Posts settings saved.</p></div>';
+    if ( isset($_REQUEST['reset']) && $_REQUEST['reset'] ) $msg = '<div class="updated" style="width: 785px;"><p>Call Posts settings reset.</p></div>';
 ?>
 <div class="wrap ahscp" id="backtotop" style="width: 800px;">
@@ -148 +154 @@
         $tabs[$numtabs] = $value['name'];
     }
+    if (!isset($cards[$numtabs])) $cards[$numtabs] = '';
     $cards[$numtabs] .= '<h'.$matches[1].'>'.$value['name'].'</h'.$matches[1].'>';
     if (!empty($value['help'])) $cards[$numtabs] .=  $value['help'];
@@ -165 +172 @@
                 $cards[$numtabs] .= '<option value="'.$optid.'" ';
                 if (get_option($value['id']) == $optid) $cards[$numtabs] .= ' selected="selected"';
-                elseif ($option == $value['std']) $cards[$numtabs] .= ' selected="selected"';
+                elseif (isset($value['std']) && $option == $value['std']) $cards[$numtabs] .= ' selected="selected"';
                 $cards[$numtabs] .= '>'.$option.'</option>';
             }
@@ -218 +225 @@
 </div><!--/ tabs -->
 
-<p class="submit">
-    <input name="save" type="submit" value="Save changes on all tabs" />
+<div style="float:right;">
+    <input name="save" type="submit" class="button button-primary" value="Save changes on all tabs" />
     <input type="hidden" name="action" value="save" />
-</p>
+</div>
 </form>
-<form method="post">
-    <p class="submit" style="float:right;">
-        <input name="reset" type="submit" value="<?php _e('Delete all Data and Reset to Default Settings'); ?>" />
-        <input type="hidden" name="action" value="reset" />
-    </p>
+<form method="post" style="float:left;">
+    <input name="reset" type="submit" class="button" value="<?php _e('Delete all Data and Reset to Default Settings'); ?>" />
+    <input type="hidden" name="action" value="reset" />
 </form>
 
@@ -234 +239 @@
     $('#tabs div.card').hide();
     <?php
-        if ($_REQUEST['saved']) {
+        if (isset($_REQUEST['saved']) && $_REQUEST['saved']) {
             $tmp = get_option('ahscp_activetab');
         }

aprils-call-posts/trunk/ahscpstyle.css

@@ -33 +33 @@
     padding: 7px 10px;
     color: #666;
-    font-family: Georgia;
     font-size: 16px;
 }
@@ -59 +58 @@
     font-size:20px;
     margin-top: 0;
-    color:#A66540;
+    color:#a6866b;
     font-weight:normal;
     clear: both;
@@ -66 +65 @@
     margin-bottom:5px;
     font-size:14px;
-    color:#A66540;
+    color:#a6866b;
     clear: both;
     border-top: 2px solid #ddd;

aprils-call-posts/trunk/readme.txt

@@ -2 +2 @@
 Contributors: springthistle
 Tags: posts, shortcode
-Requires at least: 2.9.1
-Tested up to: 4.9.x
-Stable tag: 2.0.14
+Requires at least: 5.0
+Tested up to: 5.6.x
+Stable tag: 2.1
 
 Via shortcode, lets you call in a list of posts that are filtered, ordered, and displayed based on criteria you provide.
@@ -40 +40 @@
 
 == Changelog ==
+
+= 2.1 =
+* Cleaned up code, updated to be compatible with latest PHP and WordPress
+* Updated compatibility version.
 
 = 2.0.14 =