Changeset 2141308

Timestamp:

08/18/2019 06:41:32 AM (7 years ago)

Author:

ndhaddon

Message:

MP3 download fix and basic security fixes

Location:

better-file-download/trunk

Files:

• README.txt (modified) (3 diffs)
• better-file-download.php (modified) (1 diff)
• public/partials/better-file-download-public-box-display.php (modified) (3 diffs)
• public/partials/better-file-download-public-taxonomy-box-display.php (modified) (1 diff)

better-file-download/trunk/README.txt

@@ -4 +4 @@
 Tags: better file download, file download, downloads, download manager, file upload, file types, file management, publications, albums
 Requires at least: 4.7
-Tested up to: 5.1
+Tested up to: 5.2
 Requires PHP: 5.3
-Stable tag: 1.0.8
+Stable tag: 1.0.10
 License: GPLv2 or later
 License URI: http://www.gnu.org/licenses/gpl-2.0.html
@@ -134 +134 @@
 * Added default ordering to category downloads and fixed an issue with forcing the download to open in a new tab.
 
+= 1.0.10 =
+* Fixed an issue with MP3 files not downloading. Basic security updates.
+
 
  == Upgrade Notice ==
@@ -166 +169 @@
 = 1.0.9 =
 * Added default ordering to category downloads and fixed an issue with forcing the download to open in a new tab.
+
+= 1.0.10 =
+* Fixed an issue with MP3 files not downloading. Basic security updates.

better-file-download/trunk/better-file-download.php

@@ -18 +18 @@
  * Description:        Better File Download allows you to offer various file types for your users to download, track the popularity of your files and present them in a highly configurable way. For detailed instructions and configuration options, please visit the settings link or the Download Settings link in the side bar.
  *
- * Version:           1.0.9
+ * Version:           1.0.10
  * Author:            Nik Haddon
  * Author URI:        https://nikhaddon.com

better-file-download/trunk/public/partials/better-file-download-public-box-display.php

@@ -35 +35 @@
             {
                 ?>
-                <a href="<?php echo get_permalink( $bfd_args['id'] ); ?>" title="<?php echo esc_attr( $bfd_title ); ?>" class="bfd-svg-container bfd-single-download-btn" target="_blank" >
+                <a download href="<?php echo get_permalink( $bfd_args['id'] ); ?>" title="<?php echo esc_attr( $bfd_title ); ?>" class="bfd-svg-container bfd-single-download-btn" target="_blank" >
                     <svg xmlns="http://www.w3.org/2000/svg" width="28" height="30" viewBox="0 0 28 30" version="1.1"><g stroke="none" stroke-width="1" fill="none" fill-rule="evenodd"><g transform="translate(-6.000000, -5.000000)" fill="currentColor"><path d="M26.7 21.7L21.7 21.7 21.7 5 18.3 5 18.3 21.7 13.3 21.7 20 28.3 26.7 21.7 26.7 21.7ZM6.7 31.7L6.7 35 33.3 35 33.3 31.7 6.7 31.7 6.7 31.7Z"/></g></g></svg>
                 </a>
@@ -43 +43 @@
             {
                 ?>
-                <a href="<?php echo get_permalink( $bfd_args['id'] ); ?>" title="<?php echo esc_attr( $bfd_title ); ?>" class="bfd-svg-container bfd-single-download-btn" download>
+                <a download href="<?php echo get_permalink( $bfd_args['id'] ); ?>" title="<?php echo esc_attr( $bfd_title ); ?>" class="bfd-svg-container bfd-single-download-btn" download>
                     <svg xmlns="http://www.w3.org/2000/svg" width="28" height="30" viewBox="0 0 28 30" version="1.1"><g stroke="none" stroke-width="1" fill="none" fill-rule="evenodd"><g transform="translate(-6.000000, -5.000000)" fill="currentColor"><path d="M26.7 21.7L21.7 21.7 21.7 5 18.3 5 18.3 21.7 13.3 21.7 20 28.3 26.7 21.7 26.7 21.7ZM6.7 31.7L6.7 35 33.3 35 33.3 31.7 6.7 31.7 6.7 31.7Z"/></g></g></svg>
                 </a>
@@ -51 +51 @@
          </div>
          <div class="bfd-column">
-            <a href="<?php echo get_permalink( $bfd_args['id'] ); ?>" title="<?php echo esc_attr( $bfd_title ); ?>" class="bfd-download-meta" <?php echo (! empty( $bfd_options['bfd-force-new-tab'] ) ? 'target="_blank"' : 'download' )  ?> >
+            <a download href="<?php echo get_permalink( $bfd_args['id'] ); ?>" title="<?php echo esc_attr( $bfd_title ); ?>" class="bfd-download-meta" <?php echo (! empty( $bfd_options['bfd-force-new-tab'] ) ? 'target="_blank"' : 'download' )  ?> >
                 <p class="bfd-download-title"><strong><?php _e( $bfd_download->post_title); ?></strong></p>
                 <?php

better-file-download/trunk/public/partials/better-file-download-public-taxonomy-box-display.php

@@ -79 +79 @@
                 $bfd_format .= '<div class="bfd-column">';
                 if ( ! empty( $bfd_options['bfd-force-new-tab'] )) {
-                    $bfd_format .= '<a href="%1$s" title="%2$s" class="post-%3$s bfd-download-meta" target="_blank">';
+                    $bfd_format .= '<a download href="%1$s" title="%2$s" class="post-%3$s bfd-download-meta" target="_blank">';
                 }
                 else
                 {
-                    $bfd_format .= '<a href="%1$s" title="%2$s" class="post-%3$s bfd-download-meta" download>';
+                    $bfd_format .= '<a download href="%1$s" title="%2$s" class="post-%3$s bfd-download-meta" download>';
                 }
                 // $bfd_format .= '<a href="%1$s" title="%2$s" class="post-%3$s bfd-download-meta">';