Changeset 1695358

Timestamp:

07/12/2017 06:05:22 PM (8 years ago)

Author:

ebinnion

Message:

Fix undefined event and improve theme compatibility by removing nn-overlay divs

Location:

net-neutrality/trunk

Files:

• net-neutrality.js (modified) (2 diffs)
• net-neutrality.php (modified) (2 diffs)
• readme.txt (modified) (2 diffs)

net-neutrality/trunk/net-neutrality.js

@@ -37 +37 @@
 
         nnLoading.on( 'click', '.nn-overlay', function () {
-            var thisOverlay = $ ( this );
-            nnOverlay = $( '#net-neutrality-overlay' );
-            nnOverlay.show().css( 'opacity', '1' )
+            var thisOverlay = $ ( this ),
+                nnOverlay = $( '.nn-overlay' ),
+                nnOverlayWrap = $( '#net-neutrality-overlay' );
+
+            nnOverlayWrap.show().css( 'opacity', '1' );
             $( '#net-neutrality-overlay-action' ).focus();
 
@@ -46 +48 @@
             } );
 
-            nnOverlay.on( 'click', function() {
+            nnOverlayWrap.on( 'click', function() {
                 $( '.post' ).removeClass( 'nn-loading' );
                 thisOverlay.remove();
-                $( this ).hide().css( 'opacity', '0' );
+                nnOverlay.hide().css( 'opacity', '0' ).remove();
+                nnOverlayWrap.hide().css( 'opacity', '0' );
                 $( '#net-neutrality-ribbon' ).show().css( 'opacity', '1' );
             } );
 
-            $( '#net-neutrality-overlay-close' ).on( 'click', function() {
+            $( '#net-neutrality-overlay-close' ).on( 'click', function( event ) {
                 event.preventDefault();
                 $( '.post' ).removeClass( 'nn-loading' );
                 thisOverlay.remove();
-                nnOverlay.hide().css( 'opacity', '0' );
+                nnOverlay.hide().css( 'opacity', '0' ).remove();
+                nnOverlayWrap.hide().css( 'opacity', '0' );
                 $( '#net-neutrality-ribbon' ).show().css( 'opacity', '1' );
             } );

net-neutrality/trunk/net-neutrality.php

@@ -5 +5 @@
  * Description: Slow your site down to fight for net neutrality.
  * Author: Automattic
- * Version: 1.0.1
+ * Version: 1.0.2
  * Author URI: http://wordpress.com
  * License: GPL2+
@@ -113 +113 @@
 
         wp_enqueue_style( 'net-neutrality', plugins_url( 'net-neutrality.css', __FILE__ ), array(), '20140904' );
-        wp_register_script( 'net-neutrality-js', plugins_url( 'net-neutrality.js', __FILE__ ), array( 'jquery' ), '20140904' );
+        wp_register_script( 'net-neutrality-js', plugins_url( 'net-neutrality.js', __FILE__ ), array( 'jquery' ), '20170712-2' );
         wp_localize_script( 'net-neutrality-js', 'netNeutrality', array(
             'strings' => array(

net-neutrality/trunk/readme.txt

@@ -2 +2 @@
 Contributors: automattic, pesieminski, Joen, ebinnion, michaelarestad
 Tags: net neutrality
-Stable tag: 1.0.1
+Stable tag: 1.0.2
 Requires at least: 4.6
 Tested up to: 4.8
@@ -14 +14 @@
 == Changelog ==
 
+= 1.0.2
+- Fix an issue with undefined event in latest Firefox
+- Improve compatibility with darker themes by fully removing overlay divs
+
 = 1.0.1 =