WordPress.org
Get WordPress

Plugin Directory

Changeset 1656822


Ignore:
Timestamp:
05/13/2017 11:21:39 PM (9 years ago)
Author:
WPDevHQ
Message:

Fixes Notice reported here: ​https://wordpress.org/support/topic/errors-with-wordpress-4-7-4/

Location:
tables-for-elementor
Files:
34 added
1 deleted
4 edited

Legend:

Unmodified
Added
Removed

  • tables-for-elementor/trunk/elementor-tables.php

    r1641546 r1656822  
    55 * Plugin URI: https://wordpress.org/plugins/tables-for-elementor
    66 * Author: WPDevHQ
    7  * Version: 1.0.0
     7 * Version: 1.0.1
    88 * Author URI: https://wpdevhq.com/
    99 *
    … …  
    1313if ( ! defined( 'ABSPATH' ) ) exit; // Exit if accessed directly
    1414
    15 define( 'ELEMENTOR_TABLES_VERSION', '1.0.0' );
     15define( 'ELEMENTOR_TABLES_VERSION', '1.0.1' );
    1616
    1717define( 'ELEMENTOR_TABLES__FILE__', __FILE__ );

  • tables-for-elementor/trunk/modules/tables/widgets/table-standard.php

    r1641546 r1656822  
    4242            'column_1_title',
    4343            [
    44                 'label' => __( 'First Option Title', 'elementor-tables' ),
     44                'label' => __( 'First Title Settings', 'elementor-tables' ),
    4545            ]
    4646        );
    … …  
    6060            [
    6161                'label' => __( 'Title Margins', 'elementor' ),
    62                 'description' => __( 'Use this option to adjust the margins if you have removed the CTA button.', 'vividi' ),
     62                'description' => __( 'Use this option to adjust the margins if you have removed the CTA button.', 'elementor-tables' ),
    6363                'type' => Controls_Manager::DIMENSIONS,
    6464                'size_units' => [ 'px', 'em', '%' ],
    … …  
    8080
    8181        $this->add_control(
    82             'view',
     82            'title_view',
    8383            [
    8484                'label' => __( 'View', 'elementor-tables' ),
    … …  
    9393            'option_1_button',
    9494            [
    95                 'label' => __( 'Option 1 Button', 'elementor-tables' ),
     95                'label' => __( 'CTA Button 1 Options', 'elementor-tables' ),
    9696            ]
    9797        );
    … …  
    100100            'enable_button1',
    101101            [
    102                 'label' => __( 'Enable CTA Button 1', 'vividi' ),
     102                'label' => __( 'Enable CTA Button 1', 'elementor-tables' ),
    103103                'type' => Controls_Manager::SWITCHER,
    104104                'default' => 'yes',
    … …  
    107107                'label_off' => 'No',
    108108                'return_value' => 'yes',
    109                 'description' => __( 'You can show/hide the CTA button for this option.', 'vividi' ),               
     109                'description' => __( 'You can show/hide the CTA button for this option.', 'elementor-tables' ),             
    110110            ]
    111111        );
    … …  
    129129                'label' => __( 'Link', 'elementor-tables' ),
    130130                'type' => Controls_Manager::URL,
     131                'condition' => [
     132                    'enable_button1' => 'yes',
     133                ],
    131134                'placeholder' => 'http://your-link.com',
    132135                'default' => [
    … …  
    182185            'column_2_title',
    183186            [
    184                 'label' => __( 'Second Option Title', 'elementor-tables' ),
     187                'label' => __( 'Second Title Settings', 'elementor-tables' ),
    185188            ]
    186189        );
    … …  
    200203            [
    201204                'label' => __( 'Title Margins', 'elementor' ),
    202                 'description' => __( 'Use this option to adjust the margins if you have removed the CTA button.', 'vividi' ),
     205                'description' => __( 'Use this option to adjust the margins if you have removed the CTA button.', 'elementor-tables' ),
    203206                'type' => Controls_Manager::DIMENSIONS,
    204207                'size_units' => [ 'px', 'em', '%' ],
    … …  
    220223
    221224        $this->add_control(
    222             'view',
     225            'title2_view',
    223226            [
    224227                'label' => __( 'View', 'elementor-tables' ),
    … …  
    233236            'option_2_button',
    234237            [
    235                 'label' => __( 'Option 2 Button', 'elementor-tables' ),
     238                'label' => __( 'CTA Button 2 Options', 'elementor-tables' ),
    236239            ]
    237240        );
    … …  
    240243            'enable_button2',
    241244            [
    242                 'label' => __( 'Enable CTA Button 2', 'vividi' ),
     245                'label' => __( 'Enable CTA Button 2', 'elementor-tables' ),
    243246                'type' => Controls_Manager::SWITCHER,
    244247                'default' => 'yes',
    … …  
    247250                'label_off' => 'No',
    248251                'return_value' => 'yes',
    249                 'description' => __( 'You can show/hide the CTA button for this option.', 'vividi' ),
     252                'description' => __( 'You can show/hide the CTA button for this option.', 'elementor-tables' ),
    250253               
    251254            ]
    … …  
    771774                <?php echo $title1; ?>
    772775            </h3>
    773             <?php if ( $settings['enable_button1'] == 'yes' ) : ?>
     776            <?php if ( $settings['enable_button1'] == 'yes' && ! empty( $settings['button1_cta'] ) ) : ?>
    774777                <a href="<?php echo $btn1_url; ?>" target="<?php echo $btn1_target; ?>" class="btn">
    775778                    <?php echo $button1; ?>
    … …  
    781784                <?php echo $title2; ?>
    782785            </h3>
    783             <?php if ( $settings['enable_button2'] == 'yes' ) : ?>
     786            <?php if ( $settings['enable_button2'] == 'yes' && ! empty( $settings['button2_cta'] ) ) : ?>
    784787                <a href="<?php echo $btn2_url; ?>" target="<?php echo $btn2_target; ?>" class="btn">
    785788                    <?php echo $button2; ?>

  • tables-for-elementor/trunk/plugin.php

    r1641546 r1656822  
    7272    private function _includes() {
    7373        require ELEMENTOR_TABLES_PATH . 'includes/modules-manager.php';
    74 
    75         if ( is_admin() ) {
    76             require ELEMENTOR_TABLES_PATH . 'includes/admin.php';
    77         }
    7874    }
    7975
    … …  
    189185
    190186        $this->add_actions();
    191 
    192         if ( is_admin() ) {
    193             new Admin();
    194             //new License\Admin();
    195         }
    196187    }
    197188}

  • tables-for-elementor/trunk/readme.txt

    r1641742 r1656822  
    55Tags: elementor, pagebuilder, page builder, page builder table, page builder tables, WordPress tables, table builder, builder tables   
    66Requires at least: 4.4 
    7 Tested up to: 4.7.3 
    8 Stable tag: 1.0.0 
     7Tested up to: 4.7.4 
     8Stable tag: 1.0.1 
    99License: GPLv3 
    1010License URI: https://www.gnu.org/licenses/gpl-3.0.html   
    … …  
    2727== Frequently Asked Questions ==     
    2828
    29 Non Yet!
     29**I've turned the CTA buttons off but they still show**
     30
     31While in Elementor edit mode you may need to refresh the page for the changes to take effect!
     32
     33**OK, after a refresh the buttons are gone but now I'm left with a bit of empty space(s)! How can I remove these?**
     34
     35Switch to one of the Title Settings tabs i.e. First Title Settings and set the Title Margins to 0 or as desired!
    3036
    3137== Screenshots ==
    … …  
    35412. Frontend basic comparison table   
    3642
    37 == Changelog ==     
     43== Changelog == 
     44
     45= 1.0.1 =   
     46* Fixed: Bug that generated "Notice: Elementor\Controls_Manager::add_control_to_stack was called incorrectly". See [Reported Error] (https://wordpress.org/support/topic/errors-with-wordpress-4-7-4/)   
     47* Tweak: CTA button no longer renders if the CTA text is left blank.   
     48* Added answers to some FAQ raised recently re the CTA button controls and empty spaces.   
    3849
    3950= 1.0.0 =     
Note: See TracChangeset for help on using the changeset viewer.