Changeset 1642514

Timestamp:

04/21/2017 03:23:28 PM (8 years ago)

Author:

stormrockwell

Message:

fixed bug where unpatched vulnerabilities wouldn't alert the user

Location:

vulnerable-plugin-checker/trunk

Files:

• readme.txt (modified) (2 diffs)
• todo.txt (modified) (1 diff)
• vulnerable-plugin-checker.php (modified) (2 diffs)

vulnerable-plugin-checker/trunk/readme.txt

@@ -4 +4 @@
 Requires at least: 4.0
 Tested up to: 4.7
-Stable tag: 0.3.9
+Stable tag: 0.3.10
 License: GPLv2
 License URI: https://www.gnu.org/licenses/old-licenses/gpl-2.0.en.html
@@ -43 +43 @@
 
 == Changelog ==
+
+= 0.3.10 =
+
+- Fixed bug where unpatched vulnerabilities were ignored (thank you @pluginvulnerabilities for finding the bug)
 
 = 0.3.9 =

vulnerable-plugin-checker/trunk/todo.txt

@@ -3 +3 @@
 check past plugin vulnerabilities
 error message if email fails to send automatically
-Translate settings page title
+translate settings page title
+show only vulnerabilities that effect the current version installed
 
 check past vulnerabilities button while searching plugins

vulnerable-plugin-checker/trunk/vulnerable-plugin-checker.php

@@ -151 +151 @@
                         // if plugin fix is greater than current version, assume it could be vulnerable
                         $plugin['is_known_vulnerable'] = 'false';
-                        if ( version_compare( $vulnerability['fixed_in'], $plugin['Version'] ) > 0 ) {          
+                        if ( null == $vulnerability['fixed_in'] || version_compare( $vulnerability['fixed_in'], $plugin['Version'] ) > 0 ) {            
                             $plugin['is_known_vulnerable'] = 'true';
                         }
@@ -188 +188 @@
                     // if plugin fix is greater than current version, assume it could be vulnerable
                     $plugin['is_known_vulnerable'] = 'false';
-                    if ( version_compare( $vulnerability->fixed_in, $plugin['Version'] ) > 0 ) {            
+                    if ( null == $vulnerability->fixed_in || version_compare( $vulnerability->fixed_in, $plugin['Version'] ) > 0 ) {            
                         $plugin['is_known_vulnerable'] = 'true';
                     }