Changeset 1410114

Timestamp:

05/04/2016 07:14:27 AM (10 years ago)

Author:

HeroPlugins

Message:

Added user input sanitization

Location:

hero-maps-pro/trunk

Files:

• classes/backend.class.php (modified) (6 diffs)
• classes/core/auto_generate.class.php (modified) (2 diffs)
• hmapspro.php (modified) (2 diffs)
• readme.txt (modified) (2 diffs)

hero-maps-pro/trunk/classes/backend.class.php

@@ -16 +16 @@
             $wpdb->query("
                 UPDATE `". $wpdb->prefix ."hmapspro_maps` SET
-                    `name` = '". $map_object['map_setup']['map_name'] ."',
+                    `name` = '". sanitize_text_field($map_object['map_setup']['map_name']) ."',
                     `responsive` = ". $map_object['map_setup']['responsive'] .",
-                    `width` = ". $map_object['map_setup']['map_width'] .",
-                    `height` = ". $map_object['map_setup']['map_height'] .",
+                    `width` = ". intval($map_object['map_setup']['map_width']) .",
+                    `height` = ". intval($map_object['map_setup']['map_height']) .",
                     `map_type` = '". $map_object['map_settings']['map_type'] ."',
                     `map_theme` = '". $map_object['map_settings']['map_theme'] ."',
@@ -39 +39 @@
                     `control_overview` = ". $map_object['map_controls']['overview'] .",
                     `control_overview_style` = ". $map_object['map_controls']['overview_style'] .",             
-                    `marker_drop_delay` = ". $map_object['map_advanced']['marker_drop_delay'] .",
+                    `marker_drop_delay` = ". intval($map_object['map_advanced']['marker_drop_delay']) .",
                     `marker_animation` = '". $map_object['map_advanced']['marker_animation'] ."',
-                    `marker_animation_timer` = ". $map_object['map_advanced']['marker_animation_timer'] .",
+                    `marker_animation_timer` = ". intval($map_object['map_advanced']['marker_animation_timer']) .",
                     `marker_tooltip` = ". $map_object['map_advanced']['marker_tooltip'] .",
                     `map_load_zoom` = ". $map_object['map_advanced']['map_load_zoom'] .",
                     `marker_click_zoom` = ". $map_object['map_advanced']['marker_click_zoom'] .",                   
                     `javascript_callback` = ". $map_object['map_developers']['javascript_callback'] .",
-                    `callback_method` = '". $map_object['map_developers']['callback_method'] ."',
-                    `css_class` = '". $map_object['map_developers']['css_class'] ."'
+                    `callback_method` = '". sanitize_text_field($map_object['map_developers']['callback_method']) ."',
+                    `css_class` = '". sanitize_text_field($map_object['map_developers']['css_class']) ."'
                 WHERE
                     `map_id` = ". $map_object['map_setup']['map_id'] .";
@@ -76 +76 @@
                                 ". intval($marker['marker_id']) .",
                                 '". $marker['latlng'] ."',
-                                '". $marker['title'] ."',
+                                '". sanitize_text_field($marker['title']) ."',
                                 ". $info_window_show .",
-                                '". $marker['info_window_content'] ."',
+                                '". sanitize_text_field($marker['info_window_content']) ."',
                                 ". $link_show .",
-                                '". $marker['link_title'] ."',
-                                '". $marker['link'] ."',
+                                '". sanitize_text_field($marker['link_title']) ."',
+                                '". sanitize_text_field($marker['link']) ."',
                                 '". $marker['link_colour'] ."',
                                 '". $marker['link_target'] ."',
-                                '". $marker['custom_param'] ."'
+                                '". sanitize_text_field($marker['custom_param']) ."'
                             );
                         ");
@@ -91 +91 @@
                             UPDATE `". $wpdb->prefix ."hmapspro_map_markers`
                             SET `deleted` = 1
-                            WHERE `map_marker_id` = ". $marker['map_marker_id'] .";
+                            WHERE `map_marker_id` = ". intval($marker['map_marker_id']) .";
                         ");
                     }elseif($marker['new'] == 'false' && $marker['deleted'] == 'false'){ //update existing marker
@@ -100 +100 @@
                                 `marker_id` = ". intval($marker['marker_id']) .",
                                 `latlng` = '". $marker['latlng'] ."',
-                                `title` = '". $marker['title'] ."',
+                                `title` = '". sanitize_text_field($marker['title']) ."',
                                 `info_window_show` = ". $info_window_show .",
-                                `info_window_content` = '". $marker['info_window_content'] ."',
+                                `info_window_content` = '". sanitize_text_field($marker['info_window_content']) ."',
                                 `link_show` = ". $link_show .",
-                                `link_title` = '". $marker['link_title'] ."',
-                                `link` = '". $marker['link'] ."',
+                                `link_title` = '". sanitize_text_field($marker['link_title']) ."',
+                                `link` = '". sanitize_text_field($marker['link']) ."',
                                 `link_colour` = '". $marker['link_colour'] ."',
                                 `link_target` = '". $marker['link_target'] ."',
-                                `custom_param` = '". $marker['custom_param'] ."'
+                                `custom_param` = '". sanitize_text_field($marker['custom_param']) ."'
                             WHERE
                                 `map_marker_id` = ". intval($marker['map_marker_id']) .";
@@ -275 +275 @@
             global $wpdb;
             //get map name
-            $map_name = $_POST['map_name'];
+            $map_name = sanitize_text_field($_POST['map_name']);
             //generate new map
             $wpdb->query("

hero-maps-pro/trunk/classes/core/auto_generate.class.php

@@ -46 +46 @@
                         //place the core view (index.php)
                         $handle = fopen(realpath($dir) .'/index.php', 'w');
-                        fwrite($handle, '<script type="text/javascript" src="<?php echo $_GET[\'v\']; ?>js/view.core.js" data-cfasync="false"></script>' ."\n");
+                        fwrite($handle, '<script type="text/javascript" src="<?php echo htmlspecialchars($_GET[\'v\'], ENT_QUOTES, \'UTF-8\'); ?>js/view.core.js" data-cfasync="false"></script>' ."\n");
                         fwrite($handle, '<div class="hero_viewport">'. "\n" .'</div>');
                         fclose($handle);
@@ -63 +63 @@
                                     //place the view
                                     $handle = fopen(realpath($dir) .'/'. $sub['view'] .'.view.php', 'w');
-                                    fwrite($handle, '<script type="text/javascript" src="<?php echo $_GET[\'vp\']; ?>js/'. $sub['view'] .'.view.js" data-cfasync="false"></script>' ."\n");
+                                    fwrite($handle, '<script type="text/javascript" src="<?php echo htmlspecialchars($_GET[\'vp\'], ENT_QUOTES, \'UTF-8\'); ?>js/'. $sub['view'] .'.view.js" data-cfasync="false"></script>' ."\n");
                                     fclose($handle);
                                 }

hero-maps-pro/trunk/hmapspro.php

@@ -6 +6 @@
         Plugin URI: http://www.heroplugins.com
         Description: Easily create your own Google Maps with a simple drag and drop interface
-        Version: 2.2.0
+        Version: 2.1.2
         Author: Hero Plugins
         Author URI: http://www.heroplugins.com
@@ -59 +59 @@
         private $plugin_friendly_name = 'Hero Maps Pro';
         private $plugin_friendly_description = 'Easily create your own Google Maps with a simple drag and drop interface';
-        private $plugin_version = '2.2.0';
+        private $plugin_version = '2.1.2';
         private $plugin_prefix = 'hmapspro_';
         private $first_release = '2014-11-24';
-        private $last_update = '2016-05-02';
+        private $last_update = '2016-02-04';
         private $api_version = '2.0.1';
         

hero-maps-pro/trunk/readme.txt

@@ -4 +4 @@
 Requires at least: 4.0.0
 Tested up to: 4.5.1
-Stable Tag: 2.2.0
+Stable Tag: 2.2.1
 License: GPLv2 or later
 License URI: http://www.gnu.org/licenses/gpl-2.0.html
@@ -69 +69 @@
 == Changelog ==
 
+= 2.2.1 =
+* Added user input sanitization
+
 = 2.2.0 =
 * Cross-site scripting vulnerability patch