Changeset 1174425

Timestamp:

06/04/2015 12:49:14 PM (11 years ago)

Author:

lti

Message:

Removing post_save and add_meta_box hooks if news support isn't activated

Location:

lti-sitemap/trunk/src

Files:

• admin/admin.php (modified) (2 diffs)
• lti-sitemap.php (modified) (1 diff)

lti-sitemap/trunk/src/admin/admin.php

@@ -261 +261 @@
      */
     public function add_meta_boxes() {
-        if ( $this->settings->get( 'content_news_support' ) == true ) {
-            $supported_post_types = $this->get_supported_post_types();
-            foreach ( $supported_post_types as $supported_post_type ) {
-                add_meta_box(
-                    'lti-sitemap-metadata-box',
-                    lsmint( 'admin.meta_box' ),
-                    array( $this, 'metadata_box' ),
-                    $supported_post_type,
-                    'advanced',
-                    'high'
-                );
-            }
+        $supported_post_types = $this->get_supported_post_types();
+        foreach ( $supported_post_types as $supported_post_type ) {
+            add_meta_box(
+                'lti-sitemap-metadata-box',
+                lsmint( 'admin.meta_box' ),
+                array( $this, 'metadata_box' ),
+                $supported_post_type,
+                'advanced',
+                'high'
+            );
         }
     }
@@ -459 +457 @@
             }
 
-            //If the post is a news item, we set a special post meta to make sitemap queries easier.
-            $post_variables = $this->helper->filter_var_array( $_POST['lti_sitemap_news'] );
-            if ( ! is_null( $post_variables ) && ! empty( $post_variables ) && $post_variables !== false ) {
+            if ( isset( $_POST['lti_sitemap_news'] ) ) {
+                //If the post is a news item, we set a special post meta to make sitemap queries easier.
                 update_post_meta( $post_ID, 'lti_sitemap_post_is_news', true );
             } else {
-                delete_post_meta( $post_ID, 'lti_sitemap_post_is_news', true );
+                delete_post_meta( $post_ID, 'lti_sitemap_post_is_news' );
             }
         }

lti-sitemap/trunk/src/lti-sitemap.php

@@ -135 +135 @@
         $this->loader->add_filter( 'plugin_action_links', $this->admin, 'plugin_action_links', 10, 2 );
         $this->loader->add_filter( 'plugin_row_meta', $this->admin, 'plugin_row_meta', 10, 2 );
-        $this->loader->add_action( 'add_meta_boxes', $this->admin, 'add_meta_boxes' );
-        $this->loader->add_action( 'save_post', $this->admin, 'save_post', 10, 3 );
+        if ( $this->settings->get( 'content_news_support' ) == true ) {
+            $this->loader->add_action( 'add_meta_boxes', $this->admin, 'add_meta_boxes' );
+            $this->loader->add_action( 'save_post', $this->admin, 'save_post', 10, 3 );
+        }
 
         if ( isset( $GLOBALS['pagenow'] ) ) {